On 2018-09-05 at 23:02, Erik Skultety wrote:
>On Wed, Sep 05, 2018 at 04:36:30PM +0800, Shi Lei wrote:
>> This patch replaces virNetDevPutExtraHeader with nlmsg_append directly.
>
>This patch is unrelated to the series and thus should become a standalone
>patch.
>
>Erik
Okay. I take it out of the
On Tue, Sep 04, 2018 at 01:01:32PM +0200, Andrea Bolognani wrote:
> See patch 2/3 for the rationale.
>
> Andrea Bolognani (3):
> guests: Split MinGW projects
> Split off MinGW builds
> Remove 'variant'
Per the discussion in patch 2/3:
Reviewed-by: Erik Skultety
--
libvir-list mailing list
On Tue, Sep 04, 2018 at 04:31:27PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-09-04 at 16:11 +0200, Erik Skultety wrote:
> > On Tue, Sep 04, 2018 at 01:01:34PM +0200, Andrea Bolognani wrote:
> > > Up until now, we've been considering MinGW builds as
> > > part of the respective project, at least
On 2018-09-05 at 21:26, Erik Skultety wrote:
>On Wed, Sep 05, 2018 at 04:36:27PM +0800, Shi Lei wrote:
>
>the subject should read:
>
>util: netlink: Introduce virNetlinkNewLink helper
>
>> This patch introduces virNetlinkNewLink which wraps newlink code
>> using libnl.
>
>... virNetlinkNewLink help
When doing some job holding state lock for a long time,
we may come across error:
"Timed out during operation: cannot acquire state change lock"
Well, sometimes it's not a problem and users want to continue
to wait, and this patch allow users decide how long time they
can wait the state lock.
Sign
> On Wed, Sep 05, 2018 at 04:49:59PM +0800, wang.y...@zte.com.cn wrote:
> >Hi Jano,
> >thanks for your reply.
> >
> >> On Tue, Aug 28, 2018 at 04:40:16PM +0800, Yi Wang wrote:
>
> [...]
>
> >> >diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug
> >> >index ddc4bbf..f7287ae 100644
This is actually a source of great frustration as many vendors ship
the machine type with custom strings. Engineers then do virsh
dumpxml's from one sys and wonder why it doesn't work on another
without realizing say ubuntu has this set to a machine type different
to rhel ( but actually are basical
On 08/31/2018 07:50 AM, Marek Marczykowski-Górecki wrote:
On Thu, Aug 30, 2018 at 03:29:41PM +0100, Daniel P. Berrangé wrote:
On Thu, Aug 30, 2018 at 04:27:06PM +0200, Marek Marczykowski-Górecki wrote:
On Mon, Aug 27, 2018 at 03:23:16PM -0600, Jim Fehlig wrote:
On 08/05/2018 03:48 PM, Marek Ma
The libxlDomainMigrationSrc* functions are a bit flawed in their
handling of modify jobs. A job begins at the start of the begin
phase but ends before the phase completes. No job is running for
the remaining phases of migration on the source host.
Change the logic to keep the job running after a s
The libxlDomainMigrationDst* functions are a bit flawed in their
handling of modify jobs. A job begins when the destination host
begins receiving the incoming VM and ends after the VM is started.
The finish phase contains another BeginJob/EndJob sequence.
This patch changes the logic to begin a jo
It is possible the incoming VM is not fully started when the finish
phase of migration is executed. In libxlDomainMigrationDstFinish,
wait for the thread receiving the VM to complete before executing
finish phase tasks.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.h| 1 +
src/libxl/
Patch 5 fixes a long standing problem found by some very slow hosts in
xen's osstest
https://lists.xenproject.org/archives/html/xen-devel/2018-08/msg01945.html
While working on the fix, I discovered other problems in libxl's V3
migration protocol. E.g. a modify job on the migrating VM was not
han
If for any reason the restore of a VM fails on the destination host
in a migration operation, the VM is removed (if not persistent) from
the virDomainObjList, meaning it is no longer available for additional
cleanup or processing in the finish phase. Defer removing the VM from
the virDomainObjList
libxlDoMigrateSrcP2P() performs all phases of the migration
protocol for peer-to-peer migration. Unfortunately the logic
was a bit flawed since it is possible to skip the confirm
phase after a successfull begin and prepare phase. Fix the
logic to always call the confirm phase after a successful beg
On 08/30/2018 08:01 AM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1622455
>
> If a domain is configured to use under
> we have to honour that setting and produce
> -mem-path on the command line. We are not doing so if domain has
> no guest NUMA nodes nor hugepages.
Signed-off-by: Eric Blake
---
Pushing under the trivial rule.
src/libvirt-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 63addbc470..8e91db31f6 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -8707,7
I don't remember if I sent any patch to include the check.
But I remember that I saw that @mkletzan put the check right after the
command execution.
So, when you run a command the function automatically check for errors
reported. Nice!
Well, @jferlan you have my Ok. ;-)
--
Julio Cesar Faracco
Em
On 09/05/2018 12:20 AM, Julio Faracco wrote:
> The function to retrieve the file system info using QEMU-GA is using
> some conditionals to retrieve the info. This is wrong because the error
> of some conditionals will be raised if VIR_STRDUP return errors and not
> if some problem occurred with
On 09/05/2018 12:20 AM, Julio Faracco wrote:
> QEMU-GA supports get geust hostname command. This commit includes a
> specific entry to inform this new feature for QEMU driver to 4.8.0
> release.
>
> Signed-off-by: Julio Faracco
> ---
> docs/news.xml | 10 ++
> 1 file changed, 10 inser
On 09/05/2018 12:20 AM, Julio Faracco wrote:
> This commit adds support to use the function qemuAgentGetHostname()
> for obtain the domain hostname using QEMU-GA command.
>
I'll fix the "for" to be "to"...
> Signed-off-by: Julio Faracco
> ---
> src/qemu/qemu_driver.c | 42 ++
On 09/05/2018 12:20 AM, Julio Faracco wrote:
> This commit implements the function qemuAgentGetHostname() that uses
> the QEMU guest agent command 'guest-get-host-name' to retrieve the
> guest hostname of virtual machine running the QEMU-GA.
>
> Signed-off-by: Julio Faracco
> ---
> src/qemu/q
On 08/27/2018 07:23 AM, Wang Huaqiang wrote:
> Introduce resource monitoring group in domain configuration file
> to support CPU cache monitoring technology (CMT).
>
> Domain rng file changes, supporting following types of resource
> monitoring group regarding the allocation regin it belongs to
On 08/27/2018 07:23 AM, Wang Huaqiang wrote:
> Changed the interface from
> virDomainResctrlAppend(virDomainDefPtr def,
>xmlNodePtr node,
>virResctrlAllocPtr alloc,
>virBitmapPtr vcpus,
>unsigned int
On Wed, Sep 05, 2018 at 04:33:32PM +0200, Andrea Bolognani wrote:
The new tests use DO_TEST_CAPS_ARCH_LATEST() with an input
XML describing a very simple headless guest and cover most
architectures and machine types we care about.
Signed-off-by: Andrea Bolognani
---
.../aarch64-virt-headless.aa
On Wed, Sep 05, 2018 at 04:33:31PM +0200, Andrea Bolognani wrote:
We can add aarch64, ppc64 and riscv64 to the list of
supported architectures for the macro, since we have
capabilities data for all of them.
Signed-off-by: Andrea Bolognani
---
tests/qemuxml2argvtest.c | 8 +++-
1 file changed
s/Prevent autoreconf from installing `compile' file/Modernize/
On Wed, Sep 05, 2018 at 10:55:40AM +0200, Michal Privoznik wrote:
When running autoreconf, it installs this `compile' file which
s/installs/creates/ maybe?
I'd expect 'install' to refer to the process of copying the resulting
file
On Wed, Sep 05, 2018 at 04:36:30PM +0800, Shi Lei wrote:
> This patch replaces virNetDevPutExtraHeader with nlmsg_append directly.
This patch is unrelated to the series and thus should become a standalone
patch.
Erik
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailm
On Wed, Sep 05, 2018 at 04:36:28PM +0800, Shi Lei wrote:
> This patch adds wrapper macros around nla_nest*/nla_put* which apply to
> virNetlinkNewLink and virNetDevSetVfConfig and virNetDevVPortProfileOpSetLink.
>
> Signed-off-by: Shi Lei
> ---
> src/util/virnetdev.c | 54 ++-
On 08/27/2018 07:23 AM, Wang Huaqiang wrote:
> 'virResctrlAllocMon' denotes a resctrl monitor reporting the resource
> consumption information.
>
> This patch introduced the interfaces for resctrl monitor.
>
> Relationship of 'resctrl allocation' and 'resctrl monitor':
> 1. resctrl monitor mon
On Wed, Sep 05, 2018 at 10:55:39AM +0200, Michal Privoznik wrote:
Just like we have 'rpm' we might have 'srpm'.
Signed-off-by: Michal Privoznik
---
Makefile.am | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 9ac6fc2..6ce91ed 100644
---
On 08/27/2018 07:23 AM, Wang Huaqiang wrote:
> Some code, in virresctrl.c, manupulating the file objects of resctrlfs
> could be reused for cache monitor interfaces. This patch refactor these
> functions for purpose of reusing code in later patch:
>
> virResctrlAllocDeterminePath
> virResctrlAl
On Wed, Sep 05, 2018 at 10:55:38AM +0200, Michal Privoznik wrote:
Adding new contributor to the list is something I keep forgetting
about. Therefore switch to autogenerated list of contributors,
just like every other libvirt project is doing so.
Signed-off-by: Michal Privoznik
---
.gitignore
On Wed, Sep 05, 2018 at 02:01:42PM +0200, Martin Kletzander wrote:
> On Wed, Sep 05, 2018 at 09:28:52AM +0100, Daniel P. Berrangé wrote:
> > On Tue, Sep 04, 2018 at 03:44:12PM -0400, Cole Robinson wrote:
> > > Right now in virt-manager we only track a VM's OS name (win10, fedora28,
> > > etc.) duri
The new tests use DO_TEST_CAPS_ARCH_LATEST() with an input
XML describing a very simple headless guest and cover most
architectures and machine types we care about.
Signed-off-by: Andrea Bolognani
---
.../aarch64-virt-headless.aarch64-latest.args | 51 ++
.../aarch64-virt-headles
As politely
Requested-by: Ján Tomko
Andrea Bolognani (2):
tests: Prepare to use DO_TEST_CAPS_ARCH_LATEST() more
tests: Add simple headless guests using latest caps
.../aarch64-virt-headless.aarch64-latest.args | 51 ++
.../aarch64-virt-headless.xml | 29 ++
We can add aarch64, ppc64 and riscv64 to the list of
supported architectures for the macro, since we have
capabilities data for all of them.
Signed-off-by: Andrea Bolognani
---
tests/qemuxml2argvtest.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/qemuxml2argvt
On Wed, 2018-09-05 at 14:53 +0200, Martin Kletzander wrote:
> On Wed, Sep 05, 2018 at 10:09:26AM +0200, Andrea Bolognani wrote:
> > for (i = 0; i < *n_vfname; i++) {
> > -if (virPCIGetAddrString((*virt_fns)[i]->domain,
> > -(*virt_fns)[i]->bus,
> > -
On Wed, Sep 05, 2018 at 11:25:11AM +0200, Igor Mammedov wrote:
> On Tue, 4 Sep 2018 23:12:55 -0300
> Eduardo Habkost wrote:
>
> > On Tue, Sep 04, 2018 at 03:22:35PM +0200, Igor Mammedov wrote:
> > > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology
> > > so that total number of
On Wed, 2018-09-05 at 11:39 +0200, Martin Kletzander wrote:
> On Tue, Sep 04, 2018 at 01:53:45PM +0200, Andrea Bolognani wrote:
> > On Tue, 2018-09-04 at 10:49 +0200, Martin Kletzander wrote:
> >
> > s/manually/ourselves/ in the subject.
[...]
> > This is a really nice improvement overall, but we
On Wed, Sep 05, 2018 at 04:36:27PM +0800, Shi Lei wrote:
the subject should read:
util: netlink: Introduce virNetlinkNewLink helper
> This patch introduces virNetlinkNewLink which wraps newlink code
> using libnl.
... virNetlinkNewLink helper which wraps the common libnl/netlink code to
create
On Wed, Sep 05, 2018 at 10:09:26AM +0200, Andrea Bolognani wrote:
There's a single user for it which takes an existing
virPCIDeviceAddress, passes its various bits to the
function which in turn constructs a virPCIDevice and
then copies the string representation for the caller
to use: we can use v
On Wed, Sep 05, 2018 at 10:09:25AM +0200, Andrea Bolognani wrote:
The struct is called virPCIDeviceAddress and the
functions operating on it should be named accordingly.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_addr.c | 6 +++---
src/libvirt_private.syms | 2 +-
src/qemu/
On Wed, Sep 05, 2018 at 10:09:24AM +0200, Andrea Bolognani wrote:
It's a better fit than conf/domain_conf.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_addr.c | 14 --
src/conf/domain_addr.h | 4
src/libvirt_private.syms | 2 +-
src/util/virpci.c| 13 +
On Wed, Sep 05, 2018 at 04:49:59PM +0800, wang.y...@zte.com.cn wrote:
Hi Jano,
thanks for your reply.
On Tue, Aug 28, 2018 at 04:40:16PM +0800, Yi Wang wrote:
[...]
>diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug
>index ddc4bbf..f7287ae 100644
>--- a/src/qemu/libvirtd_
On Wed, Sep 05, 2018 at 09:28:52AM +0100, Daniel P. Berrangé wrote:
On Tue, Sep 04, 2018 at 03:44:12PM -0400, Cole Robinson wrote:
Right now in virt-manager we only track a VM's OS name (win10, fedora28,
etc.) during the VM install phase. This piece of data is important
post-install though: if t
Hi,
This series was run against 'syntax-check' test by patchew.org, which failed,
please find the details below:
Type: series
Message-id: 1535368993-24901-1-git-send-email-huaqiang.w...@intel.com
Subject: [libvirt] [PATCH 00/10] Introduce x86 Cache Monitoring Technology (CMT)
=== TEST SCRIPT BE
On 08/27/2018 07:23 AM, Wang Huaqiang wrote:
> Signed-off-by: Wang Huaqiang
> ---
> .../linux-resctrl/resctrl/info/L3_MON/max_threshold_occupancy | 1 +
> .../vircaps2xmldata/linux-resctrl/resctrl/info/L3_MON/mon_features | 3 +++
> tests/vircaps2xmldata/linux-resctrl/resctrl/info/L3_MO
On 08/27/2018 07:23 AM, Wang Huaqiang wrote:
> CMT capability for each cache bank, includes
> -. Maximum CMT monitoring groups(sharing with MBM) could be created,
>which reflects the maximum hardware RMID count.
> -. 'cache threshold'.
> -. Statistical information of last level cache, the ac
On 08/27/2018 07:23 AM, Wang Huaqiang wrote:
> Introduce function for reporting CMT capability through going through
> files under /sys/fs/info/L3_MON.
> This patch is co-work with later patches and report these
> information to domain.
Do you mean you're setting the basis for future patches to
On 08/27/2018 07:23 AM, Wang Huaqiang wrote:
> To add CMT/MBM feature and let code be consistent in later patches,
> renaming variable name from 'controlBuf' to 'childrenBuf', locates
> in functions 'virCapabilitiesFormatCaches' and
> 'virCapabilitiesFormatMemoryBandwidth'.
>
> Signed-off-by: W
On Tue, 4 Sep 2018 22:40:49 -0300
Eduardo Habkost wrote:
> On Tue, Sep 04, 2018 at 05:18:48PM +0200, Andrew Jones wrote:
> > On Tue, Sep 04, 2018 at 03:22:36PM +0200, Igor Mammedov wrote:
> > > commit
> > > (5cdc9b76e3 vl.c: Remove dead assignment)
> > > removed sockets calculation when 'socket
On Tue, Sep 04, 2018 at 01:53:45PM +0200, Andrea Bolognani wrote:
On Tue, 2018-09-04 at 10:49 +0200, Martin Kletzander wrote:
s/manually/ourselves/ in the subject.
[...]
def get_root_password_file(self):
-root_pass_file = self._get_config_file("root-password")
-root_hash_f
On Tue, 4 Sep 2018 23:12:55 -0300
Eduardo Habkost wrote:
> On Tue, Sep 04, 2018 at 03:22:35PM +0200, Igor Mammedov wrote:
> > -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology
> > so that total number of logical CPUs [sockets * cores * threads]
> > would be equal to [maxcpus],
On Wed, Sep 05, 2018 at 10:25:12AM +0200, Michal Privoznik wrote:
> There are two macros ("BuildRoot" and "defattr") that were
> required in RHEL-5 world. Things are different now and we do not
> need to specify those anymore.
>
> Signed-off-by: Michal Privoznik
> ---
> libvirt-snmp.spec.in | 5
When running autoreconf, it installs this `compile' file which
triggers my OCD. It appears that our configure script can be
modernized a bit which makes it stop.
Signed-off-by: Michal Privoznik
---
configure.ac | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/configure
Adding new contributor to the list is something I keep forgetting
about. Therefore switch to autogenerated list of contributors,
just like every other libvirt project is doing so.
Signed-off-by: Michal Privoznik
---
.gitignore| 4 ++--
AUTHORS => AUTHORS.in | 12 +---
Makefi
Just like we have 'rpm' we might have 'srpm'.
Signed-off-by: Michal Privoznik
---
Makefile.am | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 9ac6fc2..6ce91ed 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,14 +1,18 @@
SUBDIRS=src/ do
I'd like to get some review for these actually.
Michal Privoznik (3):
Generate AUTHORS from git log
Makefile: Introduce srpm target
configure: Prevent autoreconf from installing `compile' file
.gitignore| 4 ++--
AUTHORS => AUTHORS.in | 12 +---
Makefile.am |
Hi Jano,
thanks for your reply.
> On Tue, Aug 28, 2018 at 04:40:16PM +0800, Yi Wang wrote:
> >When doing some job holding state lock for a long time,
> >we may come across error:
> >"Timed out during operation: cannot acquire state change lock"
> >Well, sometimes it's not a problem and users wanne
Patch v1 here:
https://www.redhat.com/archives/libvir-list/2018-August/msg01413.html
Shi Lei (4):
1/4: Introduce virNetlinkNewLink
(Since v1)
- Remove callback and just use special-case to handle macvlan
in virNetlinkNewLink
- Add struct virNetlinkNewLinkData to pack some arguments of
v
This patch simplifies virNetDevBridgeCreate and virNetDevMacVLanCreate
by using virNetlinkNewLink.
Signed-off-by: Shi Lei
---
src/util/virnetdevbridge.c | 78 +-
src/util/virnetdevmacvlan.c | 109 +---
2 files changed, 27 insertions(+), 1
This patch introduces virNetlinkNewLink which wraps newlink code
using libnl.
Signed-off-by: Shi Lei
---
src/libvirt_private.syms | 1 +
src/util/virnetlink.c| 120 +--
src/util/virnetlink.h| 13 +
3 files changed, 129 insertions(+), 5 deletions
This patch adds wrapper macros around nla_nest*/nla_put* which apply to
virNetlinkNewLink and virNetDevSetVfConfig and virNetDevVPortProfileOpSetLink.
Signed-off-by: Shi Lei
---
src/util/virnetdev.c | 54 ++
src/util/virnetdevvportprofile.c | 117 ++--
This patch replaces virNetDevPutExtraHeader with nlmsg_append directly.
Signed-off-by: Shi Lei
---
src/util/virnetdev.c | 44
1 file changed, 12 insertions(+), 32 deletions(-)
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 892a147..a7
On Tue, Sep 04, 2018 at 03:44:12PM -0400, Cole Robinson wrote:
> Right now in virt-manager we only track a VM's OS name (win10, fedora28,
> etc.) during the VM install phase. This piece of data is important
> post-install though: if the user adds a new disk to the VM later, we want to
> be able to
While trying to build libvirt-snmp on minimalistic RHEL installation
I've noticed couple of problems.
These two are pushed under trivial rule.
Michal Privoznik (2):
spec: Require git and gcc for the build
spec: Modernize the spec file
libvirt-snmp.spec.in | 13 +++--
1 file changed,
There are two macros ("BuildRoot" and "defattr") that were
required in RHEL-5 world. Things are different now and we do not
need to specify those anymore.
Signed-off-by: Michal Privoznik
---
libvirt-snmp.spec.in | 5 -
1 file changed, 5 deletions(-)
diff --git a/libvirt-snmp.spec.in b/libvi
In previous patch 46cae089f12 I've switched the spec file to
apply patches with git. However, I forgot to add that as a build
dependency so on systems with minimal install this may fail if
they don't have git installed.
Signed-off-by: Michal Privoznik
---
libvirt-snmp.spec.in | 8 +++-
1 fil
The struct is called virPCIDeviceAddress and the
functions operating on it should be named accordingly.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_addr.c | 6 +++---
src/libvirt_private.syms | 2 +-
src/qemu/qemu_command.c| 2 +-
src/qemu/qemu_domain_address.c | 6
There's a single user for it which takes an existing
virPCIDeviceAddress, passes its various bits to the
function which in turn constructs a virPCIDevice and
then copies the string representation for the caller
to use: we can use virPCIDeviceAddressAsString()
instead and avoid creating the virPCIDe
$ mv blurb here/
Andrea Bolognani (3):
conf: Move virDomainPCIAddressAsString() to util/virpci
conf: Rename virDomainPCIAddressAsString()
util: Drop virPCIGetAddrString()
src/conf/domain_addr.c | 20 +++-
src/conf/domain_addr.h | 4
src/libvirt_priva
It's a better fit than conf/domain_conf.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_addr.c | 14 --
src/conf/domain_addr.h | 4
src/libvirt_private.syms | 2 +-
src/util/virpci.c| 13 +
src/util/virpci.h| 3 +++
5 files changed, 17 ins
72 matches
Mail list logo
