Re: [libvirt] [PATCH v2] qemu: Add check for whether KVM nesting is enabled

2018-11-26 Thread Jiri Denemark
On Mon, Nov 26, 2018 at 18:38:06 -0500, John Ferlan wrote: > Support for nested KVM is handled via a kernel module configuration > adjustment which if done after libvirtd is started and/or the last > QEMU capabilities adjustment can result in the inability to start a > guest and use nested KVM unti

[libvirt] [PATCHv10 2/2] cpu_map: Add Cascadelake Server CPU model

2018-11-26 Thread Wang Huaqiang
Cascadelake Server CPU is introduced in QEMU by commit c7a88b52f62b30c04158eeb07f73e3f72221b6a8, add the CPU model in libvirt accordingly. Signed-off-by: Wang Huaqiang --- src/cpu_map/Makefile.inc.am| 1 + src/cpu_map/index.xml | 1 + src/cpu_map/x86_Cascadelake-Se

[libvirt] [PATCHv10 1/2] cpu: Add x86 stepping number as another factor to find candidate CPU

2018-11-26 Thread Wang Huaqiang
Cascadelake-SP is looked as the second generation Intel XEON processor scalable family while Skylake-SP is the first generation. Both Skylake-SP and Cascadelake-SP has the same family (6h) and model (55h), but with difference stepping number. In the process of identifying candidate CPU, the steppi

[libvirt] [PATCHv10 0/2] Add Cascadelake-SP CPU model

2018-11-26 Thread Wang Huaqiang
Cascadelake-SP is looked as the second generation Intel XEON processor scalable family while Skylake-SP is the first generation. Both Skylake-SP and Cascadelake-SP has the same family (6h) and model (55h), but with difference stepping number. In the process of identifying candidate CPU, the steppi

Re: [libvirt] [PATCHv10 0/4] Introduce x86 Cache Monitoring Technology (CMT)

2018-11-26 Thread Wang, Huaqiang
> -Original Message- > From: John Ferlan [mailto:jfer...@redhat.com] > Sent: Tuesday, November 27, 2018 10:59 AM > To: Wang, Huaqiang ; libvir-list@redhat.com > Subject: Re: [PATCHv10 0/4] Introduce x86 Cache Monitoring Technology > (CMT) > > > > On 11/26/18 9:39 PM, Wang, Huaqiang wr

Re: [libvirt] [PATCHv10 0/4] Introduce x86 Cache Monitoring Technology (CMT)

2018-11-26 Thread John Ferlan
On 11/26/18 9:39 PM, Wang, Huaqiang wrote: > Hi John, > > Really appreciate your hard work for the CMT series. Next I'll working on the > MBM. > > In testing the newly pushed code, I find a problem: > > > [david@dl-c200 ~]$ sudo virsh domstats > error: An error occurred, but the cause is un

[libvirt] [PATCH for-4.0 v3 2/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-26 Thread Eduardo Habkost
Many of the current virtio-*-pci device types actually represent 3 different types of devices: * virtio 1.0 non-transitional devices * virtio 1.0 transitional devices * virtio 0.9 ("legacy device" in virtio 1.0 terminology) That would be just an annoyance if it didn't break our device/bus compatib

[libvirt] [PATCH for-4.0 v3 1/2] virtio: Helper for registering virtio device types

2018-11-26 Thread Eduardo Habkost
Introduce a helper for registering different flavours of virtio devices. Convert code to use the helper, but keep only the existing generic types. Transitional and non-transitional device types will be added by another patch. Acked-by: Andrea Bolognani Signed-off-by: Eduardo Habkost --- Change

[libvirt] [PATCH for-4.0 v3 0/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-26 Thread Eduardo Habkost
Existing modern-only device types are not being touched by v3, as they don't need separate variants. However, I plan to implement separate cleanups in the code that calls virtio_pci_force_virtio_1(), first, and then propose additional changes (e.g. deprecating disable-legacy and disable-modern in

Re: [libvirt] [PATCHv10 0/4] Introduce x86 Cache Monitoring Technology (CMT)

2018-11-26 Thread Wang, Huaqiang
Hi John, Really appreciate your hard work for the CMT series. Next I'll working on the MBM. In testing the newly pushed code, I find a problem: [david@dl-c200 ~]$ sudo virsh domstats error: An error occurred, but the cause is unknown seems it is caused by qemuDomainGetStatsIOThread not by th

Re: [libvirt] [PATCHv10 0/4] Introduce x86 Cache Monitoring Technology (CMT)

2018-11-26 Thread John Ferlan
On 11/26/18 12:56 PM, Wang Huaqiang wrote: > These patches are the remaining part for the CMT enabling series, > and most of the series have been merged. > > This series is addressing John's review comments and suggestions, > which are > https://www.redhat.com/archives/libvir-list/2018-November

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-26 Thread Eduardo Habkost
On Thu, Nov 15, 2018 at 12:21:55PM +0100, Cornelia Huck wrote: > On Wed, 14 Nov 2018 21:38:31 -0200 > Eduardo Habkost wrote: > > > diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h > > index 813082b0d7..1d2a11504f 100644 > > --- a/hw/virtio/virtio-pci.h > > +++ b/hw/virtio/virtio-pci.h

Re: [libvirt] [PATCH v5 0/6] libxl: PVHv2 support

2018-11-26 Thread Jim Fehlig
Hi Marek, Thanks for all of the work! I've pushed this series, just in time for the 4.10.0 freeze :-). Please keep an eye out for any Coverity fallout (or anything else we may have missed) that needs fixed before the release. Regards, Jim On 11/26/18 12:34 PM, Marek Marczykowski-Górecki wrot

Re: [libvirt] [PATCH v5 6/6] news: add libxl PVH

2018-11-26 Thread Jim Fehlig
On 11/26/18 12:34 PM, Marek Marczykowski-Górecki wrote: Signed-off-by: Marek Marczykowski-Górecki --- New patch in v5 --- docs/news.xml | 8 1 file changed, 8 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 4406aeb..d345271 100644 --- a/docs/news.xml +++ b/docs/news.x

Re: [libvirt] [PATCH v5 2/6] libxl: add support for PVH

2018-11-26 Thread Jim Fehlig
On 11/26/18 12:34 PM, Marek Marczykowski-Górecki wrote: Since this is something between PV and HVM, it makes sense to put the setting in place where domain type is specified. To enable it, use It is I replaced '...' with 'xenpvh' in my local branch before pushing. Regards, Jim also incl

[libvirt] [PATCH v2] qemu: Add check for whether KVM nesting is enabled

2018-11-26 Thread John Ferlan
Support for nested KVM is handled via a kernel module configuration adjustment which if done after libvirtd is started and/or the last QEMU capabilities adjustment can result in the inability to start a guest and use nested KVM until the capabilities cache is invalidated. This is because without kn

Re: [libvirt] [PATCHv10 3/4] qemu: Report cache occupancy (CMT) with domstats

2018-11-26 Thread John Ferlan
On 11/26/18 12:56 PM, Wang Huaqiang wrote: > Adding the interface in qemu to report CMT statistic information > through command 'virsh domstats --cpu-total'. > > Below is a typical output: > > # virsh domstats 1 --cpu-total > Domain: 'ubuntu16.04-base' >... >

[libvirt] Next releases plans

2018-11-26 Thread Daniel Veillard
It's already the end of the month, if we want to get a release out say next Monday, I suggest to enter freeze sometime tomorrow (Tuesday), then plan for RC2 around Thursday, and then the release can happen over the week-end of next Monday. I hope this work if needed we can push everything by 1 da

[libvirt] [PATCH v5 6/6] news: add libxl PVH

2018-11-26 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki --- New patch in v5 --- docs/news.xml | 8 1 file changed, 8 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 4406aeb..d345271 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -68,6 +68,14 @@ be viewed via the domain st

[libvirt] [PATCH v5 4/6] xenconfig: add support for parsing type= xl config entry

2018-11-26 Thread Marek Marczykowski-Górecki
builder="hvm" is deprecated since Xen 4.10, new syntax is type="hvm" (or type="pv", which is default). Since the old one is still supported, still use it when writing native config, so the config will work on older Xen too (and will also not complicate tests). Signed-off-by: Marek Marczykowski-Gór

[libvirt] [PATCH v5 3/6] tests: add basic Xen PVH test

2018-11-26 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - update for modified "libxl: add support for PVH" - skip PVH test on too old Xen Changes in v5: - adjust for xenpvh os type --- tests/libxlxml2domconfigdata/basic-pvh.json | 49 ++- tests/libxlxml2domconfigdata/

[libvirt] [PATCH v5 0/6] libxl: PVHv2 support

2018-11-26 Thread Marek Marczykowski-Górecki
This is a respin of my old PVHv1 patch[1], converted to PVHv2. The actual code use "PVH" name. It introduce new guest ostype VIR_DOMAIN_OSTYPE_XENPVH, and also PVH machine, machine="xenpvh" attribute is used. Since PVHv2 relies on features in newer Xen versions, I needed to convert also some olde

[libvirt] [PATCH v5 5/6] xenconfig: add support for type="pvh"

2018-11-26 Thread Marek Marczykowski-Górecki
Handle PVH domain type in both directions (xen-xl->xml, xml->xen-xl). And add a test for it. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - update for modified "libxl: add support for PVH" Changes in v5: - update for xenpvh ostype --- src/xenconfig/xen_common.c | 17 +

[libvirt] [PATCH v5 2/6] libxl: add support for PVH

2018-11-26 Thread Marek Marczykowski-Górecki
Since this is something between PV and HVM, it makes sense to put the setting in place where domain type is specified. To enable it, use It is also included in capabilities.xml, for every supported HVM guest type - it doesn't seems to be any other requirement (besides new enough Xen). Signed-

[libvirt] [PATCH v5 1/6] libxl: reorder libxlMakeDomBuildInfo for upcoming PVH support

2018-11-26 Thread Marek Marczykowski-Górecki
Make it easier to share HVM and PVH code where relevant. No functional change. Signed-off-by: Marek Marczykowski-Górecki --- src/libxl/libxl_conf.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c ind

Re: [libvirt] [BUG][PATCH][RRFC][libvirt-python] libvirtError(..., conn=, dom=. vol=, pool=, snap=)

2018-11-26 Thread Philipp Hahn
Hello, Am 26.11.18 um 16:28 schrieb Michal Privoznik: > On 11/21/18 8:17 AM, Philipp Hahn wrote: >> while working on the Python type annotations for the Python libvirt >> binding I noticed the following code in >> libvirt-override-virDomainSnapshot.py: >> >>> def listAllChildren(self, flags=0)

[libvirt] [PATCHv10 3/4] qemu: Report cache occupancy (CMT) with domstats

2018-11-26 Thread Wang Huaqiang
Adding the interface in qemu to report CMT statistic information through command 'virsh domstats --cpu-total'. Below is a typical output: # virsh domstats 1 --cpu-total Domain: 'ubuntu16.04-base' ... cpu.cache.monitor.count=2 cpu.cache.monitor.0.

[libvirt] [PATCHv10 4/4] docs: Updated news.xml for CMT

2018-11-26 Thread Wang Huaqiang
Signed-off-by: Wang Huaqiang --- docs/news.xml | 12 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 4406aeb..deadb85 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -68,6 +68,18 @@ be viewed via the domain statistics.

[libvirt] [PATCHv10 0/4] Introduce x86 Cache Monitoring Technology (CMT)

2018-11-26 Thread Wang Huaqiang
These patches are the remaining part for the CMT enabling series, and most of the series have been merged. This series is addressing John's review comments and suggestions, which are https://www.redhat.com/archives/libvir-list/2018-November/msg00907.html https://www.redhat.com/archives/libvir-list

[libvirt] [PATCHv10 2/4] util: Add function to free monitor statistical data

2018-11-26 Thread Wang Huaqiang
The call of virResctrlMonitorGetStats will allocate the memory for holding cache occupancy or memory bandwidth statistics. This patch added an function, virResctrlMonitorFreeStats, as the opposing action of virResctrlMonitorGetStats to free these memory. Signed-off-by: Wang Huaqiang --- src/lib

[libvirt] [PATCHv10 1/4] util: Return a list of pointer in virResctrlMonitorGetStats

2018-11-26 Thread Wang Huaqiang
Return a list of virResctrlMonitorStatsPtr instead of a virResctrlMonitorStats array in virResctrlMonitorGetStats. Signed-off-by: Wang Huaqiang --- src/util/virresctrl.c | 10 +- src/util/virresctrl.h | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/util/virr

Re: [libvirt] [PATCHv9 1/2] qemu: Report cache occupancy (CMT) with domstats

2018-11-26 Thread Wang, Huaqiang
在 11/24/2018 1:33 AM, John Ferlan 写道: On 11/20/18 8:56 AM, Wang Huaqiang wrote: Adding the interface in qemu to report CMT statistic information through command 'virsh domstats --cpu-total'. Below is a typical output: # virsh domstats 1 --cpu-total Domain: 'ubuntu16.04-ba

Re: [libvirt] [PATCH 2/2] qemu: Add Default PCI Device for arm guests

2018-11-26 Thread Andrea Bolognani
On Sun, 2018-11-25 at 21:09 +, in...@nafets.de wrote: [...] > @@ -3267,6 +3267,15 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr def, > addDefaultMemballoon = false; > if (qemuDomainIsARMVirt(def)) > addPCIeRoot = virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_GPEX)

Re: [libvirt] [PATCH 1/2] Add armv6l Support as guest

2018-11-26 Thread Andrea Bolognani
On Sun, 2018-11-25 at 21:09 +, in...@nafets.de wrote: > From: Stefan Schallenberg > > Support for armv6l qemu guests has been added. > Tested with arm1176 CPU on x86. What OS did you run inside the guest? I would like to give this a try myself. > Signed-off-by: Stefan Schallenberg The S-o

Re: [libvirt] [PATCH] qemu: handle multicast overflow on macvtap for NIC_RX_FILTER_CHANGED

2018-11-26 Thread Jason Baron
On 11/26/18 11:24 AM, Michal Privoznik wrote: > On 11/26/18 5:10 PM, Michal Privoznik wrote: >> On 11/21/18 4:04 PM, Jason Baron wrote: >>> Guest network devices can set 'overflow' when there are a number of >>> multicast >>> ips configured. For virtio_net, the limit is only 64. In this case, t

Re: [libvirt] [PATCH] qemu: handle multicast overflow on macvtap for NIC_RX_FILTER_CHANGED

2018-11-26 Thread Michal Privoznik
On 11/26/18 5:10 PM, Michal Privoznik wrote: > On 11/21/18 4:04 PM, Jason Baron wrote: >> Guest network devices can set 'overflow' when there are a number of multicast >> ips configured. For virtio_net, the limit is only 64. In this case, the list >> of mac addresses is empty and the 'overflow' con

Re: [libvirt] [BUG][PATCH][RRFC][libvirt-python] libvirtError(..., conn=, dom=. vol=, pool=, snap=)

2018-11-26 Thread Michal Privoznik
On 11/21/18 8:17 AM, Philipp Hahn wrote: > Hi, > > while working on the Python type annotations for the Python libvirt > binding I noticed the following code in > libvirt-override-virDomainSnapshot.py: > >> def listAllChildren(self, flags=0): >> """List all child snapshots and returns

Re: [libvirt] [PATCH 0/6] qemu: Implement nested HV support for pSeries guests

2018-11-26 Thread Michal Privoznik
On 11/20/18 6:08 PM, Andrea Bolognani wrote: > Andrea Bolognani (6): > qemu: Drop duplicated code from qemuDomainDefValidateFeatures() > tests: Add capabilities data for QEMU 3.1.0 on ppc64 > qemu: Introduce QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV > conf: Parse and format nested-hv feature

Re: [libvirt] [PATCH 5/6] qemu: Format nested-hv feature on the command line

2018-11-26 Thread Michal Privoznik
On 11/20/18 6:08 PM, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_command.c | 20 > tests/qemuxml2argvdata/pseries-features.args | 2 +- > 2 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/src/qemu/qemu

Re: [libvirt] [PATCH] test: Convert testDriver to virObjectLockable

2018-11-26 Thread Michal Privoznik
On 11/20/18 2:54 PM, Marc Hartmayer wrote: > From: Marc Hartmayer > > The test driver state (@testDriver) uses it's own reference counting > and locking implementation. Instead of doing that, convert @testDriver > into a virObjectLockable and use the provided functionalities. > > Signed-off-by:

Re: [libvirt] Information sent in libvirt during the sasl usage and tls

2018-11-26 Thread Anastasiya Ruzhanskaya
Yes, I already disabled it and found out how the rpc protocol looks like. I just was wondering if something more is sent. For kerberos, I found quite a good description https://www.roguelynn.com/words/explain-like-im-5-kerberos/, but it only says that this ticket is then used in communication. So,

Re: [libvirt] [PATCH libvirt-python] Add daemon to list of shutdown reasons

2018-11-26 Thread Michal Privoznik
On 11/16/18 6:17 AM, Philipp Hahn wrote: > Add the support to work with libvirt commit 66a85cb13. > > Signed-off-by: Philipp Hahn > --- > examples/event-test.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACKed and pushed. Michal -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] qemu: Arm architectures don't have a default machine type

2018-11-26 Thread Kashyap Chamarthy
On Mon, Nov 26, 2018 at 01:21:32PM +0100, Andrea Bolognani wrote: > Commit 26cfb1a3cd39 introduced a list of preferred machine types, > which are meant to reflect QEMU's per-architecture historical > defaults and shield libvirt users from any changes in that area. > > Arm architectures, however, n

Re: [libvirt] Information sent in libvirt during the sasl usage and tls

2018-11-26 Thread Michal Privoznik
On 11/26/18 4:51 AM, Anastasiya Ruzhanskaya wrote: > Hello everyone! > > I am trying without any success to decipher traffic from client to server > in virt-manager in wireshark, but I don't know the sessioon key there, so > seems no chance to do this. > > This is why I want to ask, is any info r

Re: [libvirt] Why "integratorcp" as the default machine type for ARM / AArch64?

2018-11-26 Thread Kashyap Chamarthy
On Mon, Nov 26, 2018 at 01:08:20PM +0100, Andrea Bolognani wrote: > On Mon, 2018-11-26 at 12:51 +0100, Kashyap Chamarthy wrote: > > On Mon, Nov 26, 2018 at 12:29:45PM +0100, Andrea Bolognani wrote: > > > The entries in the table are supposed to reflect the (historical) > > > QEMU default; in the ca

[libvirt] [PATCH] qemu: Arm architectures don't have a default machine type

2018-11-26 Thread Andrea Bolognani
Commit 26cfb1a3cd39 introduced a list of preferred machine types, which are meant to reflect QEMU's per-architecture historical defaults and shield libvirt users from any changes in that area. Arm architectures, however, never had a default machine type associated with them, so if no machine type

Re: [libvirt] Why "integratorcp" as the default machine type for ARM / AArch64?

2018-11-26 Thread Andrea Bolognani
On Mon, 2018-11-26 at 12:51 +0100, Kashyap Chamarthy wrote: > On Mon, Nov 26, 2018 at 12:29:45PM +0100, Andrea Bolognani wrote: > > The entries in the table are supposed to reflect the (historical) > > QEMU default; in the case of Arm architectures, you're correct that > > integratorcp is not the r

Re: [libvirt] Why "integratorcp" as the default machine type for ARM / AArch64?

2018-11-26 Thread Kashyap Chamarthy
On Mon, Nov 26, 2018 at 12:29:45PM +0100, Andrea Bolognani wrote: > On Mon, 2018-11-26 at 11:23 +0100, Kashyap Chamarthy wrote: > > Hi > > > > I see in the following change, Dan added the default machine types for > > all architectures: > > > > https://libvirt.org/git/?p=libvirt.git;a=commitd

Re: [libvirt] Why "integratorcp" as the default machine type for ARM / AArch64?

2018-11-26 Thread Andrea Bolognani
On Mon, 2018-11-26 at 11:23 +0100, Kashyap Chamarthy wrote: > Hi > > I see in the following change, Dan added the default machine types for > all architectures: > > https://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=26cfb1a3 > ("qemu: ensure default machine types don't change if QEMU c

[libvirt] Why "integratorcp" as the default machine type for ARM / AArch64?

2018-11-26 Thread Kashyap Chamarthy
Hi I see in the following change, Dan added the default machine types for all architectures: https://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=26cfb1a3 ("qemu: ensure default machine types don't change if QEMU changes") What caught my eye was the default machine type chosen ("integra