On Thu, Jan 10, 2019 at 11:42:08AM -0500, Laine Stump wrote:
> On 1/10/19 10:38 AM, Erik Skultety wrote:
> > On Thu, Jan 10, 2019 at 09:34:35AM -0500, Laine Stump wrote:
> > > On 1/10/19 9:09 AM, Erik Skultety wrote:
> > > > On Wed, Jan 09, 2019 at 12:43:14PM -0500, Laine Stump wrote:
> > > > > Thi
On Thu, Jan 10, 2019 at 11:48:42AM -0500, Laine Stump wrote:
> On 1/10/19 10:44 AM, Erik Skultety wrote:
> > On Wed, Jan 09, 2019 at 12:43:15PM -0500, Laine Stump wrote:
> > > When checking the setting of accept_ra, we have assumed that all
> > > routes have a single nexthop, so the interface of th
This is a test case to test network indexes. NICs must be created
considering the sequence of each index no matter where the entry is.
They do not be defined in sequence as legacy version suggests.
Signed-off-by: Julio Faracco
---
tests/lxcconf2xmltest.c | 1 +
1 file changed, 1 insertion(+)
di
This commit only change the legacy network settings ("lxc.network.")
inside v3 tests to the new format ("lxc.net.X.") adopted in version
3.0. It enhaces some test cases to cover other scenarions.
Signed-off-by: Julio Faracco
---
.../lxcconf2xml-ethernet-v3.config| 16
.../lx
LXC was using a single data structure to define all LXC NICs. In terms
of optimization it is very interesting, but it is not useful when you
use a index to define networks. After major release 3.0, LXC adopted
indexes for network definitions. So, this commit adds a sparse vector to
handle network i
The series propose a new way to define NICs inside LXC native. It is
needed because LXC version 3.X uses indexes to define NICs and the
current algorithm is not able to support them. At least, if you consider
settings defined using a random logic.
v1-v2: Includes Michal's suggestions.
Julio Farac
When commit 1d94b3e7 added code to walk the [n]hostdevs list looking
to add shared hostdevs, it should've filtered any hostdevs that were
not SCSI hostdev's.
Signed-off-by: John Ferlan
---
src/qemu/qemu_hostdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_hostdev.c b/sr
See patches for details
John Ferlan (2):
qemu: Filter non SCSI hostdevs in qemuHostdevPrepareSCSIDevices
qemu: Remove virHostdevIsSCSIDevice from qemuIsSharedHostdev
src/qemu/qemu_conf.c| 3 +--
src/qemu/qemu_hostdev.c | 3 +++
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.20.1
It's essentially dead code. The only way hostdev->shareable
can be true is during virDomainHostdevDefParseXML when the
result of virHostdevIsSCSIDevice is true.
Signed-off-by: John Ferlan
---
src/qemu/qemu_conf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu
The libxl driver does not set the new memory value in the active domain def
after a successful balloon. This results in the old memory value in
. E.g.
virsh dumpxml test | grep currentMemory
20971520
virsh setmem test 16777216 --live
virsh dumpxml test | grep currentMemory
20971520
Set the ne
As planned I tagged the RC1 in git and pushed signed tarball and rpms to
the usual place:
ftp://libvirt.org/libvirt/
I didn't see the 5 patches from Laine in git at that point but those seems
to be bug + portability fixes anyway so it should still be possible to have
them in say before rc2.
On Thu, Jan 10, 2019 at 10:23:13AM -0600, Eric Blake wrote:
> On 1/10/19 9:39 AM, Daniel P. Berrangé wrote:
>
> > For any pointer parameter there's then two possibilities. Either NULL
> > is a valid value and results in some useful behaviour, or NULL is not
> > valid and libvirt will catch that an
On 1/10/19 10:44 AM, Erik Skultety wrote:
On Wed, Jan 09, 2019 at 12:43:15PM -0500, Laine Stump wrote:
When checking the setting of accept_ra, we have assumed that all
routes have a single nexthop, so the interface of the route would be
in the RTA_OIF attribute of the netlink RTM_NEWROUTE messag
On 1/10/19 10:38 AM, Erik Skultety wrote:
On Thu, Jan 10, 2019 at 09:34:35AM -0500, Laine Stump wrote:
On 1/10/19 9:09 AM, Erik Skultety wrote:
On Wed, Jan 09, 2019 at 12:43:14PM -0500, Laine Stump wrote:
This is about the same number of code lines, but is simpler, and more
consistent with wha
On 1/10/19 9:39 AM, Daniel P. Berrangé wrote:
> For any pointer parameter there's then two possibilities. Either NULL
> is a valid value and results in some useful behaviour, or NULL is not
> valid and libvirt will catch that and report an error.
But within the latter are two cases: libvirt catch
On Thu, 2019-01-10 at 16:32 +0100, Erik Skultety wrote:
> On Thu, Jan 10, 2019 at 03:11:45PM +0100, Andrea Bolognani wrote:
> > This is consistent with the way we already handle
> > configuration for other init systems such as upstart and
> > systemd.
>
> Apart from consistency, I wonder whether w
On Wed, Jan 09, 2019 at 12:43:15PM -0500, Laine Stump wrote:
> When checking the setting of accept_ra, we have assumed that all
> routes have a single nexthop, so the interface of the route would be
> in the RTA_OIF attribute of the netlink RTM_NEWROUTE message. But
> multipath routes don't have an
On Thu, Jan 10, 2019 at 09:23:06AM -0600, Eric Blake wrote:
> > I do wonder if we can enable __attribute__(nonnull) under GCC and
> > then set '-fdelete-null-pointer-checks' to stop it deleting our
> > runtime NULL checks, so we get both compile time & runtime protection.
>
> I think that leads t
On Thu, Jan 10, 2019 at 09:34:35AM -0500, Laine Stump wrote:
> On 1/10/19 9:09 AM, Erik Skultety wrote:
> > On Wed, Jan 09, 2019 at 12:43:14PM -0500, Laine Stump wrote:
> > > This is about the same number of code lines, but is simpler, and more
> > > consistent with what will be added to check anot
On Thu, Jan 10, 2019 at 03:11:43PM +0100, Andrea Bolognani wrote:
> Changes from [v1]:
>
> * patches 1-4 from v1 have been pushed;
>
> * patches 1 and 2 are new;
>
> * patch 3 (which was patch 5 in v1) no longer drops the various
> WITH_LIBVIRTD conditionals.
>
>
> [v1] https://www.redhat
On Thu, Jan 10, 2019 at 03:11:45PM +0100, Andrea Bolognani wrote:
> This is consistent with the way we already handle
> configuration for other init systems such as upstart and
> systemd.
Apart from consistency, I wonder whether we still need that extra condition or
it's a historical artefact we c
On 1/10/19 5:23 AM, Daniel P. Berrangé wrote:
>>>
>>> We have historically still added nonnull annotations even when
>>> having checks for NULL in the impl. We had to explicitly disabble
>>> the nonnull annotation when building under GCC to prevent it from
>>> optimizing out the NULL checks. We l
On 1/10/19 3:01 AM, Ján Tomko wrote:
> Since its introduction in commit 0977b8aa071 (released in v1.2.14)
> qemuAgentGetInterfaces calls qemuAgentCommand with needReply=false,
> which allows qemuAgentCommand to return 0 even when it did not get
> any reply from the agent.
>
> Set needReply to true
On Thu, Jan 10, 2019 at 03:25:03PM +0100, Jiri Denemark wrote:
The feature was added to QEMU in 3.1.0 and it is currently blocking
migration, which is expected to change in the future. Luckily 3.1.0 is
new enough to give us migratability hints on each feature via
query-cpu-model-expension, which
On Thu, Jan 10, 2019 at 02:02:33PM +0100, Michal Privoznik wrote:
The session daemon is unable to set XATTRs in 'trusted'
namespace because it doesn't run as privileged process.
Therefore, when creating the default qemu config enable
rememberOwner only when running as privileged process.
Signed-
On Thu, 2019-01-10 at 16:20 +0300, Roman Bolshakov wrote:
> Perhaps we should install grep, gnu-sed and cppi from homebrew in
> .travis.yml to get it working. I have all of them installed on my laptop
> and syntax-check passes without the errors for me.
>
> grep provides GNU grep and all the "empt
On 1/10/19 9:09 AM, Erik Skultety wrote:
On Wed, Jan 09, 2019 at 12:43:14PM -0500, Laine Stump wrote:
This is about the same number of code lines, but is simpler, and more
consistent with what will be added to check another attribute in a
coming patch.
As a side effect, it
Resolves: https://bu
The feature was added to QEMU in 3.1.0 and it is currently blocking
migration, which is expected to change in the future. Luckily 3.1.0 is
new enough to give us migratability hints on each feature via
query-cpu-model-expension, which means we don't need to use the
"migratable" attribute on the CPU
Instead of defining targets conditionally and depending on
them unconditionally, define a couple of variables and
conditionally add targets to them.
In addition to removing a bunch of useless code, this has
the nice effect of no longer requiring the main Makefile.am
to have any knowledge about the
Changes from [v1]:
* patches 1-4 from v1 have been pushed;
* patches 1 and 2 are new;
* patch 3 (which was patch 5 in v1) no longer drops the various
WITH_LIBVIRTD conditionals.
[v1] https://www.redhat.com/archives/libvir-list/2019-January/msg00212.html
Andrea Bolognani (3):
src:
Avoid building the same path several times.
Signed-off-by: Andrea Bolognani
---
src/Makefile.am | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index d3e8a1b572..0a8f54120d 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -811
This is consistent with the way we already handle
configuration for other init systems such as upstart and
systemd.
Signed-off-by: Andrea Bolognani
---
src/Makefile.am | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/Makefile.am b/src/Makefile.am
index 0a8f54120d..82a96adb99 100644
-
On Wed, Jan 09, 2019 at 12:43:14PM -0500, Laine Stump wrote:
> This is about the same number of code lines, but is simpler, and more
> consistent with what will be added to check another attribute in a
> coming patch.
>
> As a side effect, it
>
> Resolves: https://bugzilla.redhat.com/1583131
> Sign
Hi, all.
There is old patch series [1] to add file format to UEFI and NVRAM. It is not
merged because I guess it is intended to be used with online internal snapshot
On 1/10/19 5:08 AM, Daniel P. Berrangé wrote:
On Wed, Jan 09, 2019 at 10:03:33PM -0500, Laine Stump wrote:
On 1/9/19 3:53 PM, Daniel Veillard wrote:
Happy New Year everybody,
as planned we should release 5.0.0 around Jan 15. This means that
the best to meet that deadline would be to e
On Thu, Jan 10, 2019 at 11:49:35AM +0100, Andrea Bolognani wrote:
> On Thu, 2019-01-10 at 10:34 +0300, Roman Bolshakov wrote:
> > I've run 'make syntax-check' on libvirt's HEAD. It succeeds on macOS.
> > Perhaps we can add syntax-check to .travis.yml?
>
> syntax-check passes on macOS, but it doesn
The session daemon is unable to set XATTRs in 'trusted'
namespace because it doesn't run as privileged process.
Therefore, when creating the default qemu config enable
rememberOwner only when running as privileged process.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_conf.c | 2 +-
1 file c
On Thu, 2019-01-10 at 09:33 +0100, Erik Skultety wrote:
> polkitdir = $(datadir)/polkit-1 might be a nice little addition to the patch,
> but I don't care that much.
I've implemented your suggestion and pushed the first four patches
in the series.
--
Andrea Bolognani / Red Hat / Virtualization
On Thu, 2019-01-10 at 10:44 +0100, Erik Skultety wrote:
> On Wed, Jan 09, 2019 at 07:35:52PM +0100, Andrea Bolognani wrote:
[...]
> > @@ -847,7 +849,6 @@ EXTRA_DIST += \
> > $(NULL)
> >
> >
> > -if WITH_LIBVIRTD
>
> Can we really do ^this?
We were already doing so for {,un}install-init
This needs next:
- turning QEMU_CAPS_BLOCKDEV on
- adding caps data for not yet released qemu 3.1
Signed-off-by: Nikolay Shirokovskiy
---
.../qemuxml2argvdata/disk-metadata_cache_size.args | 39 ++
tests/qemuxml2argvtest.c | 2 ++
2 files changed, 4
As this patch series only works with -blockdev configurations it is better to
be pushed only after -blockdev is supported. Then 'news' and 'xml' patch need
to be updated to have correct libvirt version.
Diff from v2 [1]:
=
- move caps patch to top
- add news patch
- add _CAPPED to
Signed-off-by: Nikolay Shirokovskiy
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 8c608cd..e16d82d 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -50,6 +50,17 @@
+ Add metadata cache size
Just set l2-cache-size to INT64_MAX for all format nodes of
qcow2 type in block node graph.
-drive configuration is not supported because we can not
set l2 cache size down the backing chain in this case.
Signed-off-by: Nikolay Shirokovskiy
---
src/qemu/qemu_block.c | 5 -
src/qemu/qemu
The options specifies metadata cache size policy for a disk.
This is going to be used only for QEMU and only for qcow2 images in
next patch to set qcow2 L2 cache size.
Signed-off-by: Nikolay Shirokovskiy
---
docs/formatdomain.html.in | 11 ++
docs/schemas/domaincommo
For qemu capable of setting l2-cache-size for qcow2 images
to INT64_MAX and semantics of upper limit on l2 cache
size. We can only check this by qemu version (3.1.0) now.
Signed-off-by: Nikolay Shirokovskiy
---
src/qemu/qemu_capabilities.c | 5 +
src/qemu/qemu_capabilities.h | 1 +
2 files c
On Wed, Jan 09, 2019 at 12:43:13PM -0500, Laine Stump wrote:
> This same operation needs to be done in multiple places, so move the
> inline code into a separate function.
>
> Signed-off-by: Laine Stump
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
https://w
On Wed, Jan 02, 2019 at 02:37:00PM -0600, Eric Blake wrote:
> Adding Rich, since he recently raised the topic on the libguestfs list
> and pointed to libvirt as precedence:
>
> On 12/18/18 9:47 AM, Daniel P. Berrangé wrote:
> > On Tue, Dec 18, 2018 at 10:39:20AM -0500, John Ferlan wrote:
> >> Comm
On Thu, 2019-01-10 at 10:23 +0100, Erik Skultety wrote:
> On Wed, Jan 09, 2019 at 07:35:54PM +0100, Andrea Bolognani wrote:
> > Vim won't recognize them, and thus not enable niceties
> > such as syntax highlighting, otherwise.
>
> So, is there a strict reason for the *inc.am naming? Reading throug
On Thu, 2019-01-10 at 10:34 +0300, Roman Bolshakov wrote:
> I've run 'make syntax-check' on libvirt's HEAD. It succeeds on macOS.
> Perhaps we can add syntax-check to .travis.yml?
syntax-check passes on macOS, but it doesn't quite succeed:
[...]
unmarked_diagnostics
vulnerable_makefile_CVE-
On Thu, Jan 10, 2019 at 11:15:43AM +0100, Erik Skultety wrote:
> On Thu, Jan 10, 2019 at 10:05:49AM +, Daniel P. Berrangé wrote:
> > On Thu, Jan 10, 2019 at 10:23:07AM +0100, Erik Skultety wrote:
> > > On Wed, Jan 09, 2019 at 07:35:54PM +0100, Andrea Bolognani wrote:
> > > > Vim won't recognize
On Wed, Jan 09, 2019 at 12:43:12PM -0500, Laine Stump wrote:
> This is problematic if a callback function wants to send the nlmsghdr
> to a library function that has no "const" in its prototype
> (e.g. nlmsg_find_attr())
Makes sense, since we can't control the API signatures in external libraries.
On Thu, Jan 10, 2019 at 10:05:49AM +, Daniel P. Berrangé wrote:
> On Thu, Jan 10, 2019 at 10:23:07AM +0100, Erik Skultety wrote:
> > On Wed, Jan 09, 2019 at 07:35:54PM +0100, Andrea Bolognani wrote:
> > > Vim won't recognize them, and thus not enable niceties
> > > such as syntax highlighting,
On Wed, Jan 09, 2019 at 10:03:33PM -0500, Laine Stump wrote:
> On 1/9/19 3:53 PM, Daniel Veillard wrote:
> > Happy New Year everybody,
> >
> >as planned we should release 5.0.0 around Jan 15. This means that
> > the best to meet that deadline would be to enter freeze tomorrow Thur,
> > the
On Thu, Jan 10, 2019 at 10:23:07AM +0100, Erik Skultety wrote:
> On Wed, Jan 09, 2019 at 07:35:54PM +0100, Andrea Bolognani wrote:
> > Vim won't recognize them, and thus not enable niceties
> > such as syntax highlighting, otherwise.
>
> So, is there a strict reason for the *inc.am naming? Reading
On Wed, Jan 09, 2019 at 07:35:53PM +0100, Andrea Bolognani wrote:
> These files need to be installed on the system for apparmor
> support to work, so they don't belong with examples.
>
> Signed-off-by: Andrea Bolognani
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redh
On Wed, Jan 09, 2019 at 07:35:52PM +0100, Andrea Bolognani wrote:
> Instead of defining targets conditionally and depending on
> them unconditionally, define a couple of variables and
> conditionally add targets to them.
>
> In addition to removing a bunch of useless code, this has
> the nice effec
On Thu, Jan 10, 2019 at 10:01:19 +0100, Ján Tomko wrote:
> Since its introduction in commit 0977b8aa071 (released in v1.2.14)
> qemuAgentGetInterfaces calls qemuAgentCommand with needReply=false,
> which allows qemuAgentCommand to return 0 even when it did not get
> any reply from the agent.
>
> S
On Wed, Jan 09, 2019 at 07:35:54PM +0100, Andrea Bolognani wrote:
> Vim won't recognize them, and thus not enable niceties
> such as syntax highlighting, otherwise.
So, is there a strict reason for the *inc.am naming? Reading through [1] gave me
the necessary background, but is there an inherent i
On Wed, 2019-01-09 at 21:47 -0500, Laine Stump wrote:
> networkMigrateStateFiles was added nearly 5 years ago when the network
> state directory was moved from /var/lib/libvirt to /var/run/libvirt
> just prior to libvirt-1.2.4). It was only required to maintain proper
> state information for networ
Since its introduction in commit 0977b8aa071 (released in v1.2.14)
qemuAgentGetInterfaces calls qemuAgentCommand with needReply=false,
which allows qemuAgentCommand to return 0 even when it did not get
any reply from the agent.
Set needReply to true, since we dereference it right after.
This can
On Wed, Jan 09, 2019 at 07:35:51PM +0100, Andrea Bolognani wrote:
> Avoid building the same path several times.
>
> Signed-off-by: Andrea Bolognani
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Jan 09, 2019 at 07:35:50PM +0100, Andrea Bolognani wrote:
> Avoid building the same path several times.
>
> Signed-off-by: Andrea Bolognani
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Jan 09, 2019 at 07:35:49PM +0100, Andrea Bolognani wrote:
> Avoid building the same path several times.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/remote/Makefile.inc.am | 19 ++-
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/src/remote/Makefile.
On Wed, Jan 09, 2019 at 07:35:48PM +0100, Andrea Bolognani wrote:
> No need to have two conditional blocks.
>
> Signed-off-by: Andrea Bolognani
> ---
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
64 matches
Mail list logo
