On Fri, Jan 11, 2019 at 07:44:38AM -0500, John Ferlan wrote:
On 1/11/19 3:26 AM, Ján Tomko wrote:
On Thu, Jan 10, 2019 at 06:40:33PM -0500, John Ferlan wrote:
It's essentially dead code. The only way hostdev->shareable
can be true is during virDomainHostdevDefParseXML when the
result of virHo
On 1/11/19 3:26 AM, Ján Tomko wrote:
> On Thu, Jan 10, 2019 at 06:40:33PM -0500, John Ferlan wrote:
>> It's essentially dead code. The only way hostdev->shareable
>> can be true is during virDomainHostdevDefParseXML when the
>> result of virHostdevIsSCSIDevice is true.
>
> While this might be t
On Fri, Jan 11, 2019 at 11:23:33AM +0100, Andrea Bolognani wrote:
> According to the GNU Make manual, "double-colon rules are
> somewhat obscure and not often very useful". Looking at
> the few instances we have in libvirt, that certainly seems
> to be the case, so just drop them.
I actually wante
According to the GNU Make manual, "double-colon rules are
somewhat obscure and not often very useful". Looking at
the few instances we have in libvirt, that certainly seems
to be the case, so just drop them.
Signed-off-by: Andrea Bolognani
---
src/Makefile.am| 6 +++---
src/remote/Ma
On Thu, Jan 10, 2019 at 06:40:33PM -0500, John Ferlan wrote:
It's essentially dead code. The only way hostdev->shareable
can be true is during virDomainHostdevDefParseXML when the
result of virHostdevIsSCSIDevice is true.
While this might be true in our current codebase,
I don't think this func
On Thu, Jan 10, 2019 at 06:40:32PM -0500, John Ferlan wrote:
When commit 1d94b3e7 added code to walk the [n]hostdevs list looking
to add shared hostdevs, it should've filtered any hostdevs that were
not SCSI hostdev's.
Signed-off-by: John Ferlan
---
src/qemu/qemu_hostdev.c | 3 +++
1 file change
