Every other mock library is named ending in mock.c, move
virmocklibxl.c to follow that pattern
Signed-off-by: Cole Robinson
---
tests/Makefile.am | 12 ++--
tests/{virmocklibxl.c => libxlmock.c} | 2 +-
tests/libxlxml2domconfigtest.c| 2 +-
3 files changed,
This allows us to mock functions in the libxl driver, like
is already possible for the qemu driver
Signed-off-by: Cole Robinson
---
tests/Makefile.am | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index c9f79a4e7d..c3f633cee
No functional change, but this will allow us to mock out the function
in the test suite
Signed-off-by: Cole Robinson
---
src/libxl/libxl_capabilities.c | 16
src/libxl/libxl_capabilities.h | 1 +
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/src/libxl/libxl_ca
Mock out libxlCapsHasPVUSB to always return true, so test results
aren't dependent on host libxl version
Signed-off-by: Cole Robinson
---
tests/domaincapsmock.c| 11 +++
.../domaincapsschemadata/libxl-xenfv-usb.xml | 78 ---
tests/domaincapsschemadata/lib
There's two different domain capabilities test cases for libxl,
depending on whether host libxl supports PVUSB or not. This causes
pain when extending domain capabilities XML, because at least one
file always needs to be updated by hand.
This series adds a wrapper function for checking PVUSB, and
devices lack the model= attribute which is used by
most other device types. bus= mostly acts as one, but it
serves other purposes too like determing what target=
prefix to use, and for matching against controller type=
values.
Extending bus= to handle additional virtio transitional
devices will c
Add new model values for virtio transitional devices. Ex:
* "virtio-transitional" maps to qemu "virtio-balloon-pci-transitional"
* "virtio-non-transitional" maps to qemu "virtio-balloon-pci-non-transitional"
Reviewed-by: Andrea Bolognani
Signed-off-by: Cole Robinson
---
docs/formatdomain.
Add new model values for virtio transitional devices. Ex:
...
* "virtio-transitional" maps to qemu "virtio-rng-pci-transitional"
* "virtio-non-transitional" maps to qemu "virtio-rng-pci-non-transitional"
Signed-off-by: Cole Robinson
---
docs/formatdomain.html.in
Add new model handling for virtio transitional devices. Ex:
* "virtio-transitional" maps to qemu "virtio-net-pci-transitional"
* "virtio-non-transitional" maps to qemu "virtio-net-pci-non-transitional"
Signed-off-by: Cole Robinson
---
docs/formatdomain.html.in
v2 libvirt patches:
https://www.redhat.com/archives/libvir-list/2019-January/msg00877.html
v1 libvirt patches:
https://www.redhat.com/archives/libvir-list/2019-January/msg00593.html
Previous incomplete RFC here:
https://www.redhat.com/archives/libvir-list/2019-January/msg00346.html
qemu patches, qu
Add
* "virtio-transitional" maps to qemu "virtio-scsi-pci-transitional"
* "virtio-non-transitional" maps to qemu "virtio-scsi-non-transitional"
The naming here doesn't match the pre-existing model=virtio-scsi.
The prescence of '-scsi' there seems kind of redundant as we have
type='scsi' already,
devices lack the model= attribute which is used by
most other device types. To eventually support
virtio-9p-pci-{non-}traditional in qemu, let's add a standard
model= attribute. The accepted values are:
- virtio
- virtio-transitional
- virtio-non-transitional
Signed-off-by: Cole Robinson
---
d
qemu vhost-scsi devices map to XML roughly like:
To support vhost-scsi-pci-{non-}traditional in qemu, we
need to to extend the SCSI Host hostdev XML to handle
model= value. This matches the XML model= format used
for mediated devices. This is just the domain_conf bits
and some XM
It will be used in future patches
Reviewed-by: Andrea Bolognani
Signed-off-by: Cole Robinson
---
src/qemu/qemu_command.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 572d3bc20f..a26f6
This generates new XML like:
virtio
virtio-transitional
virtio-non-transitional
Signed-off-by: Cole Robinson
---
src/conf/domain_capabilities.c| 1 +
src/conf/domain_capabilities.h| 1 +
src/qemu/qemu_capabiliti
Add protocol=vhost model handling for virtio transitional
devices. Ex:
* "virtio-transitional" maps to qemu "vhost-scsi-pci-transitional"
* "virtio-non-transitional" maps to qemu "vhost-scsi-pci-non-transitional"
Signed-off-by: Cole Robinson
---
src/qemu/qemu_command.c
Add controller type='virtio-serial' model handling for virtio
transitional devices. Ex:
* "virtio-transitional" maps to qemu "virtio-serial-pci-transitional"
* "virtio-non-transitional" maps to qemu "virtio-serial-pci-non-transitional"
Reviewed-by: Andrea Bolognani
Signed-off-by: Cole Robins
Add model handling for virtio transitional devices. Ex:
...
* "virtio-transitional" maps to qemu "virtio-input-host-pci-transitional"
* "virtio-non-transitional" maps to qemu "virtio-input-host-non-transitional"
Reviewed-by: Andrea Bolognani
Signed-off-by: Cole Robinson
---
src/qem
Add model handling for virtio transitional devices. Ex:
...
* "virtio-transitional" maps to qemu "vhost-vsock-pci-transitional"
* "virtio-non-transitional" maps to qemu "vhost-vsock-pci-non-transitional"
Reviewed-by: Andrea Bolognani
Signed-off-by: Cole Robinson
---
docs/formatdoma
Add model handling for virtio transitional devices. Ex:
...
---
src/qemu/qemu_command.c | 6 -
src/qemu/qemu_domain_address.c| 14 +--
.../virtio-non-transitional.x86_64-3.1.0.args | 3 ++-
...virtio-non-transitional.x86_64-latest.arg
devices lack the model= attribute which is used by
most other device types. To eventually support
virtio-input-host-pci-{non-}traditional in qemu, let's add
a standard model= attribute. This just adds the domain_conf
wiring
Reviewed-by: Andrea Bolognani
Signed-off-by: Cole Robinson
---
docs/fo
Add new model values for virtio transitional devices. When
combined with bus='virtio':
* "virtio-transitional" maps to qemu "virtio-blk-pci-transitional"
* "virtio-non-transitional" maps to qemu "virtio-blk-pci-non-transitional"
Signed-off-by: Cole Robinson
---
src/qemu/qemu_command.c
Add a single QEMU_CAPS_VIRTIO_PCI_NON_TRANSITIONAL that
will be set if any of the following qemu devices are found:
virtio-blk-pci-transitional
virtio-blk-pci-non-transitional
virtio-net-pci-transitional
virtio-net-pci-non-transitional
vhost-scsi-pci-transitional
vhost-scsi
Only one path will consume the @def; otherwise, we need to free it.
Signed-off-by: John Ferlan
---
tests/storagepoolxml2argvtest.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/storagepoolxml2argvtest.c b/tests/storagepoolxml2argvtest.c
index 288b81af1d..f2a8af12b0 100644
--- a/t
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/test/test_driver.c | 169 -
1 file changed, 66 insertions(+), 103 deletions(-)
diff --git a/src/te
To prepare for subsequent change to use VIR_AUTOPTR logic rename
the @ret to @def.
Signed-off-by: John Ferlan
---
src/util/virstoragefile.c | 96 +++
1 file changed, 48 insertions(+), 48 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstorag
To prepare for subsequent change to use VIR_AUTOPTR logic rename
the @ret to @def.
Signed-off-by: John Ferlan
---
src/util/virstoragefile.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 907358a8fe..a
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c| 3 +-
src/qemu/qemu_domain.c| 3 +-
src/qemu/qemu_driver.c| 9 +-
src/qemu/qemu_migration.c
Commit 390c06b67 added @xml, but it was never used.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/test/test_driver.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index f51efa51b7..1dde92e961 100644
--- a/src/test/test_drive
To prepare for subsequent change to use VIR_AUTOPTR logic rename
the @ret to @def.
Signed-off-by: John Ferlan
---
tests/virstoragetest.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c
index 49b8f42e6d..8d
To prepare for subsequent change to use VIR_AUTOPTR logic rename
the @ret to @def.
Signed-off-by: John Ferlan
---
src/util/virstoragefile.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
ind
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/util/virstoragefile.c | 128 ++
1 file changed, 46 insertions(+), 82 deletions(-)
diff --git a/src/uti
Modify code to use the VIR_AUTOCLOSE logic cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/storage/storage_backend_logical.c | 3 +-
src/storage/storage_backend_scsi.c| 12 +--
src/storage/storage_file_fs.c | 15 +--
src/
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
---
src/storage/storage_util.c | 335 +
1 file changed, 113 insertions(+), 222 deletions(-)
diff --git a/src/storage/storage_util.c b/src/
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/storage/storage_backend_disk.c | 85 +
src/storage/storage_backend_fs.c | 39 +++---
src/storage/storag
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/conf/domain_conf.c | 3 +--
src/conf/storage_conf.c| 3 +--
src/conf/storage_conf.h| 1 +
src/conf/v
To prepare for subsequent change to use VIR_AUTOPTR logic rename
the @ret to @def.
Signed-off-by: John Ferlan
---
src/util/virstoragefile.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
ind
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/storage/storage_util.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c
index 012c6b319b..af6ab20ea6 100644
--- a/src/storage/storage_util.c
+++ b/src/st
Let's make use of the auto __cleanup capabilities. This also allows
for the cleanup of some goto paths.
Signed-off-by: John Ferlan
---
src/storage/storage_backend.c | 9 +--
src/storage/storage_backend_disk.c | 62 ++---
src/storage/storage_backend_fs.c
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
tests/storagebackendsheepdogtest.c | 50 --
tests/storagepoolxml2argvtest.c| 18 +++
tests/storagepoolx
virStorageFileGetRelativeBackingPath and virStorageFileGetMetadataRecurse
open coded.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/util/virstoragefile.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile
Commit a523770c3 added @retval return processing for
virStorageBackendUpdateVolInfo in order to allow a -2
to be return; however, upon successful completion
@retval = 0 and if either the virStorageBackendSCSISerial
or the virStoragePoolObjAddVol failed, the method would
return 0, but not add the @v
To prepare for subsequent change to use VIR_AUTOPTR logic rename
the @ret to @def.
Signed-off-by: John Ferlan
---
src/util/virstoragefile.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
ind
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/storage/storage_backend_iscsi_direct.c | 3 +-
src/storage/storage_backend_sheepdog.c | 6 +--
src/storage/storage_backend_zfs.c
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/storage/storage_driver.c | 70
1 file changed, 23 insertions(+), 47 deletions(-)
diff --git a/src/sto
Rather than have a need for old_dom_name, let's just VIR_FREE
the old name first, then use VIR_STEAL_PTR to handle the swap
from the old name to the new name.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/test/test_driver.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletio
Rather than having an error path, let's rework the code to allocate
and fill into an @def variable and then steal that into @ret when we
are successful leaving just a cleanup: path.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/conf/storage_conf.c | 113 -
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/conf/storage_conf.c | 179 +---
1 file changed, 74 insertions(+), 105 deletions(-)
diff --git a/src/co
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/conf/storage_conf.c| 3 +--
src/conf/storage_conf.h| 1 +
src/esx/esx_storage_backend_vmfs.c
Rather than having an error path, let's rework the code to allocate
and fill into an @def variable and then steal that into @ret when we
are successful leaving just a cleanup: path.
Signed-off-by: John Ferlan
---
src/conf/storage_conf.c | 114
1 file chan
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/conf/domain_conf.c| 26 ++
src/conf/storage_conf.c | 3 +--
src/qemu/qemu_parse_command.c | 3 +--
v1: https://www.redhat.com/archives/libvir-list/2019-February/msg00187.html
Much of this was R-by'd for V1 with caveats for splitting things out, etc.
Still since there isn't an end of release rush ;-) - I figure reposting
everything before doing any sort of push would be more prudent and
conserva
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/storage/storage_backend_gluster.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/storage/storage_backend_gluster.c
b/src/storage/storage_backend_gluster.c
index 559189fd1d..6759d7f1e5 100644
--- a/src/s
Let's make use of the auto __cleanup capabilities cleaning up any
now unnecessary goto paths.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/conf/storage_conf.c| 4 ++--
src/conf/storage_conf.h| 2 ++
src/storage/storage_backend_fs.c
Rather than having an error path, let's rework the code to allocate
and fill into an @authdef variable and then steal that into @ret when
we are successful leaving just a cleanup: path.
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/util/virstoragefile.c | 26 +---
Signed-off-by: John Ferlan
Reviewed-by: Erik Skultety
---
src/conf/domain_conf.c| 3 +--
src/conf/storage_conf.c | 3 +--
src/qemu/qemu_parse_command.c | 3 +--
src/util/virstoragefile.c | 3 +--
4 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/conf/domain_con
On 2/8/19 3:07 PM, Andrea Bolognani wrote:
On Fri, 2019-02-08 at 14:14 +0100, Jiri Denemark wrote:
On Fri, Feb 08, 2019 at 11:03:34 -0200, Daniel Henrique Barboza wrote:
Some devices creates empty (= cpu-less) NUMA nodes to host
its memory. This results in topologies where the following
sani
On Fri, 2019-02-08 at 14:14 +0100, Jiri Denemark wrote:
> On Fri, Feb 08, 2019 at 11:03:34 -0200, Daniel Henrique Barboza wrote:
> > Some devices creates empty (= cpu-less) NUMA nodes to host
> > its memory. This results in topologies where the following
> > sanity rule does not apply as is:
> >
>
On 2/7/19 3:28 AM, Pavel Hrdina wrote:
> On Wed, Feb 06, 2019 at 03:38:03PM -0500, Cole Robinson wrote:
>> On 1/23/19 3:59 PM, John Ferlan wrote:
>>> Add some comments to describe how to set up the QEMU environment
>>> prior to running the qemucapsprobe in order to allow for the
>>> creation of
Jobs have been renamed a while ago, and all Perl projects have
moved from ExtUtils::MakeMaker to Module::Build.
Signed-off-by: Andrea Bolognani
---
jenkins/README.markdown | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/jenkins/README.markdown b/jenkins/README.markdown
in
While the repository was initially intended to only store the
Jenkins-level job definitions, its scope has since been expanded
by adding tools to manage the guests such jobs will ultimately
be executed on; in fact, the latter currently takes up almost
ten times as many lines of code as the former.
We've split the 32-bit and 64-bit MinGW builds for a while,
so the relevant examples need to be updated.
Signed-off-by: Andrea Bolognani
---
guests/README.markdown | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guests/README.markdown b/guests/README.markdown
index 65beb6a..a
Since commit a7424faff QMP is always used.
Also, commit 932534e8 removed the last use of this apart from:
* parsing/formatting this in the caps cache
* using it as a temporary variable to know when to report an error
Signed-off-by: Ján Tomko
---
Note that the second use should be removed by this
It's best practice to have it, and that's already the case
for all Ansible-related files. Add it to Jenkins-related files
as well.
Signed-off-by: Andrea Bolognani
---
jenkins/jobs/autotools.yaml | 2 +-
jenkins/jobs/defaults.yaml| 2 +-
jenkins/jobs/generic.
Now that we have moved all Jenkins-specific files, including
the corresponding README, to their own directory, we need to
have a short explanation of what the repository is about and
how to navigate it.
Signed-off-by: Andrea Bolognani
---
README.markdown | 14 ++
1 file changed, 14 i
Andrea Bolognani (5):
jenkins: Move all Jenkins-related files
README: Add short overview of the repository
guests: Fix a small issue in README
jenkins: Fix a couple small issues in README
jenkins: Add YAML start of document marker
README.markdown | 56 -
On 2/7/19 3:36 AM, Erik Skultety wrote:
> On Wed, Feb 06, 2019 at 03:32:44PM -0500, Cole Robinson wrote:
>> On 1/23/19 3:59 PM, John Ferlan wrote:
>>> Commit d4005609 added "altered" capabilities replies output
>>> in order to fake a 'query-sev-capabilities' reply from QEMU.
>>> This worked fine
On 2/7/19 1:58 PM, Nikolay Shirokovskiy wrote:
If 2 threads call abort for example then one of them
will hang because client will send 2 abort messages and
server will reply only on first of them, the second will be
ignored. And on server reply client changes the state only
one of abort message t
On 2/7/19 1:58 PM, Nikolay Shirokovskiy wrote:
Signed-off-by: Nikolay Shirokovskiy
---
src/libvirt_remote.syms | 1 -
src/rpc/virnetclient.c | 22 --
2 files changed, 23 deletions(-)
Forgot to remove it from the header file.
Michal
--
libvir-list mailing list
libvi
On 2/7/19 1:58 PM, Nikolay Shirokovskiy wrote:
Checking virNetClientStreamRaiseError without client lock
is racy which is fixed in [1] for example. Thus let's remove such checks
when we are sending message to server. And in other cases
(like virNetClientStreamRecvHole for example) let's move the
On 2/7/19 1:58 PM, Nikolay Shirokovskiy wrote:
Nikolay Shirokovskiy (9):
rpc: fix race on stream abort/finish and server side abort
rpc: use single function to send stream messages
rpc: remove unused virNetClientSendNoReply
rpc: fix propagation of errors from server
rpc: add mising
On 2/8/19 3:07 AM, Erik Skultety wrote:
> On Wed, Feb 06, 2019 at 08:41:47AM -0500, John Ferlan wrote:
>> Let's make use of the auto __cleanup capabilities cleaning up any
>> now unnecessary goto paths. A few methods were modified to use a
>> more common methodology of defining/using @def and th
On 2/7/19 9:32 AM, Erik Skultety wrote:
> On Wed, Feb 06, 2019 at 08:41:41AM -0500, John Ferlan wrote:
>> Let's make use of the auto __cleanup capabilities cleaning up any
>> now unnecessary goto paths.
>>
>> Signed-off-by: John Ferlan
>> ---
>
> [snip]
>
>> @@ -3804,7 +3713,7 @@ virStorageBa
[...]
>> diff --git a/src/storage/storage_backend_iscsi_direct.c
>> b/src/storage/storage_backend_iscsi_direct.c
>> index 82fa4d7a25..6458b0f835 100644
>> --- a/src/storage/storage_backend_iscsi_direct.c
>> +++ b/src/storage/storage_backend_iscsi_direct.c
>> @@ -421,15 +421,14 @@ virISCSIDirectUp
The VIR_MIGRATE_PARALLEL flag is implemented using QEMU's multifd
migration capability and the corresponding multifd-channels migration
parameter.
Signed-off-by: Jiri Denemark
---
Notes:
QEMU still uses the x- prefix for multifd capability and multifd-channels,
but Juan already sent a se
This patch adds a new VIR_MIGRATE_PARALLEL flag for migration APIs which
will ask the hypervisor to use multiple parallel connections for
migrating a domain. The number of parallel connections can be set using
VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS typed parameter.
Signed-off-by: Jiri Denemark
--
This series adds a new VIR_MIGRATE_PARALLEL flag for migration APIs
which will ask the hypervisor to use multiple parallel connections for
migrating a domain. The number of parallel connections can be set using
VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS typed parameter.
Version 2:
- rebased
Jiri Dene
Signed-off-by: Jiri Denemark
---
tools/virsh-domain.c | 19 +++
tools/virsh.pod | 7 +++
2 files changed, 26 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 8b20059335..c704faf7e1 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
On Thu, 2019-02-07 at 14:31 +0300, Nikolay Shirokovskiy wrote:
[...]
> @@ -393,9 +393,11 @@ qemuBuildDeviceAddressStr(virBufferPtr buf,
>info->addr.ccw.ssid,
>info->addr.ccw.devno);
> } else if (info->type == VIR_DOMAIN_DEVICE_ADD
[...]
>> @@ -1590,14 +1590,12 @@ virStoragePoolObjLoad(virStoragePoolObjListPtr pools,
>> _("Storage pool config filename '%s' does "
>> "not match pool name '%s'"),
>> path, def->name);
>> -virStoragePoolDefFree(
On Thu, 2019-02-07 at 14:31 +0300, Nikolay Shirokovskiy wrote:
[...]
> @@ -4392,6 +4393,9 @@ virDomainDefAddConsoleCompat(virDomainDefPtr def)
>
> switch ((virDomainChrSerialTargetType) def->serials[0]->targetType) {
> case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_ISA:
> +i
On 2/7/19 12:36 AM, Cole Robinson wrote:
Commit fafcc818f changed the docs to say that when creating a
pool directory or file volume with no owner/group specified, they
will be inherited from the parent directory. This isn't correct
now and doesn't seem to have ever been correct
In reality defau
On 2/6/19 5:09 PM, Jiri Denemark wrote:
The VIR_MIGRATE_PARALLEL flag is implemented using QEMU's multifd
migration capability and the corresponding multifd-channels migration
parameter.
Signed-off-by: Jiri Denemark
---
Notes:
QEMU still uses the x- prefix for multifd capability and multi
On 2/6/19 2:46 PM, Andrea Bolognani wrote:
A while ago I was looking at the code and got annoyed by the lack
of consistency, both internal and external. This series addresses
most of it.
Andrea Bolognani (9):
qemu: Remove redundant condition
qemu: Use more specific prefixes
qemu: Move f
On Fri, Feb 08, 2019 at 11:03:34 -0200, Daniel Henrique Barboza wrote:
> Some devices creates empty (= cpu-less) NUMA nodes to host
> its memory. This results in topologies where the following
> sanity rule does not apply as is:
>
> nodes * sockets * cores * threads = total_cpus
>
> As a result,
Some devices creates empty (= cpu-less) NUMA nodes to host
its memory. This results in topologies where the following
sanity rule does not apply as is:
nodes * sockets * cores * threads = total_cpus
As a result, a call to 'virsh nodeinfo' will return the default
value (1) to nodes, sockets and th
On Fri, Feb 08, 2019 at 06:52:08AM -0500, John Ferlan wrote:
> For consistency, let's use the semicolon for all definitions.
>
> Signed-off-by: John Ferlan
> ---
>
> As discussed in the other series -
Reviewed-by: Erik Skultety
--
libvir-list mailing list
libvir-list@redhat.com
https://www.red
For consistency, let's use the semicolon for all definitions.
Signed-off-by: John Ferlan
---
As discussed in the other series -
src/qemu/qemu_migration_params.h | 2 +-
src/util/virauthconfig.h | 2 +-
src/util/virbitmap.h | 2 +-
src/util/virbuffer.c | 2 +-
On Fri, 2019-02-08 at 11:46 +0100, Erik Skultety wrote:
> Luckily, the new URL still points to the same location, the only change
> is in the document name where an escaped space (%20) was replaced by an
> underscore.
>
> Signed-off-by: Erik Skultety
> ---
> docs/formatdomain.html.in | 4 ++-
Move the majority of the packet-libvirt.h content into
packet-libvirt.c and expose only register functions which are the
only ones that are not static.
The rationale behind is that packet-libvirt.h will be included
from packet.c and therefore the header file needs to be as clean
as possible.
Sign
The wireshark-2.4.0 is almost 2 years old now. Assuming anybody
interested in running latest libvirt doesn't run old wireshark,
it is safe to do this. It also simplifies the code.
Signed-off-by: Michal Privoznik
---
libvirt.spec.in | 8 ++
m4/virt-wireshark.m4
In order to be able to dissect libvirt protocol the wireshark
plugin needs to be registered. So far this plugin registration
code was generated on every build using a script that was copied
over from wireshark's tools/ directory.
This is suboptimal, because the way that plugins register changes
ac
While implementing some other feature I wanted to use wireshark to debug
a migration issue. Only then I found that our wireshark plugin is no
longer being loaded. Here are the fixes.
Michal Prívozník (5):
tools: Cleanup packet-libvirt.h
tools: Keep wireshark plugin registration code in git
w
Since wirshark-2.5.0 toplevel plugins are no longer loaded. Only
plugins from epan/, wiretap/ or codecs/ subdirs are. Update the
plugin dir we generate. This is safe to do even for older
wiresharks, since they load plugins from there too.
Signed-off-by: Michal Privoznik
---
libvirt.spec.in
As advertised in previous commits, wireshark has changed the way
that plugins register. In fact, it has done so two times since
the last time we've touched our code (wireshark v2.5.0 and
v2.9.0). Use the wireshark script from respective releases to
generate newer registration callbacks and put them
On Thu, Feb 07, 2019 at 14:46:41 +0100, Markus Armbruster wrote:
> Peter Krempa writes:
>
> > On Wed, Feb 06, 2019 at 12:42:05 -0600, Eric Blake wrote:
> >> Adding libvirt in cc
> >>
> >> On 2/6/19 12:17 PM, Markus Armbruster wrote:
> >> > query-events doesn't reflect compile-time configuration.
Luckily, the new URL still points to the same location, the only change
is in the document name where an escaped space (%20) was replaced by an
underscore.
Signed-off-by: Erik Skultety
---
docs/formatdomain.html.in | 4 ++--
docs/formatdomaincaps.html.in | 2 +-
2 files changed, 3 insertions
On Tue, 2019-02-05 at 17:52 +, Daniel P. Berrangé wrote:
> Changed in v2:
>
> - Fix multiple package name mistakes
> - Modify lcitool to generate cross-arch docker files
> - Add --no-install-recommended flag to apt-get
> - Add DEBIAN_FRONTEND=noninteractive env to apt-get
> - Improve erro
On Tue, 2019-02-05 at 17:53 +, Daniel P. Berrangé wrote:
[...]
> +++ b/dockerfiles/Makefile
So this is basically very similar to
https://libvirt.org/git/?p=libvirt-dockerfiles.git;a=blob;f=refresh
and I feel like it belongs to that repository rather than this one.
That causes a bit of inc
On Fri, Feb 08, 2019 at 08:29:07 +0100, Peter Krempa wrote:
> On Thu, Feb 07, 2019 at 18:15:06 +0100, Ján Tomko wrote:
> > On Mon, Feb 04, 2019 at 04:47:04PM +0100, Peter Krempa wrote:
> > > QEMU accidentally exposed the id of -drive (or same value as disk
> > > serial, if provided) in one of the i
1 - 100 of 102 matches
Mail list logo
