Re: [libvirt] [PATCH v2 0/7] fix snapshot --redefine bugs (incremental backup saga)

2019-02-28 Thread John Ferlan
On 2/27/19 3:04 PM, Eric Blake wrote: > John pointed out that patch 2 of my original bug fix did too > much in one patch. Now that we are in freeze for 5.1, I've > proposed two variants of the same fix: patch 1 is the bare > minimum to fix the bug and nothing else, while patches 3-7 > are more i

Re: [libvirt] [PATCH] xml: nodedev: add class info for pci capability

2019-02-28 Thread John Ferlan
On 2/19/19 8:17 AM, Nikolay Shirokovskiy wrote: > This info can be useful to filter devices visible > to mgmt clients so that they won't see devices that > unsafe/not meaningful to pass thru. > > Provide class info the way it is provided by udev or > kernel that is as single 6-digit hexadecimal

Re: [libvirt] [jenkins-ci PATCH v5 5/5] lcitool: support generating cross compiler dockerfiles

2019-02-28 Thread Daniel P . Berrangé
On Thu, Feb 28, 2019 at 06:46:41PM +0100, Andrea Bolognani wrote: > On Thu, 2019-02-28 at 15:52 +, Daniel P. Berrangé wrote: > > On Tue, Feb 26, 2019 at 07:04:16PM +0100, Andrea Bolognani wrote: > [...] > > > > + i686: > > > > +package_arch: i386 > > > > +abi: i686-linux-gnu > > > > +

Re: [libvirt] [jenkins-ci PATCH v5 5/5] lcitool: support generating cross compiler dockerfiles

2019-02-28 Thread Andrea Bolognani
On Thu, 2019-02-28 at 15:52 +, Daniel P. Berrangé wrote: > On Tue, Feb 26, 2019 at 07:04:16PM +0100, Andrea Bolognani wrote: [...] > > > +++ b/guests/host_vars/libvirt-debian-9/main.yml > > > @@ -21,3 +21,47 @@ os_name: 'Debian' > > > os_version: '9' > > > > > > ansible_python_interpreter:

[libvirt] [PATCH 0/3] tests: Clean up qemuxml2xml a bit

2019-02-28 Thread Andrea Bolognani
Just your average yak shaving, really. Andrea Bolognani (3): tests: Rename some qemuxml2xml output files for clarity tests: Use WHEN_BOTH in qemuxml2xml whenever possible tests: Add -inactive suffix when appropriate for qemuxml2xml ...ml => channel-unix-source-path-active.xml} | 3 + ...

[libvirt] [PATCH 1/3] tests: Rename some qemuxml2xml output files for clarity

2019-02-28 Thread Andrea Bolognani
disk-mirror-old has different output file for the active and inactive parts, which should be named accordingly; on the other hand, both output files for disk-backing-chains-noindex are identical, so it makes sense to only keep around one and remove the (in-)active suffix. Signed-off-by: Andrea Bol

[libvirt] [PATCH 2/3] tests: Use WHEN_BOTH in qemuxml2xml whenever possible

2019-02-28 Thread Andrea Bolognani
There are a few cases where we are using either WHEN_ACTIVE or WHEN_INACTIVE even though WHEN_BOTH would work perfectly fine: for those, start using the simpler DO_TEST() macro. Signed-off-by: Andrea Bolognani --- ...ource-path.xml => channel-unix-source-path-active.xml} | 3 +++ ...rce-path.xml

[libvirt] [PATCH 3/3] tests: Add -inactive suffix when appropriate for qemuxml2xml

2019-02-28 Thread Andrea Bolognani
Some test cases are only executed using WHEN_INACTIVE, and the output file name should reflect this for clarity. Signed-off-by: Andrea Bolognani --- I'm actually not entirely convinced I prefer having the -inactive suffix for these files, but I figured I'd still post the patch and see what other

Re: [libvirt] [PATCH 26/26] cpu_map: Add more signatures for Skylake-Client CPU models

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:16PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu_map/x86_Skylake-Client-IBRS.xml | 5 + src/cpu_map/x86_Skylake-Client.xml | 5 + 2 files changed, 10 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP

Re: [libvirt] [PATCH 25/26] cpu_map: Add more signatures for Broadwell CPU models

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:15PM +0100, Jiri Denemark wrote: This fixes several CPUs which were incorrectly detected as Skylake-Client. Signed-off-by: Jiri Denemark --- src/cpu_map/x86_Broadwell-IBRS.xml| 3 +++ src/cpu_map/x86_Broadwell-noTSX-IBRS.xml | 3 ++

Re: [libvirt] [PATCH 24/26] cpu_map: Add more signatures for Haswell CPU models

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:14PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu_map/x86_Haswell-IBRS.xml | 3 +++ src/cpu_map/x86_Haswell-noTSX-IBRS.xml | 3 +++ src/cpu_map/x86_Haswell-noTSX.xml | 3 +++ What do we have here? src/cpu_map/x86_Haswell.xml

Re: [libvirt] [PATCH 23/26] cpu_map: Add more signatures for IvyBridge CPU models

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:13PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu_map/x86_IvyBridge-IBRS.xml | 1 + src/cpu_map/x86_IvyBridge.xml | 1 + 2 files changed, 2 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir

Re: [libvirt] [PATCH 22/26] cpu_map: Add more signatures for SandyBridge CPU models

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:12PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu_map/x86_SandyBridge-IBRS.xml | 1 + src/cpu_map/x86_SandyBridge.xml | 1 + 2 files changed, 2 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- li

Re: [libvirt] [PATCH 21/26] cpu_map: Add more signatures for Westmere CPU model

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:11PM +0100, Jiri Denemark wrote: This fixes several CPUs which were incorrectly detected as a different CPU model. Neat. Signed-off-by: Jiri Denemark --- src/cpu_map/x86_Westmere.xml | 2 ++ tests/cputestdata/x86_64-cpuid-Core-i5-650-j

Re: [libvirt] [PATCH 20/26] cpu_map: Add more signatures for Nehalem CPU models

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:10PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu_map/x86_Nehalem-IBRS.xml | 3 +++ src/cpu_map/x86_Nehalem.xml | 3 +++ 2 files changed, 6 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir

Re: [libvirt] [PATCH 19/26] cpu_map: Add more signatures for Penryn CPU model

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:09PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu_map/x86_Penryn.xml | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://w

Re: [libvirt] [PATCH 18/26] cpu_map: Add more signatures for Conroe CPU model

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:08PM +0100, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- src/cpu_map/x86_Conroe.xml | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://w

Re: [libvirt] [PATCH 17/26] cputest: Test CPU signatures

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:07PM +0100, Jiri Denemark wrote: The signature computation code is not too complicated and it will likely never change so testing it is not very important. We do it mostly for a nice side effect of easily accessible signature numbers for all CPU data files. Signed-o

Re: [libvirt] [PATCH 16/26] cpu_map: Add hex representation of signatures

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:06PM +0100, Jiri Denemark wrote: The family/model numbers are nice for humans or for comparing with /proc/cpuinfo, but sometimes there's a need to see the CPUID representation of the signature. Let's add it into a comment for each signature in out cpu_map XMLs as the

Re: [libvirt] [PATCH 15/26] cpu_x86: Add virCPUx86DataGetSignature for tests

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:05PM +0100, Jiri Denemark wrote: The function exports the functionality of x86DataToSignatureFull and x86MakeSignature to the test suite. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c| 12 src/cpu/cpu_x86.h| 5 + src/libvirt_pri

Re: [libvirt] [jenkins-ci PATCH v6 0/4] Add support for cross compiling libvirt via Debian

2019-02-28 Thread Daniel P . Berrangé
Forgot to mention that while I tested with Debian 9, I'm unable to test on Sid right now since the cross toolchain is busted failing to find deps in the apt repos On Thu, Feb 28, 2019 at 03:53:15PM +, Daniel P. Berrangé wrote: > Changed in v6: > > - Use a static mapping for arch info > - Sp

Re: [libvirt] [PATCH 11/26] cpu_x86: Allow multiple signatures for a CPU model

2019-02-28 Thread Jiri Denemark
On Thu, Feb 28, 2019 at 16:27:34 +0100, Ján Tomko wrote: > On Wed, Feb 27, 2019 at 02:29:01PM +0100, Jiri Denemark wrote: > >CPU signatures in the cpu_map serve as a hint for CPUID to CPU model > >matching algorithm. If the CPU signatures matches any CPU model in the > >cpu_map, this model will be

Re: [libvirt] [PATCH 14/26] qemu_capabilities: Use virQEMUCapsGetCPUModelInfo

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:04PM +0100, Jiri Denemark wrote: Most places in qemu_capabilities.c which call virQEMUCapsGetHostCPUData actually need qemuMonitorCPUModelInfoPtr from QEMU caps. Let's use the wrapper introduced in the previous commit instead. Signed-off-by: Jiri Denemark --- src/q

[libvirt] [jenkins-ci PATCH v6 3/4] lcitool: support generating cross compiler dockerfiles

2019-02-28 Thread Daniel P . Berrangé
Debian's filesystem layout has a nice advantage over Fedora which is that it can install non-native packages in the main root filesystem. It is thus possible to prepare an x86_64 filesystem containing -dev packages for a foreign architecture, along with a GCC cross compiler. QEMU has used this tec

[libvirt] [jenkins-ci PATCH v6 1/4] mappings: extend mapping to allow per-arch entries

2019-02-28 Thread Daniel P . Berrangé
For example to prevent Xen being installed on any s390x xen: deb: libxen-dev Fedora: xen-devel s390x-default: Or the inverse to only install Xen on x86_64 on Debian, but allow it on all archs on Fedora xen: Fedora: xen-devel x86_64-deb: libxen-dev Note that the architect

[libvirt] [jenkins-ci PATCH v6 4/4] mappings: mark packages using foreign arch for cross builds

2019-02-28 Thread Daniel P . Berrangé
All the -dev packages in Debian should use the foreign arch when setting up cross-builds, rather than than native arch package. Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 58 +++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --gi

[libvirt] [jenkins-ci PATCH v6 0/4] Add support for cross compiling libvirt via Debian

2019-02-28 Thread Daniel P . Berrangé
Changed in v6: - Use a static mapping for arch info - Split out data file changes from code changes - Change arch suffix to a prefix Changed in v5: - Remove redundant formatter class - Update commit message - Update readme - Move misplaced patch chunk - Dont set "dest" in arg when not ne

[libvirt] [jenkins-ci PATCH v6 2/4] mappings: filter arch usage for libnuma / xen

2019-02-28 Thread Daniel P . Berrangé
Both libnuma and xen are only available on a subset of architectures so need to be filtered accordingly. Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml ind

Re: [libvirt] [jenkins-ci PATCH v5 5/5] lcitool: support generating cross compiler dockerfiles

2019-02-28 Thread Daniel P . Berrangé
On Tue, Feb 26, 2019 at 07:04:16PM +0100, Andrea Bolognani wrote: > On Tue, 2019-02-26 at 11:00 +, Daniel P. Berrangé wrote: > > Debian's filesystem layout has a nice advantage over Fedora which is > > that it can install non-native RPMs > > s/RPMs/packages/ ;) > > [...] > > guests/host_vars

Re: [libvirt] [PATCH 13/26] qemu_capabilities: Introduce virQEMUCapsGetCPUModelInfo

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:03PM +0100, Jiri Denemark wrote: This is a simple wrapper around virQEMUCapsGetHostCPUData usable in tests for getting qemuMonitorCPUModelInfoPtr from QEMU caps. Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 10 ++ src/qemu/qemu_capspriv.h

[libvirt] [PATCH v2 8/7] news: More 5.1 updates

2019-02-28 Thread Eric Blake
Mention my snapshot bug fixes, and the corresponding virsh command-line parse tweak I added while working on the snapshot bug fixes. Signed-off-by: Eric Blake --- This should be valid whether we go with variant1 or variant2 from the rest of the series. docs/news.xml | 21 +

Re: [libvirt] [PATCH 12/26] qemu_capabilities: Inroduce virQEMUCapsGetCPUModelX86Data

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:02PM +0100, Jiri Denemark wrote: The code for transforming qemuMonitorCPUModelInfo data from QEMU into virCPUDefPtr consumable by virCPU* APIs was hidden inside virQEMUCapsInitCPUModelX86. This patch moves it into a new function to make it usable in tests. Signed-of

Re: [libvirt] [PATCH v2] storage: Fix iscsi-direct volume size for volumes > 4GiB

2019-02-28 Thread Michal Privoznik
On 2/28/19 4:10 PM, Jiri Denemark wrote: Both block_size and nb_block are unit32_t and multiplying them overflows at 4GiB. Moreover, the iscsi_*10_* APIs use 32bit number of blocks and thus they can only address images up to 2TiB with 512B blocks. Let's use 64b iscsi_*16_* APIs instead. Signed-

Re: [libvirt] [PATCH 11/26] cpu_x86: Allow multiple signatures for a CPU model

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:01PM +0100, Jiri Denemark wrote: CPU signatures in the cpu_map serve as a hint for CPUID to CPU model matching algorithm. If the CPU signatures matches any CPU model in the cpu_map, this model will be the preferred one. This works out well and solved several mismatc

[libvirt] [PATCH v2] storage: Fix iscsi-direct volume size for volumes > 4GiB

2019-02-28 Thread Jiri Denemark
Both block_size and nb_block are unit32_t and multiplying them overflows at 4GiB. Moreover, the iscsi_*10_* APIs use 32bit number of blocks and thus they can only address images up to 2TiB with 512B blocks. Let's use 64b iscsi_*16_* APIs instead. Signed-off-by: Jiri Denemark --- Notes: Vers

Re: [libvirt] [PATCH] news: Trivial style fixes

2019-02-28 Thread no-reply
Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: 20190228142452.22209-1-abolo...@redhat.com Subject: [libvirt] [PATCH] news: Trivial style fixes === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will b

Re: [libvirt] [PATCH] storage: Fix iscsi-direct volume size for volumes > 4GiB

2019-02-28 Thread Jiri Denemark
On Thu, Feb 28, 2019 at 15:22:00 +0100, Jiri Denemark wrote: > Both block_size and nb_block are unit32_t. > > Signed-off-by: Jiri Denemark > --- > src/storage/storage_backend_iscsi_direct.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/storage/storage_backend_

Re: [libvirt] [PATCH] virISCSIDirectRefreshVol: Don't clear volumes in each run

2019-02-28 Thread Jiri Denemark
On Thu, Feb 28, 2019 at 15:44:46 +0100, Michal Privoznik wrote: > When fetching LUNs from iscsi server the > virISCSIDirectReportLuns() is called. This function does some > libiscsi calls and then calls virISCSIDirectRefreshVol() over > each LUN found. It's unfortunate that the latter calls > virSt

[libvirt] [PATCH] virISCSIDirectRefreshVol: Don't clear volumes in each run

2019-02-28 Thread Michal Privoznik
When fetching LUNs from iscsi server the virISCSIDirectReportLuns() is called. This function does some libiscsi calls and then calls virISCSIDirectRefreshVol() over each LUN found. It's unfortunate that the latter calls virStoragePoolObjClearVols() as we lose all LUNs processed in previous iteratio

Re: [libvirt] [PATCH v2 4/4] util: alloc: Note that VIR_AUTOPTR/VIR_AUTOCLEAN must not be used with vectors

2019-02-28 Thread Erik Skultety
On Thu, Feb 28, 2019 at 02:56:36PM +0100, Peter Krempa wrote: > On Wed, Feb 27, 2019 at 15:05:18 +0100, Erik Skultety wrote: > > On Tue, Feb 26, 2019 at 04:48:26PM +0100, Peter Krempa wrote: > > > We'd free only the first element of the vector leaking the rest. > > > > > > Signed-off-by: Peter Krem

Re: [libvirt] [PATCH v2 1/4] util: string: Introduce macro for automatic string lists

2019-02-28 Thread Erik Skultety
On Wed, Feb 27, 2019 at 01:32:43PM +0100, Michal Privoznik wrote: > On 2/27/19 10:52 AM, Erik Skultety wrote: > > On Tue, Feb 26, 2019 at 04:48:23PM +0100, Peter Krempa wrote: > > > Similar to VIR_AUTOPTR, VIR_AUTOSTRINGLIST defines a list of strings > > > which will be freed if the pointer is leav

Re: [libvirt] [PATCH v4 12/20] wip: backup: Parse and output backup XML

2019-02-28 Thread John Ferlan
[...] >> >> Ahh... so this is where it's referenced... I recall this from RNG... > > Which also raises the question of whether the RNG has to call it out, if > the only thing using it is internal code, or if the user will ever see > it. We have the interesting problem of outputting some thing

[libvirt] [PATCH] news: Trivial style fixes

2019-02-28 Thread Andrea Bolognani
Some of the recent entries deviated from the established style used throughout the file, so let's fix them. Signed-off-by: Andrea Bolognani --- Pushed as trivial. docs/news.xml | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/docs/news.xml b/doc

[libvirt] [PATCH] storage: Fix iscsi-direct volume size for volumes > 4GiB

2019-02-28 Thread Jiri Denemark
Both block_size and nb_block are unit32_t. Signed-off-by: Jiri Denemark --- src/storage/storage_backend_iscsi_direct.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_iscsi_direct.c b/src/storage/storage_backend_iscsi_direct.c index 20997d5c5d

Re: [libvirt] [PATCH v2 4/4] util: alloc: Note that VIR_AUTOPTR/VIR_AUTOCLEAN must not be used with vectors

2019-02-28 Thread Peter Krempa
On Wed, Feb 27, 2019 at 15:05:18 +0100, Erik Skultety wrote: > On Tue, Feb 26, 2019 at 04:48:26PM +0100, Peter Krempa wrote: > > We'd free only the first element of the vector leaking the rest. > > > > Signed-off-by: Peter Krempa > > --- > > src/util/viralloc.h | 6 ++ > > 1 file changed, 6 i

Re: [libvirt] [PATCH v2 1/4] util: string: Introduce macro for automatic string lists

2019-02-28 Thread John Ferlan
On 2/28/19 8:39 AM, Peter Krempa wrote: > On Wed, Feb 27, 2019 at 10:52:47 +0100, Erik Skultety wrote: >> On Tue, Feb 26, 2019 at 04:48:23PM +0100, Peter Krempa wrote: >>> Similar to VIR_AUTOPTR, VIR_AUTOSTRINGLIST defines a list of strings >>> which will be freed if the pointer is leaving scope

Re: [libvirt] [PATCH v2 1/4] util: string: Introduce macro for automatic string lists

2019-02-28 Thread Peter Krempa
On Wed, Feb 27, 2019 at 13:32:43 +0100, Michal Privoznik wrote: > On 2/27/19 10:52 AM, Erik Skultety wrote: > > On Tue, Feb 26, 2019 at 04:48:23PM +0100, Peter Krempa wrote: > > > Similar to VIR_AUTOPTR, VIR_AUTOSTRINGLIST defines a list of strings > > > which will be freed if the pointer is leavin

Re: [libvirt] [PATCH for 5.1.0] news: Update for 5.1.0 release

2019-02-28 Thread John Ferlan
[...] >>> +  >>> +    >>> +  Add storage pool namespace options >>> +    >>> +    >>> +  Allow for adjustment of RBD configuration options via Storage >>> +  Pool XML Namespace adjustments. >>> +    >>> +  >> >> I deliberately left this out pri

Re: [libvirt] [PATCH v2 1/4] util: string: Introduce macro for automatic string lists

2019-02-28 Thread Peter Krempa
On Wed, Feb 27, 2019 at 10:52:47 +0100, Erik Skultety wrote: > On Tue, Feb 26, 2019 at 04:48:23PM +0100, Peter Krempa wrote: > > Similar to VIR_AUTOPTR, VIR_AUTOSTRINGLIST defines a list of strings > > which will be freed if the pointer is leaving scope. > > > > Signed-off-by: Peter Krempa > > ---

Re: [libvirt] [PATCH for 5.1.0] news: Update for 5.1.0 release

2019-02-28 Thread Michal Privoznik
On 2/28/19 1:23 PM, John Ferlan wrote: On 2/28/19 5:43 AM, Michal Privoznik wrote: Not exhaustive list of new features, improvements and bugfixes. Signed-off-by: Michal Privoznik --- docs/news.xml | 201 ++ 1 file changed, 201 insertions(+)

Re: [libvirt] [PATCH for 5.1.0] news: Update for 5.1.0 release

2019-02-28 Thread Ján Tomko
On Thu, Feb 28, 2019 at 11:43:56AM +0100, Michal Privoznik wrote: Not exhaustive list of new features, improvements and bugfixes. Signed-off-by: Michal Privoznik --- docs/news.xml | 201 ++ 1 file changed, 201 insertions(+) diff --git a/docs/news.

Re: [libvirt] [PATCH 10/26] cpu_x86: Make sure CPU model names are unique in cpu_map

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:29:00PM +0100, Jiri Denemark wrote: Having multiple CPU model definitions with the same name could result in unexpected behavior. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Ján Tomko

Re: [libvirt] [PATCH 09/26] cpu_x86: Separate feature list parsing from x86ModelParse

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:28:59PM +0100, Jiri Denemark wrote: The code is separated into a new x86ModelParseFeatures function. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 68 +++ 1 file changed, 39 insertions(+), 29 deletions(-) Reviewed-b

Re: [libvirt] [PATCH 08/26] cpu_x86: Separate vendor parsing from x86ModelParse

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:28:58PM +0100, Jiri Denemark wrote: The code is separated into a new x86ModelParseVendor function. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 50 ++- 1 file changed, 32 insertions(+), 18 deletions(-) Reviewed-by:

Re: [libvirt] [PATCH for 5.1.0] news: Update for 5.1.0 release

2019-02-28 Thread Andrea Bolognani
On Thu, 2019-02-28 at 11:43 +0100, Michal Privoznik wrote: > Not exhaustive list of new features, improvements and bugfixes. > > Signed-off-by: Michal Privoznik > --- > docs/news.xml | 201 ++ > 1 file changed, 201 insertions(+) First of all, than

Re: [libvirt] [PATCH 07/26] cpu_x86: Separate signature parsing from x86ModelParse

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:28:57PM +0100, Jiri Denemark wrote: The code is separated into a new x86ModelParseSignature function. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 58 --- 1 file changed, 35 insertions(+), 23 deletions(-) Reviewed-

Re: [libvirt] [PATCH for 5.1.0] news: Update for 5.1.0 release

2019-02-28 Thread John Ferlan
On 2/28/19 5:43 AM, Michal Privoznik wrote: > Not exhaustive list of new features, improvements and bugfixes. > > Signed-off-by: Michal Privoznik > --- > docs/news.xml | 201 ++ > 1 file changed, 201 insertions(+) > > diff --git a/docs/news.xml

Re: [libvirt] [PATCH 06/26] cpu_x86: Separate ancestor model parsing from x86ModelParse

2019-02-28 Thread Ján Tomko
On Wed, Feb 27, 2019 at 02:28:56PM +0100, Jiri Denemark wrote: The code is separated into a new x86ModelParseAncestor function. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 65 +++ 1 file changed, 38 insertions(+), 27 deletions(-) Reviewed-b

Re: [libvirt] [PATCH] iscsi_direct: Reset pool capacity and allocation just before refresh

2019-02-28 Thread Pavel Hrdina
On Thu, Feb 28, 2019 at 12:03:47PM +0100, Michal Privoznik wrote: > Jirka reported a bug that with every 'virsh pool-refresh' an > iscsi-direct pool would grow and grow. The problem is that > virISCSIDirectRefreshVol() only adds to def->capacity and > def->allocation but nothing clears it out to be

Re: [libvirt] [PATCH v1 13/15] qemuDomainDefValidate: Don't require SMM if automatic firmware selection enabled

2019-02-28 Thread Laszlo Ersek
On 02/27/19 11:04, Michal Privoznik wrote: > The firmware selection code will enable the feature if needed. > There's no need to require SMM to be enabled in that case. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_domain.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >

Re: [libvirt] [PATCH v1 11/15] qemu_firmware: Introduce qemuFirmwareFillDomain()

2019-02-28 Thread Laszlo Ersek
On 02/27/19 11:04, Michal Privoznik wrote: > And finally the last missing piece. This is what puts it all > together. > > At the beginning, qemuFirmwareFillDomain() loads all possible > firmware description files based on algorithm described earlier. > Then it tries to find description which match

[libvirt] [PATCH] iscsi_direct: Reset pool capacity and allocation just before refresh

2019-02-28 Thread Michal Privoznik
Jirka reported a bug that with every 'virsh pool-refresh' an iscsi-direct pool would grow and grow. The problem is that virISCSIDirectRefreshVol() only adds to def->capacity and def->allocation but nothing clears it out to begin with. Signed-off-by: Michal Privoznik --- src/storage/storage_backe

[libvirt] [PATCH for 5.1.0] news: Update for 5.1.0 release

2019-02-28 Thread Michal Privoznik
Not exhaustive list of new features, improvements and bugfixes. Signed-off-by: Michal Privoznik --- docs/news.xml | 201 ++ 1 file changed, 201 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 9c5ae7e8a3..813f1a93e3 100644 --- a/docs

Re: [libvirt] [PATCH v1 10/15] qemufirmwaretest: Test qemuFirmwareFetchConfigs()

2019-02-28 Thread Laszlo Ersek
On 02/27/19 11:04, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > tests/Makefile.am | 1 + > .../etc/qemu/firmware/40-ovmf-sb.json | 1 + > .../etc/qemu/firmware/60-ovmf.json| 0 > .../user/.config/qemu/firmware/10-bios.json

Re: [libvirt] [PATCH v1 09/15] qemu_firmware: Introduce qemuFirmwareFetchConfigs

2019-02-28 Thread Laszlo Ersek
On 02/27/19 11:04, Michal Privoznik wrote: > Implementation for yet another part of firmware description > specification. This one covers selecting which files to parse. > > There are three locations from which description files can be > loaded. In order of preference, from most generic to most >

Re: [libvirt] [PATCH] tools/virt-host-validate: Fix IOMMU check on s390x

2019-02-28 Thread Boris Fiuczynski
On 2/27/19 10:48 AM, Thomas Huth wrote: On 27/02/2019 10.15, Bjoern Walk wrote: With further testing... Thomas Huth [2019-02-26, 12:02PM +0100]: When running virt-host-validate on an s390x host, the tool currently warns that it is "Unknown if this platform has IOMMU support". We can use the c

Re: [libvirt] [PATCH v1 08/15] test: Introduce qemufirmwaretest

2019-02-28 Thread Laszlo Ersek
On 02/27/19 11:04, Michal Privoznik wrote: > Test firmware description parsing so far. > > Signed-off-by: Michal Privoznik > --- > tests/Makefile.am | 9 > tests/qemufirmwaredata/40-bios.json| 35 + > tests/qemufirmwaredata/50-ovmf-sb.json | 36

Re: [libvirt] [PATCH v1 07/15] qemu: Introduce basic skeleton for parsing firmware description

2019-02-28 Thread Laszlo Ersek
On 02/27/19 11:04, Michal Privoznik wrote: > The firmware description is a JSON file which follows > specification from qemu.git/docs/interop/firmware.json. The > description file basically says: Firmware file X is {bios|uefi}, > supports these targets and machine types, requires these features > t

Re: [libvirt] [PATCH v1 06/15] conf: Introduce firmware attribute to

2019-02-28 Thread Laszlo Ersek
On 02/27/19 11:04, Michal Privoznik wrote: > The idea is that using this attribute users enable libvirt to > automagically select firmware image for their domain. For > instance: > > > hvm > > > > > hvm > > > (The automagic of selecting firmware image will be described i

Re: [libvirt] [PATCH v1 05/15] conf: Introduce VIR_DOMAIN_LOADER_TYPE_NONE

2019-02-28 Thread Laszlo Ersek
On 02/27/19 11:04, Michal Privoznik wrote: > This is going to extend virDomainLoader enum. The reason is that > once loader path is NULL its type makes no sense. However, since > value of zero corresponds to VIR_DOMAIN_LOADER_TYPE_ROM the > following XML would be produced: > > > > ...

Re: [libvirt] [PATCH v1 04/15] virDomainLoaderDefParseXML: Allow loader path to be NULL

2019-02-28 Thread Laszlo Ersek
On 02/27/19 11:04, Michal Privoznik wrote: > Except not really. At least for now. > > In the future, the firmware will be selected automagically. > Therefore, it makes no sense to require path to one in the domain I suggest replacing "path to one" with "the pathname of a specific firmware binary"

Re: [libvirt] [PATCH v1 03/15] qemu_capabilities: Expose qemu <-> libvirt arch translators

2019-02-28 Thread Laszlo Ersek
On 02/27/19 11:04, Michal Privoznik wrote: > In some cases, the string representing architecture is different > in qemu and libvirt. That is the reason why we have > virQEMUCapsArchFromString() and virQEMUCapsArchToString(). So > far, we did not need them outside of qemu_capabilities code, but > th

Re: [libvirt] [PATCH v1 02/15] qemu_domain: Separate NVRAM VAR store file name generation

2019-02-28 Thread Laszlo Ersek
On 02/27/19 11:04, Michal Privoznik wrote: > Move the code that (possibly) generates filename of NVRAM VAR > store into a single function so that it can be re-used later. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_domain.c | 26 ++ > src/qemu/qemu_domain.h

Re: [libvirt] [Qemu-devel] Virtio-net control queue handling

2019-02-28 Thread Nikhil Agarwal
Hi Stefan, Thanks for directing question to correct people, yes your understanding is correct. I want virtio-net control virtqueue to be handled by vhost-user-net device based backend for vdpa use case where control message would do some configuration on actual hw device. Or these changes shou

Re: [libvirt] [Qemu-devel] Libvirt upstream CI efforts

2019-02-28 Thread Wainer dos Santos Moschetta
On 02/21/2019 03:50 PM, Cleber Rosa wrote: On 2/21/19 9:39 AM, Erik Skultety wrote: Hi, I'm starting this thread in order to continue with the ongoing efforts to bring actual integration testing to libvirt. Currently, the status quo is that we build libvirt (along with our unit test suite) us