On 04.04.2019 17:48, Cole Robinson wrote:
> On 4/4/19 2:57 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 03.04.2019 23:44, Cole Robinson wrote:
>>> On 3/18/19 5:08 AM, Nikolay Shirokovskiy wrote:
Stream/fd callbacks accessing console object are called from the
event loop thread and the c
On Thu, Apr 04, 2019 at 15:29:30 -0500, Eric Blake wrote:
> On 4/4/19 3:16 PM, Eric Blake wrote:
> > On 3/22/19 1:00 PM, Peter Krempa wrote:
> >> There was only one caller, remove the unnecessary wrapper.
> >>
> >> Signed-off-by: Peter Krempa
> >> ---
> >> src/conf/domain_conf.c | 60
For now it's just a helper for building a qemu virDomainCapsPtr.
It will be used in upcoming patches
Signed-off-by: Cole Robinson
---
src/qemu/qemu_conf.c | 39 +++
src/qemu/qemu_conf.h | 7 +++
src/qemu/qemu_driver.c | 18 +++---
3 files
The qemu driver already does some model validation, based on
qemuCaps. However, the logic for exposing model values in domcaps
is basically identical. This drops the qemuCaps checking and compares
against the domCaps data directly.
This approach makes it basically impossible to add a new model
The model logic is taken from qemuDomainRNGDefValidate
Signed-off-by: Cole Robinson
---
src/qemu/qemu_capabilities.c | 30 +++
.../qemu_1.7.0.x86_64.xml | 9 ++
.../qemu_2.12.0-virt.aarch64.xml | 11 +++
.../qemu_2.12.0.p
Fill in virDomainCaps at Validate time and use it to call
virDomainCapsDeviceDefValidate
Signed-off-by: Cole Robinson
---
src/qemu/qemu_domain.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index f0bf1aa4fe..6da27a79b0 100644
-
qemuCaps is tied to a binary on disk. domCaps is tied to a combo
of binary+machine+arch+virttype values. For the qemu driver this almost
entirely translates to a permutation of qemuCaps though
Upcoming patches want to use the domCaps data store at XML validate
time, but we need to cache the data s
This adds device reporting. Example output:
virtio
virtio-transitional
virtio-non-transitional
random
egd
Signed-off-by: Cole Robinson
---
docs/formatdomaincaps.html.in | 35 ++
docs
This is an entrypoint to validate a virDomainDeviceDef against
values filled into virDomainCaps.
Currently it's just a stub
Signed-off-by: Cole Robinson
---
src/conf/domain_capabilities.c | 40 ++
src/conf/domain_capabilities.h | 4
src/libvirt_private.syms
I'm trying to remove some hurdles and pitfalls WRT extending
domaincapabilities data. One issue is that it's too easy to add
invalid data to it, or let the data become out of date.
For example the first two patches of this series add
domcaps reporting. The logic to fill in the domcaps data from q
On 4/4/19 10:35 AM, Ján Tomko wrote:
> On Wed, Apr 03, 2019 at 06:26:49PM -0400, Cole Robinson wrote:
>> The website search is perpetually broken, has had XSS issues in the
>> past, and I suspect when it's working it's not as fast or capable as
>> a simple google site:libvirt.org search
>>
>> Repla
On 4/4/19 3:16 PM, Eric Blake wrote:
> On 3/22/19 1:00 PM, Peter Krempa wrote:
>> There was only one caller, remove the unnecessary wrapper.
>>
>> Signed-off-by: Peter Krempa
>> ---
>> src/conf/domain_conf.c | 60 --
>> 1 file changed, 23 insertions(+), 37
On 3/22/19 1:00 PM, Peter Krempa wrote:
> There was only one caller, remove the unnecessary wrapper.
>
> Signed-off-by: Peter Krempa
> ---
> src/conf/domain_conf.c | 60 --
> 1 file changed, 23 insertions(+), 37 deletions(-)
Alas, my backup code wants to
On 4/3/19 4:52 PM, Cole Robinson wrote:
> If we see if, skip all remaining header guard checks
s/see if/see it/
>
> Signed-off-by: Cole Robinson
> ---
> build-aux/header-ifdef.pl | 5 +
> 1 file changed, 5 insertions(+)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
On Wed, Apr 03, 2019 at 03:06:33PM +0200, Peter Krempa wrote:
This helper has solely to do with virObjects. Move it together with
other virObject stuff.
This also avoids the potential problem where VIR_AUTOUNREF uses
virObjectAutoUnref which is defined in virobject.h.
Signed-off-by: Peter Kremp
On Thu, 2019-04-04 at 09:41 -0500, Eric Blake wrote:
> In a constrained CI environment, where it is intentional that attempts
> to write outside the current directory will fail, virsh-snapshot was
> failing:
>
> @@ -1,2 +1,3 @@
> error: invalid argument: parent s3 for snapshot s2 not found
> err
On 4/4/19 9:54 AM, Daniel P. Berrangé wrote:
The actual network def was updated to save the bridge name back
in 1.2.11:
commit a3609121799d44898a3e0d0bf92b755e55e7b418
Author: Laine Stump
Date: Fri Nov 21 12:20:37 2014 -0500
network: save bridge name in ActualNetDef when actual
On 4/4/19 2:57 AM, Nikolay Shirokovskiy wrote:
>
>
> On 03.04.2019 23:44, Cole Robinson wrote:
>> On 3/18/19 5:08 AM, Nikolay Shirokovskiy wrote:
>>> Stream/fd callbacks accessing console object are called from the
>>> event loop thread and the console object is also accessed from
>>> the main th
On Thu, 2019-04-04 at 15:29 +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 04, 2019 at 10:25:52AM +0200, Andrea Bolognani wrote:
> > I would, however, suggest a slightly different implementation than
> > what you have here, where using the search bar would still send you
> > to https://libvirt.org/
In a constrained CI environment, where it is intentional that attempts
to write outside the current directory will fail, virsh-snapshot was
failing:
@@ -1,2 +1,3 @@
error: invalid argument: parent s3 for snapshot s2 not found
error: marker
+error: Failed to create '/home/travis/.cache/libvirt/vi
On Wed, Apr 03, 2019 at 06:26:49PM -0400, Cole Robinson wrote:
The website search is perpetually broken, has had XSS issues in the
past, and I suspect when it's working it's not as fast or capable as
a simple google site:libvirt.org search
Replace the implementation with one that sends the user
On Thu, Apr 04, 2019 at 10:25:52AM +0200, Andrea Bolognani wrote:
> On Wed, 2019-04-03 at 18:26 -0400, Cole Robinson wrote:
> > Andrea's ChangeLog patches reminder me that I attempted something
> > similarish once, and also tried to drop our custom website search:
> >
> > http://www.redhat.com/arc
On Wed, Apr 03, 2019 at 06:26:51PM -0400, Cole Robinson wrote:
> libvirt.org/search.php drops into some kind of screen which I guess
> is supposed to show a search bar with options, but presently for me
> renders as nothing but the following text:
>
> Search the documentation on Libvirt.org
>
> T
On Wed, Apr 03, 2019 at 06:26:50PM -0400, Cole Robinson wrote:
> This was used for generating the website search, which now just calls
> out to google. Remove it
>
> Signed-off-by: Cole Robinson
> ---
> docs/index.py | 1266 -
> 1 file changed, 126
On Wed, Apr 03, 2019 at 06:26:49PM -0400, Cole Robinson wrote:
> The website search is perpetually broken, has had XSS issues in the
> past, and I suspect when it's working it's not as fast or capable as
> a simple google site:libvirt.org search
>
> Replace the implementation with one that sends
On 4/4/19 4:25 AM, Andrea Bolognani wrote:
> On Wed, 2019-04-03 at 18:26 -0400, Cole Robinson wrote:
>> Andrea's ChangeLog patches reminder me that I attempted something
>> similarish once, and also tried to drop our custom website search:
>>
>> http://www.redhat.com/archives/libvir-list/2016-May/m
On Thu, Apr 04, 2019 at 02:08:41PM +, Frank Schreuder wrote:
> > > To fix this issue I have to restart libvirt. Some iptable chains are
> > > missing, which is probably caused by a nwfilter-define operation.
> > > I'm able to reproduce this bug within 2 hours by running 2 loops. One
> > > loo
> > To fix this issue I have to restart libvirt. Some iptable chains are
> > missing, which is probably caused by a nwfilter-define operation.
> > I'm able to reproduce this bug within 2 hours by running 2 loops. One loop
> > is defining nwfilters and the second loop is destroying and starting
>
The actual network def was updated to save the bridge name back
in 1.2.11:
commit a3609121799d44898a3e0d0bf92b755e55e7b418
Author: Laine Stump
Date: Fri Nov 21 12:20:37 2014 -0500
network: save bridge name in ActualNetDef when actualType==network too
The chance that someone is runni
The NVLink2 support in QEMU implements the detection of NVLink2
capable devices by verifying the attributes of the VFIO mem region
QEMU allocates for the NVIDIA GPUs. To properly allocate an
adequate amount of memLock, Libvirt needs this information before
a QEMU instance is even created, thus quer
This series adds support for a new QEMU feature for the spapr
(PPC64) machine, NVIDIA V100 + P9 passthrough. Refer to [1]
for the version 7 of this feature (version accepted upstream).
changes in v5:
- patch1:
* use ARRAY_CARDINALITY instead of hard coding the array size
* fixed leak of 'file
The NVIDIA V100 GPU has an onboard RAM that is mapped into the
host memory and accessible as normal RAM via an NVLink2 bridge. When
passed through in a guest, QEMU puts the NVIDIA RAM window in a
non-contiguous area, above the PCI MMIO area that starts at 32TiB.
This means that the NVIDIA RAM windo
On Tue, Apr 02, 2019 at 09:53:57PM -0400, Laine Stump wrote:
> On 3/19/19 8:46 AM, Daniel P. Berrangé wrote:
> > Separate network port deletion code from the domain driver network
> > callback implementation.
> >
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > src/network/bridge_driver.c | 91
On Thu, 2019-04-04 at 11:13 +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 04, 2019 at 10:51:22AM +0200, Andrea Bolognani wrote:
> > On Wed, 2019-04-03 at 16:42 +0100, Daniel P. Berrangé wrote:
> You mean fix that fact that not everything is signed ?
Yes. Definitely for all releases going forward,
On 04.04.2019 15:23, Nikolay Shirokovskiy wrote:
>
>
> On 14.02.2019 14:32, Ján Tomko wrote:
>> v2: https://www.redhat.com/archives/libvir-list/2019-February/msg00293.html
>> v3:
>> * dropped the pointless isa-prefix
>> * use DO_TEST_CAPS_LATEST
>> * trimmed the XML
>> * compiles with g
On Tue, 2019-04-02 at 11:22 +0100, Daniel P. Berrangé wrote:
> When debugging why tests fail it is important to have commonly
> used tools like gdb, strace, lsof and netstat available.
>
> Note that although the entry for FreeBSD is blank for strace
> and net-tools, the truss (strace equiv) and ne
On Tue, Apr 02, 2019 at 09:22:38PM -0400, Laine Stump wrote:
> On 3/19/19 8:46 AM, Daniel P. Berrangé wrote:
> > The current qemu driver code for changing bandwidth on a NIC first asks
> > the network driver if the change is supported, then changes the
> > bandwidth on the VIF, and then tells the n
On Fri, Mar 22, 2019 at 03:03:06PM -0400, Laine Stump wrote:
> On 3/19/19 8:46 AM, Daniel P. Berrangé wrote:
> > When (un)plugging an interface into a network, the 'plugged'
> > and 'unplugged' operations are invoked in the hook script.
> >
> > The data provided to the script contains the network
On 14.02.2019 14:32, Ján Tomko wrote:
> v2: https://www.redhat.com/archives/libvir-list/2019-February/msg00293.html
> v3:
> * dropped the pointless isa-prefix
> * use DO_TEST_CAPS_LATEST
> * trimmed the XML
> * compiles with gcc
> * only make irq optional
> * autofill iobase
>
> Ján
On Fri, Mar 22, 2019 at 02:54:28PM -0400, Laine Stump wrote:
> On 3/19/19 8:46 AM, Daniel P. Berrangé wrote:
> > Convert the virDomainNetDef object into a virNetworkPortDef object
> > at the start of networkReleaseActualDevice. This largely decouples
> > the method impl from the domain object type.
On 14.02.2019 14:32, Ján Tomko wrote:
> If no address was provided, use QEMU's default of 0xE9 and reflect it
> in the domain XML.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_domain.c | 9 +
> .../isa-serial-debugcon.x86_64-latest.args
On 14.02.2019 14:32, Ján Tomko wrote:
> From: Nikolay Shirokovskiy
>
> Format the device on QEMU command line.
>
> Signed-off-by: Nikolay Shirokovskiy
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 2 +-
> .../isa-serial-debugcon.x86_64-latest.args|
Commit 6864d8f740e2502dc7625bdf18ffde4465b14f69 moved this one level up
for qemuBuildMemoryBackendProps but left qemuBuildMemPathStr intact.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 8 +---
src/qemu/qemu_conf.c| 35 +--
2 files changed, 18 i
It is no longer used.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_conf.c | 24
src/qemu/qemu_conf.h | 3 ---
2 files changed, 27 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 4bec885c6b..daea11dacb 100644
--- a/src/qemu/qemu_conf.c
+++ b/sr
Ján Tomko (3):
qemu: rename function for getting the default hugepage size
qemu: do not fill in default pagesize in qemuGetDomainHupageMemPath
qemu: remove qemuGetDomainDefaultHugepath
src/qemu/qemu_command.c | 14 +-
src/qemu/qemu_conf.c| 59 +---
Use qemuBuildMemoryGetDefaultPagesize.
Fixes: 6864d8f740e2502dc7625bdf18ffde4465b14f69
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 029780fe86..aaca75900b 100
On 14.02.2019 14:32, Ján Tomko wrote:
> From: Nikolay Shirokovskiy
>
> This interface can be used for example by firmware to print
> debug messages. Here is domain xml example:
>
>
>
>
>
>
>
>
> Add checks to make sure this new serial type won't be repo
On 14.02.2019 14:32, Ján Tomko wrote:
> Some devices (e.g. debugcon) only use the iobase.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index c28ce
On 14.02.2019 14:32, Ján Tomko wrote:
> From: Nikolay Shirokovskiy
>
> This interface can be used for example by firmware to print
> debug messages. Here is domain xml example:
>
>
>
>
>
>
>
>
> Add checks to make sure this new serial type won't be repo
On 14.02.2019 14:32, Ján Tomko wrote:
> Allow adding serial device models that deviate from the perceived
> semantics of our model attributes blindly copying the
> hypervisor-specific device name strings.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 16 +++-
> 1 f
Daniel P. Berrangé [2019-04-04, 11:41AM +0100]:
> On Thu, Apr 04, 2019 at 10:01:30AM +0200, Bjoern Walk wrote:
> > +virCheckDomainReturn(domain, -1);
> > +if (params)
> > +virCheckNonNullArgGoto(nparams, error);
>
> While I remember, we must forbid this for "read only" connections
On Thu, Apr 04, 2019 at 12:18:39PM +0200, Andrea Bolognani wrote:
> On Wed, 2019-04-03 at 18:11 +0100, Daniel P. Berrangé wrote:
> [...]
> > %if %{with_python2}
> > +%if 0%{?fedora} >= 29 || 0%{?rhel} >= 8
> > +%py2_build
> > +%else
>
> So based on this it looks like the %py*_build macros were on
On Thu, Apr 04, 2019 at 10:01:30AM +0200, Bjoern Walk wrote:
> This API function extends the virDomainGetState function by returning
> additional state information as a dictionary of typed parameters.
>
> Reviewed-by: Boris Fiuczynski
> Signed-off-by: Bjoern Walk
> ---
> include/libvirt/libvirt
On Thu, Apr 04, 2019 at 11:48:40AM +0200, Peter Krempa wrote:
> On Thu, Apr 04, 2019 at 09:49:16 +0100, Daniel Berrange wrote:
> > On Thu, Apr 04, 2019 at 10:01:27AM +0200, Bjoern Walk wrote:
> > > This patch series introduces the ability to save additional information
> > > for the domain state an
On Thu, Apr 04, 2019 at 11:59:50AM +0200, Bjoern Walk wrote:
> Daniel P. Berrangé [2019-04-04, 09:49AM +0100]:
> > On Thu, Apr 04, 2019 at 10:01:27AM +0200, Bjoern Walk wrote:
> > > This patch series introduces the ability to save additional information
> > > for the domain state and exposes this
On Wed, 2019-04-03 at 18:11 +0100, Daniel P. Berrangé wrote:
[...]
> %if %{with_python2}
> +%if 0%{?fedora} >= 29 || 0%{?rhel} >= 8
> +%py2_build
> +%else
So based on this it looks like the %py*_build macros were only
introduced in Fedora 29...
> %if %{with_python2}
> +%if 0%{?fedora} || 0%{?rh
On Thu, Apr 04, 2019 at 10:51:22AM +0200, Andrea Bolognani wrote:
> On Wed, 2019-04-03 at 16:42 +0100, Daniel P. Berrangé wrote:
> > docs: stop advertizing FTP or HTTP for downloads of libvirt
>
> We never advertised HTTP downloads, we only had an HTTPS URL
> incorrectly labeled as "HTTP". So s/or
On Thu, Apr 04, 2019 at 11:59:50 +0200, Bjoern Walk wrote:
> Daniel P. Berrangé [2019-04-04, 09:49AM +0100]:
> > On Thu, Apr 04, 2019 at 10:01:27AM +0200, Bjoern Walk wrote:
[...]
> > Why not just have virDomainGetPanicInfo() and "virsh dompanicinfo"
>
> Do we want to later add an additional p
On Wed, 2019-04-03 at 16:42 +0100, Daniel P. Berrangé wrote:
> The search.cpan.org site is a transparent redirect to metacpan.org these
> days, so we should just point directly to the new site.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/downloads.html.in | 4 ++--
> 1 file changed, 2 ins
Daniel P. Berrangé [2019-04-04, 09:49AM +0100]:
> On Thu, Apr 04, 2019 at 10:01:27AM +0200, Bjoern Walk wrote:
> > This patch series introduces the ability to save additional information
> > for the domain state and exposes this information in virsh domstate.
> >
> > For example in the case of QE
On Thu, Apr 04, 2019 at 09:49:16 +0100, Daniel Berrange wrote:
> On Thu, Apr 04, 2019 at 10:01:27AM +0200, Bjoern Walk wrote:
> > This patch series introduces the ability to save additional information
> > for the domain state and exposes this information in virsh domstate.
> >
> > For example in
This completer is used to offer shutdown/reboot modes.
Signed-off-by: Michal Privoznik
---
tools/virsh-completer.c | 56 +
tools/virsh-completer.h | 4 +++
tools/virsh-domain.c| 2 ++
3 files changed, 62 insertions(+)
diff --git a/tools/virsh-comple
On Wed, Apr 03, 2019 at 02:10:19PM -0400, Cole Robinson wrote:
> On 4/1/19 8:19 AM, Michal Privoznik wrote:
> > There was this introduction made on the users list:
> >
> > https://www.redhat.com/archives/libvirt-users/2019-March/msg00046.html
> >
> > Add the application onto the list of apps know
On Wed, 2019-04-03 at 16:42 +0100, Daniel P. Berrangé wrote:
> docs: stop advertizing FTP or HTTP for downloads of libvirt
We never advertised HTTP downloads, we only had an HTTPS URL
incorrectly labeled as "HTTP". So s/or HTTP // in the subject.
> On the modern internet it is not credible to con
On Thu, Apr 04, 2019 at 10:01:27AM +0200, Bjoern Walk wrote:
> This patch series introduces the ability to save additional information
> for the domain state and exposes this information in virsh domstate.
>
> For example in the case of QEMU guest panic events, we can provide additional
> informat
On Wed, 2019-04-03 at 11:23 +0100, Daniel P. Berrangé wrote:
> On Red Hat variant distros ca-certificates gets pulled in
> automatically by other packages we require. This doesn't
> happen on Debian and so any use of https URIs fails. This
> prevents git from cloning submodules over https.
All the
On Wed, 2019-04-03 at 18:26 -0400, Cole Robinson wrote:
> Andrea's ChangeLog patches reminder me that I attempted something
> similarish once, and also tried to drop our custom website search:
>
> http://www.redhat.com/archives/libvir-list/2016-May/msg01616.html
Glad to be an inspiration for you!
From: Marc Hartmayer
This patch adds the Python binding for the virDomainGetStateParams API.
The Python side can be generated automatically, the C side cannot.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
Signed-off-by: Bjoern Walk
---
generator.py | 1 +
libvirt-
Implement the API function virDomainGetStateParams for the remote driver
and wire up the remote protocol.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
---
src/remote/remote_daemon_dispatch.c | 50 +
src/remote/remote_driver.c | 48 +++
Add a new parameter to virsh domstate, --info, to report additional
information for the domain state, e.g. for a QEMU guest running a S390
domain:
virsh # domstate --info guest-1
crashed (panicked)
s390.core = 0
s390.psw-mask = 0x000200018000
s390.psw-addr = 0x0
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 0729e0ba..6a7394c7 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,6 +35,17 @@
+
+
+
Implement the API function virDomainGetStateParams for the QEMU
hypervisor driver.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
---
src/qemu/qemu_driver.c | 118 +
1 file changed, 118 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qe
In order to later process the event data, we need to be able to access
it over the lifetime of the domain. So, as an initial step, let's move
the event data structure and utility functions to qemu_domain.[ch] and
rename them appropriately to make it accessible for other users.
Reviewed-by: Boris F
This patch series introduces the ability to save additional information
for the domain state and exposes this information in virsh domstate.
For example in the case of QEMU guest panic events, we can provide additional
information like the crash reason or register state of the domain. This
informa
Let's store additional state information in the hypervisor-specific
private data to virDomainObj. For now, just consider panic state in QEMU
domains for which additional information is available from the guest
crash event handler.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
---
src
This API function extends the virDomainGetState function by returning
additional state information as a dictionary of typed parameters.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
---
include/libvirt/libvirt-domain.h | 76
src/driver-hypervisor.h
76 matches
Mail list logo
