Replaced usage of virSaveLastError and virSetError/virFreeError with
virErrorPreserveLast and virErrorRestore respectively.
Signed-off-by: Syed Humaid
---
src/network/bridge_driver.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/src/network/bridge_driver.c
On 4/16/19 2:51 PM, Syed Humaid wrote:
> Replaced all virSaveLastError and virSetError/virFreeError usages to
> virErrorPreserveLast and virErrorRestore respectively.
>
> Signed-off-by: Syed Humaid
> ---
> src/libvirt-domain.c | 24 +---
> 1 file changed, 9 insertions(+), 15
On 4/16/19 12:50 PM, Kashyap Chamarthy wrote:
> I learnt from Dan Berrangé that the 'nvram' section in
> `/etc/libvirt/qemu.conf` will now go away in light of all the work done
> in QEMU ('firmware.json', et al) and libvirt (the firmware
> auto-selection).
>
> But for my own education, can anyon
On 4/16/19 1:54 PM, Cole Robinson wrote:
> On 4/16/19 9:53 AM, Eric Blake wrote:
>> Wire up the accessor functions necessary for the testsuite to install
>> an alternative post-parse handler from normal drivers. I could have
>> modified the signature for virDomainXMLOptionNew() to take another
>> p
On 4/16/19 9:53 AM, Eric Blake wrote:
> Wire up the accessor functions necessary for the testsuite to install
> an alternative post-parse handler from normal drivers. I could have
> modified the signature for virDomainXMLOptionNew() to take another
> parameter, but thought it was easier to add a ne
Replaced all virSaveLastError and virSetError/virFreeError usages to
virErrorPreserveLast and virErrorRestore respectively.
Signed-off-by: Syed Humaid
---
src/libvirt-domain.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/src/libvirt-domain.c b/src
On 4/16/19 6:55 AM, Andrea Bolognani wrote:
> Reduce repetition by replacing reutterances with reusable references.
>
> Andrea Bolognani (4):
> tests: Make TEST_QEMU_CAPS_PATH public
> tests: Drop dirname argument from testQemuGetLatestCapsForArch()
> tests: Drop dirname argument from testQe
On 4/15/19 10:28 PM, Han Han wrote:
> Because the page of QEMU and KVM use the same doc drvqemu.html, merge the into
> one and name it as QEMU/KVM.
>
> Signed-off-by: Han Han
> ---
> docs/index.html.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/index.html.
On 4/16/19 11:27 AM, Michal Privoznik wrote:
> On 3/13/19 4:51 PM, Cole Robinson wrote:
>> This adds a network model enum. The virDomainNetDef property
>> is named 'model' like most other devices.
>>
>> When the XML parser or a driver calls NetSetModelString, if
>> the passed string is in the enum,
On 4/16/19 11:26 AM, Michal Privoznik wrote:
> On 3/13/19 4:51 PM, Cole Robinson wrote:
>> This requires drivers to opt in to handle the raw modelstr
>> network model, all others will error if a passed in XML value
>> is not in the model enum.
>>
>> Enable this feature for libxl/xen/xm and qemu dri
On 4/16/19 4:58 AM, Andrea Bolognani wrote:
> On Mon, 2019-04-15 at 19:09 -0400, Cole Robinson wrote:
> [...]
>> +DO_TEST_CAPS_LATEST("virtio-transitional");
>> +DO_TEST_CAPS_LATEST("virtio-non-transitional");
>
> We should also add
>
> DO_TEST_CAPS_VER("virtio-transitional", "3.1.0");
I learnt from Dan Berrangé that the 'nvram' section in
`/etc/libvirt/qemu.conf` will now go away in light of all the work done
in QEMU ('firmware.json', et al) and libvirt (the firmware
auto-selection).
But for my own education, can anyone confirm that the current content of
'nvram' is out of da
On 4/16/19 5:11 AM, Michal Privoznik wrote:
> On 4/16/19 8:32 AM, Peter Krempa wrote:
>> On Mon, Apr 15, 2019 at 17:26:41 -0400, Cole Robinson wrote:
>>> Allow passing in a 'label' string for raising errors from
>>> ToString/FromString calls. Adjust all VIR_ENUM_IMPL calls to
>>> pass in NULL to di
Dear QEMU, KVM, and libvirt communities,
virtio-fs is a shared file system that lets virtual machines access a
directory tree on the host. Unlike existing approaches, it is designed
to offer local file system semantics and performance. The guest can
take advantage of Linux DAX to access file cont
On 4/16/19 12:01 AM, Cole Robinson wrote:
On 4/15/19 1:09 PM, Michal Privoznik wrote:
On 4/10/19 11:35 PM, Cole Robinson wrote:
On 3/28/19 11:04 AM, Michal Privoznik wrote:
Here is the problem: If all disks had XATTRs (i.e. domains using
them were started with owner remembering turned on) then
On 3/13/19 4:51 PM, Cole Robinson wrote:
> To ease converting the net->model value to an enum, add
> the wrapper functions:
>
> virDomainNetGetModelString
> virDomainNetSetModelString
> virDomainNetStreqModelString
> virDomainNetStrcaseeqModelString
>
> Signed-off-by: Cole Robinson
> ---
> src
On 3/13/19 4:51 PM, Cole Robinson wrote:
Examples of passing unknown strings through
Signed-off-by: Cole Robinson
---
tests/qemuxml2argvdata/net-many-models.args | 39 ++
tests/qemuxml2argvdata/net-many-models.xml| 37 +
tests/qemuxml2argvtest.c
On 3/13/19 4:51 PM, Cole Robinson wrote:
v1 here:
https://www.redhat.com/archives/libvir-list/2019-January/msg00763.html
Changes since v1:
- patch #7, case insensitive model input comparison
- Add xml2xml testing
- compile tested on freebsd12.0
This series partially converts the net->model valu
On 3/13/19 4:51 PM, Cole Robinson wrote:
This adds a network model enum. The virDomainNetDef property
is named 'model' like most other devices.
When the XML parser or a driver calls NetSetModelString, if
the passed string is in the enum, we will set net->model,
otherwise we copy the string into
On 3/13/19 4:51 PM, Cole Robinson wrote:
This requires drivers to opt in to handle the raw modelstr
network model, all others will error if a passed in XML value
is not in the model enum.
Enable this feature for libxl/xen/xm and qemu drivers
Signed-off-by: Cole Robinson
---
src/conf/domain_c
On Mon, Apr 15, 2019 at 06:01:55PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_qapi.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
--
libvir-list mailing list
l
On Tue, Apr 16, 2019 at 15:32:31 +0100, Daniel Berrange wrote:
> On Tue, Apr 16, 2019 at 04:26:49PM +0200, Peter Krempa wrote:
> > On Tue, Apr 16, 2019 at 15:17:31 +0100, Daniel Berrange wrote:
> > > On Tue, Apr 16, 2019 at 04:09:54PM +0200, Peter Krempa wrote:
[...]
> > Currently there aren't an
On Mon, Apr 15, 2019 at 06:01:57PM +0200, Peter Krempa wrote:
The return statement after the infinite loop without a break is there to
appease the compiler. Make it return NULL as it would be a failure if
control flow reaches that point.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_qapi.c | 2
On Mon, Apr 15, 2019 at 06:01:56PM +0200, Peter Krempa wrote:
While we technically test the query strings in the qemucapabilitiestest
this was done to help refactor and extend the QAPI schema query
infrastructure.
Signed-off-by: Peter Krempa
---
tests/qemumonitorjsontest.c | 45
On Tue, Apr 16, 2019 at 04:41:57PM +0200, Peter Krempa wrote:
> On Tue, Apr 16, 2019 at 15:32:31 +0100, Daniel Berrange wrote:
> > On Tue, Apr 16, 2019 at 04:26:49PM +0200, Peter Krempa wrote:
> > > On Tue, Apr 16, 2019 at 15:17:31 +0100, Daniel Berrange wrote:
> > > > On Tue, Apr 16, 2019 at 04:09
On Tue, Apr 16, 2019 at 04:09:54PM +0200, Peter Krempa wrote:
> In cases when the hash function for a name collides with other entry
> already in the hash we prepend to the bucket. This creates a 'stack
> effect' on the buckets if we then iterate through the hash. Normally
> this is not a problem,
On Mon, Apr 15, 2019 at 06:01:54PM +0200, Peter Krempa wrote:
Rename DO_TEST_QAPI_SCHEMA to DO_TEST_QAPI_VALIDATE.
Signed-off-by: Peter Krempa
---
tests/qemumonitorjsontest.c | 60 ++---
1 file changed, 30 insertions(+), 30 deletions(-)
Reviewed-by: Ján Tomko
On Tue, Apr 16, 2019 at 04:26:49PM +0200, Peter Krempa wrote:
> On Tue, Apr 16, 2019 at 15:17:31 +0100, Daniel Berrange wrote:
> > On Tue, Apr 16, 2019 at 04:09:54PM +0200, Peter Krempa wrote:
> > > In cases when the hash function for a name collides with other entry
> > > already in the hash we pr
On Tue, Apr 16, 2019 at 15:17:31 +0100, Daniel Berrange wrote:
> On Tue, Apr 16, 2019 at 04:09:54PM +0200, Peter Krempa wrote:
> > In cases when the hash function for a name collides with other entry
> > already in the hash we prepend to the bucket. This creates a 'stack
> > effect' on the buckets
On Tue, Apr 16, 2019 at 04:09:54PM +0200, Peter Krempa wrote:
> In cases when the hash function for a name collides with other entry
> already in the hash we prepend to the bucket. This creates a 'stack
> effect' on the buckets if we then iterate through the hash. Normally
> this is not a problem,
In cases when the hash function for a name collides with other entry
already in the hash we prepend to the bucket. This creates a 'stack
effect' on the buckets if we then iterate through the hash. Normally
this is not a problem, but in tests we want deterministic results.
Since it does not matter
None of the existing drivers actually use the 0-valued 'nostate'
snapshot state; rather, it was a fluke of implementation. In fact,
some drivers, like qemu, actively reject 'nostate' as invalid during a
snapshot redefine. Normally, a driver computes the state post-parse
from the current domain, and
Upcoming changes want to separate out a post-parse massaging of
snapshots separate from parsing the XML, so as not to be dependent on
filtering out an ever-changing timestamp from the testsuite. Along the
way, this means we will want to add yet another conditional to the
snapshot xml2xml tests on w
Now that we can override the post-parse handling, let's update the
testsuite to provide the desired timestamp/name rather than ignoring
the non-deterministic one that was previously being generated. A few
output files need timestamps added now that they are no longer
ignored.
Signed-off-by: Eric B
Wire up the accessor functions necessary for the testsuite to install
an alternative post-parse handler from normal drivers. I could have
modified the signature for virDomainXMLOptionNew() to take another
parameter, but thought it was easier to add a new set function rather
than chase down all exis
During my checkpoint series, one of the review comments complained
that setting the element during XML parsing to the
current time is non-deterministic, which in turn makes writing
testsuite additions difficult. The recommendation was to split out the
non-deterministic defaults to a post-parse han
Move the non-deterministic code that sets snapshot properties
independently of what the incoming XML described to instead live in a
post-parse function common to virDomainMoment (as checkpoints will
also reuse it in later patches). This patch is just code motion, with
no difference to any callers;
On Mon, Apr 15, 2019 at 06:32:32PM +0200, Michal Privoznik wrote:
On 4/15/19 3:47 PM, Martin Kletzander wrote:
On Wed, Apr 10, 2019 at 06:10:44PM +0200, Michal Privoznik wrote:
It's funny how this went unnoticed for such a long time. Long
story short, if a domain is configured with
VIR_DOMAIN_N
On Tue, Apr 16, 2019 at 12:59:34PM +0200, Ján Tomko wrote:
On Mon, Apr 15, 2019 at 04:59:30PM +0200, Ján Tomko wrote:
On Mon, Apr 15, 2019 at 04:23:18PM +0200, Martin Kletzander wrote:
I'll fix other things you mentioned and send a v3 if you want, just let me know.
Depending on your opinion
On Mon, Apr 15, 2019 at 04:59:30PM +0200, Ján Tomko wrote:
On Mon, Apr 15, 2019 at 04:23:18PM +0200, Martin Kletzander wrote:
I'll fix other things you mentioned and send a v3 if you want, just let me know.
Depending on your opinion on the refactor:
https://www.redhat.com/archives/libvir-lis
After the recent changes, there are only a few places left
where we use the explicit path instead of taking advantage of
the publicly available define; let's get rid of those too.
Signed-off-by: Andrea Bolognani
---
tests/domaincapstest.c | 4 ++--
tests/qemuargv2xmltest.c | 2 +-
test
As evidenced by all existing callers, the only directory it makes
sense to use is TEST_QEMU_CAPS_PATH, so let's just bake that into
the function.
Signed-off-by: Andrea Bolognani
---
tests/qemublocktest.c | 3 +--
tests/testutilsqemu.c | 14 ++
tests/testutilsqemu.h
As evidenced by all existing callers, the only directory it makes
sense to use is TEST_QEMU_CAPS_PATH, so let's just bake that into
the function.
Signed-off-by: Andrea Bolognani
---
tests/qemucapabilitiestest.c | 2 +-
tests/qemucaps2xmltest.c | 2 +-
tests/testutilsqemu.c| 7 +++
The value (with a slightly different name) is currently private
to testutilsqemu, but since we use this path all over the place
it makes sense to define it publicly and avoid repetition.
Signed-off-by: Andrea Bolognani
---
tests/testutilsqemu.c | 4 +---
tests/testutilsqemu.h | 2 ++
2 files cha
Reduce repetition by replacing reutterances with reusable references.
Andrea Bolognani (4):
tests: Make TEST_QEMU_CAPS_PATH public
tests: Drop dirname argument from testQemuGetLatestCapsForArch()
tests: Drop dirname argument from testQemuCapsIterate()
tests: Use TEST_QEMU_CAPS_PATH whereve
On Tue, Apr 16, 2019 at 12:49:05AM +0200, Ján Tomko wrote:
On Mon, Apr 15, 2019 at 06:51:48PM +0200, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Qemu commit 767abe7 ("chardev: forbid 'wait' option with client
sockets") effectively deprecates usage of "wait" with client sockets
s
On Mon, 15 Apr 2019 at 17:34, Marc-André Lureau
wrote:
>
> Commit 767abe7 ("chardev: forbid 'wait' option with client sockets")
> is a bit too strict. Current libvirt always set wait=false, and will
> thus fail to add client chardev.
>
> Make the code more permissive, allowing wait=false with clie
On Tue, Apr 16, 2019 at 11:27:44AM +0200, Ilias Stamatis wrote:
Στις Τρί, 16 Απρ 2019 στις 2:00 π.μ., ο/η Cole Robinson
έγραψε:
On 4/9/19 6:16 AM, Ján Tomko wrote:
> On Mon, Apr 08, 2019 at 01:43:17AM +0200, Ilias Stamatis wrote:
>> Implement testDomainGetTime by returning the current time.
>>
On Mon, Apr 15, 2019 at 08:29:42PM +0200, Adrian Brzezinski wrote:
> Failed new gnutls context allocations in virNetTLSContextNew function
> results in double free and segfault. Occasional memory leaks may also
> occur.
>
> Signed-off-by: Adrian Brzezinski
> ---
> src/rpc/virnettlscontext.c | 10
GitLab CI provides some shared build runners that use Docker containers.
This resource can usefully run cross-compiled builds since all other CI
build testing is currently x86 only, and Travis CI is already very busy
testing native builds.
Signed-off-by: Daniel P. Berrangé
---
.gitlab-ci.yml | 4
On Tue, Apr 16, 2019 at 12:02:30PM +0200, Peter Krempa wrote:
> On Tue, Apr 16, 2019 at 10:57:28 +0100, Daniel Berrange wrote:
> > On Tue, Apr 16, 2019 at 11:56:12AM +0200, Peter Krempa wrote:
> > > On Tue, Apr 16, 2019 at 10:45:29 +0100, Daniel Berrange wrote:
> > > > Signed-off-by: Daniel P. Berr
On Tue, Apr 16, 2019 at 10:57:28 +0100, Daniel Berrange wrote:
> On Tue, Apr 16, 2019 at 11:56:12AM +0200, Peter Krempa wrote:
> > On Tue, Apr 16, 2019 at 10:45:29 +0100, Daniel Berrange wrote:
> > > Signed-off-by: Daniel P. Berrangé
> > > ---
> > > docs/news.xml | 10 ++
> > > 1 file cha
Most releases don't need a "Removed features" section so don't include
it in the template by default, but leave a reminder in case it is
relevant.
Signed-off-by: Daniel P. Berrangé
---
docs/news.xml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index b49
On Mon, 2019-04-15 at 16:55 +0200, Ján Tomko wrote:
[...]
> switch (sched->policy) {
> case VIR_PROC_POLICY_BATCH:
> case VIR_PROC_POLICY_IDLE:
> -virBufferAsprintf(buf, "<%s "
> - "%s='%zu' scheduler='%s'/>\n",
> -
On Tue, Apr 16, 2019 at 11:56:12AM +0200, Peter Krempa wrote:
> On Tue, Apr 16, 2019 at 10:45:29 +0100, Daniel Berrange wrote:
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > docs/news.xml | 10 ++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/docs/news.xml b/docs/news.xml
On Tue, Apr 16, 2019 at 10:45:29 +0100, Daniel Berrange wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/news.xml | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index 86c7734694..79b5658cc3 100644
> --- a/docs/news.xml
> +++ b/docs/new
On Mon, 2019-04-15 at 16:55 +0200, Ján Tomko wrote:
> Instead of constructing them dynamically from a base name, pass the two
> different static strings.
>
> While adjusting the callers, also expect a negative return value.
Changing the arguments and changing the return value should happen
in sep
Signed-off-by: Daniel P. Berrangé
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 86c7734694..79b5658cc3 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -49,6 +49,16 @@
release.
+
+
Στις Τρί, 16 Απρ 2019 στις 2:00 π.μ., ο/η Cole Robinson
έγραψε:
>
> On 4/9/19 6:16 AM, Ján Tomko wrote:
> > On Mon, Apr 08, 2019 at 01:43:17AM +0200, Ilias Stamatis wrote:
> >> Implement testDomainGetTime by returning the current time.
> >>
> >> Signed-off-by: Ilias Stamatis
> >> ---
> >> I initi
On Mon, 2019-04-15 at 19:09 -0400, Cole Robinson wrote:
[...]
> +DO_TEST_CAPS_ARCH_LATEST("aarch64-os-firmware-efi", "aarch64");
Welp, I see you've taken my comments from 4/6 to heart and
implemented them *in the past*! :)
I would move this right after the other os-firmware-* tests to match
t
On 4/16/19 8:32 AM, Peter Krempa wrote:
On Mon, Apr 15, 2019 at 17:26:41 -0400, Cole Robinson wrote:
Allow passing in a 'label' string for raising errors from
ToString/FromString calls. Adjust all VIR_ENUM_IMPL calls to
pass in NULL to disable error reporting. We will add strings at
a later time
On Mon, 2019-04-15 at 19:09 -0400, Cole Robinson wrote:
> Convert these test cases to use DO_TEST_CAPS_LATEST
>
> * genid
> * genid-auto
>
> This ensures the test infrastructure is working as expected for
> a test case with explicit -active and -inactive XML test data
>
> Signed-off-by: Cole Rob
On Mon, 2019-04-15 at 19:09 -0400, Cole Robinson wrote:
> Convert these test cases to use DO_TEST_CAPS_LATEST
>
> * os-firmware-bios
> * os-firmware-efi
> * os-firmware-efi-secboot
>
> Signed-off-by: Cole Robinson
> ---
> .../os-firmware-bios.x86_64-latest.xml| 68 +++
>
On Mon, 2019-04-15 at 19:09 -0400, Cole Robinson wrote:
[...]
> +DO_TEST_CAPS_LATEST("virtio-transitional");
> +DO_TEST_CAPS_LATEST("virtio-non-transitional");
We should also add
DO_TEST_CAPS_VER("virtio-transitional", "3.1.0");
DO_TEST_CAPS_VER("virtio-non-transitional", "3.1.0");
s
On Mon, 2019-04-15 at 19:09 -0400, Cole Robinson wrote:
> Add DO_TEST_CAPS* macros, lifted from qemuxml2argvtest.
>
> Signed-off-by: Cole Robinson
> ---
> tests/qemuxml2xmltest.c | 39 ---
> 1 file changed, 32 insertions(+), 7 deletions(-)
Reviewed-by: Andrea
On Mon, Apr 15, 2019 at 4:16 PM Dimitri John Ledkov wrote:
>
> Signed-off-by: Dimitri John Ledkov
> ---
> src/util/viruuid.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/util/viruuid.c b/src/util/viruuid.c
> index 0c12ddcc3e..8553a68965 100644
> --- a/src/util/viruuid.c
> +++ b
On Mon, 2019-04-15 at 19:09 -0400, Cole Robinson wrote:
[...]
> @@ -148,7 +146,6 @@ mymain(void)
> {
> int ret = 0;
> char *fakerootdir;
> -struct testQemuInfo info;
> virQEMUDriverConfigPtr cfg = NULL;
> virHashTablePtr capslatest = NULL;
>
> @@ -168,39 +165,40 @@ mymain
On Tue, Apr 16, 2019 at 12:44:26AM +0200, Ján Tomko wrote:
> On Mon, Apr 15, 2019 at 02:15:28PM -0400, Cole Robinson wrote:
> > On 4/15/19 11:25 AM, Pavel Hrdina wrote:
> > > Calling fixtures directly was removed in pytest 4.0, we can change the
> > > fixture to be a wrapper around the original fun
On Mon, 2019-04-15 at 18:06 +0200, Andrea Bolognani wrote:
> On Fri, 2019-04-12 at 14:00 +0100, Daniel P. Berrangé wrote:
> > Daniel P. Berrangé (7):
> > vbox: drop support for VirtualBox 4.x releases
> > vbox: drop C API definition for release 4.0
> > vbox: drop C API definition for release
69 matches
Mail list logo
