Re: [libvirt] [PATCH 05/12] tests: assume JSON in qemuMonitorTestIO

2019-06-16 Thread Peter Krempa
On Sat, Jun 15, 2019 at 13:54:03 +0200, Ján Tomko wrote: > Only strip the carriage return for agent monitor, now that we > no longer support text monitor. > > Signed-off-by: Ján Tomko > --- > tests/qemumonitortestutils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t

Re: [libvirt] [PATCH 04/12] tests: qemuMonitorTestProcessCommandDefaultValidate: simplify condition

2019-06-16 Thread Peter Krempa
On Sat, Jun 15, 2019 at 13:54:02 +0200, Ján Tomko wrote: > This function is skipped for non-JSON monitor (which never happens now) > and for agent connections (which we currently do not test). > > Only check for qapischema to simplify the condition. > > Signed-off-by: Ján Tomko > --- > tests/qe

Re: [libvirt] [PATCH] build: Require cppi for syntax-check

2019-06-16 Thread Ján Tomko
On Sat, Jun 15, 2019 at 03:17:22PM +0200, Michal Privoznik wrote: Since its introduction in v0.8.0~314 we allowed for cppi to be not present for 'syntax-check' because the package did exist in Fedora Core 12. Well, we don't care anymore ¯\_(ツ)_/¯ All recent distros have it. Moreover, it's fairly