Re: [libvirt] [PATCH] tests: qemucaps: Update 4.1.0 capabilities to a more recent version

2019-06-19 Thread Erik Skultety
On Thu, Jun 20, 2019 at 08:04:45AM +0200, Peter Krempa wrote: > Update the capabilities from a non-upstream version (9c70209b63 is not > in qemu.git) to qemu upstream commit 33d6099906 (2019/06/18) so that we > get the QMP schema 'features' field support and are able to detect that > the 'file' blo

[libvirt] [PATCH v2 4/7] cpu_x86: Read CPU features from IA32_ARCH_CAPABILITIES MSR

2019-06-19 Thread Jiri Denemark
This is used by the host capabilities code to construct host CPU definition. Signed-off-by: Jiri Denemark Reviewed-by: Ján Tomko --- src/cpu/cpu_x86.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index a7ec0f7095..5f051950de 1

[libvirt] [PATCH v2 0/7] Finish support for IA32_ARCH_CAPABILITIES MSR features

2019-06-19 Thread Jiri Denemark
As promised in v1 this series contains a few additional patches which limit usage of MSR features to QEMU that supports "unavailable-features" CPU property. This series intentionally enables MSR features for all QEMU versions before restricting the usage to make this restriction more visible in th

[libvirt] [PATCH v2 3/7] cpu_x86: Introduce virCPUx86FeatureIsMSR

2019-06-19 Thread Jiri Denemark
This function may be used as a virCPUDefFeatureFilter callback for virCPUDefCheckFeatures, virCPUDefFilerFeatures, and similar functions to filter or pick out features reported via MSR. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c| 40 src/c

[libvirt] [PATCH v2 6/7] qemu: Forbid MSR features with old QEMU

2019-06-19 Thread Jiri Denemark
Without "unavailable-features" CPU property we cannot properly detect whether a specific MSR feature we asked for (either explicitly or implicitly via a CPU model) was disabled by QEMU for some reason. Because this could break migration, snapshots, and save/restore operaions, it's better to just fo

[libvirt] [PATCH v2 5/7] cpu_map: Introduce IA32_ARCH_CAPABILITIES MSR features

2019-06-19 Thread Jiri Denemark
Signed-off-by: Jiri Denemark Reviewed-by: Ján Tomko --- src/cpu_map/x86_features.xml | 20 +++ .../x86_64-cpuid-Core-i7-7600U-enabled.xml| 1 + .../x86_64-cpuid-Core-i7-7600U-json.xml | 1 + ...86_64-cpuid-Xeon-Platinum-8268-enabled.xml | 1 + .../x8

[libvirt] [PATCH v2 1/7] conf: Introduce virCPUDefCheckFeatures

2019-06-19 Thread Jiri Denemark
This API can be used to check whether a CPU definition contains features matching a given filter. Signed-off-by: Jiri Denemark --- src/conf/cpu_conf.c | 33 + src/conf/cpu_conf.h | 6 ++ src/libvirt_private.syms | 1 + 3 files changed, 40 insertion

[libvirt] [PATCH v2 7/7] qemu: Drop MSR features from host-model with old QEMU

2019-06-19 Thread Jiri Denemark
With QEMU versions which lack "unavailable-features" we use CPUID based detection of features which were enabled or disabled once QEMU starts. Thus using MSR features with host-model would result in all of them being marked as disabled in the active domain definition even though QEMU did not actual

[libvirt] [PATCH v2 2/7] cpu_x86: Turn virCPUx86DataIteratorInit into a function

2019-06-19 Thread Jiri Denemark
Until now, this was a macro usable for direct initialization when a variable is defined. Turning the macro into a function makes it more general. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 34 -- 1 file changed, 24 insertions(+), 10 deletions(-) diff --

Re: [libvirt] [PATCH 24/24] cpu_map: Introduce IA32_ARCH_CAPABILITIES MSR features

2019-06-19 Thread Jiri Denemark
On Wed, Jun 19, 2019 at 14:40:27 +0200, Ján Tomko wrote: > On Wed, Jun 19, 2019 at 11:38:21AM +0200, Jiri Denemark wrote: > >--- > > src/cpu_map/x86_features.xml | 20 +++ > > .../x86_64-cpuid-Core-i7-7600U-enabled.xml| 1 + > > .../x86_64-cpuid-Core-i7-7600U-jso

Re: [libvirt] [PATCH 15/24] qemu_command: Use canonical names of CPU features

2019-06-19 Thread Jiri Denemark
On Wed, Jun 19, 2019 at 14:08:58 +0200, Ján Tomko wrote: > On Wed, Jun 19, 2019 at 11:38:12AM +0200, Jiri Denemark wrote: > >When building QEMU command line, we should use the preferred spelling of > >each CPU feature without relying on compatibility aliases (which may be > >removed at some point).

Re: [libvirt] [PATCH 09/24] qemuxml2argvtest: Add 4.0.0 cases for kvm features tests

2019-06-19 Thread Jiri Denemark
On Wed, Jun 19, 2019 at 13:47:14 +0200, Ján Tomko wrote: > On Wed, Jun 19, 2019 at 11:38:06AM +0200, Jiri Denemark wrote: > > Again, why 4.0.0 in particular? Forgot again :/ Newer QEMU will translate the feature names to their canonical names so 4.0.0 is the last one which produces the results we

[libvirt] [PATCH 3/3] tests: qemuMonitorTest: drop the JSON field

2019-06-19 Thread Ján Tomko
Now that we no longer support testing HMP monitor, the json field is pointless. Signed-off-by: Ján Tomko --- tests/qemumonitortestutils.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index 9f18e511ac..d395a9b539 100644 --- a/tes

[libvirt] [PATCH 2/3] tests: qemuMonitorTestProcessCommandDefaultValidate: simplify condition

2019-06-19 Thread Ján Tomko
We return success when running this function for either non-JSON monitor testing or guest agent testing. However we no longer test HMP monitor and we do not try to validate the guest agent interaction. Drop the test->json check and report a proper error if someone tries to run this function for t

[libvirt] [PATCH 0/3] tests: drop the JSON field from qemuMonitorTest

2019-06-19 Thread Ján Tomko
Ján Tomko (3): tests: assume JSON in qemuMonitorTestIO tests: qemuMonitorTestProcessCommandDefaultValidate: simplify condition tests: qemuMonitorTest: drop the JSON field tests/qemumonitortestutils.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) -- 2.19.2 -- lib

[libvirt] [PATCH 1/3] tests: assume JSON in qemuMonitorTestIO

2019-06-19 Thread Ján Tomko
The QMP monitor only uses a newline to separate lines, while HMP and the guest agent also use a carriage return. In preparation to dropping support for testing HMP interaction, only skip the carriage return if we're dealing with the guest agent, removing the need to check the 'json' field. Signed

Re: [libvirt] [PATCH 05/24] qemuxml2argvtest: Switch some tests to DO_TEST_CAPS_*

2019-06-19 Thread Jiri Denemark
On Wed, Jun 19, 2019 at 13:43:53 +0200, Ján Tomko wrote: > On Wed, Jun 19, 2019 at 11:38:02AM +0200, Jiri Denemark wrote: > >These test check all kvm CPU features that could be passed to the -cpu > >option by libvirt. > > > > It would be nice to mention why you picked 2.7.0 here. Yeah, I forgot t

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-19 Thread Alex Williamson
On Wed, 19 Jun 2019 11:04:15 +0200 Sylvain Bauza wrote: > On Wed, Jun 19, 2019 at 12:27 AM Alex Williamson > wrote: > > > On Tue, 18 Jun 2019 14:48:11 +0200 > > Sylvain Bauza wrote: > > > > > On Tue, Jun 18, 2019 at 1:01 PM Cornelia Huck wrote: > > > > > > > On Mon, 17 Jun 2019 11:05:17 -

[libvirt] [PATCH v2] syntax check: update header guard check

2019-06-19 Thread Jonathon Jongsma
Internal headers should use #pragma once instead of the standard #ifndef guard. Public headers still require the existing header guard. Signed-off-by: Jonathon Jongsma --- Changes in v2: - fix error messages when no header guard is found (#ifndef for public headers, #pragma for internal hea

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-19 Thread Alex Williamson
On Wed, 19 Jun 2019 11:46:59 +0200 Cornelia Huck wrote: > On Wed, 19 Jun 2019 08:28:02 +0100 > Daniel P. Berrangé wrote: > > > On Tue, Jun 18, 2019 at 04:12:10PM -0600, Alex Williamson wrote: > > > On Tue, 18 Jun 2019 14:48:11 +0200 > > > Sylvain Bauza wrote: > > > > > > > On Tue, Jun 1

Re: [libvirt] [PATCH] qemuProcessLaunch: Return earlier if spawning qemu failed

2019-06-19 Thread Ján Tomko
On Thu, May 23, 2019 at 11:03:29AM +0200, Michal Privoznik wrote: If spawning qemu fails then we report an error and proceed to writing status XML onto the disk. This is unnecessary as we are sure that the domain is not running. At the same time, if virPidFileReadPath() fails it returns -errno.

Re: [libvirt] [PATCH] remote: delete the avahi mDNS support

2019-06-19 Thread Ján Tomko
On Wed, Jun 19, 2019 at 05:09:26PM +0100, Daniel P. Berrangé wrote: Libvirtd has long had integration with avahi for advertising libvirtd using mDNS when TCP/TLS listening is enabled. For a long time the virt-manager application had support for auto-detecting libvirtds on the local network using

Re: [libvirt] [PATCH 0/3] Ditch external JavaScript libraries

2019-06-19 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 05:22:56PM +0200, Martin Kletzander wrote: > This is a response to all the discussions (mainly) other people had about all > the JS code we're currently using, bundling, etc. > > I would love some feedback on whether we can work on any of the solutions for > getting rid of

Re: [libvirt] [PATCH] Revert "spec: Bump minimum supported Fedora version to 29"

2019-06-19 Thread Ján Tomko
On Tue, May 28, 2019 at 01:51:06PM +0200, Andrea Bolognani wrote: On Tue, 2019-05-28 at 13:34 +0200, Daniel Veillard wrote: On Tue, May 28, 2019 at 01:14:19PM +0200, Ján Tomko wrote: > This reverts commit 8a1179831b5edc0a3590489eda693914fc0ff94f. > > It bumped the version prematurely, before the

Re: [libvirt] [PATCH] docs: Advertise pcie-to-pci-bridge for use on q35

2019-06-19 Thread Ján Tomko
On Fri, Jun 07, 2019 at 10:53:17AM +0200, Andrea Bolognani wrote: We support pcie-to-pci-bridge, and prefer it to dmi-to-pci-bridge, since libvirt 4.3.0, but we didn't update all the documentation accordingly at the time. Signed-off-by: Andrea Bolognani --- docs/formatdomain.html.in | 10 +-

Re: [libvirt] [PATCH 1/3] docs: Use our own implementation for fetching the RSS data

2019-06-19 Thread Daniel P . Berrangé
On Wed, Jun 19, 2019 at 05:22:57PM +0200, Martin Kletzander wrote: > This is just a small script I wrote. It works the same way as all the > libraries > together which we are bundling, but with just JS. The only difference is that > the day of the date is formatted as 2-digit, but this should be

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
On Wed, Jun 19, 2019 at 4:19 PM Michal Privoznik wrote: > > On 6/19/19 4:04 PM, Ilias Stamatis wrote: > > On Wed, Jun 19, 2019 at 3:48 PM Michal Privoznik > > wrote: > >> > >> On 6/19/19 1:18 PM, Ilias Stamatis wrote: > >>> testDomainInterfaceAddresses always returns the same hard-coded > >>> ad

Re: [libvirt] [PATCH 3/3] docs: Remove unused JS libraries

2019-06-19 Thread Andrea Bolognani
On Wed, 2019-06-19 at 17:22 +0200, Martin Kletzander wrote: [...] > javascript = \ > - js/main.js \ > - js/jquery-3.1.1.min.js \ > - js/jquery.rss.min.js \ > - js/moment.min.js > - > + js/main.js Please keep the list as javascript = \ js/main.js \ $(NULL) Smaller diff, both right

Re: [libvirt] [PATCH 2/3] docs: use case sensitive javascript

2019-06-19 Thread Andrea Bolognani
On Wed, 2019-06-19 at 17:22 +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > docs/js/main.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) In the subject: s/use/Use/ s/javascript/JavaScript/ Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat

Re: [libvirt] [PATCH 1/3] docs: Use our own implementation for fetching the RSS data

2019-06-19 Thread Andrea Bolognani
On Wed, 2019-06-19 at 17:22 +0200, Martin Kletzander wrote: [...] > +docLoc = document.location; > +if (docLoc.protocol != "file:" || > +docLoc.origin != "null" || > +docLoc.host !== "" || > +docLoc.hostname !== "") { > +fetchRSS() > +} This probably doe

[libvirt] [PATCH v2] test_driver: properly handle DHCP ranges and IPv6 networks in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
testDomainInterfaceAddresses always returns the same hard-coded addresses. Change the behavior such as if there is a DHCP range defined, addresses are returned from that pool. The specific address returned depends on both the domain id and the specific guest interface in an attempt to return uniqu

Re: [libvirt] [PATCH 10/13] backup: test: Implement metadata tracking for checkpoint APIs

2019-06-19 Thread Peter Krempa
On Tue, Jun 18, 2019 at 22:47:51 -0500, Eric Blake wrote: > A lot of this work heavily copies from the existing snapshot APIs. > The test driver doesn't really have to do anything more than just > expose an interface into libvirt metadata, making it possible to test > saving and restoring XML, and

Re: [libvirt] [PATCH 13/13] backup: qemu: Implement VIR_DOMAIN_CHECKPOINT_XML_SIZE flag

2019-06-19 Thread Peter Krempa
On Tue, Jun 18, 2019 at 22:47:54 -0500, Eric Blake wrote: > Once a checkpoint has been created, it is desirable to estimate the > size of the disk delta that is represented between the checkpoint and > the current operation. To do this, we have to scrape information out > of QMP query-block on a re

Re: [libvirt] [PATCH 12/13] backup: Wire up qemu checkpoint commands over QMP

2019-06-19 Thread Peter Krempa
On Tue, Jun 18, 2019 at 22:47:53 -0500, Eric Blake wrote: > Time to actually issue the QMP transactions that create and > delete persistent checkpoints. For create, we only need one > transaction: inside, we visit all disks affected by the > checkpoint, and create a new enabled bitmap, as well as

[libvirt] [PATCH] remote: delete the avahi mDNS support

2019-06-19 Thread Daniel P . Berrangé
Libvirtd has long had integration with avahi for advertising libvirtd using mDNS when TCP/TLS listening is enabled. For a long time the virt-manager application had support for auto-detecting libvirtds on the local network using mDNS, but this was removed last year commit fc8f8d5d7e3ba80a0771df1

Re: [libvirt] [PATCH 2/3] docs: use case sensitive javascript

2019-06-19 Thread Christophe de Dinechin
> On 19 Jun 2019, at 17:22, Martin Kletzander wrote: > > Signed-off-by: Martin Kletzander > --- > docs/js/main.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/js/main.js b/docs/js/main.js > index 07f79c7ff903..668bf752b73d 100644 > --- a/docs/js/main.js > +++

[libvirt] [PATCH 3/3] docs: Remove unused JS libraries

2019-06-19 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- docs/Makefile.am| 6 +- docs/index.html.in | 3 --- docs/js/jquery-3.1.1.min.js | 4 docs/js/jquery.rss.min.js | 11 --- docs/js/moment.min.js | 7 --- 5 files changed, 1 insertion(+), 30 deletions(-) dele

[libvirt] [PATCH 1/3] docs: Use our own implementation for fetching the RSS data

2019-06-19 Thread Martin Kletzander
This is just a small script I wrote. It works the same way as all the libraries together which we are bundling, but with just JS. The only difference is that the day of the date is formatted as 2-digit, but this should be a bug in Firefox (at least locally for me) as the documentation states that

[libvirt] [PATCH 2/3] docs: use case sensitive javascript

2019-06-19 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- docs/js/main.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/js/main.js b/docs/js/main.js index 07f79c7ff903..668bf752b73d 100644 --- a/docs/js/main.js +++ b/docs/js/main.js @@ -28,7 +28,7 @@ function pageload() { advancedSearc

[libvirt] [PATCH 0/3] Ditch external JavaScript libraries

2019-06-19 Thread Martin Kletzander
This is a response to all the discussions (mainly) other people had about all the JS code we're currently using, bundling, etc. I would love some feedback on whether we can work on any of the solutions for getting rid of that external proxy. We would have to: - either have our own proxy, - se

Re: [libvirt] [PATCH 00/46] Finish moving header guards to #pragma once

2019-06-19 Thread Ján Tomko
The subject prefixes show up with various numbers of spaces for me. I do not know why the list started doing that, but not including the [libvirt] prefix in the patches I send and letting the list add it fixed it for me. On Tue, Jun 18, 2019 at 11:12:30AM -0500, Jonathon Jongsma wrote: My previo

Re: [libvirt] [PATCH 46/46] syntax check: update header guard check

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:16AM -0500, Jonathon Jongsma wrote: Internal headers should use #pragma once instead of the standard #ifndef guard. Public headers still require the existing header guard. Signed-off-by: Jonathon Jongsma --- build-aux/header-ifdef.pl | 35 ++

Re: [libvirt] [PATCH 45/46] tools: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:15AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- tools/nss/libvirt_nss.h | 27 - tools/virsh-completer.h | 6 +- tools/virsh-console.h| 11 ++-- tools/virsh-domain-monitor.h | 7 +-- tool

Re: [libvirt] [PATCH 44/46] tests: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:14AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- tests/qemumonitortestutils.h | 19 +++--- tests/qemusecuritytest.h | 7 +- tests/testutils.h| 45 ++-- tests/testutilshostcpus.h| 11 ++- tests/testutilslxc.h

Re: [libvirt] [PATCH 43/46] xen: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:13AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/xenapi/xenapi_driver.h | 5 + src/xenapi/xenapi_driver_private.h | 17 +++-- src/xenapi/xenapi_utils.h | 15 ++- src/xenconfig/xen_common.h

Re: [libvirt] [PATCH 42/46] src/vz: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:12AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/vz/vz_driver.h | 5 + src/vz/vz_sdk.h| 9 +++-- src/vz/vz_utils.h | 37 + 3 files changed, 21 insertions(+), 30 deletions(-) Reviewed-by: J

Re: [libvirt] [PATCH v3 0/5] docs: Update third-party JavaScript libraries

2019-06-19 Thread Christophe de Dinechin
> On 19 Jun 2019, at 14:41, Andrea Bolognani wrote: > > We're carrying around embedded copies of a few JavaScript libraries > for use in our homepage, and we've been unforgivably bad at keeping > them up to date. Address that. > > While doing so, replace the minified version of each library w

Re: [libvirt] [PATCH 41/46] src/vmx: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:11AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/vmx/vmx.h | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing list

Re: [libvirt] [PATCH 40/46] src/vmware: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:10AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/vmware/vmware_conf.h | 19 --- src/vmware/vmware_driver.h | 5 + 2 files changed, 9 insertions(+), 15 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Descr

Re: [libvirt] [PATCH 39/46] src/vbox: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:09AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/vbox/vbox_MSCOMGlue.h | 11 +-- src/vbox/vbox_common.h| 161 +- src/vbox/vbox_driver.h| 19 ++-- src/vbox/vbox_get_driver.h| 7 +- src

Re: [libvirt] [PATCH 38/46] util: misc: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:08AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virarptable.h | 7 ++ [...] src/util/virvsock.h | 4 +-- src/util/virxdrdefs.h| 35 --- 64 files changed, 248 insertions(+), 434 de

Re: [libvirt] [PATCH 36/46] util: xml: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:06AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virxml.h | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-l

Re: [libvirt] [PATCH 37/46] util: scsi: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:07AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virscsi.h | 11 --- src/util/virscsihost.h | 7 ++- src/util/virscsivhost.h | 13 + 3 files changed, 11 insertions(+), 20 deletions(-) Reviewed-by: Ján To

Re: [libvirt] [PATCH 35/46] util: netlink: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:05AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virnetlink.h | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature --

Re: [libvirt] [PATCH 31/46] util: object: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:01AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virobject.h | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing

Re: [libvirt] [PATCH 30/46] util: mac: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:00AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virmacaddr.h | 17 +++-- src/util/virmacmap.h | 5 + 2 files changed, 8 insertions(+), 14 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP

Re: [libvirt] [PATCH 34/46] util: sysinfo: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:04AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virsysinfo.h | 13 + src/util/virsysinfopriv.h | 5 + 2 files changed, 6 insertions(+), 12 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description:

Re: [libvirt] [PATCH 27/46] util: dbus: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:57AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virdbus.h | 22 ++ src/util/virdbuspriv.h | 11 --- 2 files changed, 14 insertions(+), 19 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Des

Re: [libvirt] [PATCH 33/46] util: socketaddr: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:03AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virsocketaddr.h | 45 +++- 1 file changed, 21 insertions(+), 24 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signatu

Re: [libvirt] [PATCH 32/46] util: string: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:13:02AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virstring.h | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- l

Re: [libvirt] [PATCH 28/46] util: command: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:58AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/vircommand.h | 11 --- src/util/vircommandpriv.h | 7 ++- 2 files changed, 6 insertions(+), 12 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description:

Re: [libvirt] [PATCH 29/46] util: hash: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:59AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virhash.h | 8 ++-- src/util/virhashcode.h | 7 ++- 2 files changed, 4 insertions(+), 11 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signatu

Re: [libvirt] [PATCH 26/46] util: virprobe.h: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:56AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virprobe.h | 63 + 1 file changed, 30 insertions(+), 33 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signatu

Re: [libvirt] [PATCH v3 4/5] docs: Perform JavaScript minimization at build time

2019-06-19 Thread Christophe de Dinechin
> On 19 Jun 2019, at 14:41, Andrea Bolognani wrote: > > We want to store third-party JavaScript libraries in their > non-minimized (source) form in the repository, but when users > are browsing libvirt.org we'd rather only transmit the more > compact minified variant. > > Call uglifyjs at buil

Re: [libvirt] [PATCH 25/46] util: error: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:55AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virerror.h | 41 +++-- src/util/virerrorpriv.h | 5 + 2 files changed, 20 insertions(+), 26 deletions(-) Reviewed-by: Ján Tomko Jano si

Re: [libvirt] [PATCH] qemu: delete unused QEMUD_CPUMASK_LEN macro

2019-06-19 Thread Andrea Bolognani
On Wed, 2019-06-19 at 16:27 +0200, Ján Tomko wrote: > Unused as of: > commit f136b83139c63f20de0df3285d9e82df2fb97bfc > qemu: Rework setting process affinity > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_conf.h | 8 > 1 file changed, 8 deletions(-) Reviewed-by: Andrea Bolognan

Re: [libvirt] [PATCH 24/46] util: cgroup: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:54AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/vircgroup.h| 10 -- src/util/vircgroupbackend.h | 15 ++- src/util/vircgroupv1.h | 5 + src/util/vircgroupv2.h | 5 + 4 files changed, 12 ins

Re: [libvirt] [PATCH 23/46] util: log: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:53AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virlog.h | 55 ++- 1 file changed, 26 insertions(+), 29 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signatu

Re: [libvirt] [PATCH 22/46] util: host: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:52AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virhostcpu.h | 17 +++-- src/util/virhostcpupriv.h | 11 --- src/util/virhostdev.h | 19 --- src/util/virhostmem.h | 7 ++- 4 files chan

Re: [libvirt] [PATCH 21/46] util: firewall: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:51AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virfirewall.h | 11 --- src/util/virfirewalld.h | 7 ++- src/util/virfirewalldpriv.h | 7 ++- src/util/virfirewallpriv.h | 7 ++- 4 files changed, 10 insert

Re: [libvirt] [PATCH 20/46] util: file: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:50AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virfile.h | 61 ++ 1 file changed, 29 insertions(+), 32 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signatu

Re: [libvirt] [PATCH 19/46] util: arch.h: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:49AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virarch.h | 41 +++-- 1 file changed, 19 insertions(+), 22 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature --

Re: [libvirt] [PATCH 18/46] util: netdev: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:48AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virnetdev.h | 33 +++- src/util/virnetdevbandwidth.h| 8 +++- src/util/virnetdevbridge.h | 8 +++- src/util/virnetdevip.h

Re: [libvirt] [PATCH 17/46] util: storage: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:47AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virstorageencryption.h | 17 +++-- src/util/virstoragefile.h| 31 ++- src/util/virstoragefilebackend.h | 9 +++-- 3 files changed, 24

Re: [libvirt] [PATCH 15/46] util: alloc: use #pragma once

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:45AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/viralloc.h | 101 +--- 1 file changed, 49 insertions(+), 52 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signatu

Re: [libvirt] [PATCH 16/46] util: atomic: use #pragma once

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:46AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/viratomic.h | 91 +--- 1 file changed, 44 insertions(+), 47 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signatu

Re: [libvirt] [PATCH 13/46] src/test: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:43AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/test/test_driver.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing list libvir-

Re: [libvirt] [PATCH 14/46] util: thread: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:44AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/util/virthread.h | 19 --- src/util/virthreadjob.h | 6 +- src/util/virthreadpool.h | 9 +++-- 3 files changed, 12 insertions(+), 22 deletions(-) Reviewed-by:

Re: [libvirt] [PATCH 12/46] src/storage: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:42AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/storage/storage_backend.h | 13 - src/storage/storage_backend_disk.h | 5 +--- src/storage/storage_backend_fs.h| 5 +--- src/storage/storage_backend

Re: [libvirt] [RFC PATCH] docs: Use our own implementation for fetching the RSS data

2019-06-19 Thread Andrea Bolognani
On Wed, 2019-06-19 at 16:11 +0200, Martin Kletzander wrote: [...] > simpleSearch = document.getElementById("simplesearch") > -simplesearch.addEventListener("submit", advancedsearch) > +simpleSearch.addEventListener("submit", advancedsearch) If I'm not mistaken, this is an unrelated bu

Re: [libvirt] [PATCH 11/46] src/security: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:41AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/security/security_apparmor.h | 13 + src/security/security_dac.h | 7 ++- src/security/security_driver.h | 11 --- src/security/security_manager.h | 13 +---

Re: [libvirt] [PATCH 09/46] src/rpc: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:39AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/rpc/virkeepalive.h| 9 +++- src/rpc/virnetclient.h| 41 --- src/rpc/virnetclientprogram.h | 15 + src/rpc/virnetclientstream.h

Re: [libvirt] [PATCH 10/46] src/secret: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:40AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/secret/secret_driver.h | 5 + src/secret/secret_util.h | 8 +++- 2 files changed, 4 insertions(+), 9 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP si

Re: [libvirt] [PATCH 08/46] src/remote: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:38AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/remote/remote_daemon.h | 35 +--- src/remote/remote_daemon_config.h | 7 ++ src/remote/remote_daemon_dispatch.h | 11 - src/remote/remote_daemon_

Re: [libvirt] [PATCH 07/46] src/qemu: use #pragma once in headers

2019-06-19 Thread Ján Tomko
On Tue, Jun 18, 2019 at 11:12:37AM -0500, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- src/qemu/qemu_agent.h| 8 ++- src/qemu/qemu_alias.h| 13 ++--- [...] src/qemu/qemu_qapi.h | 12 ++--- src/qemu/qemu_security.h | 58 ++

[libvirt] [PATCH] qemu: delete unused QEMUD_CPUMASK_LEN macro

2019-06-19 Thread Ján Tomko
Unused as of: commit f136b83139c63f20de0df3285d9e82df2fb97bfc qemu: Rework setting process affinity Signed-off-by: Ján Tomko --- src/qemu/qemu_conf.h | 8 1 file changed, 8 deletions(-) diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index 983e74a3cf..9f2d652adc 100644 ---

Re: [libvirt] [PATCH 2/3] test_driver: return addresses only for nets of type network

2019-06-19 Thread Ilias Stamatis
On Wed, Jun 19, 2019 at 3:48 PM Michal Privoznik wrote: > > On 6/19/19 1:18 PM, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 9 + > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/src/test/test_driver.c b/src/test/t

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Michal Privoznik
On 6/19/19 4:04 PM, Ilias Stamatis wrote: > On Wed, Jun 19, 2019 at 3:48 PM Michal Privoznik wrote: >> >> On 6/19/19 1:18 PM, Ilias Stamatis wrote: >>> testDomainInterfaceAddresses always returns the same hard-coded >>> addresses. Change the behavior such as if there is a DHCP range defined, >>> a

Re: [libvirt] [PATCH] remote: drop code for migrating config files from pre-XDG dir layout

2019-06-19 Thread Andrea Bolognani
On Wed, 2019-06-19 at 14:37 +0100, Daniel P. Berrangé wrote: > The unprivileged libvirtd daemon switched to use the XDG dir layout in > the 0.9.13 release, and included code for moving config files from the > old location. The chances of someone upgrading libvirt from <= 0.9.12 > directly to libvir

[libvirt] [PATCH 2/4] util: vircgroup: move virCgroupGetValueStr out of virCgroupGetValueForBlkDev

2019-06-19 Thread Pavel Hrdina
If we need to get a path of specific file and we need to check its existence before we use it then we can reuse that path to get value for specific device. This way we will not build the path again in virCgroupGetValueForBlkDev. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 8 +---

[libvirt] [PATCH 4/4] util: vircgroupv2: add support for BFQ files

2019-06-19 Thread Pavel Hrdina
In kernel 4.12 there was introduced new BFQ scheduler and in kernel 5.0 the old CFQ scheduler was removed. This has an implication on the cgroups file names. If the CFQ controller is enabled we use one file: io.weight The new BFQ controller expose one file with different name: io.bfq.w

[libvirt] [PATCH 1/4] util: vircgroup: introduce virCgroup(Get|Set)ValueRaw

2019-06-19 Thread Pavel Hrdina
If we need to get a path of specific file and we need to check its existence before we use it then we can reuse that path to get/set values instead of calling the existing get/set value functions which would be building the path again. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 6

[libvirt] [PATCH 0/4] cgroups: add support for BFQ scheduler

2019-06-19 Thread Pavel Hrdina
Pavel Hrdina (4): util: vircgroup: introduce virCgroup(Get|Set)ValueRaw util: vircgroup: move virCgroupGetValueStr out of virCgroupGetValueForBlkDev util: vircgroupv1: add support for BFQ blkio files util: vircgroupv2: add support for BFQ files src/util/vircgroup.c | 70 +

[libvirt] [PATCH 3/4] util: vircgroupv1: add support for BFQ blkio files

2019-06-19 Thread Pavel Hrdina
In kernel 4.12 there was introduced new BFQ scheduler and in kernel 5.0 the old CFQ scheduler was removed. This has an implication on the cgroups file names. If the CFQ controller is enabled we use these two files: blkio.weight blkio.weight_device The new BFQ controller expose only one

[libvirt] [RFC PATCH] docs: Use our own implementation for fetching the RSS data

2019-06-19 Thread Martin Kletzander
This is just a small script I wrote. It works the same way as all the libraries together which we are bundling, but with just JS. The only difference is that the day of the date is formatted as 2-digit, but this should be a bug in Firefox (at least locally for me) as the documentation states that

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Ilias Stamatis
On Wed, Jun 19, 2019 at 3:48 PM Michal Privoznik wrote: > > On 6/19/19 1:18 PM, Ilias Stamatis wrote: > > testDomainInterfaceAddresses always returns the same hard-coded > > addresses. Change the behavior such as if there is a DHCP range defined, > > addresses are returned from that pool. > > > >

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Ján Tomko
On Wed, Jun 19, 2019 at 03:47:58PM +0200, Michal Privoznik wrote: On 6/19/19 1:18 PM, Ilias Stamatis wrote: [...] @@ -3413,6 +3426,16 @@ testDomainInterfaceAddresses(virDomainPtr dom, if (vm->def->nets[i]->type != VIR_DOMAIN_NET_TYPE_NETWORK) continue; +virObjec

Re: [libvirt] [PATCH 1/3] test_driver: validate @source in testDomainInterfaceAddresses

2019-06-19 Thread Michal Privoznik
On 6/19/19 1:18 PM, Ilias Stamatis wrote: Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) ACKed and pushed. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/3] test_driver: consider DHCP ranges in testDomainInterfaceAddresses

2019-06-19 Thread Michal Privoznik
On 6/19/19 1:18 PM, Ilias Stamatis wrote: testDomainInterfaceAddresses always returns the same hard-coded addresses. Change the behavior such as if there is a DHCP range defined, addresses are returned from that pool. The specific address returned depends on both the domain id and the specific g

Re: [libvirt] [PATCH 2/3] test_driver: return addresses only for nets of type network

2019-06-19 Thread Michal Privoznik
On 6/19/19 1:18 PM, Ilias Stamatis wrote: Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 437df9cdf9..0c2cfdd2f7 100644 --- a/src/test/test_driver.c +++

  1   2   3   >