Re: [libvirt] [PATCH 10/21] conf: network: store namespace prefix

On Wed, Aug 21, 2019 at 01:15:32 +0200, Ján Tomko wrote: > Signed-off-by: Ján Tomko > --- > src/network/bridge_driver.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c > index b34b742bfa..b0ada0132a 100644 > --- a/src/network/bri

Re: [libvirt] [PATCH 04/21] conf: ns.parse: decouple call from condition

On Wed, Aug 21, 2019 at 01:15:26 +0200, Ján Tomko wrote: > In the future we will perform more actions if ns.parse > is present. Decouple the condition from the actual call. > > Signed-off-by: Ján Tomko > --- > src/conf/domain_conf.c | 7 --- > src/conf/network_conf.c | 7 --- > src/conf

Re: [libvirt] [PATCH 09/21] xml: virXMLNamespace: add prefix

On Wed, Aug 21, 2019 at 01:15:31 +0200, Ján Tomko wrote: > We have hardcoded the namespace prefix in various places: > 1) the xmlns string stored in the 'href' function > 2) the xmlXPathRegisterNs call in each parser > 3) all the parsing and formatting code actually dealing >with these elements

Re: [libvirt] [PATCH 07/21] conf: storage: use generic XML namespace types

On Wed, Aug 21, 2019 at 01:15:29 +0200, Ján Tomko wrote: > There is no need to copy and paste the same types pointing > to void all over the place. > > Signed-off-by: Ján Tomko > --- > src/conf/storage_conf.c | 4 ++-- > src/conf/storage_conf.h | 23 --- >

Re: [libvirt] [PATCH 05/21] util: introduce virXMLNamespace

On Wed, Aug 21, 2019 at 01:15:27 +0200, Ján Tomko wrote: > For various XMLs, we allow a custom namespace for passing unsupported > configurations. > > Introduce a single structure to hold all the driver-specific functions > to remove duplication. > > Signed-off-by: Ján Tomko > --- > src/util/vi

Re: [libvirt] [PATCH 08/21] conf: domain: use generic XML namespace types

On Wed, Aug 21, 2019 at 01:15:30 +0200, Ján Tomko wrote: > Now that virDomainXMLNamespace matches virXMLNamespace, > we no longer need to keep both around. > > Signed-off-by: Ján Tomko > --- > src/bhyve/bhyve_domain.c | 2 +- > src/bhyve/bhyve_domain.h | 2 +- > src/conf/capabilities.h | 12 -

Re: [libvirt] [PATCH 06/21] conf: network: use generic XML namespace types

On Wed, Aug 21, 2019 at 01:15:28 +0200, Ján Tomko wrote: > There is no need to copy and paste the same types pointing > to void all over the place. > > Signed-off-by: Ján Tomko > --- > src/conf/network_conf.c | 2 +- > src/conf/network_conf.h | 25 - > src/networ

Re: [libvirt] [PATCH 03/21] prepare: domain format if format not href

On Wed, Aug 21, 2019 at 01:15:25 +0200, Ján Tomko wrote: > --- > src/conf/domain_conf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index 1f2a91c710..f848483235 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/do

Re: [libvirt] [PATCH 01/21] virDomainDefNamespaceParse: remove unused attributes

On Wed, Aug 21, 2019 at 01:15:23 +0200, Ján Tomko wrote: > Neither the xmlDocPtr nor the root xmlNode (also passed > in the XPathContext) are interesting to the callees. > > Signed-off-by: Ján Tomko > --- > src/bhyve/bhyve_domain.c | 4 +--- > src/conf/capabilities.h | 3 +-- > src/conf/domain_

Re: [libvirt] [PATCH 02/21] virDomainDefParseXML: remove unused parameter

On Wed, Aug 21, 2019 at 01:15:24 +0200, Ján Tomko wrote: > We do not need to pass the root node, since it's already > included in the XPathContext. > > Signed-off-by: Ján Tomko > --- > src/conf/domain_conf.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Jiri Denemark

[libvirt] [PATCH 11/21] conf: domain: store namespace prefix

Signed-off-by: Ján Tomko --- src/bhyve/bhyve_domain.c | 1 + src/lxc/lxc_domain.c | 1 + src/qemu/qemu_domain.c | 1 + src/test/test_driver.c | 1 + src/vmx/vmx.c| 1 + 5 files changed, 5 insertions(+) diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index 492

[libvirt] [PATCH 18/21] util: xml: introduce virXMLNamespaceRegister

A wrapper around xmlXPathRegisterNs that will save us from having to include xpathInternals.h everywhere we want to use a custom namespace and open-coding the strings already contained in virXMLNamespace. Signed-off-by: Ján Tomko --- src/util/virxml.c | 20 src/util/virxml.h

[libvirt] [PATCH 01/21] virDomainDefNamespaceParse: remove unused attributes

Neither the xmlDocPtr nor the root xmlNode (also passed in the XPathContext) are interesting to the callees. Signed-off-by: Ján Tomko --- src/bhyve/bhyve_domain.c | 4 +--- src/conf/capabilities.h | 3 +-- src/conf/domain_conf.c | 4 ++-- src/lxc/lxc_domain.c | 4 +--- src/qemu/qemu_domai

[libvirt] [PATCH 06/21] conf: network: use generic XML namespace types

There is no need to copy and paste the same types pointing to void all over the place. Signed-off-by: Ján Tomko --- src/conf/network_conf.c | 2 +- src/conf/network_conf.h | 25 - src/network/bridge_driver.c | 2 +- src/network/bridge_driver.h | 2 +- 4 files c

[libvirt] [PATCH 10/21] conf: network: store namespace prefix

Signed-off-by: Ján Tomko --- src/network/bridge_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index b34b742bfa..b0ada0132a 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -252,6 +252,7 @@ virXML

[libvirt] [PATCH 03/21] prepare: domain format if format not href

--- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1f2a91c710..f848483235 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -28312,7 +28312,7 @@ virDomainDefFormatInternal(virDomainD

[libvirt] [PATCH 14/21] util: introduce virXMLNamespaceFormatNS

A function to automatically format the xmlns:='' attribute for per-driver namespaces. Signed-off-by: Ján Tomko --- src/util/virxml.c | 7 +++ src/util/virxml.h | 4 2 files changed, 11 insertions(+) diff --git a/src/util/virxml.c b/src/util/virxml.c index f55b9a362c..11b6031b09 100644

[libvirt] [PATCH 19/21] conf: network: use virXMLNamespaceRegister

Signed-off-by: Ján Tomko --- src/conf/network_conf.c | 2 ++ src/network/bridge_driver.c | 10 -- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 7eba9eacbf..8db041bd2c 100644 --- a/src/conf/network_conf.c +++ b/

[libvirt] [PATCH 21/21] conf: domain: use virXMLNamespaceRegister

Signed-off-by: Ján Tomko --- src/bhyve/bhyve_domain.c | 9 - src/conf/domain_conf.c | 2 ++ src/lxc/lxc_domain.c | 8 src/qemu/qemu_domain.c | 8 src/test/test_driver.c | 9 - 5 files changed, 2 insertions(+), 34 deletions(-) diff --git a/src/bhyve/bhy

[libvirt] [PATCH 13/21] conf: test: store namespace href

Unlike all the other occurrences, only store the actual URL instead of the whole xmlns:='' header. The rest will be converted before this string is used. Signed-off-by: Ján Tomko --- src/test/test_driver.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/test/test_driver.c b/src/t

[libvirt] [PATCH 12/21] conf: storage: store namespace prefix

Signed-off-by: Ján Tomko --- src/storage/storage_backend_fs.c | 1 + src/storage/storage_backend_rbd.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index d575b75449..c2d0d7bd1f 100644 --- a/src/storage/storage_backend_f

[libvirt] [PATCH 20/21] conf: storage: use virXMLNamespaceRegister

Signed-off-by: Ján Tomko --- src/conf/storage_conf.c | 2 ++ src/storage/storage_backend_fs.c | 9 - src/storage/storage_backend_rbd.c | 9 - 3 files changed, 2 insertions(+), 18 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 6588d5c8

[libvirt] [PATCH 08/21] conf: domain: use generic XML namespace types

Now that virDomainXMLNamespace matches virXMLNamespace, we no longer need to keep both around. Signed-off-by: Ján Tomko --- src/bhyve/bhyve_domain.c | 2 +- src/bhyve/bhyve_domain.h | 2 +- src/conf/capabilities.h | 12 src/conf/domain_conf.c | 6 +++--- src/conf/domain_conf.h

[libvirt] [PATCH 17/21] conf: domain: use virXMLNamespaceFormatNS

Signed-off-by: Ján Tomko --- src/bhyve/bhyve_domain.c | 2 +- src/conf/domain_conf.c | 2 +- src/lxc/lxc_domain.c | 2 +- src/qemu/qemu_domain.c | 2 +- src/vmx/vmx.c| 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhy

[libvirt] [PATCH 05/21] util: introduce virXMLNamespace

For various XMLs, we allow a custom namespace for passing unsupported configurations. Introduce a single structure to hold all the driver-specific functions to remove duplication. Signed-off-by: Ján Tomko --- src/util/virxml.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/

[libvirt] [PATCH 00/21] conf: namespaces: remove some copy'n'paste

Ján Tomko (21): virDomainDefNamespaceParse: remove unused attributes virDomainDefParseXML: remove unused parameter prepare: domain format if format not href conf: ns.parse: decouple call from condition util: introduce virXMLNamespace conf: network: use generic XML namespace types conf

[libvirt] [PATCH 16/21] conf: storage: use virXMLNamespaceFormatNS

Signed-off-by: Ján Tomko --- src/conf/storage_conf.c | 2 +- src/storage/storage_backend_fs.c | 2 +- src/storage/storage_backend_rbd.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index fb8a16a119..6588d5c8ef

[libvirt] [PATCH 04/21] conf: ns.parse: decouple call from condition

In the future we will perform more actions if ns.parse is present. Decouple the condition from the actual call. Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 7 --- src/conf/network_conf.c | 7 --- src/conf/storage_conf.c | 7 --- 3 files changed, 12 insertions(+), 9 deletio

[libvirt] [PATCH 15/21] conf: network: use virXMLNamespaceFormatNS

Signed-off-by: Ján Tomko --- src/conf/network_conf.c | 2 +- src/network/bridge_driver.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 2c3a11fb10..7eba9eacbf 100644 --- a/src/conf/network_conf.c +++ b/src/conf/ne

[libvirt] [PATCH 07/21] conf: storage: use generic XML namespace types

There is no need to copy and paste the same types pointing to void all over the place. Signed-off-by: Ján Tomko --- src/conf/storage_conf.c | 4 ++-- src/conf/storage_conf.h | 23 --- src/storage/storage_backend_fs.c | 2 +- src/storage/storage_backend_

[libvirt] [PATCH 09/21] xml: virXMLNamespace: add prefix

We have hardcoded the namespace prefix in various places: 1) the xmlns string stored in the 'href' function 2) the xmlXPathRegisterNs call in each parser 3) all the parsing and formatting code actually dealing with these elements While eliminating the third one is probably a job for an actual X

[libvirt] [PATCH 02/21] virDomainDefParseXML: remove unused parameter

We do not need to pass the root node, since it's already included in the XPathContext. Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 40b5f9b801..1f2a91c710 100644

[libvirt] QEMU bitmap backup usability FAQ

Hi, downstream here at Red Hat I've been fielding some questions about the usability and feature readiness of Bitmaps (and related features) in QEMU. Here are some questions I answered internally that I am copying to the list for two reasons: (1) To make sure my answers are actually correct, and

[libvirt] [jenkins-ci PATCH 7/7] Switch osinfo-db-tools builds to Meson

Signed-off-by: Fabiano Fidêncio --- .../playbooks/build/projects/osinfo-db-tools+mingw32.yml | 4 ++-- .../playbooks/build/projects/osinfo-db-tools+mingw64.yml | 4 ++-- guests/playbooks/build/projects/osinfo-db-tools.yml | 8 jenkins/projects/osinfo-db-tools+mingw32.yaml

[libvirt] [jenkins-ci PATCH 5/7] Only build osinfo-db-tools on systems with meson >= 0.49.0

osinfo-db-tools has switched its build system to meson and requires 0.49.0 or newer. Signed-off-by: Fabiano Fidêncio --- guests/host_vars/libvirt-centos-7/main.yml| 1 - guests/host_vars/libvirt-debian-9/main.yml| 1 - guests/host_vars/libvirt-ubuntu-16/main.yml | 1 - guests/host_v

[libvirt] [jenkins-ci PATCH 1/7] jobs: add a template for Meson

Add a template for projects using the Meson framework. Signed-off-by: Fabiano Fidêncio --- jenkins/jobs/defaults.yaml | 3 + jenkins/jobs/meson.yaml| 174 + 2 files changed, 177 insertions(+) create mode 100644 jenkins/jobs/meson.yaml diff --git a/jenk

[libvirt] [jenkins-ci PATCH 4/7] osinfo-db-tools: Add meson dependency

It's been introduced as dependency as part of v1.7.0 development cycle. Signed-off-by: Fabiano Fidêncio --- guests/vars/projects/osinfo-db-tools+mingw32.yml | 1 + guests/vars/projects/osinfo-db-tools+mingw64.yml | 1 + guests/vars/projects/osinfo-db-tools.yml | 1 + 3 files changed, 3 i

[libvirt] [jenkins-ci PATCH 6/7] Update osinfo-db-tools' archive_format

Since the switch to meson, osinfo-db-tools' archive format is "xz" instead of "gz". Signed-off-by: Fabiano Fidêncio --- guests/playbooks/build/projects/osinfo-db-tools+mingw32.yml | 2 +- guests/playbooks/build/projects/osinfo-db-tools+mingw64.yml | 2 +- guests/playbooks/build/projects/osinfo-d

[libvirt] [jenkins-ci PATCH 2/7] guests: Add Meson jobs

These tasks mirror the Jenkins's Meson jobs contained in the top-level jobs/ directory. Signed-off-by: Fabiano Fidêncio --- guests/playbooks/build/jobs/defaults.yml | 3 +++ guests/playbooks/build/jobs/meson-build-job.yml | 14 ++ guests/playbooks/build/jobs/meson-check-j

[libvirt] [jenkins-ci PATCH 0/7] Switch osinfo-db-tools to Meson

This patch series switches osinfo-db-tools to using meson instead of autotools. In order to do so, meson build jobs had to be added as the first step. I've tried to make the osinfo-db-tools changes as small as possible so it'd make the review easier. Fabiano Fidêncio (7): jobs: add a template

[libvirt] [jenkins-ci PATCH 3/7] mappings: Add meson

meson is a new dependency, introduced as part of v1.7.0 release, for (mingw-*)?osinfo-db-tools. Signed-off-by: Fabiano Fidêncio --- guests/vars/mappings.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 5012741..c5a7824 100644 --

Re: [libvirt] [PATCH 00/12] Drop KVM assignment

On 8/20/19 11:30 AM, Michal Privoznik wrote: The KVM style of PCI assignment is not used, and it hasn't been for a while. Any attempt to start a domain with it would result in error as kernel dropped its support in 4.12.0 (after being deprecated for 1.5 years). LGTM. Just a comment in patch 0

Re: [libvirt] [PATCH 01/12] qemu: Drop KVM assignment

On 8/20/19 1:52 PM, Daniel Henrique Barboza wrote: On 8/20/19 11:30 AM, Michal Privoznik wrote: KVM style of PCI devices assignment was dropped in kernel in favor of vfio pci (see kernel commit v4.12-rc1~68^2~65). Since vfio is around for quite some time now and is far superior discourage pe

Re: [libvirt] [PATCH 12/12] news: Document KVM assignment removal

On 8/20/19 11:30 AM, Michal Privoznik wrote: Signed-off-by: Michal Privoznik --- Reviewed-by: Daniel Henrique Barboza Tested-by: Daniel Henrique Barboza docs/news.xml | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index d63fca3b48..6

Re: [libvirt] [PATCH 09/12] virpcimock: Don't create "pci-stub" driver

On 8/20/19 11:30 AM, Michal Privoznik wrote: Now that nothing supports "pci-stub" driver (aka KVM style of PCI device assignment) there is no need for virpcimock to create it. Signed-off-by: Michal Privoznik --- Reviewed-by: Daniel Henrique Barboza Tested-by: Daniel Henrique Barboza

Re: [libvirt] [PATCH 10/12] virpcimock: Don't create new_id or remove_id files

On 8/20/19 11:30 AM, Michal Privoznik wrote: Now that PCI attach/detach happens solely via driver_override these two files are no longer needed. Signed-off-by: Michal Privoznik --- Reviewed-by: Daniel Henrique Barboza Tested-by: Daniel Henrique Barboza tests/virpcimock.c | 112 --

Re: [libvirt] [PATCH 11/12] virpcimock: Drop @driverActions enum

On 8/20/19 11:30 AM, Michal Privoznik wrote: This enum was introduced to model how RHEL-7 kernel behaves - for some reason going with the old way (via new_id + bind) fails but using driver_override succeeds. Well, we don't need to care about that anymore since we don't create new_id file. Sig

Re: [libvirt] [PATCH 06/12] virpci: Drop 'pci-stub' driver

On 8/20/19 11:30 AM, Michal Privoznik wrote: Now that no one uses KVM style of PCI assignment we can safely remove 'pci-stub' backend. Signed-off-by: Michal Privoznik --- Reviewed-by: Daniel Henrique Barboza Tested-by: Daniel Henrique Barboza src/util/virpci.c | 11 --- sr

Re: [libvirt] [PATCH 08/12] virpci: Drop newid style of PCI device detach

On 8/20/19 11:30 AM, Michal Privoznik wrote: As stated in 84f9358b18346 all kernels that we are interested in have 'drivers_override'. Drop the other, older style of overriding PCI device driver - newid. Signed-off-by: Michal Privoznik --- Reviewed-by: Daniel Henrique Barboza Tested-by:

Re: [libvirt] [PATCH 07/12] virpci: Remove unused virPCIDeviceWaitForCleanup

On 8/20/19 11:30 AM, Michal Privoznik wrote: This function is no longer used after previous commit. Signed-off-by: Michal Privoznik --- Reviewed-by: Daniel Henrique Barboza Tested-by: Daniel Henrique Barboza src/libvirt_private.syms | 1 - src/util/virpci.c| 108 -

Re: [libvirt] [PATCH 05/12] virhostdev: Disable legacy kvm assignment

On 8/20/19 11:30 AM, Michal Privoznik wrote: The KVM assignment is going to be removed shortly. Don't let the hostdev module configure it. Signed-off-by: Michal Privoznik --- Reviewed-by: Daniel Henrique Barboza Tested-by: Daniel Henrique Barboza src/util/virhostdev.c | 12

Re: [libvirt] [PATCH 03/12] virhostdev: Unify virDomainHostdevDef to virPCIDevice translation

On 8/20/19 11:30 AM, Michal Privoznik wrote: There are two places where we need to create virPCIDevice from given virDomainHostdevDef. In both places the code is duplicated. Move them into a single function and call it from those two places. Signed-off-by: Michal Privoznik --- Reviewed-by:

Re: [libvirt] [PATCH 04/12] qemu: Drop unused qemuOpenPCIConfig()

On 8/20/19 11:30 AM, Michal Privoznik wrote: After previous commits, the function is not used anymore. Remove it. Signed-off-by: Michal Privoznik --- Reviewed-by: Daniel Henrique Barboza Tested-by: Daniel Henrique Barboza src/qemu/qemu_command.c | 22 -- src/qem

Re: [libvirt] [PATCH 02/12] tests: Remove 'kvm' PCI backend from domaincapstest

On 8/20/19 11:30 AM, Michal Privoznik wrote: The KVM assignment was removed in qemu driver in previous commit. Remove it from domaincapstest too which is hard coding it. Signed-off-by: Michal Privoznik --- tests/domaincapsschemadata/qemu_1.7.0.x86_64.xml| 1 - tests/domaincapssche

Re: [libvirt] [PATCH] virt-aa-helper: Actually fix AppArmor profile

On Tue, 20 Aug 2019, Andrea Bolognani wrote: > --- a/src/security/apparmor/usr.lib.libvirt.virt-aa-helper > +++ b/src/security/apparmor/usr.lib.libvirt.virt-aa-helper > @@ -18,8 +18,8 @@ profile virt-aa-helper > /usr/{lib,lib64}/libvirt/virt-aa-helper { >@{PROC}/filesystems r, > ># Used

Re: [libvirt] [PATCH 01/12] qemu: Drop KVM assignment

On 8/20/19 11:30 AM, Michal Privoznik wrote: KVM style of PCI devices assignment was dropped in kernel in favor of vfio pci (see kernel commit v4.12-rc1~68^2~65). Since vfio is around for quite some time now and is far superior discourage people in using KVM style. Ideally, I'd make QEMU_CAPS_

Re: [libvirt] [PATCH 0/2] cgroups v2 fixes

On Tue, Aug 20, 2019 at 05:04:59PM +0200, Jiri Denemark wrote: > On Tue, Aug 20, 2019 at 14:51:21 +0200, Pavel Hrdina wrote: > > *** BLURB HERE *** > > You too? Just a mistake :). > > > Pavel Hrdina (2): > > vircgroupv2: fix parsing multiple values in single file > > vircgroupv2: fix virCgr

Re: [libvirt] [PATCH 0/2] cgroups v2 fixes

On Tue, Aug 20, 2019 at 14:51:21 +0200, Pavel Hrdina wrote: > *** BLURB HERE *** You too? > Pavel Hrdina (2): > vircgroupv2: fix parsing multiple values in single file > vircgroupv2: fix virCgroupV2GetCpuCfsQuota for "max" value > > src/util/vircgroupv2.c | 20 +++- > 1 file

Re: [libvirt] [PATCH v1 07/11] virStoragePoolObjListAdd: Separate out definition assignment

On 8/19/19 6:08 PM, John Ferlan wrote: Was it intentional to swap the order? That's a good question. Honestly, I don't recall. I'll fix it in my local branch. It looks like we should set the new pool definition with the pool list locked so that virStoragePoolObjIsDuplicate() and virStorageP

Re: [libvirt] [PATCH v4 8/8] qemu_driver: hook up query-cpu-model-comparison

On Wed, Jul 17, 2019 at 10:03:29 -0400, Collin Walling wrote: > This command is hooked into the virsh hypervisor-cpu-compare command. > As such, the CPU model XML provided to the command will be compared > to the hypervisor CPU contained in the QEMU capabilities file for the > appropriate QEMU bina

[libvirt] [PATCH 12/12] news: Document KVM assignment removal

Signed-off-by: Michal Privoznik --- docs/news.xml | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index d63fca3b48..6137ebd943 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -51,6 +51,19 @@ + + + +

[libvirt] [PATCH 06/12] virpci: Drop 'pci-stub' driver

Now that no one uses KVM style of PCI assignment we can safely remove 'pci-stub' backend. Signed-off-by: Michal Privoznik --- src/util/virpci.c | 11 --- src/util/virpci.h | 1 - 2 files changed, 12 deletions(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index 4c7c26f981..9c9ff

[libvirt] [PATCH 10/12] virpcimock: Don't create new_id or remove_id files

Now that PCI attach/detach happens solely via driver_override these two files are no longer needed. Signed-off-by: Michal Privoznik --- tests/virpcimock.c | 112 - 1 file changed, 112 deletions(-) diff --git a/tests/virpcimock.c b/tests/virpcimock.c i

[libvirt] [PATCH 08/12] virpci: Drop newid style of PCI device detach

As stated in 84f9358b18346 all kernels that we are interested in have 'drivers_override'. Drop the other, older style of overriding PCI device driver - newid. Signed-off-by: Michal Privoznik --- src/util/virpci.c | 284 +- 1 file changed, 2 insertions(

[libvirt] [PATCH 04/12] qemu: Drop unused qemuOpenPCIConfig()

After previous commits, the function is not used anymore. Remove it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 22 -- src/qemu/qemu_command.h | 2 -- 2 files changed, 24 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f7

[libvirt] [PATCH 09/12] virpcimock: Don't create "pci-stub" driver

Now that nothing supports "pci-stub" driver (aka KVM style of PCI device assignment) there is no need for virpcimock to create it. Signed-off-by: Michal Privoznik --- tests/virpcimock.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/virpcimock.c b/tests/virpcimock.c index c0dcd377d5..b

[libvirt] [PATCH 11/12] virpcimock: Drop @driverActions enum

This enum was introduced to model how RHEL-7 kernel behaves - for some reason going with the old way (via new_id + bind) fails but using driver_override succeeds. Well, we don't need to care about that anymore since we don't create new_id file. Signed-off-by: Michal Privoznik --- tests/virpcimoc

[libvirt] [PATCH 07/12] virpci: Remove unused virPCIDeviceWaitForCleanup

This function is no longer used after previous commit. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 - src/util/virpci.c| 108 --- src/util/virpci.h| 1 - 3 files changed, 110 deletions(-) diff --git a/src/libvirt_priva

[libvirt] [PATCH 02/12] tests: Remove 'kvm' PCI backend from domaincapstest

The KVM assignment was removed in qemu driver in previous commit. Remove it from domaincapstest too which is hard coding it. Signed-off-by: Michal Privoznik --- tests/domaincapsschemadata/qemu_1.7.0.x86_64.xml| 1 - tests/domaincapsschemadata/qemu_2.12.0-virt.aarch64.xml | 1 - tests/dom

[libvirt] [PATCH 01/12] qemu: Drop KVM assignment

KVM style of PCI devices assignment was dropped in kernel in favor of vfio pci (see kernel commit v4.12-rc1~68^2~65). Since vfio is around for quite some time now and is far superior discourage people in using KVM style. Ideally, I'd make QEMU_CAPS_VFIO_PCI implicitly assumed but turns out qemu-3.

[libvirt] [PATCH 05/12] virhostdev: Disable legacy kvm assignment

The KVM assignment is going to be removed shortly. Don't let the hostdev module configure it. Signed-off-by: Michal Privoznik --- src/util/virhostdev.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index e3f48a9a2e.

[libvirt] [PATCH 00/12] Drop KVM assignment

The KVM style of PCI assignment is not used, and it hasn't been for a while. Any attempt to start a domain with it would result in error as kernel dropped its support in 4.12.0 (after being deprecated for 1.5 years). Michal Prívozník (12): qemu: Drop KVM assignment tests: Remove 'kvm' PCI back

[libvirt] [PATCH 03/12] virhostdev: Unify virDomainHostdevDef to virPCIDevice translation

There are two places where we need to create virPCIDevice from given virDomainHostdevDef. In both places the code is duplicated. Move them into a single function and call it from those two places. Signed-off-by: Michal Privoznik --- src/util/virhostdev.c | 93 +---

Re: [libvirt] [PATCH v4 7/8] cpu_conf: xml to cpu definition parse helper

On Wed, Jul 17, 2019 at 10:03:28 -0400, Collin Walling wrote: > Implement an XML to virCPUDefPtr helper that handles > the ctxt prerequisite for virCPUDefParseXML. > > This does not alter any functionality. > > Signed-off-by: Collin Walling > Reviewed-by: Bjoern Walk > Reviewed-by: Daniel Henri

Re: [libvirt] [PATCH v4 6/8] qemu_capabilities: introduce QEMU_CAPS_QUERY_CPU_MODEL_COMPARISON

On Wed, Jul 17, 2019 at 10:03:27 -0400, Collin Walling wrote: > This capability enables CPU model comparison between two CPU > definitions via QMP. > > Signed-off-by: Collin Walling > Reviewed-by: Daniel Henrique Barboza > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qem

Re: [libvirt] [ocaml PATCH 3/3] Fix shebang in perl scripts

On Tue, Aug 20, 2019 at 03:44:56PM +0200, Pino Toscano wrote: > Instead of hardcoding the location of perl (assuming it is installed in > /usr), use /usr/bin/env to run it, and thus picking it from $PATH. > This makes it possible to run these scripts also on installations with > perl in a different

Re: [libvirt] [PATCH v4 5/8] qemu_monitor: implement query-cpu-model-comparison

On Wed, Jul 17, 2019 at 10:03:26 -0400, Collin Walling wrote: > Interfaces with QEMU to compare CPU models. The command takes two > CPU models, A and B, that are given a model name and an optional list > of CPU features. Through the query-cpu-model-comparison command issued > via QMP, a result is p

Re: [libvirt] [PATCH v4 0/8] CPU Model Baseline and Comparison for s390x

First, let me apologize for such a late review. I'll try my best to review your series earlier next time. On Wed, Jul 17, 2019 at 10:03:21 -0400, Collin Walling wrote: > When baselining CPU models and the user appends the --features argument > to the command, s390x will only report back features

Re: [libvirt] [PATCH v4 4/8] qemu_driver: hook up query-cpu-model-baseline

On Wed, Jul 17, 2019 at 10:03:25 -0400, Collin Walling wrote: > This command is hooked into the virsh hypervisor-cpu-baseline command. > As such, the CPU models provided in the XML sent to the command will be > baselined with the CPU contained in the QEMU capabilities file for the > appropriate QEM

Re: [libvirt] [PATCH v4 3/8] qemu_capabilities: introduce QEMU_CAPS_QUERY_CPU_MODEL_BASELINE

On Wed, Jul 17, 2019 at 10:03:24 -0400, Collin Walling wrote: > This capability enables CPU model baselining between two CPU > definitions via QMP. > > Signed-off-by: Collin Walling > Reviewed-by: Daniel Henrique Barboza > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qe

Re: [libvirt] [PATCH v4 2/8] qemu_monitor: implement query-cpu-model-baseline

On Wed, Jul 17, 2019 at 10:03:23 -0400, Collin Walling wrote: > Interfaces with QEMU to baseline CPU models. The command takes two > CPU models, A and B, that are given a model name and an optional list > of CPU features. Through the query-cpu-model-baseline command issued > via QMP, a result is pr

Re: [libvirt] [PATCH v4 1/8] qemu_monitor: helper functions for CPU models

On Wed, Jul 17, 2019 at 10:03:22 -0400, Collin Walling wrote: > Refactor some code in qemuMonitorJSONGetCPUModelExpansion to be > later used for the comparison and baseline functions. You're mixing refactoring with adding new functionality. Splitting such changes into separate patches is better. M

Re: [libvirt] 5.6.0 regression: "Some activation file descriptors are unclaimed"

On Mon, Aug 19, 2019 at 12:35:15PM +, Allen, John wrote: > On Mon, Aug 19, 2019 at 01:30:06PM +0100, Daniel P. Berrangé wrote: > > On Mon, Aug 19, 2019 at 12:15:48PM +, Allen, John wrote: > > > On Mon, Aug 19, 2019 at 12:24:43PM +0100, Daniel P. Berrangé wrote: > > > > On Wed, Aug 14, 2019

Re: [libvirt] [PATCH 2/2] libxl: send lifecycle event on PMSuspend

On 8/13/19 6:06 PM, Jim Fehlig wrote: After a successful call to libxl_domain_suspend_only(), set domain state to VIR_DOMAIN_PMSUSPENDED and send lifecycle event. Signed-off-by: Jim Fehlig --- (pure code review, sadly I don't have access to a XEN env to test it) Reviewed-by: Daniel Henriq

Re: [libvirt] [PATCH 1/2] Revert "libxl: send lifecycle event on suspend"

On 8/13/19 6:06 PM, Jim Fehlig wrote: A libxl event with shutdown reason LIBXL_SHUTDOWN_REASON_SUSPEND is sent after a domain is successfully suspended, which could result from suspending the domain to file (virDomainSave), suspending it to socket (virDomainMigrate), or suspending it to memory

[libvirt] [ocaml PATCH 1/3] Synchronize Virterror with libvirt 5.6.0

Signed-off-by: Pino Toscano --- libvirt/libvirt.ml | 8 libvirt/libvirt.mli | 4 libvirt/libvirt_c_epilogue.c | 4 ++-- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/libvirt/libvirt.ml b/libvirt/libvirt.ml index d935bfc..03a5af8 100644 --- a/libv

[libvirt] [ocaml PATCH 0/3] Misc improvements

*** IMAGINE A BLURB HERE *** Pino Toscano (3): Synchronize Virterror with libvirt 5.6.0 Update config.guess and config.sub Fix shebang in perl scripts config.guess | 284 --- config.sub | 69 + libvirt/generator.pl

[libvirt] [ocaml PATCH 2/3] Update config.guess and config.sub

Signed-off-by: Pino Toscano --- config.guess | 284 +-- config.sub | 69 +++-- 2 files changed, 266 insertions(+), 87 deletions(-) diff --git a/config.guess b/config.guess index b33c9e8..97ad073 100755 --- a/config.guess +++ b/config.gue

[libvirt] [ocaml PATCH 3/3] Fix shebang in perl scripts

Instead of hardcoding the location of perl (assuming it is installed in /usr), use /usr/bin/env to run it, and thus picking it from $PATH. This makes it possible to run these scripts also on installations with perl in a different prefix than /usr. Also, given that we want enable warnings on script

Re: [libvirt] [PATCH v4 5/8] qemu_monitor: implement query-cpu-model-comparison

On Wed, Jul 24, 2019 at 18:18:27 +0200, Boris Fiuczynski wrote: > On 7/17/19 4:03 PM, Collin Walling wrote: > > Interfaces with QEMU to compare CPU models. The command takes two > > CPU models, A and B, that are given a model name and an optional list > > of CPU features. Through the query-cpu-mode

Re: [libvirt] [PATCH] conf: resctrl object is not properly handled

On 8/20/19 3:18 PM, Daniel Henrique Barboza wrote: On 8/20/19 7:06 AM, Wang Huaqiang wrote: resctrl object stored in def->resctrls is shared by cachetune and memorytune. The domain xml configuration is parsed firstly for cachetune then memorytune, and the resctrl object will not be created in

Re: [libvirt] [PATCH v2] tools: console: Relax stream EOF handling

On Mon, Aug 12, 2019 at 07:01:47PM -0300, Daniel Henrique Barboza wrote: > The comment I have here is that you're changing virConsoleShutdown > API for all callers, with this new boolean value 'needAbort', because of a > scenario (virStreamRecv being called before) that happens only on > virConsole

Re: [libvirt] [PATCH] conf: resctrl object is not properly handled

On 8/20/19 7:06 AM, Wang Huaqiang wrote: resctrl object stored in def->resctrls is shared by cachetune and memorytune. The domain xml configuration is parsed firstly for cachetune then memorytune, and the resctrl object will not be created in parsing settings for memorytune once it found sharin

[libvirt] [PATCH 14/19] qemuBuildShmemCommandLine: add chardev variable

That way devstr will only be used for the device string. Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index cc589a70b2..6557643dbe 100644 --- a/src/qemu/qemu_comm

[libvirt] [PATCH 08/19] qemu_command: use VIR_AUTOPTR for virJSONValue

Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 94a6ad546e..b5448a074f 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command

[libvirt] [PATCH 01/19] qemuBuildSerialChrDeviceStr: rename cmd to buf

We usually use 'cmd' for a virCommand(Ptr) variable. Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e3f4ef624b..98516d2627 100644 --- a/src/qemu/qemu_com

[libvirt] [PATCH 07/19] qemu_command: switch to VIR_AUTOCLEAN for virBuffer

Simplify the code by annotating all the temporary virBuffers with VIR_AUTOCLEAN. Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 194 ++-- 1 file changed, 67 insertions(+), 127 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c

[libvirt] [PATCH 19/19] qemuBuildCommandLine: remove unnecessary error label

Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 101 +++- 1 file changed, 49 insertions(+), 52 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 82e2a451c2..8cc8f82aab 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/q

[libvirt] [PATCH 13/19] qemuBuildSmpCommandLine: use virCommandAddArgBuffer directly

Instead of getting the string then passing it to virCommand. Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 67de0fc35e..cc589a70b2 100644 --- a/src/qemu/qemu_com

[libvirt] [PATCH 05/19] qemu: move TPM vaildation to qemuDomainDeviceDefValidateTPM

Simplify the command line formatter by complicating the validator. Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 15 +-- src/qemu/qemu_domain.c | 29 +++-- 2 files changed, 28 insertions(+), 16 deletions(-) diff --git a/src/qemu/qemu_command.c b/src

  1   2   >