Re: [libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed cons

2019-11-24 Thread Lance Liu
Previous patch can not pass build because of missing virNetServerClientCheckFilterExist stated in libvirt_remote.syms LanceLiu 于2019年11月25日周一 下午3:34写道： > --- > src/libvirt_remote.syms | 1 + > src/remote/remote_daemon_stream.c | 10 +- > src/rpc/virnetserverclient.c | 12

[libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed console

2019-11-24 Thread LanceLiu
--- src/libvirt_remote.syms | 1 + src/remote/remote_daemon_stream.c | 10 +- src/rpc/virnetserverclient.c | 12 src/rpc/virnetserverclient.h | 2 ++ 4 files changed, 24 insertions(+), 1 deletion(-) diff --git a/src/libvirt_remote.syms b/src/libvirt_remo

Re: [libvirt] [PATCH 2/2] qemu: cold-unplug of sound

2019-11-24 Thread Jidong Xia
On 11/14/19 5:52 AM, Cole Robinson wrote: On 10/15/19 2:41 AM, Jidong Xia wrote: With this patch users can cold unplug some sound devices. use "virsh detach-device vm sound.xml --config" command. I reviewed and pushed patch #1 Some comments below Signed-off-by: Jidong Xia --- src/conf/

Re: [libvirt] [PATCH 1/2] driver: Include source parameter to virDomainGetHostname

2019-11-24 Thread Julio Faracco
Thanks for your explanation, Peter! I will focus on LXC side then... Em dom., 24 de nov. de 2019 às 18:34, Peter Krempa escreveu: > > On Sun, Nov 24, 2019 at 21:24:07 +0100, Peter Krempa wrote: > > On Sun, Nov 24, 2019 at 17:19:48 -0300, jcfara...@gmail.com wrote: > > > From: Julio Faracco > >

Re: [libvirt] [PATCH 1/2] driver: Include source parameter to virDomainGetHostname

2019-11-24 Thread Peter Krempa
On Sun, Nov 24, 2019 at 21:24:07 +0100, Peter Krempa wrote: > On Sun, Nov 24, 2019 at 17:19:48 -0300, jcfara...@gmail.com wrote: > > From: Julio Faracco > > > > There is a lots of possibilities to retrieve hostname information from > > domain. Libvirt could use lease information from dnsmasq to g

Re: [libvirt] [PATCH 1/2] driver: Include source parameter to virDomainGetHostname

2019-11-24 Thread Peter Krempa
On Sun, Nov 24, 2019 at 17:19:48 -0300, jcfara...@gmail.com wrote: > From: Julio Faracco > > There is a lots of possibilities to retrieve hostname information from > domain. Libvirt could use lease information from dnsmasq to get current > hostname too. QEMU supports QEMU-agent but it can use lea

[libvirt] [PATCH 2/2] lxc: Introduce lxcDomainGetHostname

2019-11-24 Thread jcfaracco
From: Julio Faracco Using lease information from dnsmasq, libvirt can retrieve hostname information. LXC documentation says that hostname can be 'lxc.uts.name', but if an user runs 'hostnamectl' and change hostname during container execution, it will reflect the command output. This option could

[libvirt] [PATCH 1/2] driver: Include source parameter to virDomainGetHostname

2019-11-24 Thread jcfaracco
From: Julio Faracco There is a lots of possibilities to retrieve hostname information from domain. Libvirt could use lease information from dnsmasq to get current hostname too. QEMU supports QEMU-agent but it can use lease source. See 'domifaddr' as an example. This commit still adds lease optio

[libvirt] [PATCH 0/2] driver: change scope of virDomainGetHostname to

2019-11-24 Thread jcfaracco
From: Julio Faracco The first patch add a new parameter into virDomainGetHostname to specify which source an user would like to fetch hostname. QEMU supports agent and lease from dnsmasq. Drivers that are not supporting any of these, are included into default section of switch-case structure. So,

Re: [libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

2019-11-24 Thread Julio Faracco
Em sex., 22 de nov. de 2019 às 14:09, Erik Skultety escreveu: > > This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3. > > This patch results in the following error when trying to start > essentially any VM with default network: This kind of issue should be caught by test driver, shouldn

[libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed console

2019-11-24 Thread LanceLiu
--- src/remote/remote_daemon_stream.c | 10 +- src/rpc/virnetserverclient.c | 12 src/rpc/virnetserverclient.h | 2 ++ 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_daemon_stream.c b/src/remote/remote_daemon_stream.c index 82cadb6