Re: [libvirt] [PATCH] travis: explicitly require xcode 10.3 image for macOS

2019-11-27 Thread Pavel Hrdina
On Wed, Nov 27, 2019 at 03:38:48PM +, Daniel P. Berrangé wrote: > The default macOS image in travis is broken, throwing python > exceptions when trying to install glib. Explicitly ask for the > newer 10.3 image which works correctly. > > We now need to also point to the homebrew installed libx

Re: [libvirt] [PATCH 1/1] qemu: sync blockjob finishing in qemuDomainGetBlockJobInfo

2019-11-27 Thread Nikolay Shirokovskiy
On 27.11.2019 17:56, Peter Krempa wrote: > On Wed, Nov 27, 2019 at 17:19:18 +0300, Nikolay Shirokovskiy wrote: >> Due to race qemuDomainGetBlockJobInfo can return there is >> no block job for disk but later call to spawn new blockjob >> can fail because libvirt internally still not process block

Re: [libvirt] [PATCH] remote_daemon_stream: Hold an extra reference to stream in daemonStreamFilter

2019-11-27 Thread Lance Liu
Hi, Michal: I think the daemonFreeClientStream(NULL, stream); in your patch should line above virMutexUnlock(&stream->priv->lock), or else there is issue WAW. That is two threads may sub stream-> Lance Liu 于2019年11月26日周二 下午1:54写道: > Yeah, your patch is perfectly fine for stream freed pro

Re: [libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed cons

2019-11-27 Thread Lance Liu
Ok, I'll check it out. Look like your patch is still not in master branch。May you commit it? I'll check out it and test for force console case Michal Privoznik 于2019年11月25日周一 下午10:12写道: > On 11/25/19 11:53 AM, Lance Liu wrote: > > We first produce this bug in rhel7.4's libvir daemon。For easily

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Philippe Mathieu-Daudé
On 11/27/19 10:31 PM, Aleksandar Markovic wrote: On Wed, Nov 27, 2019 at 10:17 PM Philippe Mathieu-Daudé wrote: Hi Aleksandar, On 11/27/19 7:47 PM, Aleksandar Markovic wrote: On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé wrote: The r4k machine was introduced in 2005 (6af0bf9c7)

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Aleksandar Markovic
On Wed, Nov 27, 2019 at 10:17 PM Philippe Mathieu-Daudé wrote: > > Hi Aleksandar, > > On 11/27/19 7:47 PM, Aleksandar Markovic wrote: > > On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé > > wrote: > >> > >> The r4k machine was introduced in 2005 (6af0bf9c7) and its last > >> logical chang

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Aleksandar Markovic
On Wed, Nov 27, 2019 at 10:17 PM Philippe Mathieu-Daudé wrote: > > Hi Aleksandar, > > On 11/27/19 7:47 PM, Aleksandar Markovic wrote: > > On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé > > wrote: > >> > >> The r4k machine was introduced in 2005 (6af0bf9c7) and its last > >> logical chang

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 11/27/19 7:47 PM, Aleksandar Markovic wrote: On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé wrote: The r4k machine was introduced in 2005 (6af0bf9c7) and its last logical change was in 2005 (9542611a6). After we can count 164 maintenance commits (QEMU API changes) w

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Philippe Mathieu-Daudé
On 11/27/19 8:40 PM, Aleksandar Markovic wrote: On Mon, Nov 25, 2019 at 4:40 PM Daniel P. Berrangé wrote: On Mon, Nov 25, 2019 at 03:45:35PM +0100, Aleksandar Markovic wrote: On Monday, November 25, 2019, Philippe Mathieu-Daudé wrote: The r4k machine was introduced in 2005 (6af0bf9c7) and

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Aleksandar Markovic
On Mon, Nov 25, 2019 at 4:40 PM Daniel P. Berrangé wrote: > > On Mon, Nov 25, 2019 at 03:45:35PM +0100, Aleksandar Markovic wrote: > > On Monday, November 25, 2019, Philippe Mathieu-Daudé > > wrote: > > > > > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > > > logical change was

Re: [libvirt] [PATCH] tests: improve build time for qemuxml2argvtest

2019-11-27 Thread Ján Tomko
On Wed, Nov 27, 2019 at 04:22:42PM +, Daniel P. Berrangé wrote: On Fedora 31 with GCC 9.2.1, compiling qemuxml2argvtest takes about 36 seconds since commit 30c6d99209cd36bba8e14795622f658827698522 Author: Jiri Denemark Date: Thu Oct 24 17:51:42 2019 +0200 qemuxml2argvtest: Update h

Re: [libvirt] [PATCH 13/21] qemu: domain: Track backup job data in the status XML

2019-11-27 Thread Eric Blake
On 11/26/19 3:39 PM, Peter Krempa wrote: Store the data of a backup job along with the index counter for new backup jobs in the status XML. Currently we will support only one backup job and thus there's no necessity to add arrays of jobs. Is this commit message slightly stale given our change t

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Aleksandar Markovic
On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé wrote: > > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > logical change was in 2005 (9542611a6). After we can count 164 > maintenance commits (QEMU API changes) with the exception of > 1 fix in 2015 (memory leak, commit 3a

Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-27 Thread Aleksandar Markovic
On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé wrote: > > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > logical change was in 2005 (9542611a6). After we can count 164 > maintenance commits (QEMU API changes) with the exception of > 1 fix in 2015 (memory leak, commit 3a

Re: [libvirt] [PATCH 12/21] qemu: monitor: Add support for blockdev-backup via 'transaction'

2019-11-27 Thread Eric Blake
On 11/26/19 3:39 PM, Peter Krempa wrote: Implement the transaction actions generator for blockdev-backup. Signed-off-by: Peter Krempa --- +{ +const char *syncmodestr = qemuMonitorTransactionBackupSyncModeTypeToString(syncmode); + +return qemuMonitorJSONTransactionAdd(actions, +

Re: [libvirt] [PATCH 11/21] Add 'backup' block job type

2019-11-27 Thread Eric Blake
On 11/26/19 3:39 PM, Peter Krempa wrote: A backup job may consist of many backup sub-blockjobs. Add the new blockjob type and add all type converter strings. Signed-off-by: Peter Krempa --- +++ b/include/libvirt/libvirt-domain.h @@ -2446,6 +2446,9 @@ typedef enum { * exists as long as

Re: [libvirt] [PATCH 10/21] qemu: domain: Introduce QEMU_ASYNC_JOB_BACKUP async job type

2019-11-27 Thread Eric Blake
On 11/26/19 3:39 PM, Peter Krempa wrote: We will want to use the async job infrastructure along with all the APIs and event for the backup job so add the backup job as a new async job type. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c| 3 +++ src/qemu/qemu_domain.h| 1 +

Re: [libvirt] [PATCH 09/21] qemu: Add infrastructure for statistics of a backup job

2019-11-27 Thread Eric Blake
On 11/26/19 3:39 PM, Peter Krempa wrote: Introduce QEMU_DOMAIN_JOB_STATS_TYPE_BACKUP and the convertors and other plumbing to be able to report statistics for the backup job. Signed-off-by: Peter Krempa --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [libvirt] [PATCH 08/21] backup: Implement virsh support for backup

2019-11-27 Thread Eric Blake
On 11/26/19 3:39 PM, Peter Krempa wrote: From: Eric Blake Introduce virsh commands for performing backup jobs. Signed-off-by: Eric Blake Signed-off-by: Peter Krempa --- +=item B I [I] +[I + +Begin a new backup job. If I is omitted, this defaults to a full +backup using a push model to fil

Re: [libvirt] [PATCH 05/21] API: Add domain job operation for backups

2019-11-27 Thread Eric Blake
On 11/26/19 3:39 PM, Peter Krempa wrote: Introduce VIR_DOMAIN_JOB_OPERATION_BACKUP into virDomainJobOperation. Signed-off-by: Peter Krempa --- include/libvirt/libvirt-domain.h | 1 + tools/virsh-domain.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) Reviewed-by: E

Re: [libvirt] [PATCH 04/21] backup: Introduce virDomainBackup APIs

2019-11-27 Thread Eric Blake
On 11/26/19 3:39 PM, Peter Krempa wrote: From: Eric Blake Introduce a few new public APIs related to incremental backups. This builds on the previous notion of a checkpoint (without an existing checkpoint, the new API is a full backup, differing from virDomainBlockCopy in the point of time cho

Re: [libvirt] [PATCH 04/21] backup: Introduce virDomainBackup APIs

2019-11-27 Thread Daniel P . Berrangé
On Tue, Nov 26, 2019 at 10:39:50PM +0100, Peter Krempa wrote: > From: Eric Blake > > Introduce a few new public APIs related to incremental backups. This > builds on the previous notion of a checkpoint (without an existing > checkpoint, the new API is a full backup, differing from > virDomainBlo

Re: [libvirt] [PATCH 02/21] virsh: Implement VIR_DOMAIN_JOB_DISK_TEMP_(USED|TOTAL) in cmdDomjobinfo

2019-11-27 Thread Daniel P . Berrangé
On Tue, Nov 26, 2019 at 10:39:48PM +0100, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > tools/virsh-domain.c | 18 ++ > 1 file changed, 18 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/p

Re: [libvirt] [PATCH 01/21] API: Introduce field for reporting temporary disk space usage of a domain job

2019-11-27 Thread Daniel P . Berrangé
On Tue, Nov 26, 2019 at 10:39:47PM +0100, Peter Krempa wrote: > A pull mode backup job uses temporary disk images to hold the changed > parts of the disk while the client is copying the changes. Since usage > of the temporary space can be monitored but doesn't really fit any of > the existing stats

Re: [libvirt] [PATCH 03/21] backup: Document new XML for backups

2019-11-27 Thread Eric Blake
On 11/26/19 3:39 PM, Peter Krempa wrote: From: Eric Blake Prepare for new backup APIs by describing the XML that will represent a backup. The XML resembles snapshots and checkpoints in being able to select actions for a set of disks, but has other differences. It can support both push model (

Re: [libvirt] [PATCH] tests: improve build time for qemuxml2argvtest

2019-11-27 Thread Daniel Henrique Barboza
On 11/27/19 1:22 PM, Daniel P. Berrangé wrote: On Fedora 31 with GCC 9.2.1, compiling qemuxml2argvtest takes about 36 seconds since commit 30c6d99209cd36bba8e14795622f658827698522 Author: Jiri Denemark Date: Thu Oct 24 17:51:42 2019 +0200 qemuxml2argvtest: Update host arch fo

[libvirt] [PATCH] tests: improve build time for qemuxml2argvtest

2019-11-27 Thread Daniel P . Berrangé
On Fedora 31 with GCC 9.2.1, compiling qemuxml2argvtest takes about 36 seconds since commit 30c6d99209cd36bba8e14795622f658827698522 Author: Jiri Denemark Date: Thu Oct 24 17:51:42 2019 +0200 qemuxml2argvtest: Update host arch for DO_TEST*ARCH* tests The optimizer is hitting some pa

[libvirt] [PATCH] travis: explicitly require xcode 10.3 image for macOS

2019-11-27 Thread Daniel P . Berrangé
The default macOS image in travis is broken, throwing python exceptions when trying to install glib. Explicitly ask for the newer 10.3 image which works correctly. We now need to also point to the homebrew installed libxml2 rather than the OS distro provided one, since the OS distro one has a pkg-

Re: [libvirt] [PATCH 02/21] virsh: Implement VIR_DOMAIN_JOB_DISK_TEMP_(USED|TOTAL) in cmdDomjobinfo

2019-11-27 Thread Eric Blake
On 11/26/19 3:39 PM, Peter Krempa wrote: Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 325d748b49..ec9292a5c1 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-do

Re: [libvirt] [PATCH 01/21] API: Introduce field for reporting temporary disk space usage of a domain job

2019-11-27 Thread Eric Blake
On 11/27/19 9:28 AM, Eric Blake wrote: [adding some qemu folks for a side note] On 11/26/19 3:39 PM, Peter Krempa wrote: A pull mode backup job uses temporary disk images to hold the changed parts of the disk while the client is copying the changes. Since usage of the temporary space can be mon

Re: [libvirt] [PATCH 01/21] API: Introduce field for reporting temporary disk space usage of a domain job

2019-11-27 Thread Eric Blake
[adding some qemu folks for a side note] On 11/26/19 3:39 PM, Peter Krempa wrote: A pull mode backup job uses temporary disk images to hold the changed parts of the disk while the client is copying the changes. Since usage of the temporary space can be monitored but doesn't really fit any of the

Re: [libvirt] [PATCH 1/1] qemu: sync blockjob finishing in qemuDomainGetBlockJobInfo

2019-11-27 Thread Peter Krempa
On Wed, Nov 27, 2019 at 17:19:18 +0300, Nikolay Shirokovskiy wrote: > Due to race qemuDomainGetBlockJobInfo can return there is > no block job for disk but later call to spawn new blockjob > can fail because libvirt internally still not process blockjob > finishing. Thus let's wait for blockjob fin

[libvirt] [PATCH 1/1] qemu: sync blockjob finishing in qemuDomainGetBlockJobInfo

2019-11-27 Thread Nikolay Shirokovskiy
Due to race qemuDomainGetBlockJobInfo can return there is no block job for disk but later call to spawn new blockjob can fail because libvirt internally still not process blockjob finishing. Thus let's wait for blockjob finishing if we report there is no more blockjob. Signed-off-by: Nikolay Shiro

[libvirt] [PATCH for 5.10.0] docs: don't run xmllint when generating API HTML files

2019-11-27 Thread Daniel P . Berrangé
After generating the API HTML files we run xmllint in docs/html/*.html to validate the correctness. Since commit 0aa8536f14b08dfb5188d0bb3aba532680500d38 Author: Daniel P. Berrangé Date: Wed Nov 20 14:49:26 2019 + docs: generate API reference pages for admin, qemu & lxc libraries

Re: [libvirt] [PATCH for 5.10.0] news: Update for 5.10.0 release

2019-11-27 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 02:21:14PM +0100, Ján Tomko wrote: > On Wed, Nov 27, 2019 at 12:38:00PM +, Daniel P. Berrangé wrote: > > On Wed, Nov 27, 2019 at 01:34:12PM +0100, Michal Privoznik wrote: > > > On 11/27/19 1:19 PM, Peter Krempa wrote: > > > > On Wed, Nov 27, 2019 at 12:08:01 +, Danie

Re: [libvirt] [PATCH 03/21] backup: Document new XML for backups

2019-11-27 Thread Peter Krempa
On Tue, Nov 26, 2019 at 22:39:49 +0100, Peter Krempa wrote: > From: Eric Blake > > Prepare for new backup APIs by describing the XML that will represent > a backup. The XML resembles snapshots and checkpoints in being able > to select actions for a set of disks, but has other differences. It >

Re: [libvirt] [PATCH for 5.10.0] news: Update for 5.10.0 release

2019-11-27 Thread Ján Tomko
On Wed, Nov 27, 2019 at 12:38:00PM +, Daniel P. Berrangé wrote: On Wed, Nov 27, 2019 at 01:34:12PM +0100, Michal Privoznik wrote: On 11/27/19 1:19 PM, Peter Krempa wrote: > On Wed, Nov 27, 2019 at 12:08:01 +, Daniel Berrange wrote: > > On Wed, Nov 27, 2019 at 01:05:04PM +0100, Ján Tomko

Re: [libvirt] [PATCH for 5.10] Revert "qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull"

2019-11-27 Thread Ján Tomko
On Wed, Nov 27, 2019 at 01:52:23PM +0100, Peter Krempa wrote: This reverts commit 421c9550f5446729b513ee50f5c44e6f6969b5a2. Feel free to demote this from a sentence by removing the trailing period, to make it easier to select. qemuDomainBlockPullCommon calls virDomainObjEndAPI internally so

[libvirt] [PATCH for 5.10] Revert "qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull"

2019-11-27 Thread Peter Krempa
This reverts commit 421c9550f5446729b513ee50f5c44e6f6969b5a2. qemuDomainBlockPullCommon calls virDomainObjEndAPI internally so the original commit made us shed two references of @vm instead of one getting us into a premature free of @vm. This is not a straight revert as qemuDomainBlockPull was mo

Re: [libvirt] [PATCH for 5.10.0] news: Update for 5.10.0 release

2019-11-27 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 01:34:12PM +0100, Michal Privoznik wrote: > On 11/27/19 1:19 PM, Peter Krempa wrote: > > On Wed, Nov 27, 2019 at 12:08:01 +, Daniel Berrange wrote: > > > On Wed, Nov 27, 2019 at 01:05:04PM +0100, Ján Tomko wrote: > > > > On Wed, Nov 27, 2019 at 11:24:56AM +0100, Michal P

Re: [libvirt] [PATCH for 5.10.0] news: Update for 5.10.0 release

2019-11-27 Thread Michal Privoznik
On 11/27/19 1:19 PM, Peter Krempa wrote: On Wed, Nov 27, 2019 at 12:08:01 +, Daniel Berrange wrote: On Wed, Nov 27, 2019 at 01:05:04PM +0100, Ján Tomko wrote: On Wed, Nov 27, 2019 at 11:24:56AM +0100, Michal Privoznik wrote: Signed-off-by: Michal Privoznik --- docs/news.xml | 124

Re: [libvirt] [PATCH for 5.10.0] news: Update for 5.10.0 release

2019-11-27 Thread Peter Krempa
On Wed, Nov 27, 2019 at 12:08:01 +, Daniel Berrange wrote: > On Wed, Nov 27, 2019 at 01:05:04PM +0100, Ján Tomko wrote: > > On Wed, Nov 27, 2019 at 11:24:56AM +0100, Michal Privoznik wrote: > > > Signed-off-by: Michal Privoznik > > > --- > > > docs/news.xml | 124 ++

Re: [libvirt] [PATCH for 5.10.0] news: Update for 5.10.0 release

2019-11-27 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 01:05:04PM +0100, Ján Tomko wrote: > On Wed, Nov 27, 2019 at 11:24:56AM +0100, Michal Privoznik wrote: > > Signed-off-by: Michal Privoznik > > --- > > docs/news.xml | 124 ++ > > 1 file changed, 124 insertions(+) > > > > diff

Re: [libvirt] [PATCH for 5.10.0] news: Update for 5.10.0 release

2019-11-27 Thread Ján Tomko
On Wed, Nov 27, 2019 at 11:24:56AM +0100, Michal Privoznik wrote: Signed-off-by: Michal Privoznik --- docs/news.xml | 124 ++ 1 file changed, 124 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 72c0edb317..b6782df136 100644 --- a/doc

Re: [libvirt] configuraton error while configuring libvirt

2019-11-27 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 10:50:22AM +0530, Billa Surendra wrote: > HI all, > > I am trying to install libvirt-5.4.0 in fedora 31 host pc, but I am > > getting error like *configure: error: You must install the gnutls >= > > 3.2.0 pkg-config module to compile libvirt*. I have higher version of > >

[libvirt] configuraton error while configuring libvirt

2019-11-27 Thread Billa Surendra
HI all, I am trying to install libvirt-5.4.0 in fedora 31 host pc, but I am > getting error like *configure: error: You must install the gnutls >= > 3.2.0 pkg-config module to compile libvirt*. I have higher version of > gnutls avilable in my host pc already. Any one tell me how to install > libv

[libvirt] CLZERO support for AMD

2019-11-27 Thread Ani Sinha
Hi : I see a commit in qemu that adds support for CLZERO but in CPUIDs. : commit e900135dcfb676a4019dc206395e02db5d1de0d6 Author: Sebastian Andrzej Siewior Date: Wed Sep 25 23:49:48 2019 +0200 i386: Add CPUID bit for CLZERO and XSAVEERPTR The CPUID bits CLZERO and XSAVEERPTR are availble on AM

[libvirt] [PATCH for 5.10.0] news: Update for 5.10.0 release

2019-11-27 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- docs/news.xml | 124 ++ 1 file changed, 124 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 72c0edb317..b6782df136 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -81,8 +81,132 @@

Re: [libvirt] [Libvirt-announce] Entering freeze for libvirt 5.10.0

2019-11-27 Thread Daniel P . Berrangé
On Tue, Nov 26, 2019 at 10:41:29PM +0100, Daniel Veillard wrote: > As planned this is now tagged in git head and signed source tarball > and rpm are available at the usual place: > > https://libvirt.org/sources/ > > there is a few weirdness on CI, some apparently related to freebsd, > others

Re: [libvirt] [PATCH 1/4] replace use of gnulib setenv by g_setenv

2019-11-27 Thread Pavel Hrdina
On Tue, Nov 26, 2019 at 07:18:14PM -0500, Cole Robinson wrote: > On 11/14/19 5:42 AM, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > src/security/virt-aa-helper.c | 4 ++-- > > src/vbox/vbox_XPCOMCGlue.c | 2 +- > > tests/libxlxml2domconfigtest.c