Re: [libvirt] Question about parallel migration connections

On 1/10/20 12:16 AM, Peter Krempa wrote: > On Thu, Jan 09, 2020 at 23:04:19 +, Jim Fehlig wrote: >> Are they supported with tunneled migration? The feature seems limited to >> native >> migration, in which case I can send a patch prohibiting parallel migration >> connections with the tunnel. >

[libvirt] [PATCH v2 3/8] qemu: Don't store disk alias in qemuAgentDiskInfo

The qemuAgentDiskInfo structure is filled with information received from the agent command response, except for the 'alias' field, which is retrieved from the vm definition. Limit this structure only to data that was received from the agent message. This is another intermediate step in moving the

[libvirt] [PATCH v2 5/8] qemu: remove qemuDomainObjBegin/EndJobWithAgent()

This function potentially grabs both a monitor job and an agent job at the same time. This is problematic because it means that a malicious (or just buggy) guest agent can cause a denial of service on the host. The presence of this function makes it easy to do the wrong thing and hold both jobs at

[libvirt] [PATCH v2 6/8] qemu: use glib alloc in qemuAgentGetFSInfoFillDisks()

Signed-off-by: Jonathon Jongsma --- src/qemu/qemu_agent.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 47bfef7141..7186b1da64 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1894,10 +1894,8 @@ q

[libvirt] [PATCH v2 4/8] qemu: don't access vmdef within qemu_agent.c

In order to avoid holding an agent job and a normal job at the same time, we want to avoid accessing the domain's definition while holding the agent job. To achieve this, qemuAgentGetFSInfo() only returns the raw information from the agent query to the caller. The caller can then release the agent

[libvirt] [PATCH v2 8/8] Use glib alloc API for virDomainFSInfo

Signed-off-by: Jonathon Jongsma --- src/libvirt-domain.c| 12 ++-- src/qemu/qemu_driver.c | 18 +- src/remote/remote_daemon_dispatch.c | 2 +- 3 files changed, 12 insertions(+), 20 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-

[libvirt] [PATCH v2 1/8] qemu: rename qemuAgentGetFSInfoInternalDisk()

The function name doesn't give a good idea of what the function does. Rename to qemuAgentGetFSInfoFillDisks() to make it more obvious than it is filling in the disk information in the fsinfo struct. Signed-off-by: Jonathon Jongsma --- src/qemu/qemu_agent.c | 8 1 file changed, 4 inserti

[libvirt] [PATCH v2 2/8] qemu: store complete agent filesystem information

In an effort to avoid holding both an agent and normal job at the same time, we shouldn't access the vm definition from within qemu_agent.c (i.e. while the agent job is being held). In preparation, we need to store the full filesystem disk information in qemuAgentDiskInfo. In a following commit, w

[libvirt] [PATCH v2 0/8] Don't hold both monitor and agent jobs at the same time

We have to assume that the guest agent may be malicious, so we don't want to allow any agent queries to block any other libvirt API. By holding a monitor job and an agent job while we're querying the agent, any other threads will be blocked from using the monitor while the agent is unresponsive. Be

[libvirt] [PATCH v2 7/8] qemu: use glib allocation apis for qemuAgentFSInfo

Switch from old VIR_ allocation APIs to glib equivalents. Signed-off-by: Jonathon Jongsma --- src/qemu/qemu_agent.c | 26 -- src/qemu/qemu_driver.c | 2 +- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c ind

[libvirt] [PATCH] nodedev: use autofree for more local variables

Simplify function logic by using g_autofree to free local variables so that we can remove some goto statements that are used for cleanup. Introduce a g_autoptr cleanup function for virNodeDeviceDef. Signed-off-by: Jonathon Jongsma --- src/conf/node_device_conf.h | 2 ++ src/node_devic

Re: [libvirt] [rust PATCH v2 3/5] libvirt-rust: stream: automated lint

On 2020-01-10 04:48, Sahid Orentino Ferdjaoui wrote: > On Tue, Dec 24, 2019 at 12:12:53AM -0700, Zixing Liu wrote: >> * used rustfmt to clean up the code >> >> Signed-off-by: Zixing Liu >> --- >> src/stream.rs | 97 +-- >> 1 file changed, 56 insert

Re: [libvirt] [rust PATCH v2 1/5] libvirt-rust: stream: add more functions in stream

On 2020-01-10 04:36, Sahid Orentino Ferdjaoui wrote: > On Tue, Dec 24, 2019 at 12:12:51AM -0700, Zixing Liu wrote: >> * added new functions: virStreamNew virStreamEventUpdateCallback >> virStreamEventRemoveCallback >> * added new constants: VIR_STREAM_NONBLOCK >> * added new types/aliases: Strea

Re: [libvirt] Question / Bug: "IO mon_iothread" not affected by "

On Mon, Dec 30, 2019 at 12:26:40AM +0200, gima+libvir-l...@iki.fi wrote: > # Question / Bug > > For "1", QEMU creates two threads by name of > "IO mon_iothread"and > "IO iothread1" That isn't correct. The "IO mon_iothread" always exists with new QEMU, regardless of whether any element is presen

[libvirt] [PATCH 4/4] conf: Always format storage source auth and encryption under for backing files

Historically there are two places where we format authentication and encryption for a disk. The logich which formats it for backing files was flawed though and didn't format it at all. This worked if the image became a backing file through the means of a snapshot but not directly. Force formatting

[libvirt] [PATCH 3/4] tests: qemuxml2xml: Enable luks-disks-source-qcow2 case

The test data was used only in xml->argv testing but it will have some interresting fallout soon. Signed-off-by: Peter Krempa --- .../luks-disks-source-qcow2.x86_64-latest.xml | 102 ++ tests/qemuxml2xmltest.c | 1 + 2 files changed, 103 insertions(+) cre

[libvirt] [PATCH 2/4] tests: qemuxml2argv: Run luks-disks-source-qcow2 case with latest caps

Try also the modern incarnation of the test. Signed-off-by: Peter Krempa --- ...luks-disks-source-qcow2.x86_64-latest.args | 110 ++ tests/qemuxml2argvtest.c | 1 + 2 files changed, 111 insertions(+) create mode 100644 tests/qemuxml2argvdata/luks-disks-so

[libvirt] [PATCH 1/4] tests: qemuxml2argv: Add disk image with encrypted backing file

Add another disk to luks-disks-source-qcow2 case to cover a backing chain with encrypted members. Signed-off-by: Peter Krempa --- .../luks-disks-source-qcow2.args | 8 .../luks-disks-source-qcow2.xml| 18 ++ 2 files changed, 26 insertions(+

[libvirt] [PATCH 0/4] Fix formatting of encrypted disk secret info (for 6.0.0)

See the last patch for explanation. Peter Krempa (4): tests: qemuxml2argv: Add disk image with encrypted backing file tests: qemuxml2argv: Run luks-disks-source-qcow2 case with latest caps tests: qemuxml2xml: Enable luks-disks-source-qcow2 case conf: Always format storage source auth and e

Re: [libvirt] [PATCH v2 12/12] autogen.sh: remove --no-git and --gnulib-srcdir options

On Thu, Jan 09, 2020 at 03:53:22PM +0100, Pavel Hrdina wrote: > Now that we have bootstrap output stored in git there is no need for > these options. > > Signed-off-by: Pavel Hrdina > --- > autogen.sh | 29 +++-- > docs/compiling.html.in | 13 - >

Re: [libvirt] [PATCH v2 11/12] autogen.sh: remove --dry-run option

On Thu, Jan 09, 2020 at 03:53:21PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > autogen.sh | 53 +++-- > 1 file changed, 15 insertions(+), 38 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange

Re: [libvirt] [PATCH v2 09/12] autogen.sh: fix autoreconf step

On Thu, Jan 09, 2020 at 03:53:19PM +0100, Pavel Hrdina wrote: > Running bootstrap and autoreconf from autogen.sh produced different > files in build-aux directory. The reason is that gnulib usually have > newer version of these files and overwrites them after the autoreconf > step. > > In order t

Re: [libvirt] [PATCH v2 08/12] syntax-check: remove deleted daemon directory from space_indent_check

On Thu, Jan 09, 2020 at 03:53:18PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > build-aux/syntax-check.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/

Re: [libvirt] [PATCH v2 07/12] bootstrap.conf: stop creating AUTHORS file

On Thu, Jan 09, 2020 at 03:53:17PM +0100, Pavel Hrdina wrote: > The existence of AUTHORS file is required for GNU projects but since > commit <8bfb36db40f38e92823b657b5a342652064b5adc> we do not require > these files to exist. > > Signed-off-by: Pavel Hrdina > --- > autogen.sh | 2 +- > boot

Re: [libvirt] [PATCH v2 06/12] bootstrap.conf: disable VC ignore files

On Thu, Jan 09, 2020 at 03:53:16PM +0100, Pavel Hrdina wrote: > We already ignore most of these files and the .gitignore files as well. > > Signed-off-by: Pavel Hrdina > --- > .gitignore | 5 - > bootstrap.conf | 3 +++ > 2 files changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Dani

Re: [libvirt] [PATCH v2 05/12] bootstrap.conf: declare bootstrap sync in configuration file

On Thu, Jan 09, 2020 at 03:53:15PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > autogen.sh | 2 +- > bootstrap.conf | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https:/

Re: [libvirt] [PATCH v2 04/12] bootstrap.conf: always copy files

On Thu, Jan 09, 2020 at 03:53:14PM +0100, Pavel Hrdina wrote: > Preparation for having bootstrap result in git. > > Signed-off-by: Pavel Hrdina > --- > bootstrap.conf | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://b

Re: [libvirt] [jenkins-ci PATCH] lcitool: Mark Fedora kernel packages as user-installed

On Fri, Jan 10, 2020 at 05:03:35PM +0100, Andrea Bolognani wrote: > >From time to time we hit > > https://bugzilla.redhat.com/show_bug.cgi?id=1741381 > > which result in 'dnf autoremove' failing. The suggested workaround > is to manually mark kernel packages as user-installed, so let's do > tha

[libvirt] [jenkins-ci PATCH] lcitool: Mark Fedora kernel packages as user-installed

>From time to time we hit https://bugzilla.redhat.com/show_bug.cgi?id=1741381 which result in 'dnf autoremove' failing. The suggested workaround is to manually mark kernel packages as user-installed, so let's do that every single time just in case. Signed-off-by: Andrea Bolognani --- guests/

[libvirt] [jenkins-ci PATCH] mappings: Refactor python3-devel mapping

All RPM-based distributions except for CentOS 7 use the same name. Signed-off-by: Andrea Bolognani --- guests/vars/mappings.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 14bf2ff..9833856 100644 --- a/guests/var

[libvirt] [PATCH 3/4] virsh: secret: Allow setting secrets from file

The necessity to specify the secret value as command argument is insecure. Allow reading the secret from a file. Signed-off-by: Peter Krempa --- docs/manpages/virsh.rst | 5 +++-- tools/virsh-secret.c| 30 +++--- 2 files changed, 30 insertions(+), 5 deletions(-) dif

[libvirt] [PATCH 1/4] virsh: secret: Add 'secret-passwd' command

Add a command which allows to read a secret value from terminal. 'secret-passwd' is chosen as a name as the password has limitations as passwords do have (printable, terminated by newline which is not contained in the value). This makes it way more user-friendly to use the secret driver with virsh

[libvirt] [PATCH 0/4] virsh: secret: Improve handling of secret value

The currently existing virsh APIs for secrets are awful for human use and don't promote security. Peter Krempa (4): virsh: secret: Add 'secret-passwd' command virsh: secret: Allow getting secret's value without base64 encoding virsh: secret: Allow setting secrets from file docs: secret: Un

[libvirt] [PATCH 4/4] docs: secret: Unify and sanitize examples on how to set secret value

Discourage passing secrets as commandline arguments. Signed-off-by: Peter Krempa --- docs/formatsecret.html.in | 86 +-- 1 file changed, 55 insertions(+), 31 deletions(-) diff --git a/docs/formatsecret.html.in b/docs/formatsecret.html.in index 8f5383cf64..61a

[libvirt] [PATCH 06/12] src: convert code to use new socket portability wrappers

Convert to use socket wrappers. Aside from the header file include change, this requires changing close -> closesocket since our portability isn't trying to replace the close function. Signed-off-by: Daniel P. Berrangé --- src/rpc/virnetsocket.c | 34 +++--- src/

[libvirt] [PATCH 2/4] virsh: secret: Allow getting secret's value without base64 encoding

Users might want to get the raw value instead of dealing with base64 encoding. This might be useful for redirection to file and also for simple human-readable secrets. Signed-off-by: Peter Krempa --- docs/manpages/virsh.rst | 6 +- tools/virsh-secret.c| 16 ++-- 2 files chan

[libvirt] [PATCH 11/12] src: replace gmtime_r/localtime_r/strftime with GDateTime

gmtime_r/localtime_r are mostly used in combination with strftime to format timestamps in libvirt. This can all be replaced with GDateTime resulting in simpler code that is also more portable. There is some boundary condition problem in parsing POSIX timezone offsets in GLib which tickles our test

[libvirt] [PATCH 12/12] bootstrap: remove 25 more gnulib modules

* send, recv: we use write & read for sockets so don't need these portability wrappers * ioctl, fcntl, fcntl-h: any usage of these is conditionally compiled and excludes Windows * ttyname_r: this exists in all supported platforms that we require now * environ: the tests explicitly decl

[libvirt] [PATCH 07/12] util: pull gnulib physmem impl into local code

We don't need all the platforms gnulib deals with, so this is a cut down version of GNULIB's physmem.c code. This also allows us to integrate libvirt's error reporting functions closer to the error cause. Signed-off-by: Daniel P. Berrangé --- build-aux/syntax-check.mk | 2 +- src/conf/capabili

[libvirt] [PATCH 05/12] util: introduce compat wrappers for Winsock2

Windows sockets take a SOCKET HANDLE object instead of a file descriptor. Wrap them in the same way that gnulib does so that they use C runtime file descriptors. While we could in theory use GSocket, it is hard to get the exact same semantics libvirt has for its current socket usage. Wrapping the

[libvirt] [PATCH 10/12] src: add check for termios.h and conditionally include it

The GNULIB termios module ensures termios.h exists, but this is not neccessary and libvirt doesn't use any of its functionality on platforms where it is missing. It is thus sufficient to conditonallyinclude termios.h Signed-off-by: Daniel P. Berrangé --- configure.ac | 1 + src/util/vi

[libvirt] [PATCH 08/12] util: replace atomic ops impls with g_atomic_int*

Libvirt's original atomic ops impls were largely copied from GLib's code at the time. The only API difference was that libvirt's virAtomicIntInc() would return a value, but g_atomic_int_inc was void. We thus use g_atomic_int_add(v, 1) instead, though this means virAtomicIntInc() now returns the ori

[libvirt] [PATCH 01/12] src: import gnulib's intprops.h header

This copies intprops.h to virintprops.h. A couple of conditionals were cut out since we don't need to support OpenVMS or ancient GCC 2.x Signed-off-by: Daniel P. Berrangé --- build-aux/syntax-check.mk | 7 +- src/hyperv/hyperv_driver.c| 2 +- src/libvirt-domai

[libvirt] [PATCH 02/12] tests: always declare environ

Some UNIX platforms don't declare 'environ' in their header files. We can unconditionally declare it ourselves to avoid this problem. There is no need to do this in the aa-helper code since that is Linux only code. Signed-off-by: Daniel P. Berrangé --- tests/commandhelper.c | 3 +++ tests/comma

[libvirt] [PATCH 03/12] build: validate headers against local gnulib not git repo

Some syntax check rules validate usage of headers provided by gnulib. We want to validate these only against the gnulib modules we've chosen to use, not all modules, since we're trying to eliminate them. Signed-off-by: Daniel P. Berrangé --- build-aux/syntax-check.mk | 3 --- 1 file changed, 3 d

[libvirt] [PATCH 09/12] src: replace verify(expr) with G_STATIC_ASSERT(expr)

G_STATIC_ASSERT() is a drop-in functional equivalent of the GNULIB verify() macro. Signed-off-by: Daniel P. Berrangé --- build-aux/syntax-check.mk | 6 -- src/conf/snapshot_conf.h | 2 +- src/conf/virdomaincheckpointobjlist.c | 8 src/esx/esx_network_driv

[libvirt] [PATCH 00/12] even less gnulib: 25 more modules purged, leaving 25 to go

A continued effort to purge gnulib from the libvirt build system. The bulk of the win comes from implementing our own Winsock portability wrappers. The use of GSocket turned out to have many complications, making it hard for us to achieve the same level of functionality as we currently have. Thus w

[libvirt] [PATCH 04/12] util: add detection of openpty function

All UNIX platforms we care about have openpty() in the libutil library. Use of pty.h must also be made conditional, excluding Win32. Signed-off-by: Daniel P. Berrangé --- configure.ac | 4 src/util/Makefile.inc.am | 1 + src/util/virfile.c | 14 +- 3 files ch

Re: [libvirt] [jenkins-ci PATCH 1/2] guests: Add projects to OpenSUSE 15.1

On Wed, Jan 08, 2020 at 02:14:17PM +, Daniel P. Berrangé wrote: > On Wed, Jan 08, 2020 at 03:08:44PM +0100, Fabiano Fidêncio wrote: > > The following projects were not added: > > - libvirt-perl: > > - missing packages: > > - perl-TimeHiRes; > > - perl-generators; > > perl-generators

[libvirt] [jenkins-ci PATCH] mappings: Reorder some entries

We've always strived to keep entries sorted in a way that reflects the order in which they're actually processed, with entries that have the same priority being sorted alphabetically, however a few mistakes have managed to sneak into the file over time. Fix them. Signed-off-by: Andrea Bolognani -

[libvirt] Call for Google Summer of Code 2020 project ideas

Dear list, GSoC 2020 has been announced and I plan to apply again [1]. Please, update the list of ideas [2] for students to work on. If you have an idea but don't feel like mentoring, that is okay too, just put it onto the wiki and I will find a mentor myself. Thanks, Michal 1: https://sum

Re: [libvirt] Question about parallel migration connections

On Fri, Jan 10, 2020 at 02:22:00PM +, Jim Fehlig wrote: > On 1/10/20 2:26 AM, Daniel P. Berrangé wrote: > > On Thu, Jan 09, 2020 at 11:04:19PM +, Jim Fehlig wrote: > >> Are they supported with tunneled migration? The feature seems limited to > >> native > >> migration, in which case I can

Re: [libvirt] Question about parallel migration connections

On 1/10/20 2:26 AM, Daniel P. Berrangé wrote: > On Thu, Jan 09, 2020 at 11:04:19PM +, Jim Fehlig wrote: >> Are they supported with tunneled migration? The feature seems limited to >> native >> migration, in which case I can send a patch prohibiting parallel migration >> connections with the tu

Re: [libvirt] [PATCH v4 3/5] qemu: Implement virDomainGetHostnameFlags

On Fri, Jan 10, 2020 at 03:19:16PM +0100, Michal Privoznik wrote: > On 1/10/20 2:05 PM, Erik Skultety wrote: > > On Thu, Jan 09, 2020 at 01:45:58PM +0100, Michal Privoznik wrote: > > > From: Julio Faracco > > > > > > We have to keep the default - querying the agent if no flag is > > > set. > > > >

Re: [libvirt] [PATCH v4 3/5] qemu: Implement virDomainGetHostnameFlags

On 1/10/20 2:05 PM, Erik Skultety wrote: On Thu, Jan 09, 2020 at 01:45:58PM +0100, Michal Privoznik wrote: From: Julio Faracco We have to keep the default - querying the agent if no flag is set. Signed-off-by: Michal Privoznik Signed-off-by: Julio Faracco --- ... + +static int +qemuDomai

Re: [libvirt] FYI: intention to remove mail subject prefix & footer text

On Fri, Jan 10, 2020 at 12:26:07PM +, Daniel P. Berrangé wrote: > The solution is to disable any feature in mailman which modifies > parts of the mail validated by the DKIM signature. This means removing > the subject prefix and the mail body header. For the libvir-list we can mitigate the eff

Re: [libvirt] [PATCH v4 5/5] virsh: Expose virDomainGetHostnameFlags

On Thu, Jan 09, 2020 at 01:46:00PM +0100, Michal Privoznik wrote: > From: Julio Faracco > > Our virsh already has 'domhostname' command. Add '--source' > argument to it so that users can chose between 'lease' and > 'agent' sources. Also, implement completer for the argument. > > Signed-off-by: Jul

Re: [libvirt] [PATCH v4 0/5] Introduce flags to virDomainGetHostname()

On Thu, Jan 09, 2020 at 01:45:55PM +0100, Michal Privoznik wrote: > v4 of: > > https://www.redhat.com/archives/libvir-list/2019-December/msg01453.html > > diff to v3: > - I've split Julio's one patch into 4 smaller ones, > - I've fixed issues I've raised in v3, like new error code (patch 1/5 is >

Re: [libvirt] [PATCH v4 4/5] lxc: Implement virDomainGetHostnameFlags

On Thu, Jan 09, 2020 at 01:45:59PM +0100, Michal Privoznik wrote: > From: Julio Faracco > > Since there is no guest agent in LXC world (yet), we can > implement _LEASE flag only. > > Signed-off-by: Michal Privoznik > + > +for (j = 0; j < n_leases; j++) { > +virNetworkDHCPLea

Re: [libvirt] [PATCH v4 3/5] qemu: Implement virDomainGetHostnameFlags

On Thu, Jan 09, 2020 at 01:45:58PM +0100, Michal Privoznik wrote: > From: Julio Faracco > > We have to keep the default - querying the agent if no flag is > set. > > Signed-off-by: Michal Privoznik > Signed-off-by: Julio Faracco > --- ... > + > +static int > +qemuDomainGetHostnameLease(virQEMUD

Re: [libvirt] [PATCH v4 2/5] Introduce source flags to virDomainGetHostname()

On Thu, Jan 09, 2020 at 01:45:57PM +0100, Michal Privoznik wrote: > From: Julio Faracco > > There is a lots of possibilities to retrieve hostname information > from domain. Libvirt could use lease information from dnsmasq to > get current hostname too. QEMU supports QEMU-agent but it can use > lea

Re: [libvirt] [PATCH v2 0/5] introduce support for CPU dies in host/guest topology

On Fri, Jan 10, 2020 at 01:36:54PM +0100, Jiri Denemark wrote: > On Fri, Jan 10, 2020 at 11:20:58 +, Daniel P. Berrangé wrote: > > Latest generation CPUs (CascadeLake-AP) support a new topology level > > known as a 'die', sitting between a socket and a core. > > > > QEMU supports this with -sm

[libvirt] [dockerfiles PATCH] Refresh after dropping librbd from Debian sid on mipsel

The corresponding libvirt-jenkins-ci commit is d08ad842e12d. Signed-off-by: Andrea Bolognani --- Pushed under the Dockerfile refresh rule. buildenv-libvirt-debian-sid-cross-mipsel.zip | Bin 1016 -> 1013 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/buildenv-libvirt-debian

Re: [libvirt] [PATCH] Don't check if the path exists for LVM

On 1/6/20 12:51 AM, ebenner wrote: I'm not entirely sure why Libvirt is checking to see if the target file exists for LVM but it is a problem. Empty volume groups do not appear in /dev. When libvirt starts these pools then fail to autostart because their path does not exist. This is not useful,

Re: [libvirt] [PATCH v2 0/5] introduce support for CPU dies in host/guest topology

On Fri, Jan 10, 2020 at 11:20:58 +, Daniel P. Berrangé wrote: > Latest generation CPUs (CascadeLake-AP) support a new topology level > known as a 'die', sitting between a socket and a core. > > QEMU supports this with -smp arg since 4.1.0 ... > > Changed in v2: > > - Fixed docs for dies att

Re: [libvirt] [PATCH v4 1/5] virerror: Make it easier to add new error number

On Thu, Jan 09, 2020 at 01:45:56PM +0100, Michal Privoznik wrote: > In v5.0.0-rc1~94 we switched from one huge switch() to an array > for translating error numbers into error messages. However, the > array is declared to have VIR_ERR_NUMBER_LAST items which makes > it impossible to spot this place

[libvirt] FYI: intention to remove mail subject prefix & footer text

Hi List Subscribers, In recent months we have been seeing an increasing number of bounced deliveries from libvirt mailing lists[1] due to DMARC policies on list subscriber's mail servers. IOW, many subscribers are only receiving a subset of mails sent to the libvirt mailing lists. We believe the

Re: [libvirt] [jenkins-ci PATCH 1/2] mappings: Refactor librbd mapping

On Fri, Jan 10, 2020 at 12:29:18PM +0100, Andrea Bolognani wrote: > All RPM-based distributions except for CentOS 7 use the same name. > > Signed-off-by: Andrea Bolognani > --- > guests/vars/mappings.yml | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé

Re: [libvirt] [PATCH] docs: add pages to support Go module package resolution

On Fri, Jan 10, 2020 at 11:50:48 +, Daniel P. Berrangé wrote: > On Fri, Jan 10, 2020 at 12:47:51PM +0100, Jiri Denemark wrote: > > On Fri, Jan 10, 2020 at 10:03:28 +, Daniel P. Berrangé wrote: > > > Currently the libvirt Go modules are accessed by applications using > > > their github repos

Re: [libvirt] [jenkins-ci PATCH 2/2] mappings: Remove librbd from Debian on mipsel going forward

On Fri, Jan 10, 2020 at 12:49:28PM +0100, Andrea Bolognani wrote: > On Fri, 2020-01-10 at 11:35 +, Daniel P. Berrangé wrote: > > On Fri, Jan 10, 2020 at 12:29:19PM +0100, Andrea Bolognani wrote: > > > The package is no longer built on the architecture: this only affects > > > sid at the moment,

Re: [libvirt] [PATCH] docs: add pages to support Go module package resolution

On Fri, Jan 10, 2020 at 12:47:51PM +0100, Jiri Denemark wrote: > On Fri, Jan 10, 2020 at 10:03:28 +, Daniel P. Berrangé wrote: > > Currently the libvirt Go modules are accessed by applications using > > their github repository URLs. This is undesirable as we don't want > > applications to have

Re: [libvirt] [jenkins-ci PATCH 2/2] mappings: Remove librbd from Debian on mipsel going forward

On Fri, 2020-01-10 at 11:35 +, Daniel P. Berrangé wrote: > On Fri, Jan 10, 2020 at 12:29:19PM +0100, Andrea Bolognani wrote: > > The package is no longer built on the architecture: this only affects > > sid at the moment, but it's unlikely that it will be re-introduced so > > just assume that w

Re: [libvirt] [rust PATCH v2 5/5] libvirt-rust: stream: addressed comments

On Tue, Dec 24, 2019 at 12:12:55AM -0700, Zixing Liu wrote: > * minimized unsafe scope > * removed pub from `from_ptr` function > > Signed-off-by: Zixing Liu > --- > src/stream.rs | 16 +++- > 1 file changed, 7 insertions(+), 9 deletions(-) Reviewed-by: Sahid Orentino Ferdjaoui >

Re: [libvirt] [rust PATCH v2 4/5] libvirt-rust: use reference instead of moving

On Tue, Dec 24, 2019 at 12:12:54AM -0700, Zixing Liu wrote: > Signed-off-by: Zixing Liu > --- > src/domain.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Sahid Orentino Ferdjaoui > diff --git a/src/domain.rs b/src/domain.rs > index 40a18d8..61ca411 100644 > --- a/src/d

Re: [libvirt] [rust PATCH v2 3/5] libvirt-rust: stream: automated lint

On Tue, Dec 24, 2019 at 12:12:53AM -0700, Zixing Liu wrote: > * used rustfmt to clean up the code > > Signed-off-by: Zixing Liu > --- > src/stream.rs | 97 +-- > 1 file changed, 56 insertions(+), 41 deletions(-) NAK, we don't have specific rule fo

Re: [libvirt] [PATCH] docs: add pages to support Go module package resolution

On Fri, Jan 10, 2020 at 10:03:28 +, Daniel P. Berrangé wrote: > Currently the libvirt Go modules are accessed by applications using > their github repository URLs. This is undesirable as we don't want > applications to have a direct dependancy on a specific source repo > location. We want to en

Re: [libvirt] [rust PATCH v2 2/5] libvirt-rust: stream: add more functions in stream

On Tue, Dec 24, 2019 at 12:12:52AM -0700, Zixing Liu wrote: > * added virStreamEventAddCallback function > * added new types: StreamEventCallback and FreeCallback > * added new field: callback for storing event callback > * drop: will drop the Box if any > * added wrapper event_callback for easier

Re: [libvirt] [PATCH 2/2] news: Mention problems with backing image format probing

On Fri, Jan 10, 2020 at 12:29:46PM +0100, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > docs/news.xml | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index 1af57f8af0..4f1bea4fb5 100644 > --- a/docs/news.xml > +++ b/docs/news.xm

Re: [libvirt] [rust PATCH v2 1/5] libvirt-rust: stream: add more functions in stream

On Tue, Dec 24, 2019 at 12:12:51AM -0700, Zixing Liu wrote: > * added new functions: virStreamNew virStreamEventUpdateCallback > virStreamEventRemoveCallback > * added new constants: VIR_STREAM_NONBLOCK > * added new types/aliases: StreamFlags > * changed the previous `new` associate function to

Re: [libvirt] [PATCH 1/2] util: storage: Link to knowledge base when reporting missing image backing format

On Fri, Jan 10, 2020 at 12:29:45PM +0100, Peter Krempa wrote: > Mention the knowledge base article which has tips how to fix the backing > chain to work with current libvirt. > > Signed-off-by: Peter Krempa > --- > src/util/virstoragefile.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(

Re: [libvirt] [jenkins-ci PATCH 2/2] mappings: Remove librbd from Debian on mipsel going forward

On Fri, Jan 10, 2020 at 12:29:19PM +0100, Andrea Bolognani wrote: > The package is no longer built on the architecture: this only affects > sid at the moment, but it's unlikely that it will be re-introduced so > just assume that won't happen and structure the mapping accordingly. IIRC, rbd upstrea

[libvirt] [PATCH 0/2] Improve error message for missing backing image format

Improve the error message and mention it in the news. Peter Krempa (2): util: storage: Link to knowledge base when reporting missing image backing format news: Mention problems with backing image format probing docs/news.xml | 13 + src/util/virstoragefile.c | 3

[libvirt] [jenkins-ci PATCH 1/2] mappings: Refactor librbd mapping

All RPM-based distributions except for CentOS 7 use the same name. Signed-off-by: Andrea Bolognani --- guests/vars/mappings.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 69750ad..ac2ae58 100644 --- a/guests/va

[libvirt] [PATCH 2/2] news: Mention problems with backing image format probing

Signed-off-by: Peter Krempa --- docs/news.xml | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 1af57f8af0..4f1bea4fb5 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -88,6 +88,19 @@ + + + qemu: Repo

[libvirt] [jenkins-ci PATCH 0/2] Fixes necessary for buildenv-libvirt-debian-sid-cross-mipsel

The latest container build failed; this series addresses the underlying issue. Andrea Bolognani (2): mappings: Refactor librbd mapping mappings: Remove librbd from Debian on mipsel going forward guests/vars/mappings.yml | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.24.1

[libvirt] [jenkins-ci PATCH 2/2] mappings: Remove librbd from Debian on mipsel going forward

The package is no longer built on the architecture: this only affects sid at the moment, but it's unlikely that it will be re-introduced so just assume that won't happen and structure the mapping accordingly. Signed-off-by: Andrea Bolognani --- guests/vars/mappings.yml | 3 +++ 1 file changed, 3

[libvirt] [PATCH 1/2] util: storage: Link to knowledge base when reporting missing image backing format

Mention the knowledge base article which has tips how to fix the backing chain to work with current libvirt. Signed-off-by: Peter Krempa --- src/util/virstoragefile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index

[libvirt] [PATCH v2 4/5] hostcpu: add support for reporting die_id in NUMA topology

Update the host CPU code to report the die_id in the NUMA topology capabilities. On systems with multiple dies, this fixes the bug where CPU cores can't be distinguished: Notice how core_id is repeated within the scope of the same socket_id. It now reports

[libvirt] [PATCH v2 1/5] conf: add support for specifying CPU "dies" parameter

Recently CPU hardware vendors have started to support a new structure inside the CPU package topology known as a "die". Thus the hierarchy is now: sockets > dies > cores > threads This adds support for "dies" in the XML parser, with the value defaulting to 1 if not specified for backwards compa

[libvirt] [PATCH v2 0/5] introduce support for CPU dies in host/guest topology

Latest generation CPUs (CascadeLake-AP) support a new topology level known as a 'die', sitting between a socket and a core. QEMU supports this with -smp arg since 4.1.0 Linux can report this via /sys/devices/system/cpu/cpuNNN/topology via 'die_id' and 'die_cpus' and 'die_cpus_list' files since 5.

[libvirt] [PATCH v2 3/5] qemu: add support for specifying CPU "dies" topology parameter

QEMU since 4.1.0 supports the "dies" parameter for -smp Reviewed-by: Daniel Henrique Barboza Reviewed-by: Jiri Denemark Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c

[libvirt] [PATCH v2 2/5] conf: remove unused virCapabilitiesSetHostCPU method

Reviewed-by: Daniel Henrique Barboza Reviewed-by: Jiri Denemark Signed-off-by: Daniel P. Berrangé --- src/conf/capabilities.c | 21 - src/conf/capabilities.h | 6 -- src/libvirt_private.syms | 1 - 3 files changed, 28 deletions(-) diff --git a/src/conf/capabilities.

[libvirt] [PATCH v2 5/5] tests: add host CPU data files for validating die_id

Only Cascadelake-AP CPUs appear to report "die_id" values != 0 on Linux right now - AMD EPYC's don't report "die_id" (at least with Fedora 31 kernel). Lacking access to Cascadelake-AP CPUs, this test data was from a Fedora 31 QEMU guest launched with -cpu qemu64 -smp sockets=2,dies=3,cores=2,thre

Re: [libvirt] [PATCH v1 8/8] qemu_domain_address.c: turn qemuDomainFillDeviceIsolationGroup to void

On 1/9/20 3:33 PM, Daniel Henrique Barboza wrote: Starting on commit 1f43393283ff, qemuDomainFillDeviceIsolationGroup() returns 0 in all circunstances. Let's turn it to 'void' make it clearer that the function will not fail. This also spares a check for < 0 return in qemu_hotplug.c. The qemuDo

[libvirt] Entering freeze for 6.0.0

I just tagged it RC1 in git, and pushed signed tarball and source rpm to the usual place: https://libvirt.org/sources/ Looks fine in my very limited testing, ci seems mostly green (though I sometimes wonder how reliable that is) so looks we should be fine, but please give it some testing !

Re: [libvirt] [PATCH v3 0/5] introduce support for an embedded driver mode

On Thu, Jan 09, 2020 at 05:22:39PM +0100, Michal Privoznik wrote: > On 1/9/20 2:15 PM, Daniel P. Berrangé wrote: > > On Wed, Jan 08, 2020 at 05:30:23PM +0100, Michal Privoznik wrote: > > > On 12/20/19 3:16 PM, Daniel P. Berrangé wrote: > > > > > > > > > > Hm.. maybe I'm doing something wrong, but

[libvirt] [PATCH v4 3/6] libvirt: support an "embed" URI path selector for opening drivers

The driver URI scheme: "$drivername:///embed?root=/some/path" enables a new way to use the drivers by embedding them directly in the calling process. To use this the process must have a thread running the libvirt event loop. This URI will then cause libvirt to dynamically load the driver module

[libvirt] [PATCH v4 0/6] introduce support for an embedded driver mode

This is a followup to: v1: https://www.redhat.com/archives/libvir-list/2019-May/msg00467.html v2: https://www.redhat.com/archives/libvir-list/2019-December/msg00050.html v3: https://www.redhat.com/archives/libvir-list/2019-December/msg01364.html This series implements support for an embedded d

[libvirt] [PATCH v4 6/6] qemu: introduce a new "virt-qemu-run" program

The previous "QEMU shim" proof of concept was taking an approach of only caring about initial spawning of the QEMU process. It was then registered with the libvirtd daemon who took over management of it. The intent was that later libvirtd would be refactored so that the shim retained control over t

[libvirt] [PATCH v4 4/6] qemu: add support for running QEMU driver in embedded mode

This enables support for running QEMU embedded to the calling application process using a URI: qemu:///embed?root=/some/path Note that it is important to keep the path reasonably short to avoid risk of hitting the limit on UNIX socket path names which is 108 characters. When using the embedde

  1   2   >