Re: [PATCH v1 01/14] vircgroup: add virCgroupSetupBlkioTune()

On Mon, Feb 10, 2020 at 07:05:07PM -0300, Daniel Henrique Barboza wrote: This new util function puts the duplicated code from qemu_cgroup.c:qemuSetupBlkioCgroup() and lxc_cgroup.c:virLXCCgroupSetupBlkioTune() in a single function to be used in both places. Signed-off-by: Daniel Henrique Barboza

[libvirt PATCH 7/9] syntax-check: exclude: remove virstring

We no longer implement a wrapper over strdup - g_strdup is preferred. The use of strncpy was removed in: commit 7d70a63b947e9a654a4e3fffa0ffa355f5549ec7 util: Improve virStrncpy() implementation Signed-off-by: Ján Tomko --- build-aux/syntax-check.mk | 6 ++ 1 file changed, 2 insertions(

[libvirt PATCH 9/9] syntax-check: remove some exception mechanisms

Do not look for exception patterns in ${srcdir}./x-$@ nor the VC_LIST_EXCEPT_DEFAULT variable. This also removes the default exception for ChangeLog. Signed-off-by: Ján Tomko --- build-aux/syntax-check.mk | 2 -- 1 file changed, 2 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux

[libvirt PATCH 6/9] syntax-check: exclude: remove deleted files

Both xen/xend_internal and bootstrap.conf have been deleted from git. Signed-off-by: Ján Tomko --- build-aux/syntax-check.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 2c1ec877b1..3c1f46cb98 100644 --- a/bui

[libvirt PATCH 4/9] syntax-check: drop CVS keyword expansion check

$ date +%Y 2020 Signed-off-by: Ján Tomko --- build-aux/syntax-check.mk | 8 1 file changed, 8 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 52a6062ad5..23d2bf8b34 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1655

[libvirt PATCH 1/9] syntax-check: do not enforce ChangeLog syntax

Our last conforming ChangeLog was removed from git in 2009 by: commit 27b175b9a254d5dc4bbc1d6f198f58b287e516a2 generate ChangeLog from git logs into distribution tarball Ten years later, it reappeared in: commit ce97c33a795dec053f1e85c65ecd924b8c6ec4ba maint: Stop generating ChangeLog from

[libvirt PATCH 8/9] syntax-check: remove README

This exception is no longer useful since README is just a symlink to README.md, which is a subject to this check already. Signed-off-by: Ján Tomko --- build-aux/syntax-check.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.

[libvirt PATCH 3/9] syntax-check: drop vulnerable Makefile checks

As foretold, fixed automake is so common nowadays even Ubuntu 16.04 and Debian 9 have 1.11.6 as the oldest available version. Signed-off-by: Ján Tomko --- build-aux/syntax-check.mk | 30 -- 1 file changed, 30 deletions(-) diff --git a/build-aux/syntax-check.mk b/buil

[libvirt PATCH 5/9] syntax-check: drop update-NEWS-hash

NEWS was replaced by docs/news.html, so the pre-requisite for this rule is not fulfilled. Also, PREV_VERSION_REGEXP does not seem to be defined anywhere. Signed-off-by: Ján Tomko --- build-aux/syntax-check.mk | 14 -- 1 file changed, 14 deletions(-) diff --git a/build-aux/syntax-ch

[libvirt PATCH 2/9] syntax-check: fix sc-prohibit-cross-inclusion

Using '^' in in_vc_files assumes the build is happening in srcdir, which is no longer possible as of: commit f96395e78eaccffbf128336382c74b1250f04032 Signed-off-by: Ján Tomko --- build-aux/syntax-check.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/syntax-check.

[libvirt PATCH 0/9] syntax-check: fix sc-prohibit-cross-inclusion

And drop some legacy stuff, since I already had to open the file. Ján Tomko (9): syntax-check: do not enforce ChangeLog syntax syntax-check: fix sc-prohibit-cross-inclusion syntax-check: drop vulnerable Makefile checks syntax-check: drop CVS keyword expansion check syntax-check: drop upd

[PATCH v1 02/14] vircgroup: add virCgroupSetupMemtune()

virLXCCgroupSetupMemTune() and qemuSetupMemoryCgroup() shares duplicated code that can be put in a new helper to avoid code repetition. Signed-off-by: Daniel Henrique Barboza --- src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 14 +- src/qemu/qemu_cgroup.c | 14 +---

[PATCH v1 12/14] vircgroup: turn virCgroup{Get/Set}BlkioDevice* static

The new virCgroupSetupBlkioTune() centralized all the code that call those functions inside vircgroup.c. Signed-off-by: Daniel Henrique Barboza --- src/libvirt_private.syms | 11 -- src/util/vircgroup.c | 44 src/util/vircgroup.h | 41

[PATCH v1 04/14] vircgroup: add virCgroupSetAndRetrieveCpuShares()

The code that calls virCgroupSetCpuShares() and virCgroupGetCpuShares() is repeated in 4 different places. Let's put it in a new virCgroupSetAndRetrieveCpuShares() to avoid code repetition. There's a reason of why we execute a Get in the same value we just executed Set, explained in detail by comm

[PATCH v1 03/14] vircgroup: add virCgroupSetupCpusetCpus()

The code from qemuSetupCgroupCpusetCpus() and virLXCCgroupSetupCpusetTune() can be centralized in a new helper called virCgroupSetupCpusetCpus(). Signed-off-by: Daniel Henrique Barboza --- src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 11 +++ src/qemu/qemu_cgroup.c | 14 +

[PATCH v1 11/14] vircgroup: add virCgroupGetCpuPeriodQuota()

Another vircgroup helper to avoid code repetition between the LXC and QEMU driver. Signed-off-by: Daniel Henrique Barboza --- src/libvirt_private.syms | 1 + src/lxc/lxc_driver.c | 8 +--- src/qemu/qemu_driver.c | 8 +--- src/util/vircgroup.c | 14 ++ src/util/vi

[PATCH v1 10/14] vircgroup: add virCgroupSetMemoryLimitParameters()

lxcDomainSetMemoryParameters() and qemuDomainSetMemoryParameters() has duplicated chunks of code that can be put in a new helper. Signed-off-by: Daniel Henrique Barboza --- src/libvirt_private.syms | 1 + src/lxc/lxc_driver.c | 70 ++- src/qemu/qemu_driver.c

[PATCH v1 13/14] vircgroup: turn SetMemory and SetCpusetCpus functions static

The new virCgroupSetupMemtune() virCgroupSetupCpusetCpus() made the cgroup SetMemory and SetCpusetCpus functions to be called only inside vircgroup.c. Signed-off-by: Daniel Henrique Barboza --- src/libvirt_private.syms | 4 src/util/vircgroup.c | 16 src/util/vircgroup

[PATCH v1 14/14] vircgroup: turn more cgroup functions static

The new functions virCgroupSetAndRetrieveCpuShares(), virCgroupSetupCpuPeriodQuota() and virCgroupGetCpuPeriodQuota() centralized all callers of {get/set}Cpu{Shares,CfsPeriod,CfsQuota} to be inside vircgroup.c. Signed-off-by: Daniel Henrique Barboza --- src/libvirt_private.syms | 5 - src/u

[PATCH v1 09/14] domain_conf: add virDomainParseMergePersistentDefBlkioParams()

This new helper avoids more code repetition inside lxcDomainSetBlkioParameters() and qemuDomainSetBlkioParameters(). Signed-off-by: Daniel Henrique Barboza --- src/conf/domain_conf.c | 41 src/conf/domain_conf.h | 4 src/libvirt_private.syms |

[PATCH v1 07/14] domain_conf: add virDomainParseBlkioDeviceStr()

lxcDomainParseBlkioDeviceStr() and qemuDomainParseBlkioDeviceStr() are the same function. Avoid code repetition by putting the code in a new helper. Signed-off-by: Daniel Henrique Barboza --- src/conf/domain_conf.c | 111 ++ src/conf/domain_conf.h | 3 + src

[PATCH v1 08/14] vircgroup: add virCgroupSetupDomainBlkioParameters()

After the introduction of virDomainMergeBlkioDevice() in a previous patch, it is now clear that lxcDomainSetBlkioParameters() and qemuDomainSetBlkioParameters() uses the same loop to set cgroup blkio parameter of a domain. Avoid the repetition by adding a new helper called virCgroupSetupDomainBlki

[PATCH v1 06/14] domain_conf: add virDomainMergeBlkioDevice()

lxcDomainMergeBlkioDevice() and -qemuDomainMergeBlkioDevice() are the same functions. Put the code in a new virDomainMergeBlkioDevice() inside domain_conf.c and update both callers. This change is a preliminary step for more code reduction of cgroup related code inside lxcDomainSetBlkioParameters(

[PATCH v1 05/14] vircgroup: add virCgroupSetupCpuPeriodQuota()

qemuSetupCgroupVcpuBW() and lxcSetVcpuBWLive() shares the same code to set CPU CFS period and quota. This code can be moved to a new virCgroupSetupCpuPeriodQuota() helper to avoid code repetition. A similar code is also executed in virLXCCgroupSetupCpuTune(), but without the rollback on error. Use

[PATCH v1 00/14] vircgroup code duplication purge

Hi, This is my attempt to a side quest from Cole Robinson reported in the wiki. It started with an innocent code duplication reduction work, then I got dragged into code duplication inside LXC and QEMU drivers. There is a significant amount of code sharing between LXC and QEMU drivers that should

[PATCH v1 01/14] vircgroup: add virCgroupSetupBlkioTune()

This new util function puts the duplicated code from qemu_cgroup.c:qemuSetupBlkioCgroup() and lxc_cgroup.c:virLXCCgroupSetupBlkioTune() in a single function to be used in both places. Signed-off-by: Daniel Henrique Barboza --- src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 49 +-

Questions about using qemuProcess API within a libvirt test

Hello, I am working on implementing libvirt test cases for the hypervisor-cpu-compare and -baseline commands. Ideally, I would like to take advantage of the qemuProcess API to spin up a QEMU instance and run these commands to test real data queried from the hypervisor. However, I am having issues

Re: glib crash via eventtest.c

On Mon, Feb 10, 2020 at 01:13:55PM -0500, Cole Robinson wrote: > I attempted to review some patches on Friday and started hitting > occasional crashes via eventtest.c. Long story short it's a glib bug: > > https://gitlab.gnome.org/GNOME/glib/merge_requests/1358 > > It's a ref counting issue cause

glib crash via eventtest.c

I attempted to review some patches on Friday and started hitting occasional crashes via eventtest.c. Long story short it's a glib bug: https://gitlab.gnome.org/GNOME/glib/merge_requests/1358 It's a ref counting issue caused when g_source_remove (virEventRemoveHandle) is called from one thread, wh

[libvirt PATCH 1/2] ci: Make container environment available to scripts

For container images targeted at cross-building, we bake a small amount of architecture-specific information in the environment so that builds can work as expected without requiring additional work from the user; unfortunately this information got lost as soon as we called sudo. Explicitly allow it

[libvirt PATCH 0/2] travis: Use dedicated images for MinGW builds

Andrea Bolognani (2): ci: Make container environment available to scripts travis: Use dedicated images for MinGW builds .travis.yml | 10 -- ci/Makefile | 2 ++ 2 files changed, 6 insertions(+), 6 deletions(-) -- 2.24.1

[libvirt PATCH 2/2] travis: Use dedicated images for MinGW builds

Now that we treat MinGW like any other cross-build target, we should update our Travis CI configuration. Signed-off-by: Andrea Bolognani --- This patch needs https://www.redhat.com/archives/libvir-list/2020-February/msg00409.html to be merged into libvirt-jenkins-ci and the corresponding cont

[jenkins-ci PATCH 6/8] lcitool: Add RPM-specific _dockerfile_build_varmap() variant

A lot of the code in _dockerfile_build_varmap() only applies to Debian, so we can have a simpler version for use with Fedora. This split will come in handy later on, when we start introducing features that work in Fedora and not in Debian. Signed-off-by: Andrea Bolognani --- guests/lcitool | 48

[dockerfiles PATCH] refresh: Drop MinGW hacks

Up until now we have had to hardcode some information in our refresh script, but with the recent improvements to lcitool that's no longer necessary. Signed-off-by: Andrea Bolognani --- This patch needs https://www.redhat.com/archives/libvir-list/2020-February/msg00409.html to be merged into l

[jenkins-ci PATCH 0/8] lcitool: Support MinGW cross-build Dockerfiles

More details in the commit message for patch 7/8. Pavel pointed out today that the current method of triggering MinGW builds using our CI scaffolding, eg. $ make ci-build@fedora-30 CI_CONFIGURE=mingw64-configure is easy to get wrong and not very discoverable, so I took that as motivation to im

[jenkins-ci PATCH 3/8] lcitool: Separate computation and formatting

Signed-off-by: Andrea Bolognani --- guests/lcitool | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 80a0d6a..6da2206 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -720,8 +720,6 @@ class Application:

[jenkins-ci PATCH 5/8] lcitool: Introduce _dockerfile_build_varmap()

This function takes care of most of what's still handled by _action_dockerfile(), namely populating the dictionary that _dockerfile_format() will later consume. Signed-off-by: Andrea Bolognani --- guests/lcitool | 132 ++--- 1 file changed, 71 insertio

[jenkins-ci PATCH 2/8] lcitool: Change check for pip_pkgs formatting

Signed-off-by: Andrea Bolognani --- guests/lcitool | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 6624887..80a0d6a 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -725,7 +725,9 @@ class Application: varmap = {}

[jenkins-ci PATCH 7/8] lcitool: Support MinGW cross-build Dockerfiles on Fedora

Up until this point, MinGW has been treated as a very special case, even having its own sub-projects. While this was perfectly reasonable back when lcitool was introduced, now that we support cross-building as a first-class concept in the Dockerfile generator it makes little sense for MinGW builds

[jenkins-ci PATCH 8/8] lcitool: Add more checks to _action_dockerfile()

There are a few problematic scenarios that we can catch early. Signed-off-by: Andrea Bolognani --- guests/lcitool | 16 1 file changed, 16 insertions(+) diff --git a/guests/lcitool b/guests/lcitool index abc803b..771402e 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -931,

[jenkins-ci PATCH 4/8] lcitool: Introduce _dockerfile_format()

This function takes care of approximately half of the job that was up until now handled by _action_dockerfile(), namely taking a populated dictionary and turning it into a Dockerfile. Signed-off-by: Andrea Bolognani --- guests/lcitool | 192 + 1 fi

[jenkins-ci PATCH 1/8] lcitool: Introduce cross_arch local variable

Signed-off-by: Andrea Bolognani --- guests/lcitool | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 8a681e4..6624887 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -657,15 +657,16 @@ class Application:

[libvirt PATCH 4/5] docs: QoS parameter 'floor' is supported for 'open' networks too

Relevant code seems to treat forward modes 'route', 'nat', 'open' and none the same but documentation hasn't reflected that so far. Signed-off-by: Pavel Mores --- docs/formatnetwork.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatnetwork.html.in b/docs/form

[libvirt PATCH 5/5] qemu: reuse convenience variable introduced in a00b97f27672b3

Since we have the result of a compound condition named now we can use it to simplify another complex condition to make it more readable. Signed-off-by: Pavel Mores --- src/network/bridge_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/network/bridge_driver.c b/

[libvirt PATCH 3/5] qemu: call networkPlugBandwidth() for all types of network

To fix the actual bug, it was necessary to make networkPlugBandwidth() be called also for 'bridge'-type networks implemented using macvtap's 'bridge' mode (previously it was only called for those implemented on top of an existing bridge). However, it seems beneficial to call it for other network t

[libvirt PATCH 1/5] qemu: fail on attempt to set 'floor' if interface type is not 'network'

QoS 'floor' setting is documented to be only supported for interfaces of type 'network'. Fail with an error message on attempt to set 'floor' on an interface of any other type. Signed-off-by: Pavel Mores --- src/qemu/qemu_driver.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletion

[libvirt PATCH 2/5] qemu: check if 'floor' is supported for given interface and network

Even if an interface of type 'network', setting 'floor' is only supported if the network's forward type is nat, route, open or none. Signed-off-by: Pavel Mores --- src/network/bridge_driver.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/network/bridge_driver.c b/src

[libvirt PATCH 0/5] qemu: add stricter checks of permissibility of the QoS parameter 'floor'

Aims to fix https://bugzilla.redhat.com/show_bug.cgi?id=1750219 Libvirt previously silently accepted attempts to set 'floor' even for direct bridge interface types where the parameter is not supported. This could happen when manipulating both inactive and active (e.g. via 'virsh domiftune') doma

Re: [libvirt PATCH 0/6] Introduce Local Migration Support in Libvirt

On 2/3/20 5:43 AM, Daniel P. Berrangé wrote: I'm (re-)sending this patch series on behalf of Shaju Abraham who has tried to send this several times already. Red Hat's email infrastructure is broken, accepting the mails and then failing to deliver them to mailman, or any other Red Hat address. U

Re: [libvirt PATCH v2 5/8] qemu: Format the armvtimer timer on the command line

On Fri, Feb 07, 2020 at 03:27:05PM +0100, Andrea Bolognani wrote: > Its behavior is controlled by a KVM-specific CPU feature. > > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_command.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/src/qemu/qemu_command.c b/src

Re: [libvirt PATCH v2 3/8] conf: Introduce VIR_DOMAIN_TIMER_NAME_ARMVTIMER

On Fri, Feb 07, 2020 at 03:27:03PM +0100, Andrea Bolognani wrote: > This new timer model will be used to control the behavior of the > virtual timer for KVM ARM/virt guests. > > Signed-off-by: Andrea Bolognani > --- > docs/schemas/domaincommon.rng | 1 + > src/conf/domain_conf.c| 1 + >

Re: [libvirt PATCH v2 4/8] qemu: Validate configuration for the armvtimer timer

On Fri, Feb 07, 2020 at 03:27:04PM +0100, Andrea Bolognani wrote: > Its use is limited to certain guest types, and it only supports > a subset of all possible tick policies. > > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_domain.c | 33 + > 1 file change

Re: [libvirt PATCH v2 2/8] qemu: Add the QEMU_CAPS_CPU_KVM_NO_ADJVTIME capability

On Fri, Feb 07, 2020 at 03:27:02PM +0100, Andrea Bolognani wrote: > We will use this capability to detect whether the QEMU binary > supports the kvm-no-adjvtime CPU feature. > > Reviewed-by: Ján Tomko > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_capabilities.c |

Re: [libvirt PATCH v2 1/8] qemu: Use switch statement in qemuBuildCpuCommandLine()

On Fri, Feb 07, 2020 at 03:27:01PM +0100, Andrea Bolognani wrote: > Make sure we are taking all possible virDomainTimerNameType values > into account. This will make upcoming changes easier. > > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_command.c | 34

[rust PATCH 0/3] Implement virStoragePoolListVolumes and virStoragePoolListAllVolumes

From: Mathias Pius This patch implements virStoragePoolListAllVolumes and virStoragePoolListVolumes for the StoragePool object. I'm not too familiar with the libvirt codebase, so I've used similar functions from connect.rs and domain.rs for so the implementations should (hopefully) be as corre

[rust PATCH 1/3] Implement virStoragePoolListAllVolumes and virStoragePoolListVolumes for StoragePool

From: Mathias Pius --- src/storage_pool.rs | 54 ++- tests/storage_pool.rs | 34 +++ 2 files changed, 87 insertions(+), 1 deletion(-) diff --git a/src/storage_pool.rs b/src/storage_pool.rs index 96258f0..02395bf 100644 --- a/src/

[rust PATCH 3/3] Newline at end of file

From: Mathias Pius --- tests/storage_pool.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/storage_pool.rs b/tests/storage_pool.rs index 303867b..21c1139 100644 --- a/tests/storage_pool.rs +++ b/tests/storage_pool.rs @@ -91,4 +91,4 @@ fn test_list_all_volumes() {

[rust PATCH 2/3] cargo fmt

From: Mathias Pius --- src/storage_pool.rs | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/storage_pool.rs b/src/storage_pool.rs index 02395bf..571fabd 100644 --- a/src/storage_pool.rs +++ b/src/storage_pool.rs @@ -387,12 +387,13 @@ impl StoragePool { pub fn

Fwd: FW: [libvirt PATCH 0/6] Introduce Local Migration Support in Libvirt

On 2/3/20, 7:16 PM, "Daniel P. Berrangé" wrote: On Mon, Feb 03, 2020 at 10:42:48AM -0300, Daniel Henrique Barboza wrote: > Hi Daniel, > > I am happy that Libvirt is pushing local migration/live patching support, but > at the same time I am wondering wha