On 2/18/20 10:14 PM, Laine Stump wrote:
On 2/18/20 12:39 PM, Ján Tomko wrote:
On Sun, Feb 16, 2020 at 11:22:54PM -0500, Laine Stump wrote:
This is a very simple thing to parse and format, but needs to be done
in 4 places, so two trivial utility functions have been made that can
be called from a
Em qua., 19 de fev. de 2020 às 09:27, Daniel Henrique Barboza
escreveu:
>
>
>
> On 2/16/20 2:11 PM, Julio Faracco wrote:
> > This commit tries to fix a lots of issues related to LXC VCPUs. One of
>
> Extra 'a' there. "tries to fix lots of issues ..."
>
>
> > them is related to /proc/cpuinfo conten
This commit add more features to storages that supports setuid, setgid
and sticky bit. This extend some permission levels of volumes when you
run an hypervisor using a specific user that can run but cannot delete
volumes for instance. Additionally, when you create a directory without
`pool-build` c
[adding qemu]
On 2/19/20 12:57 PM, Peter Krempa wrote:
Namely a user creates an overlay on top of single raw/qcow2 image and
expects it to work. And it's not just random users, libguestfs and
openstack also neglected to set the backing format.
Yes, and they are getting patched. Belatedly, b
On Wed, Feb 19, 2020 at 11:07:09 -0600, Eric Blake wrote:
> On 2/19/20 10:40 AM, Peter Krempa wrote:
[]
> > Namely a user creates an overlay on top of single raw/qcow2 image and
> > expects it to work. And it's not just random users, libguestfs and
> > openstack also neglected to set the back
On 2/19/20 10:40 AM, Peter Krempa wrote:
1b: base.raw probes as qcow2 (because of whatever the guest wrote there),
using it as qcow2 is wrong - the guest will see corrupted data. What's more,
if the probe sees it as qcow2 with backing file, and we open the backing
file, it also has security impl
On Wed, Feb 19, 2020 at 17:40:34 +0100, Peter Krempa wrote:
> On Wed, Feb 19, 2020 at 10:21:00 -0600, Eric Blake wrote:
> > On 2/17/20 11:13 AM, Peter Krempa wrote:
[...]
> > > With pre-blockdev configurations this will restore the previous
> > > behaviour for the images mentioned above as qemu w
On Wed, Feb 19, 2020 at 10:31:18 -0600, Eric Blake wrote:
> On 2/17/20 11:13 AM, Peter Krempa wrote:
> > Note that this is not finished yet, but allows to test the image
> > detection patches:
>
> "allows to ${verb}" is not idiomatic; you want "allows ${verb}ing" or
> "allows $subject to ${verb}".
On 2/19/20 10:21 AM, Eric Blake wrote:
It took me a few minutes of thinking about this.
Scenario 1:
base.raw <- wrap.qcow2
where wrap.qcow2 specifies backing of base.raw but not the format. If
we probe, we can have a couple of outcomes:
1a: base.raw probes as raw (the probed image has no
On Wed, Feb 19, 2020 at 10:21:00 -0600, Eric Blake wrote:
> On 2/17/20 11:13 AM, Peter Krempa wrote:
> > Allow format probing to work around lazy clients which did not specify
> > their format in the overlay. Format probing will be allowed only, if we
>
> s/only, if/only if/
>
> > are able to pro
On 2/17/20 11:13 AM, Peter Krempa wrote:
Note that this is not finished yet, but allows to test the image
detection patches:
"allows to ${verb}" is not idiomatic; you want "allows ${verb}ing" or
"allows $subject to ${verb}". Here, I would go with "allows testing of
the image detection patche
On 2/17/20 11:13 AM, Peter Krempa wrote:
Allow format probing to work around lazy clients which did not specify
their format in the overlay. Format probing will be allowed only, if we
s/only, if/only if/
are able to probe the image, the probing result was successful and the
probed image does
On 2/17/20 11:13 AM, Peter Krempa wrote:
There's nothing to clean up. Make it obvious what is returned.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 50 +++
1 file changed, 19 insertions(+), 31 deletions(-)
Reviewed-by: Eric Blake
--
Er
On 2/17/20 11:13 AM, Peter Krempa wrote:
Extract the code that directly deals with storage. This allows further
simplification and clarification of virStorageFileGetMetadataRecurse.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 71 ++-
1 file
On 2/17/20 11:13 AM, Peter Krempa wrote:
Replacing virHashLookup by virHashHasEntry allows to use NULL as the
allows us to
payload of the hash table rather than putting a fake '1' pointer into
the table.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 4 ++--
1 file changed,
On 2/17/20 11:13 AM, Peter Krempa wrote:
The path can be NULL e.g. for NBD disks. Use NULLSTR to prevent use of
NULL in %s.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake
diff --git a/src/util/
On 2/17/20 11:13 AM, Peter Krempa wrote:
Move the assignment to a place where we know that the backing store is
present rather than having to check in the cleanup section.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
On 2/17/20 11:13 AM, Peter Krempa wrote:
We call virStorageFileSupportsBackingChainTraversal which already checks
that the 'storageFileRead' callback is non-NULL, which in turn means
that virStorageFileRead will not return -2.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 9 +---
On Wed, Feb 19, 2020 at 09:18:40 -0600, Eric Blake wrote:
> On 2/17/20 11:13 AM, Peter Krempa wrote:
> > Probing by file suffix was meant to be a last resort if probing by
> > contents fails or is not supported. For most formats we never specified
> > any suffix. There's a few formats implementing
On 2/17/20 11:13 AM, Peter Krempa wrote:
Probing by file suffix was meant to be a last resort if probing by
contents fails or is not supported. For most formats we never specified
any suffix. There's a few formats implementing both magic bytes and
suffix and finally DMG which had only suffix prob
On 2/19/20 4:53 AM, Max Reitz wrote:
On 31.01.20 18:11, Eric Blake wrote:
ping
Do you want further review or is Ján’s sufficient for you?
Commit 0bc16997 has already landed, so no further review will show in
git history. But you're always welcome to raise issues that might result
in follow
On Wed, Feb 19, 2020 at 02:09:03PM +0100, Jiri Denemark wrote:
This patch show a bug in our code: the
s/show/shows/
element present in the source XML is lost when the parsed CPU definition
is formatted back to XML.
https://bugzilla.redhat.com/show_bug.cgi?id=1804549
Signed-off-by: Jiri Den
On Wed, Feb 19, 2020 at 02:09:04PM +0100, Jiri Denemark wrote:
In commit v5.9.0-400-gaf8e39921a I removed printing model's fallback and
vendor_id attributes when no model is specified. However, vendor_id
makes sense even without a specific CPU model (for host-model CPUs).
https://bugzilla.redhat
In commit v5.9.0-400-gaf8e39921a I removed printing model's fallback and
vendor_id attributes when no model is specified. However, vendor_id
makes sense even without a specific CPU model (for host-model CPUs).
https://bugzilla.redhat.com/show_bug.cgi?id=1804549
Signed-off-by: Jiri Denemark
---
In commit v5.9.0-400-gaf8e39921a I removed printing model's fallback and
vendor_id attributes when no model is specified. However, vendor_id
makes sense even without a specific CPU model (for host-model CPUs).
https://bugzilla.redhat.com/show_bug.cgi?id=1804549
Jiri Denemark (2):
qemuxml2xmltes
This patch show a bug in our code: the
element present in the source XML is lost when the parsed CPU definition
is formatted back to XML.
https://bugzilla.redhat.com/show_bug.cgi?id=1804549
Signed-off-by: Jiri Denemark
---
.../cpu-host-model-vendor.xml | 28 +++
On Wed, 2020-02-19 at 01:31 +0100, Ján Tomko wrote:
> To more closely match the previous usage in virEventPollDispatchHandles,
> where called the handle callback for any revents returned by poll.
>
> This should fix the virtlogd error on subsequent domain startup:
> error: can't connect to virtl
On 2/16/20 2:11 PM, Julio Faracco wrote:
Native config files sometimes can setup cpuset.cpus to pin som CPUs.
typo: s/som/some
Everything else LGTM.
Before this, LXC was using a fixed number of 1 VCPU. After this commit,
XML definition will generate a dynamic number of VCPUs based on th
On 2/16/20 2:11 PM, Julio Faracco wrote:
This commit tries to fix a lots of issues related to LXC VCPUs. One of
Extra 'a' there. "tries to fix lots of issues ..."
them is related to /proc/cpuinfo content. If only 1 VCPU is set, LXC
containers will show all CPUs available for host. The sec
On 2/16/20 2:11 PM, Julio Faracco wrote:
This commit share host Real Time Clock device (rtc) into LXC containers
to support hardware clock. This should be available setting up a `rtc`
timer under clock section. Since this option is not emulated, it should
be available only for `localtime` cloc
On 31.01.20 18:11, Eric Blake wrote:
> ping
Do you want further review or is Ján’s sufficient for you?
Also, I wonder whether it would make a good GSoC/Outreachy/... project
to add partition reading support to the raw block driver, or whether
that’s a bad idea. O:-)
Max
signature.asc
Descript
On Tue, Feb 18, 2020 at 10:08:42PM -0500, Laine Stump wrote:
On 2/18/20 12:52 PM, Ján Tomko wrote:
On Sun, Feb 16, 2020 at 11:22:58PM -0500, Laine Stump wrote:
During the hypervisor-agnostic validation of network devices, verify
that the interface type is either "network" or "bridge", and that
On Wed, Feb 19, 2020 at 09:26:23AM +0100, Peter Krempa wrote:
qemuMonitorGetIOThreads returns a NULL terminated list even when 0
NULL-terminated
iothreads are present. The caller didn't perform cleanup if there were 0
iothreads leaking the array.
https://bugzilla.redhat.com/show_bug.cgi?id=1
qemuMonitorGetIOThreads returns a NULL terminated list even when 0
iothreads are present. The caller didn't perform cleanup if there were 0
iothreads leaking the array.
https://bugzilla.redhat.com/show_bug.cgi?id=1804548
Reported-by: Jing Yan
Signed-off-by: Peter Krempa
---
src/qemu/qemu_drive
34 matches
Mail list logo
