On 31.03.20 04:43, PRAKHAR BANSAL wrote:
Hi Jan,
Thanks for the confirmation to proceed on project proposal.
Also, I tried installing Jailhouse on my VM after enabling VT-x/EPT and
IOMMU for my VM(Guest OS- Ubuntu 18.04) on VMware fusion hypervisor with
MacOS on the host side.
However, Jailhou
Hi Jan,
Thanks for the confirmation to proceed on project proposal.
Also, I tried installing Jailhouse on my VM after enabling VT-x/EPT and
IOMMU for my VM(Guest OS- Ubuntu 18.04) on VMware fusion hypervisor with
MacOS on the host side.
However, Jailhouse hardware check was failed because of mis
GSoC Proposal - 2020
Project Name: Introducing Job control to the storage driver
===
About Me:
=
Name: Prathamesh Chavan
University: Indian Institute of Technology Kharagpur
Major: Computer Science an
The QEMU 9pfs 'multidevs' option exists since QEMU 4.2. Probe QEMU's
command line set though to check whether this option is really
available, and if yes enable this new QEMU_CAPS_VIRTFS_MULTIDEVS
capability on libvirt side.
Signed-off-by: Christian Schoenebeck
---
src/qemu/qemu_capabilities.c
This option prevents misbehaviours on guest if a qemu 9pfs export
contains multiple devices, due to the potential file ID collisions
this otherwise may cause.
Signed-off-by: Christian Schoenebeck
---
src/qemu/qemu_command.c | 7 +++
src/qemu/qemu_domain.c
QEMU 4.2 added a new option 'multidevs' for 9pfs. The following patch adds
support for this new option to libvirt.
In short, what is this about: to distinguish files uniquely from each other
in general, numeric file IDs are typically used for comparison, which in
practice is the combination of a f
Introduce new 'multidevs' option for filesystem.
This option prevents misbehaviours on guest if a qemu 9pfs export
contains multiple devices, due to the potential file ID collisions
this otherwise may cause.
Signed-off-by: Christian Schoenebeck
---
docs/formatdomain.html.in
Setting CC="ccache cc" works in most cases, but sometimes it will
break the build: in particular, we have experienced issues in the
past with that approach when using cgo to build our Go bindings.
A more robust approach is to have a directory containing symlinks
from the compiler name to the ccach
Since libvirt-jenkins-ci commit 27cfddee8835, paths to build tools
such as ninja and make are exported in the container's environment
and can be used directly.
Signed-off-by: Andrea Bolognani
---
.gitlab-ci.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
in
Test pipeline: https://gitlab.com/abologna/libvirt/pipelines/131128028
Andrea Bolognani (2):
gitlab: Don't define $MAKE
gitlab: Enable improved ccache usage
.gitlab-ci.yml | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
--
2.25.1
On Mon, Mar 30, 2020 at 07:05:26PM +0200, Andrea Bolognani wrote:
> On Mon, 2020-03-30 at 17:04 +0100, Daniel P. Berrangé wrote:
> > The Fedora rawhide job started failing with the latest container build.
> > Since we now have broad CI coverage on GitLab CI, there's not a strong
> > reason to conti
On Mon, 2020-03-30 at 17:04 +0100, Daniel P. Berrangé wrote:
> The Fedora rawhide job started failing with the latest container build.
> Since we now have broad CI coverage on GitLab CI, there's not a strong
> reason to continue using Travis for Linux jobs. Deleting the redundant
> jobs is a better
On Mon, Mar 30, 2020 at 06:20:28PM +0200, Michal Prívozník wrote:
> On 30. 3. 2020 13:16, Daniel P. Berrangé wrote:
> > On Thu, Mar 26, 2020 at 04:15:09PM +0100, Michal Privoznik wrote:
> >> This function returns embeddedRoot member of the driver
> >> structure.
> >>
> >> Signed-off-by: Michal Priv
On Mon, Mar 30, 2020 at 06:16:29PM +0200, Michal Prívozník wrote:
> On 30. 3. 2020 13:09, Daniel P. Berrangé wrote:
> > On Thu, Mar 26, 2020 at 04:15:06PM +0100, Michal Privoznik wrote:
> >> Initially introduced in v3.10.0-rc1~172.
> >>
> >> When generating a path for memory-backend-file or -mem-pa
On 30. 3. 2020 13:16, Daniel P. Berrangé wrote:
> On Thu, Mar 26, 2020 at 04:15:09PM +0100, Michal Privoznik wrote:
>> This function returns embeddedRoot member of the driver
>> structure.
>>
>> Signed-off-by: Michal Privoznik
>> Reviewed-by: Andrea Bolognani
>> Reviewed-by: Daniel Henrique Barbo
On 30. 3. 2020 13:09, Daniel P. Berrangé wrote:
> On Thu, Mar 26, 2020 at 04:15:06PM +0100, Michal Privoznik wrote:
>> Initially introduced in v3.10.0-rc1~172.
>>
>> When generating a path for memory-backend-file or -mem-path, qemu
>> driver will use the following pattern:
>>
>> $memoryBackingDir
The Fedora rawhide job started failing with the latest container build.
Since we now have broad CI coverage on GitLab CI, there's not a strong
reason to continue using Travis for Linux jobs. Deleting the redundant
jobs is a better use of time than trying to debug the failure.
Signed-off-by: Daniel
On Montag, 30. März 2020 16:45:08 CEST Ján Tomko wrote:
> >> A change to qemuxml2argvtest is needed.
> >>
> >> If you already added the XML file to qemuxml2argvdata in the previous
> >> commit, all you need to to to generate the output file is:
> >> * add a new DO_TEST_CAPS_LATEST line to qemuxml2
On 30.03.2020 13:41, Daniel P. Berrangé wrote:
> On Sun, Mar 29, 2020 at 02:33:41PM +0300, nshirokovskiy wrote:
>>
>>
>> On 26.03.2020 20:50, Daniel P. Berrangé wrote:
>>> On Fri, Feb 28, 2020 at 10:09:41AM +0300, Nikolay Shirokovskiy wrote:
On 27.02.2020 16:48, Daniel P. Berrangé wrote:
>>
On a Monday in 2020, Christian Schoenebeck wrote:
On Freitag, 27. März 2020 18:16:37 CEST Ján Tomko wrote:
On a Friday in 2020, Christian Schoenebeck wrote:
>This option prevents misbehaviours on guest if a qemu 9pfs export
>contains multiple devices, due to the potential file ID collisions
>thi
On a Monday in 2020, Peter Krempa wrote:
On Mon, Mar 30, 2020 at 16:18:26 +0200, Ján Tomko wrote:
On a Monday in 2020, Peter Krempa wrote:
> Add a new attribute for holding the query part for http(s) disks.
>
> Signed-off-by: Peter Krempa
> ---
> docs/formatdomain.html.in
On Mon, Mar 30, 2020 at 16:18:26 +0200, Ján Tomko wrote:
> On a Monday in 2020, Peter Krempa wrote:
> > Add a new attribute for holding the query part for http(s) disks.
> >
> > Signed-off-by: Peter Krempa
> > ---
> > docs/formatdomain.html.in | 7 ++-
> > docs
On a Monday in 2020, Peter Krempa wrote:
For http/https URIs we need to preserve the query part as it may be
important to refer to the image.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 13 ++---
tests/virstoragetest.c| 4 ++--
2 files changed, 12 insertions(+), 5 del
On a Monday in 2020, Peter Krempa wrote:
If the storage source has the query part set, format it in the output.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c| 2 ++
src/qemu/qemu_domain.c | 9 +
tests/qemuxml2ar
On a Monday in 2020, Peter Krempa wrote:
Add a new attribute for holding the query part for http(s) disks.
Signed-off-by: Peter Krempa
---
docs/formatdomain.html.in | 7 ++-
docs/schemas/domaincommon.rng | 6 ++
src/conf/domain
On a Monday in 2020, Peter Krempa wrote:
http, https, ftp, ftps, and tftp were not mentioned in the
documentation. Note that 'ssh' is still omitted as it's used only
internally.
Signed-off-by: Peter Krempa
---
docs/formatdomain.html.in | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
http, https, ftp, ftps, and tftp were not mentioned in the
documentation. Note that 'ssh' is still omitted as it's used only
internally.
Signed-off-by: Peter Krempa
---
docs/formatdomain.html.in | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/docs/formatdomain.html.in
Add a new attribute for holding the query part for http(s) disks.
Signed-off-by: Peter Krempa
---
docs/formatdomain.html.in | 7 ++-
docs/schemas/domaincommon.rng | 6 ++
src/conf/domain_conf.c
If the storage source has the query part set, format it in the output.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c| 2 ++
src/qemu/qemu_domain.c | 9 +
tests/qemuxml2argvdata/disk-cdrom-network.args
v2:
- fixed docs to mention http/ftp/tftp protocols
- query part is stored separately to prevent ambiguity in using of the
'?' sign
- added checks that query is valid only for http
- added tests for pre-blockdev configurations
Peter Krempa (4):
docs: formatdomain: Mention missing protocols
con
For http/https URIs we need to preserve the query part as it may be
important to refer to the image.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 13 ++---
tests/virstoragetest.c| 4 ++--
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/util/virstor
Hi
On Mon, Mar 30, 2020 at 1:54 PM Daniel P. Berrangé wrote:
>
> On Sat, Mar 28, 2020 at 12:38:57AM +0100, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Add an option to ease setting up a VM with existing libvirt qemu.conf.
> >
> > Fixes:
> > https://bugzilla.redhat.com/
On a Monday in 2020, Peter Krempa wrote:
Peter Krempa (2):
qemu: block: Support VIR_DOMAIN_BLOCK_COMMIT/PULL/REBASE_RELATIVE with
blockdev
qemuDomainSnapshotDiskPrepareOne: Don't load the relative path with
blockdev
src/qemu/qemu_block.c | 46 ++
s
Paths to commands such as $MAKE and $NINJA are now exposed in the
container's environment, and the symlinks necessary to make ccache
work transparently are also included.
The corresponding libvirt-jenkins-ci commit is 2563aebb6c5c.
Signed-off-by: Andrea Bolognani
---
Pushed under the Dockerfile
On Mon, 2020-03-30 at 13:19 +0100, Daniel P. Berrangé wrote:
> On Mon, Mar 30, 2020 at 02:17:15PM +0200, Andrea Bolognani wrote:
> > I also considered /usr/libexec/ccache-wrappers - what would you think
> > of that option?
>
> I don't mind either that or your original
Okay, I'll go with /usr/libe
On Mon, Mar 30, 2020 at 02:31:40PM +0200, Andrea Bolognani wrote:
> On Mon, 2020-03-30 at 13:23 +0100, Daniel P. Berrangé wrote:
> > On Mon, Mar 30, 2020 at 02:21:19PM +0200, Andrea Bolognani wrote:
> > > We could still expose the path as something like
> > >
> > > ENV CCACHE_WRAPPERSDIR "/usr/l
On Mon, 2020-03-30 at 13:23 +0100, Daniel P. Berrangé wrote:
> On Mon, Mar 30, 2020 at 02:21:19PM +0200, Andrea Bolognani wrote:
> > We could still expose the path as something like
> >
> > ENV CCACHE_WRAPPERSDIR "/usr/local/share/ccache-wrappers"
> >
> > so that the CI rules would be able to d
Re-adding libvir-list to the CC line.
On Mon, Mar 30, 2020 at 08:20:44PM +0800, Zhenyu Zheng wrote:
> Hi, yes, I think we can do that using inline assembly, I can check it out
> if you think it is a better solution,
> do you have any suggestions for the features(cpu flags) part? It seems that
> A
On Mon, Mar 30, 2020 at 02:21:19PM +0200, Andrea Bolognani wrote:
> On Mon, 2020-03-30 at 12:52 +0100, Daniel P. Berrangé wrote:
> > On Fri, Mar 27, 2020 at 08:34:59PM +0100, Andrea Bolognani wrote:
> > > sys.stdout.write(textwrap.dedent("""
> > > ENV LANG "en_US.UTF-8"
> > >
On Mon, 2020-03-30 at 12:52 +0100, Daniel P. Berrangé wrote:
> On Fri, Mar 27, 2020 at 08:34:59PM +0100, Andrea Bolognani wrote:
> > sys.stdout.write(textwrap.dedent("""
> > ENV LANG "en_US.UTF-8"
> > +ENV PATH "/usr/local/share/ccache-wrappers:$PATH"
>
> I don't
On Mon, Mar 30, 2020 at 02:17:15PM +0200, Andrea Bolognani wrote:
> On Mon, 2020-03-30 at 12:47 +0100, Daniel P. Berrangé wrote:
> > On Fri, Mar 27, 2020 at 08:34:55PM +0100, Andrea Bolognani wrote:
> > > +- name: 'Create ccache wrappers'
> > > + file:
> > > +path: /usr/local/share/ccache-wrap
On Mon, Mar 30, 2020 at 02:11:29PM +0200, Andrea Bolognani wrote:
> On Mon, 2020-03-30 at 12:45 +0100, Daniel P. Berrangé wrote:
> > On Fri, Mar 27, 2020 at 08:34:54PM +0100, Andrea Bolognani wrote:
> > > +export CCACHE_MAXSIZE="2G"
> >
> > I was wondering what a good size for ccache would be. Is
On Mon, Mar 30, 2020 at 12:23:32PM +0200, Michal Prívozník wrote:
On 29. 3. 2020 0:43, Martin Kletzander wrote:
On Wed, Mar 25, 2020 at 02:59:16PM +0100, Michal Prívozník wrote:
On 23. 3. 2020 10:45, Prathamesh Chavan wrote:
Hi Everyone,
Hey!
It's nice to see somebody new interested in libv
On Mon, 2020-03-30 at 12:47 +0100, Daniel P. Berrangé wrote:
> On Fri, Mar 27, 2020 at 08:34:55PM +0100, Andrea Bolognani wrote:
> > +- name: 'Create ccache wrappers'
> > + file:
> > +path: /usr/local/share/ccache-wrappers
> > +state: directory
>
> I weakly suggest "/usr/local/share/ccach
On Mon, 2020-03-30 at 12:45 +0100, Daniel P. Berrangé wrote:
> On Fri, Mar 27, 2020 at 08:34:54PM +0100, Andrea Bolognani wrote:
> > +export CCACHE_MAXSIZE="2G"
>
> I was wondering what a good size for ccache would be. Is there any history
> to why we picked 2G ? Having it too big didn't really m
On Mon, Mar 30, 2020 at 07:32:36PM +0800, Zhenyu Zheng wrote:
> Hi Daniel,
>
> Thanks for thre review and reply, my first implementation was going to
> gather data from /proc/cpuinfo, but unlike X86, we can only get this kind
> of info:
>
> processor : 0
> BogoMIPS: 200.00
> F
On Sat, Mar 28, 2020 at 12:38:57AM +0100, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Add an option to ease setting up a VM with existing libvirt qemu.conf.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1817776
>
> Signed-off-by: Marc-André Lureau
> ---
> docs/
On Fri, Mar 27, 2020 at 08:34:59PM +0100, Andrea Bolognani wrote:
> VM-based builds have used ccache by default for a very long time,
> and now container-based builds will too.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 18 ++
> 1 file changed, 18 insertions(+)
On Fri, Mar 27, 2020 at 08:34:57PM +0100, Andrea Bolognani wrote:
> It's nicer to use, and will make further changes easier.
>
> This commit is better viewed with 'git show -w'.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 29 ++---
> 1 file changed, 14 i
On Fri, Mar 27, 2020 at 08:34:58PM +0100, Andrea Bolognani wrote:
> It's nicer to use, and consistent with how we're building the native
> part of the Dockerfile.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 33 +++--
> 1 file changed, 19 insertions(+)
On Fri, Mar 27, 2020 at 08:34:56PM +0100, Andrea Bolognani wrote:
> It will make further changes easier.
>
> This commit is better viewed with 'git show -w'.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 34 --
> 1 file changed, 16 insertions(+), 1
On Fri, Mar 27, 2020 at 08:34:55PM +0100, Andrea Bolognani wrote:
> Having the wrappers inside $HOME works fine when we have control
> over which user will run the build, as is the case for the current
> Jenkins-based environment, but not when the user is chosen by an
> external entity, as is the c
On Fri, Mar 27, 2020 at 08:34:54PM +0100, Andrea Bolognani wrote:
> We're going to stop creating $HOME/.ccache soon, so we need an
> alternative way to configure ccache; environment variables work
> perfectly fine.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/playbooks/update/tasks/users.y
On Fri, Mar 27, 2020 at 08:34:53PM +0100, Andrea Bolognani wrote:
> Instead of having the same code snippet twice, once for Linux and
> once for FreeBSD, the only actual difference being the name of the
> compiler, include the compiler's path in the inventory among other
> paths and then figure out
On Fri, Mar 27, 2020 at 06:26:27PM +0100, Andrea Bolognani wrote:
> These paths are a reflections of the contents of the container
> image, so it makes sense to expose them in the container's
> environment.
>
> This will allow the GitLab CI integration for both libvirt and
> libosinfo to stop sett
On Fri, Mar 27, 2020 at 06:26:26PM +0100, Andrea Bolognani wrote:
> Some values don't depend on whether the underlying OS user deb or
> rpm as the package format, so we can set them in common code.
>
> Signed-off-by: Andrea Bolognani
> ---
> guests/lcitool | 15 +--
> 1 file changed,
On Fri, Mar 27, 2020 at 06:26:25PM +0100, Andrea Bolognani wrote:
> Figuring them out at runtime is neat, but in practice they don't
> change frequently enough for it to be necessary; more importantly,
> including them in the inventory means we can use them in the
> Dockerfile generator in addition
On Fri, Mar 27, 2020 at 04:51:19PM +0100, Peter Krempa wrote:
> For non-NBD URIs we need to preserve the query part as it may be
> important to refer to the image. If the query doesn't start with
> 'socket=' concatenate it to the name of the image.
I can see that this makes sense for HTTP URIs (an
Hi Daniel,
Thanks for thre review and reply, my first implementation was going to
gather data from /proc/cpuinfo, but unlike X86, we can only get this kind
of info:
processor : 0
BogoMIPS: 200.00
Features: fp asimd evtstrm aes pmull sha1 sha2 crc32 cpuid
CPU implemen
On Fri, Mar 27, 2020 at 04:52:25PM +0800, Zhenyu Zheng wrote:
> Introduce getHost support for ARM, use data from 'lscpu' cmd
> result. 'util-linux/lscpu' provided a very good translation of
> ARM cpu data start from release v2.32, use it directly to avoid
> re-implement the translation.
I'm a bit
On Thu, Mar 26, 2020 at 04:15:15PM +0100, Michal Privoznik wrote:
> So far, libvirt generates the following path for automatic dumps:
>
> $autoDumpPath/$id-$shortName-$timestamp
>
> where $autoDumpPath is where libvirt stores dumps of guests (e.g.
> /var/lib/libvirt/qemu/dump), $id is domain ID
On Thu, Mar 26, 2020 at 04:15:14PM +0100, Michal Privoznik wrote:
> So far, libvirt generates the following path for memory:
>
> $memoryBackingDir/$id-$shortName/ram-nodeN
>
> where $memoryBackingDir is the path where QEMU mmaps() memory for
> the guest (e.g. /var/lib/libvirt/qemu/ram), $id is
On Thu, Mar 26, 2020 at 04:15:13PM +0100, Michal Privoznik wrote:
> So far, libvirt generates the following path for hugepages:
>
> $mnt/libvirt/qemu/$id-$shortName
>
> where $mnt is the mount point of hugetlbfs corresponding to
> hugepages of desired size (e.g. /dev/hugepages), $id is domain I
Since we are refreshing the relative paths when doing the blockjobs we
no longer need to load them upfront when doing the snapshot.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qe
Peter Krempa (2):
qemu: block: Support VIR_DOMAIN_BLOCK_COMMIT/PULL/REBASE_RELATIVE with
blockdev
qemuDomainSnapshotDiskPrepareOne: Don't load the relative path with
blockdev
src/qemu/qemu_block.c | 46 ++
src/qemu/qemu_block.h | 5 +
src
Preservation of the relative relationship requires us to load the
backing store strings from the disk images. With blockdev we stopped
detecting the backing chain if it's specified in the XML so the relative
links were not loaded at that point. To preserve the functionality from
the pre-blockdev wi
On Thu, Mar 26, 2020 at 04:15:11PM +0100, Michal Privoznik wrote:
> Now that we have shiny accessor for driver->embeddedRoot use it
> instead of accessing the struct member directly.
Is this really better ?
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_driver.c | 6 +++---
> src/
On Thu, Mar 26, 2020 at 04:15:12PM +0100, Michal Privoznik wrote:
> This reverts commit 06a19921b6a522cd7b4d352c9320909752947de3.
>
> What I haven't realized when writing this ^^ commit is that the
> virQEMUDriver structure already stores the root directory path.
> And since the pointer is immutab
On Thu, Mar 26, 2020 at 04:15:09PM +0100, Michal Privoznik wrote:
> This function returns embeddedRoot member of the driver
> structure.
>
> Signed-off-by: Michal Privoznik
> Reviewed-by: Andrea Bolognani
> Reviewed-by: Daniel Henrique Barboza
> ---
> src/qemu/qemu_conf.c | 12
>
On 30.03.20 10:02, PRAKHAR BANSAL wrote:
Hi Jan,
On Sat, Mar 28, 2020 at 4:12 AM Jan Kiszka mailto:jan.kis...@web.de>> wrote:
On 28.03.20 08:47, PRAKHAR BANSAL wrote:
> Hi Jan,
>
> Thanks for the reply!
>
> I was only considering the command-line tool "code" for ref
On Thu, Mar 26, 2020 at 04:15:08PM +0100, Michal Privoznik wrote:
> The code that generates "qemu-embed-$hash" is going to be useful
> in more places. Separate it out into a function.
>
> Signed-off-by: Michal Privoznik
> Reviewed-by: Andrea Bolognani
> Reviewed-by: Daniel Henrique Barboza
> --
On Thu, Mar 26, 2020 at 04:15:07PM +0100, Michal Privoznik wrote:
> The virDomainGenerateMachineName() function doesn't belong in
> src/conf/ really, because it has nothing to do with domain XML
> parsing. It landed there because of lack of better place in the
> past. But now that we have src/hyper
On Thu, Mar 26, 2020 at 04:15:06PM +0100, Michal Privoznik wrote:
> Initially introduced in v3.10.0-rc1~172.
>
> When generating a path for memory-backend-file or -mem-path, qemu
> driver will use the following pattern:
>
> $memoryBackingDir/libvirt/qemu/$id-$shortName
>
> where $memoryBacking
On Thu, Mar 26, 2020 at 04:15:05PM +0100, Michal Privoznik wrote:
> The virQEMUDriverConfigNew() accepts path to root directory for
> embed mode as an argument. If the argument is not NULL it uses
> the passed value as prefix for some internal paths (e.g.
> cfg->libDir). If it is NULL though, it lo
On Mon, Mar 30, 2020 at 11:25:00AM +0200, Michal Privoznik wrote:
> While it is impossible for VIR_ALLOC() to return an error, we
> should be consistent with the rest of the code and not continue
> initializing the virSecurityDeviceLabelDef structure.
>
> Signed-off-by: Michal Privoznik
> ---
>
On Sun, Mar 29, 2020 at 5:13 AM Martin Kletzander wrote:
>
> On Wed, Mar 25, 2020 at 02:59:16PM +0100, Michal Prívozník wrote:
> >On 23. 3. 2020 10:45, Prathamesh Chavan wrote:
> >> Hi Everyone,
> >
> >Hey!
> >
> >It's nice to see somebody new interested in libvirt.
> >
> >>
> >> I'm Prathamesh Ch
On Mon, Mar 30, 2020 at 11:24:58AM +0200, Michal Privoznik wrote:
> Unfortunately, yajl_free() is not NOP on NULL. It really does
> expect a valid pointer. Therefore, check whether the pointer we
> want to pass to it is NULL or not.
>
> Signed-off-by: Michal Privoznik
> ---
> src/util/virjson.c
On Mon, Mar 30, 2020 at 11:24:59AM +0200, Michal Privoznik wrote:
> Even with GLib it is still possible for virQEMUCapsNew() to
> return NULL because it calls virQEMUCapsInitialize() which is a
> wrapper over pthread_once() which may fail. At least, we still
> check for its retval. If it so happens
On Sun, Mar 29, 2020 at 02:33:41PM +0300, nshirokovskiy wrote:
>
>
> On 26.03.2020 20:50, Daniel P. Berrangé wrote:
> > On Fri, Feb 28, 2020 at 10:09:41AM +0300, Nikolay Shirokovskiy wrote:
> >> On 27.02.2020 16:48, Daniel P. Berrangé wrote:
> >>> On Thu, Feb 27, 2020 at 03:57:04PM +0300, Nikolay
On 29. 3. 2020 9:30, Radostin Stoyanov wrote:
> Support for Python 2.X has been dropped with commit b22e4f2.
>
> Signed-off-by: Radostin Stoyanov
> ---
> tox.ini | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Michal Privoznik
and pushed.
Michal
On Mon, Mar 30, 2020 at 12:11:19PM +0200, Andrea Bolognani wrote:
> On Fri, 2020-03-27 at 17:20 +, Daniel P. Berrangé wrote:
> > On Fri, Mar 27, 2020 at 03:59:51PM +0100, Andrea Bolognani wrote:
> > > Another question is, once we start doing cascading builds, what to do
> > > with stuff like (f
On 29. 3. 2020 0:43, Martin Kletzander wrote:
> On Wed, Mar 25, 2020 at 02:59:16PM +0100, Michal Prívozník wrote:
>> On 23. 3. 2020 10:45, Prathamesh Chavan wrote:
>>> Hi Everyone,
>>
>> Hey!
>>
>> It's nice to see somebody new interested in libvirt.
>>
>>>
>>> I'm Prathamesh Chavan, a final year s
On Freitag, 27. März 2020 18:16:37 CEST Ján Tomko wrote:
> On a Friday in 2020, Christian Schoenebeck wrote:
> >This option prevents misbehaviours on guest if a qemu 9pfs export
> >contains multiple devices, due to the potential file ID collisions
> >this otherwise may cause.
> >
> >Signed-off-by:
On Fri, 2020-03-27 at 17:20 +, Daniel P. Berrangé wrote:
> On Fri, Mar 27, 2020 at 03:59:51PM +0100, Andrea Bolognani wrote:
> > Another question is, once we start doing cascading builds, what to do
> > with stuff like (from the .bashrc template used by lcitool)
>
> I don't think we will do ca
On Fri, Mar 27, 2020 at 16:51:20 +0100, Peter Krempa wrote:
> Look for the questionmark in the name and move the contents into the
> query portion so that we format the URI back properly.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_block.c | 6 ++
> 1 file changed, 6 insertions(+)
Even with GLib it is still possible for virQEMUCapsNew() to
return NULL because it calls virQEMUCapsInitialize() which is a
wrapper over pthread_once() which may fail. At least, we still
check for its retval. If it so happens that the virQEMUCapsNew()
fails and returns NULL, we should not dereferen
Unfortunately, yajl_free() is not NOP on NULL. It really does
expect a valid pointer. Therefore, check whether the pointer we
want to pass to it is NULL or not.
Signed-off-by: Michal Privoznik
---
src/util/virjson.c | 2 +-
tools/nss/libvirt_nss_leases.c | 3 ++-
tools/nss/libvirt_ns
While it is impossible for VIR_ALLOC() to return an error, we
should be consistent with the rest of the code and not continue
initializing the virSecurityDeviceLabelDef structure.
Signed-off-by: Michal Privoznik
---
src/util/virseclabel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
*** BLURB HERE ***
Michal Prívozník (3):
Don't pass NULL to yajl_free()
virQEMUCapsNewBinary: Avoid NULL dereference
virSecurityDeviceLabelDefNew: Avoid NULL dereference
src/qemu/qemu_capabilities.c | 3 ++-
src/util/virjson.c | 2 +-
src/util/virseclabel.c | 2 +-
to
On Fri, Mar 27, 2020 at 08:40:31PM +0100, Andrea Bolognani wrote:
> On Fri, 2020-03-27 at 16:52 +0100, Michal Prívozník wrote:
> > On 27. 3. 2020 16:42, Daniel P. Berrangé wrote:
> > > > > +if (priv->escapeChar[0] == '^') {
> > > > > +vshPrintExtra(ctl, " (Ctrl + %c)", priv->escapeChar[
On Fri, 2020-03-27 at 21:17 +0100, Jiri Denemark wrote:
> The documentation could confuse people to expect that CPU models with
> usable='no' attribute are not usable at all on the current host. But
> they cannot be only used without explicitly disabling some features.
>
> Signed-off-by: Jiri Dene
On 27. 3. 2020 18:40, Rafael Fonseca wrote:
> The daemons are not supported on Win32 and therefore were not compiled
> in that platform. However, with the daemon code sharing, all the code in
> utils *is* compiled and it failed because `waitpid`, `fork`, and
> `setsid` are not available. So, as bef
Hi Jan,
On Sat, Mar 28, 2020 at 4:12 AM Jan Kiszka wrote:
> On 28.03.20 08:47, PRAKHAR BANSAL wrote:
> > Hi Jan,
> >
> > Thanks for the reply!
> >
> > I was only considering the command-line tool "code" for reference to the
> > Jailhouse kernel API(ioctl calls) because I didn't find a documentat
On Fri, 2020-03-27 at 14:15 +0100, Peter Krempa wrote:
> - review is terrible
> - threads are only single level
> - response can't be quoted (okay, they can but you have to copy and
> pase what you want to quote and then select that it's a quote)
FYI, you can just select the part you
94 matches
Mail list logo
