Re: [PATCH] qemu_cgroup.c: use VIR_AUTOSTRINGLIST, g_autofree and g_autoptr

2020-03-31 Thread Daniel Henrique Barboza
On 3/31/20 12:44 PM, Seeteena Thoufeek wrote: Signed-off-by: Seeteena Thoufeek --- Reviewed-by: Daniel Henrique Barboza

Re: [GSoC][RFC] Project Proposal: "Introducing Job control to the storage driver"

2020-03-31 Thread Prathamesh Chavan
On Tue, Mar 31, 2020 at 9:34 PM Michal Prívozník wrote: > > On 31. 3. 2020 17:35, Prathamesh Chavan wrote: > > On Tue, Mar 31, 2020 at 3:20 PM Michal Prívozník > > wrote: > >> > >> On 31. 3. 2020 2:27, Prathamesh Chavan wrote: > >>> GSoC Proposal - 2020 > >>> > >> > >> Looks

[PATCH v3 09/10] qemu: Make memory path generation embed driver aware

2020-03-31 Thread Michal Privoznik
So far, libvirt generates the following path for memory: $memoryBackingDir/$id-$shortName/ram-nodeN where $memoryBackingDir is the path where QEMU mmaps() memory for the guest (e.g. /var/lib/libvirt/qemu/ram), $id is domain ID and $shortName is shortened version of domain name. So for instance,

[PATCH v3 10/10] qemu: Make auto dump path generation embed driver aware

2020-03-31 Thread Michal Privoznik
So far, libvirt generates the following path for automatic dumps: $autoDumpPath/$id-$shortName-$timestamp where $autoDumpPath is where libvirt stores dumps of guests (e.g. /var/lib/libvirt/qemu/dump), $id is domain ID and $shortName is shortened version of domain name. So for instance, the gene

[PATCH v3 05/10] virDomainDriverGenerateMachineName: Factor out embed path hashing

2020-03-31 Thread Michal Privoznik
The code that generates "qemu-embed-$hash" is going to be useful in more places. Separate it out into a function. Signed-off-by: Michal Privoznik Reviewed-by: Andrea Bolognani Reviewed-by: Daniel Henrique Barboza Reviewed-by: Daniel P. Berrangé --- src/hypervisor/domain_driver.c | 42

[PATCH v3 00/10] Another round of qemu:///embed fixes

2020-03-31 Thread Michal Privoznik
v3 of: https://www.redhat.com/archives/libvir-list/2020-March/msg01112.html diff to v2: - Patch 2/10 is new; after discussion to v2 we can access driver->privileged and driver->embeddedRoot directly - Patch 3/10 is slightly reworked; it still drops unnecessary layers of nesting in the default

[PATCH v3 06/10] qemuDomainGetMachineName: Access embeddedRoot from driver rather than cfg

2020-03-31 Thread Michal Privoznik
The cfg->root is going away, therefore get the info right from the driver structure. Signed-off-by: Michal Privoznik Reviewed-by: Andrea Bolognani Reviewed-by: Daniel Henrique Barboza Reviewed-by: Daniel P. Berrangé --- src/qemu/qemu_domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[PATCH v3 08/10] qemu: Make hugepages path generation embed driver aware

2020-03-31 Thread Michal Privoznik
So far, libvirt generates the following path for hugepages: $mnt/libvirt/qemu/$id-$shortName where $mnt is the mount point of hugetlbfs corresponding to hugepages of desired size (e.g. /dev/hugepages), $id is domain ID and $shortName is shortened version of domain name. So for instance, the gen

[PATCH v3 07/10] Revert "qemu_conf: Track embed root dir"

2020-03-31 Thread Michal Privoznik
This reverts commit 06a19921b6a522cd7b4d352c9320909752947de3. What I haven't realized when writing this ^^ commit is that the virQEMUDriver structure already stores the root directory path. And since the pointer is immutable it can be accessed right from the structure and thus there is no need to

[PATCH v3 04/10] conf: Move virDomainGenerateMachineName to hypervisor/

2020-03-31 Thread Michal Privoznik
The virDomainGenerateMachineName() function doesn't belong in src/conf/ really, because it has nothing to do with domain XML parsing. It landed there because of lack of better place in the past. But now that we have src/hypervisor/ the function should live there. At the same time, the function name

[PATCH v3 03/10] qemu: Drop two layers of nesting of memoryBackingDir

2020-03-31 Thread Michal Privoznik
Initially introduced in v3.10.0-rc1~172. When generating a path for memory-backend-file or -mem-path, qemu driver will use the following pattern: $memoryBackingDir/libvirt/qemu/$id-$shortName where $memoryBackingDir defaults to /var/lib/libvirt/qemu/ram but can be overridden in qemu.conf. Anyw

[PATCH v3 01/10] tests: Fix virQEMUDriverConfigNew() calling with respect to @root

2020-03-31 Thread Michal Privoznik
The virQEMUDriverConfigNew() accepts path to root directory for embed mode as an argument. If the argument is not NULL it uses the passed value as prefix for some internal paths (e.g. cfg->libDir). If it is NULL though, it looks if the other argument, @privileged is true or false and generates inte

[PATCH v3 02/10] qemu: Drop virQEMUDriverIsPrivileged()

2020-03-31 Thread Michal Privoznik
Introduced in v1.2.17-rc1~121, the assumption was that the driver->privileged is immutable at the time but it might change in the future. Well, it did not ever since. It is still immutable variable. Drop the needless accessor then. Signed-off-by: Michal Privoznik --- src/qemu/qemu_cgroup.c|

Re: [GSoC][RFC] Project Proposal: "Introducing Job control to the storage driver"

2020-03-31 Thread Michal Prívozník
On 31. 3. 2020 17:35, Prathamesh Chavan wrote: > On Tue, Mar 31, 2020 at 3:20 PM Michal Prívozník wrote: >> >> On 31. 3. 2020 2:27, Prathamesh Chavan wrote: >>> GSoC Proposal - 2020 >>> >> >> Looks good. It's visible that you've already participated in GSoC >> previously. Just

Re: On the need to move to a merge request workflow

2020-03-31 Thread Ján Tomko
On a Friday in 2020, Daniel P. Berrangé wrote: On Fri, Mar 27, 2020 at 02:15:01PM +0100, Peter Krempa wrote: On Thu, Mar 26, 2020 at 15:50:20 +, Daniel Berrange wrote: > On Thu, Mar 26, 2020 at 02:10:59PM +0100, Peter Krempa wrote: > > On Fri, Mar 06, 2020 at 11:44:07 +, Daniel Berrange

Re: GSoC'20 Interested Student: Adding support to Jailhouse Hypervisor

2020-03-31 Thread PRAKHAR BANSAL
Hi Jan, I have shared the draft proposal link with libvirt on GSoC's system. Could you please check and provide your feedback, if possible. Thanks, Prakhar On Tue, Mar 31, 2020 at 1:47 AM Jan Kiszka wrote: > On 31.03.20 04:43, PRAKHAR BANSAL wrote: > > Hi Jan, > > > > Thanks for the confirmati

[PATCH] qemu_cgroup.c: use VIR_AUTOSTRINGLIST, g_autofree and g_autoptr

2020-03-31 Thread Seeteena Thoufeek
Signed-off-by: Seeteena Thoufeek --- src/qemu/qemu_cgroup.c | 91 +++--- 1 file changed, 35 insertions(+), 56 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index c0e30f6..d34c515 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src

Re: [libvirt-jenkins-ci PATCH 5/5] guests: lcitool: Enable the new 'gitlab' flavor in the lcitool script

2020-03-31 Thread Andrea Bolognani
On Thu, 2020-03-26 at 14:33 +0100, Erik Skultety wrote: > +++ b/guests/lcitool > +def get_gitlab_runner_token_file(self): > +gitlab_runner_token_file = > self._get_config_file("gitlab-runner-token") > + > +try: > +with open(gitlab_runner_token_file, "r") as infile:

Re: [libvirt-jenkins-ci PATCH 4/5] playbooks: gitlab: Force a random password for the root account

2020-03-31 Thread Andrea Bolognani
On Thu, 2020-03-26 at 14:33 +0100, Erik Skultety wrote: > Unlike with the 'test' flavour, where the 'test' user has sudo > permissions on the system, with machines set up with the 'gitlab' > flavour which are intended to contact the outside world which, we don't > want that. More importantly though

Re: [GSoC][RFC] Project Proposal: "Introducing Job control to the storage driver"

2020-03-31 Thread Prathamesh Chavan
On Tue, Mar 31, 2020 at 3:20 PM Michal Prívozník wrote: > > On 31. 3. 2020 2:27, Prathamesh Chavan wrote: > > GSoC Proposal - 2020 > > > > Looks good. It's visible that you've already participated in GSoC > previously. Just don't forget to make it final. The deadline is in ~8

Re: [libvirt-jenkins-ci PATCH 3/5] guests: Introduce the new 'gitlab' flavor

2020-03-31 Thread Andrea Bolognani
On Thu, 2020-03-26 at 14:33 +0100, Erik Skultety wrote: > +++ b/guests/group_vars/all/main.yml > @@ -5,3 +5,6 @@ > ansible_ssh_pass: root > > jenkins_url: https://ci.centos.org/computer/{{ inventory_hostname > }}/slave-agent.jnlp > + > +# In our case, ansible_system is either Linux or FreeBSD

Re: [libvirt-jenkins-ci PATCH 2/5] guests: templates: Introduce a gitlab-runner RC init service template

2020-03-31 Thread Andrea Bolognani
On Thu, 2020-03-26 at 14:33 +0100, Erik Skultety wrote: > guests: templates: Introduce a gitlab-runner RC init service template "RC init" is sort of a loaded term, I'd just call out FreeBSD directly. > +++ b/guests/playbooks/update/templates/gitlab-runner.j2 > @@ -0,0 +1,32 @@ > +#!/bin/sh > +# P

Re: [libvirt-jenkins-ci PATCH 1/5] guests: templates: Introduce a gitlab-runner systemd service template

2020-03-31 Thread Andrea Bolognani
On Thu, 2020-03-26 at 14:33 +0100, Erik Skultety wrote: > +++ b/guests/playbooks/update/templates/gitlab-runner.service.j2 > @@ -0,0 +1,12 @@ > +[Unit] > +Description=GitLab Runner > +After=network.target > +ConditionFileIsExecutable=/usr/local/bin/gitlab-runner > + > +[Service] > +ExecStart=/usr/l

[libvirt-jenkins-ci PATCH] guests: allow for container image inheritance

2020-03-31 Thread Daniel P . Berrangé
Currently when creating a Dockerfile for a container, we include the full set of base packages, along with the packages for the project itself. If building a Perl binding, this would require us to install the base package, libvirt packages and Perl packages. With the use of the "--inherit libvirt-f

[libvirt-go-xml PATCH 2/2] travis: delete CI configuration

2020-03-31 Thread Daniel P . Berrangé
We are standardizing on GitLab, so no longer need to run CI tests on Travis. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 13 - 1 file changed, 13 deletions(-) delete mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index f3396ba..0

[libvirt-go-xml PATCH 0/2] Switch CI from Travis to GitLab

2020-03-31 Thread Daniel P . Berrangé
Daniel P. Berrangé (2): gitlab: add CI definition for GitLab travis: delete CI configuration .gitlab-ci.yml | 25 + .travis.yml| 13 - README.md | 2 +- 3 files changed, 26 insertions(+), 14 deletions(-) create mode 100644 .gitlab-ci.yml dele

[libvirt-go-xml PATCH 1/2] gitlab: add CI definition for GitLab

2020-03-31 Thread Daniel P . Berrangé
We want to test against a variety of Go versions to validate that there are not any incompatibilities in XML parser handling between versions. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 25 + README.md | 2 +- 2 files changed, 26 insertions(+), 1 deletio

Re: [libvirt PATCH] travis: delete all Linux jobs

2020-03-31 Thread Daniel P . Berrangé
On Tue, Mar 31, 2020 at 02:21:00PM +0200, Andrea Bolognani wrote: > On Mon, 2020-03-30 at 18:12 +0100, Daniel P. Berrangé wrote: > > On Mon, Mar 30, 2020 at 07:05:26PM +0200, Andrea Bolognani wrote: > > > My only concern is that our ci/Makefile scaffolding will bitrot now > > > that it will no long

Re: [libvirt PATCH] travis: delete all Linux jobs

2020-03-31 Thread Andrea Bolognani
On Mon, 2020-03-30 at 18:12 +0100, Daniel P. Berrangé wrote: > On Mon, Mar 30, 2020 at 07:05:26PM +0200, Andrea Bolognani wrote: > > My only concern is that our ci/Makefile scaffolding will bitrot now > > that it will no longer be exercised directly through CI... Perhaps we > > could leave a single

Re: [PATCH] Add blog for ARM Datacenter Project.

2020-03-31 Thread Robert Foley
Fantastic, thank you. Regards, -Rob On Tue, 31 Mar 2020 at 04:43, Daniel P. Berrangé wrote: > > On Mon, Mar 30, 2020 at 02:39:36PM -0400, Robert Foley wrote: > > Our blog covers QEMU topics. > > > > Signed-off-by: Robert Foley > > --- > > updater/virt-tools/config.ini | 3 +++ > > 1 file chang

[virttools-web PATCH 2/3] Introduce use of GitLab CI for publishing to GitLab Pages

2020-03-31 Thread Daniel P . Berrangé
To publish to GitLab pages, all that is required is to provide a CI job that creates files in a directory called "public" and list that as an artifact. When the CI job completes, the website is immediately available at the URL https://username.gitlab.io/reponame. This makes it much easier to prev

[virttools-web PATCH 1/3] Convert README to markdown format

2020-03-31 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- README| 19 --- README.md | 21 + 2 files changed, 21 insertions(+), 19 deletions(-) delete mode 100644 README create mode 100644 README.md diff --git a/README b/README deleted file mode 100644 index 9126ab1..000

[virttools-web PATCH 3/3] Remove obsolete openshift hosting configuration

2020-03-31 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- openshift/templates/.gitignore | 2 - openshift/templates/update-tls.sh | 16 -- openshift/templates/virttools-web-tls.json | 82 --- openshift/templates/virttools-web.json | 272 - 4 files changed, 372 del

[virttools-web PATCH 0/3] Switch www.virt-tools.org over to use GitLab Pages

2020-03-31 Thread Daniel P . Berrangé
This introduces use of GitLab CI + Pages to replace the current OpenShift application which is only admin accessible by myself. It also has automatic integration with LetsEncrypt guaranteeing that we'll never have expired certificates. Daniel P. Berrangé (3): Convert README to markdown format

[virttools-planet PATCH 4/4] Drop Amit Shah and Nathan Gauër

2020-03-31 Thread Daniel P . Berrangé
Both these feeds are returning errors due to moved URLs. In addition the sites have not been updated with any virtualization related content for several years. Signed-off-by: Daniel P. Berrangé --- virt-tools/config.ini | 6 -- 1 file changed, 6 deletions(-) diff --git a/virt-tools/config.i

[virttools-planet PATCH 3/4] Remove obsolete openshift hosting configuration

2020-03-31 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- openshift/templates/.gitignore| 2 - openshift/templates/update-tls.sh | 16 - openshift/templates/virttools-planet-tls.json | 82 openshift/templates/virttools-planet.json | 425 -- web/httpd-cfg/cors.

[virttools-planet PATCH 0/4] Switch planet.virt-tools.org over to use GitLab Pages

2020-03-31 Thread Daniel P . Berrangé
This introduces use of GitLab CI + Pages to replace the current OpenShift application which is only admin accessible by myself. It also has automatic integration with LetsEncrypt guaranteeing that we'll never have expired certificates. Daniel P. Berrangé (4): Convert README to markdown format

[virttools-planet PATCH 2/4] Introduce use of GitLab CI for publishing to GitLab Pages

2020-03-31 Thread Daniel P . Berrangé
To publish to GitLab pages, all that is required is to provide a CI job that creates files in a directory called "public" and list that as an artifact. When the CI job completes, the website is immediately available at the URL https://username.gitlab.io/reponame. This makes it much easier to prev

[virttools-planet PATCH 1/4] Convert README to markdown format

2020-03-31 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- README| 39 --- README.md | 47 +++ 2 files changed, 47 insertions(+), 39 deletions(-) delete mode 100644 README create mode 100644 README.md diff --git a/README b/README d

Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

2020-03-31 Thread Peter Krempa
On Tue, Mar 31, 2020 at 11:18:29 +0200, Pavel Mores wrote: > Works by blockcommitting the snapshot to be deleted into its parent. Handles > both deleting children as well and deleting children only (commits the > children into the snapshot referred to by snapshot-delete argument). If the > necess

Re: [GSoC][RPC] Project Proposal: "Introducing Job control to the storage driver"

2020-03-31 Thread Michal Prívozník
On 31. 3. 2020 2:27, Prathamesh Chavan wrote: > GSoC Proposal - 2020 > Looks good. It's visible that you've already participated in GSoC previously. Just don't forget to make it final. The deadline is in ~8 hours. Michal

[libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

2020-03-31 Thread Pavel Mores
Works by blockcommitting the snapshot to be deleted into its parent. Handles both deleting children as well and deleting children only (commits the children into the snapshot referred to by snapshot-delete argument). If the necessary block commit operation turns out to be active (the snapshot ref

[libvirt PATCH 0/3] qemu: block: basic implementation of deletion of external snapshots

2020-03-31 Thread Pavel Mores
Deleting external snapshots has been unimplemented so far. This series aims to enable limited functionality in that direction, handling just the common cases for now. The intention is to subsequently build upon this to eventually cover the more complex/exotic cases as well. Please refer to the c

[libvirt PATCH 2/3] qemu: block: factor implementation out of qemuDomainBlockJobAbort()

2020-03-31 Thread Pavel Mores
As with the previous commit, this should primarily make qemuDomainBlockJobAbort() callable from within the QEMU driver. Signed-off-by: Pavel Mores --- src/qemu/qemu_driver.c | 62 -- 1 file changed, 41 insertions(+), 21 deletions(-) diff --git a/src/qemu/

[libvirt PATCH 1/3] qemu: block: factor implementation out of qemuDomainBlockCommit()

2020-03-31 Thread Pavel Mores
The idea is to make block commit callable from within the QEMU driver. Signed-off-by: Pavel Mores --- src/qemu/qemu_driver.c | 84 +++--- 1 file changed, 55 insertions(+), 29 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e9a6

[PATCH] Add blog for ARM Datacenter Project.

2020-03-31 Thread Robert Foley
Our blog covers QEMU topics. Signed-off-by: Robert Foley --- updater/virt-tools/config.ini | 3 +++ 1 file changed, 3 insertions(+) diff --git a/updater/virt-tools/config.ini b/updater/virt-tools/config.ini index 9375c82..4e53029 100644 --- a/updater/virt-tools/config.ini +++ b/updater/virt-too

Re: [PATCH] Add blog for ARM Datacenter Project.

2020-03-31 Thread Daniel P . Berrangé
On Mon, Mar 30, 2020 at 02:39:36PM -0400, Robert Foley wrote: > Our blog covers QEMU topics. > > Signed-off-by: Robert Foley > --- > updater/virt-tools/config.ini | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Daniel P. Berrangé It is pushed and will be live within the next hour Re