[PATCH] libxl: fix crash when initializing driver

Commit 54a401af478 split out DriverConfigInit from DriverConfigNew, but then called it a bit late from libxlStateInitialize. The cfg is used in libxlDriverConfigLoadFile and when uninitialized results in a crash. Calling DriverConfigInit immediately after DriverConfigNew fixes the crash. Signed-of

[PATCH v5 1/7] sheepdog: Add trivial backing_fmt support

Sheepdog already requires that if backing_file is present, that it be another sheepdog image (see sd_co_create). Meanwhile, we want to move towards always being explicit about the backing format for other drivers where it matters. So for convenience, make qemu-img create -F sheepdog work, while r

[PATCH v5 6/7] block: Add support to warn on backing file change without format

For now, this is a mechanical addition; all callers pass false. But the next patch will use it to improve 'qemu-img rebase -u' when selecting a backing file with no format. Signed-off-by: Eric Blake Reviewed-by: Peter Krempa Reviewed-by: Ján Tomko --- include/block/block.h | 4 ++-- block.c

[PATCH v5 7/7] qemu-img: Deprecate use of -b without -F

Creating an image that requires format probing of the backing image is inherently unsafe (we've had several CVEs over the years based on probes leaking information to the guest on a subsequent boot, although these days tools like libvirt are aware of the issue enough to prevent the worst effects).

[PATCH v5 2/7] vmdk: Add trivial backing_fmt support

vmdk already requires that if backing_file is present, that it be another vmdk image (see vmdk_co_do_create). Meanwhile, we want to move towards always being explicit about the backing format for other drivers where it matters. So for convenience, make qemu-img create -F vmdk work, while rejectin

[PATCH v5 4/7] qcow2: Deprecate use of qemu-img amend to change backing file

The use of 'qemu-img amend' to change qcow2 backing files is not tested very well. In particular, our implementation has a bug where if a new backing file is provided without a format, then the prior format is blindly reused, even if this results in data corruption, but this is not caught by iotes

[PATCH v5 3/7] qcow: Tolerate backing_fmt=, but warn on backing_fmt=raw

qcow has no space in the metadata to store a backing format, and there are existing qcow images backed both by raw or by other formats (usually qcow) images, reliant on probing to tell the difference. While we don't recommend the creation of new qcow images (as qcow2 is hands-down better), we can a

[PATCH v5 for-5.0? 0/7] Tighten qemu-img rules on missing backing format

v4 was here: https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg03775.html In v5: - fix 'qemu-img convert -B' to actually warn [Kashyap] - squash in followups - a couple more iotest improvements If we decide this is not 5.0 material, then patches 4 and 7 need a tweak to s/5.0/5.1/ as the sta

Re: [libvirt PATCH] github: enable lockdown of issues and merge requests

On a Friday in 2020, Andrea Bolognani wrote: On Fri, 2020-04-03 at 11:38 +0100, Daniel P. Berrangé wrote: +++ b/.github/lockdown.yml @@ -0,0 +1,36 @@ +pulls: + comment: | +Thank you for your interest in the libvirt project. + +Since this repository is a read-only mirror of the project's

Re: [libvirt PATCH] github: enable lockdown of issues and merge requests

On Fri, 2020-04-03 at 11:38 +0100, Daniel P. Berrangé wrote: > +++ b/.github/lockdown.yml > @@ -0,0 +1,36 @@ > +pulls: > + comment: | > +Thank you for your interest in the libvirt project. > + > +Since this repository is a read-only mirror of the project's > master repostory hosted on

Re: [PATCH 01/36] util: virresctrl: convert classes to GObject

On Fri, Apr 03, 2020 at 07:02:17PM +0200, Rafael Fonseca wrote: > On Fri, Apr 3, 2020 at 5:51 PM Rafael Fonseca wrote: > > > > Anyway I'll replace them by g_clear_object. Tks. > > Is it ok if I wait to collect more feedback before sending a v2 with > 's/if (...) g_object_unref/g_clear_object/'?

Re: [PATCH 01/36] util: virresctrl: convert classes to GObject

On Fri, Apr 3, 2020 at 5:51 PM Rafael Fonseca wrote: > > Anyway I'll replace them by g_clear_object. Tks. Is it ok if I wait to collect more feedback before sending a v2 with 's/if (...) g_object_unref/g_clear_object/'? Att. -- Rafael Fonseca

Re: [PATCH v3 0/3] add support for QEMU 9pfs 'multidevs' option

On Freitag, 3. April 2020 18:27:28 CEST you wrote: > On a Friday in 2020, Christian Schoenebeck wrote: > >On Montag, 30. März 2020 20:27:00 CEST Christian Schoenebeck wrote: > >> v2->v3: > >> * Rebased to master (SHA-1 e4bf03b8ff). > >> > >> * Auto sense QEMU capability for command line opti

Re: [PATCH v3 0/3] add support for QEMU 9pfs 'multidevs' option

On Montag, 30. März 2020 20:27:00 CEST Christian Schoenebeck wrote: > v2->v3: > > * Rebased to master (SHA-1 e4bf03b8ff). > > * Auto sense QEMU capability for command line option fsdev.multidevs > instead of checking for QEMU version 4.2. [patch 1] > > * Auto regenerated capabilities d

Re: [PATCH v3 0/3] add support for QEMU 9pfs 'multidevs' option

On a Friday in 2020, Christian Schoenebeck wrote: On Montag, 30. März 2020 20:27:00 CEST Christian Schoenebeck wrote: v2->v3: * Rebased to master (SHA-1 e4bf03b8ff). * Auto sense QEMU capability for command line option fsdev.multidevs instead of checking for QEMU version 4.2. [patch 1]

Re: [libvirt-jenkins-ci PATCH 2/5] guests: templates: Introduce a gitlab-runner RC init service template

Looks like I somehow sent an empty reply by mistake the first time around. Let's try again... On Fri, 2020-04-03 at 16:04 +0200, Erik Skultety wrote: > On Fri, Apr 03, 2020 at 03:50:21PM +0200, Andrea Bolognani wrote: > > I have tested this, though not extensively, on Linux and adding > > User=git

Re: [PATCH] cpu.c: Use g_autoptr and g_autofree in virCPUDataParse

cpu: Use g_autoptr and g_autofree in virCPUDataParse The first part says which driver/area the patch touches, no need to put an extension there. On a Friday in 2020, Seeteena Thoufeek wrote: Signed-off-by: Seeteena Thoufeek --- src/cpu/cpu.c | 18 +++--- 1 file changed, 7 insertions

Re: [PATCH 00/36] convert virObjects to GObject

On Fri, Apr 03, 2020 at 05:15:28PM +0200, Rafael Fonseca wrote: > This patch series convert various simple instances of virObject to a > GObject equivalent. > > virDomain is still WIP because it causes some linking problem I am still > investigating. > > virObjects that work as parent class to ot

Re: [libvirt-jenkins-ci PATCH 2/5] guests: templates: Introduce a gitlab-runner RC init service template

On Fri, 2020-04-03 at 16:04 +0200, Erik Skultety wrote: > On Fri, Apr 03, 2020 at 03:50:21PM +0200, Andrea Bolognani wrote: > > On Fri, 2020-04-03 at 09:21 +0200, Erik Skultety wrote: > > > On Tue, Mar 31, 2020 at 04:42:10PM +0200, Andrea Bolognani wrote: > > > > On Thu, 2020-03-26 at 14:33 +0100,

[PATCH 1/3] selinux: Don't remember label for restore path

The seclabel for @stdin_path in virSecuritySELinuxSetAllLabel() is not restored, because at virSecuritySELinuxRestoreAllLabel() phase it's too late and the caller (QEMU driver) simply doesn't care. Well, don't remember the label and let the perms leak. Signed-off-by: Michal Privoznik --- src/sec

[PATCH 0/3] qemu: Fix restoring a domain from a block device

*** BLURB HERE *** Michal Prívozník (3): selinux: Don't remember label for restore path security: Introduce virSecurityManagerDomainSetIncomingPathLabel qemu: Label restore path outside of secdriver transactions src/libvirt_private.syms| 1 + src/qemu/qemu_security.c| 7 +

[PATCH 3/3] qemu: Label restore path outside of secdriver transactions

As explained in the previous commit, we need to relabel the file we are restoring the domain from. That is the FD that is passed to QEMU. If the file is not under /dev then the file inside the namespace is the very same as the one in the host. And regardless of using transactions, the file will be

[PATCH 2/3] security: Introduce virSecurityManagerDomainSetIncomingPathLabel

This API allows drivers to separate out handling of @stdin_path of virSecurityManagerSetAllLabel(). The thing is, the QEMU driver uses transactions for virSecurityManagerSetAllLabel() which relabels devices from inside of domain's namespace. This is what we usually want. Except when resuming domain

Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

On Tue, Mar 31, 2020 at 12:06:15PM +0200, Peter Krempa wrote: > On Tue, Mar 31, 2020 at 11:18:29 +0200, Pavel Mores wrote: > > +} > > + > > +if (flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN) > > +topPath = disk->src->path; > > +else > > +

Re: [PATCH 01/36] util: virresctrl: convert classes to GObject

On Fri, Apr 3, 2020 at 5:37 PM Peter Krempa wrote: > > On Fri, Apr 03, 2020 at 17:15:29 +0200, Rafael Fonseca wrote: > > Signed-off-by: Rafael Fonseca > > --- > > src/conf/capabilities.c | 3 +- > > src/conf/domain_conf.c | 21 +++--- > > src/util/virresctrl.c | 137 ++-

Re: [PATCH 2/4] conf: domain: support for virtio packed option

On a Thursday in 2020, Bjoern Walk wrote: Expose the virtio parameter for packed virtqueues as a optional libvirt XML s/a optional/an optional/ attribute to virtio-backed devices, e.g.: If the attribute is omitted, the default value for this attribute is 'off' and

Re: [PATCH 3/4] qemu: command: support for virtio packed option

On a Thursday in 2020, Bjoern Walk wrote: Pass the packed option on the QEMU command line of the capability for packed virtqueues is detected and the parameter is set explicitly. Signed-off-by: Bjoern Walk --- src/qemu/qemu_command.c| 10 +++ tests/qemuxml2argvdata/virtio

Re: [PATCH 1/4] qemu: capabilities: add 'packed' capability

On a Thursday in 2020, Bjoern Walk wrote: Add the capability for QEMU's packed virtqueues for virtio that supposedly have better cache utilization and performance compared to the default split queues. Signed-off-by: Bjoern Walk --- src/qemu/qemu_capabilities.c | 6 ++ sr

Re: [PATCH 01/36] util: virresctrl: convert classes to GObject

On Fri, Apr 03, 2020 at 17:15:29 +0200, Rafael Fonseca wrote: > Signed-off-by: Rafael Fonseca > --- > src/conf/capabilities.c | 3 +- > src/conf/domain_conf.c | 21 +++--- > src/util/virresctrl.c | 137 ++-- > src/util/virresctrl.h | 15 +++-- > tests/

Re: [libvirt-jenkins-ci PATCH 4/5] playbooks: gitlab: Force a random password for the root account

On Fri, 2020-04-03 at 09:43 +0200, Erik Skultety wrote: > On Tue, Mar 31, 2020 at 05:39:45PM +0200, Andrea Bolognani wrote: > > On Thu, 2020-03-26 at 14:33 +0100, Erik Skultety wrote: > > > Unlike with the 'test' flavour, where the 'test' user has sudo > > > permissions on the system, with machines

[PATCH 36/36] util: convert virStorageSource to GObject

Signed-off-by: Rafael Fonseca --- src/qemu/qemu_blockjob.c | 71 ++- src/qemu/qemu_domain.c| 13 +++ src/util/virstoragefile.c | 41 +++--- src/util/virstoragefile.h | 6 ++-- 4 files changed, 65 insertions(+), 66 deletions(-) diff --

[PATCH 24/36] datatypes: convert virNodeDevice to GObject

Signed-off-by: Rafael Fonseca --- src/conf/node_device_event.c | 9 +++- src/conf/node_device_util.c | 4 ++-- src/conf/virnodedeviceobj.c | 10 ++-- src/datatypes.c | 44 ++-- src/datatypes.h | 14 +++- src/libvirt-nod

[PATCH 32/36] qemu: convert qemuBlockJobData to GObject

Signed-off-by: Rafael Fonseca --- src/qemu/qemu_blockjob.c | 55 +++- src/qemu/qemu_blockjob.h | 15 +++ src/qemu/qemu_domain.c | 7 +++-- 3 files changed, 41 insertions(+), 36 deletions(-) diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_block

[PATCH 31/36] libxl: convert libxlMigrationDstArgs to GObject

Signed-off-by: Rafael Fonseca --- src/libxl/libxl_migration.c | 57 +++-- 1 file changed, 36 insertions(+), 21 deletions(-) diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index a105a03b47..15724bb262 100644 --- a/src/libxl/libxl_migration.c

[PATCH 26/36] datatypes: convert virStream to GObject

Signed-off-by: Rafael Fonseca --- src/conf/virchrdev.c| 5 +++-- src/datatypes.c | 32 + src/datatypes.h | 15 +++--- src/libvirt-stream.c| 7 +++ src/libvirt_private.syms

[PATCH 25/36] datatypes: convert virSecret to GObject

Signed-off-by: Rafael Fonseca --- src/conf/secret_event.c | 9 ++ src/conf/virsecretobj.c | 8 +- src/datatypes.c | 44 ++--- src/datatypes.h | 14 + src/libvirt-secret.c| 7

[PATCH 35/36] conf: convert virSaveCookie to GObject

Signed-off-by: Rafael Fonseca --- src/conf/snapshot_conf.c | 3 ++- src/conf/snapshot_conf.h | 2 +- src/conf/virsavecookie.c | 10 src/conf/virsavecookie.h | 14 +-- src/qemu/qemu_domain.c | 53 +++- src/qemu/qemu_domain.h | 12 ++---

[PATCH 29/36] libxl: convert libxlDriverConfig to GObject

Signed-off-by: Rafael Fonseca --- src/libxl/libxl_conf.c | 51 ++- src/libxl/libxl_conf.h | 12 ++- src/libxl/libxl_driver.c| 163 +--- src/libxl/libxl_migration.c | 21 ++--- tests/testutilsxen.c| 3 +- 5 files changed, 98 insert

[PATCH 23/36] datatypes: convert virStorageVol to GObject

Signed-off-by: Rafael Fonseca --- src/conf/virstorageobj.c | 8 +- src/datatypes.c | 48 ++-- src/datatypes.h | 15 +-- src/libvirt-storage.c| 6 ++--- src/libvirt_private.syms | 1 - src/qemu/qemu_migration.

[PATCH 18/36] datatypes: convert virNWFilterBinding to GObject

Signed-off-by: Rafael Fonseca --- src/conf/virnwfilterbindingobjlist.c | 6 +++- src/datatypes.c | 44 +--- src/datatypes.h | 14 ++--- src/libvirt-nwfilter.c | 7 ++--- src/nwfilter/nwfilter_driver.c | 3

[PATCH 28/36] lxc: convert virLXCDriverConfig to GObject

Signed-off-by: Rafael Fonseca --- src/lxc/lxc_conf.c| 31 +- src/lxc/lxc_conf.h| 10 +++-- src/lxc/lxc_driver.c | 51 +++ src/lxc/lxc_process.c | 33 +--- 4 files changed, 51 insertions(+), 74 del

[PATCH 30/36] hypervisor: convert virHostdevManager to GObject

Signed-off-by: Rafael Fonseca --- src/hypervisor/virhostdev.c | 31 +-- src/hypervisor/virhostdev.h | 13 + src/libxl/libxl_driver.c| 3 ++- src/lxc/lxc_driver.c| 3 ++- src/qemu/qemu_driver.c | 3 ++- 5 files changed, 36 insertions(+),

[PATCH 34/36] conf: convert virDomain*Private to GObject

Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c| 29 ++-- src/conf/domain_conf.h| 18 +- src/qemu/qemu_domain.c| 347 -- src/qemu/qemu_domain.h| 145 +++- src/util/virstoragefile.h | 3 +- 5 files changed, 281 insertions

[PATCH 21/36] datatypes: convert virInterface to GObject

Signed-off-by: Rafael Fonseca --- src/conf/virinterfaceobj.c | 7 ++-- src/datatypes.c | 44 +++-- src/datatypes.h | 10 +++--- src/interface/interface_backend_netcf.c | 2 +- src/interface/interface_backend_udev.c

[PATCH 33/36] qemu: convert virQEMUDriverConfig to GObject

Signed-off-by: Rafael Fonseca --- src/qemu/qemu_conf.c | 36 ++-- src/qemu/qemu_conf.h | 19 --- src/qemu/qemu_driver.c | 3 ++- tests/domaincapstest.c | 3 ++- tests/testutilsqemu.c | 3 ++- 5 files changed, 36 insertions(+), 28 deletions(-

[PATCH 27/36] conf: convert virNetworkXMLOption to GObject

Signed-off-by: Rafael Fonseca --- src/conf/network_conf.c | 31 ++- src/conf/network_conf.h | 12 +--- src/network/bridge_driver.c | 2 +- tests/networkxml2xmltest.c | 3 +-- 4 files changed, 25 insertions(+), 23 deletions(-) diff --git a/src/conf/n

[PATCH 20/36] datatypes: convert virNetworkPort to GObject

Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c | 6 ++--- src/conf/virnetworkobj.c| 7 +++--- src/datatypes.c | 37 +++-- src/datatypes.h | 15 ++-- src/libvirt-network.c |

[PATCH 22/36] datatypes: convert virStoragePool to GObject

Signed-off-by: Rafael Fonseca --- src/conf/storage_event.c| 15 -- src/conf/virstorageobj.c| 8 - src/datatypes.c | 46 ++--- src/datatypes.h | 15 +- src/libvirt-storage.c |

[PATCH 17/36] datatypes: convert virNWFilter to GObject

Signed-off-by: Rafael Fonseca --- src/conf/virnwfilterobj.c | 6 +++-- src/datatypes.c | 46 --- src/datatypes.h | 10 + src/libvirt-nwfilter.c| 7 +++--- src/libvirt_private.syms | 1 - 5 files changed, 41 insertions(+), 29

[PATCH 06/36] conf: convert virDomainXMLOption to GObject

Signed-off-by: Rafael Fonseca --- src/bhyve/bhyve_driver.c | 3 ++- src/conf/domain_conf.c| 29 +++-- src/conf/domain_conf.h| 9 + src/esx/esx_driver.c | 3 ++- src/libxl/libxl_driver.c | 3 ++- src/lxc/lxc_controller.c |

[PATCH 03/36] qemu: convert virQEMUCaps to GObject

virFileCache had to also be changed to properly unref the QEMUCaps objects; in turn, virfilecachetest was also converted to GObject so it plays nicely with virFileCache. Signed-off-by: Rafael Fonseca --- src/qemu/qemu_capabilities.c | 119 +++ src/qemu/qemu_capabi

[PATCH 09/36] rpc: convert virNetServerService to GObject

Signed-off-by: Rafael Fonseca --- src/lxc/lxc_controller.c | 6 +-- src/rpc/virnetserver.c| 4 +- src/rpc/virnetserverprogram.h | 7 ++- src/rpc/virnetserverservice.c | 87 +++ tests/virnetdaemontest.c | 4 +- 5 files changed, 48 insertions(+)

[PATCH 14/36] admin: convert virAdmClient to GObject

Signed-off-by: Rafael Fonseca --- src/admin/libvirt-admin.c| 2 +- src/admin/libvirt_admin_private.syms | 1 - src/datatypes.c | 36 ++-- src/datatypes.h | 13 +- 4 files changed, 31 insertions(+), 21 deletion

[PATCH 10/36] conf: convert virDomainCapsCPUModels to GObject

Signed-off-by: Rafael Fonseca --- src/conf/domain_capabilities.c | 48 ++ src/conf/domain_capabilities.h | 10 --- tests/cputest.c| 35 - 3 files changed, 43 insertions(+), 50 deletions(-) diff --git a/src/conf/domain_ca

[PATCH 04/36] rpc: convert virNetClientProgram to GObject

Signed-off-by: Rafael Fonseca --- src/admin/admin_remote.c| 10 +++ src/locking/lock_driver_lockd.c | 23 --- src/logging/log_manager.c | 17 ++- src/lxc/lxc_monitor.c | 3 +- src/remote/remote_driver.c | 52 +

[PATCH 02/36] conf: capabilities: convert virCaps to GOBject

Signed-off-by: Rafael Fonseca --- src/bhyve/bhyve_capabilities.c | 16 src/bhyve/bhyve_driver.c| 30 -- src/conf/capabilities.c | 39 ++-- src/conf/capabilities.h | 6 ++--- src/conf/storage_capabilities.c | 5 ++-

[PATCH 13/36] admin: convert virAdmServer to GObject

Signed-off-by: Rafael Fonseca --- src/admin/libvirt-admin.c| 2 +- src/admin/libvirt_admin_private.syms | 1 - src/datatypes.c | 42 ++-- src/datatypes.h | 20 +++-- 4 files changed, 40 insertions(+), 25 delet

[PATCH 11/36] util: convert dnsmasqCaps to GObject

Signed-off-by: Rafael Fonseca --- src/network/bridge_driver.c | 21 ++ src/util/virdnsmasq.c | 56 + src/util/virdnsmasq.h | 6 ++-- tests/networkxml2conftest.c | 10 ++- 4 files changed, 41 insertions(+), 52 deletions(-) diff --gi

[PATCH 19/36] datatypes: convert virNetwork to GObject

Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c | 6 ++-- src/conf/network_event.c| 2 +- src/conf/virnetworkobj.c| 7 ++-- src/datatypes.c | 50 + src/datatypes.h | 33 ++-

[PATCH 07/36] bhyve: convert bhyveMonitor to GObject

Signed-off-by: Rafael Fonseca --- src/bhyve/bhyve_monitor.c | 35 +++ src/bhyve/bhyve_monitor.h | 3 ++- 2 files changed, 21 insertions(+), 17 deletions(-) diff --git a/src/bhyve/bhyve_monitor.c b/src/bhyve/bhyve_monitor.c index e5cd39a086..4609e3c53a 100644 ---

[PATCH 16/36] datatypes: convert virDomainSnapshot to GObject

Signed-off-by: Rafael Fonseca --- src/conf/virdomainsnapshotobjlist.c | 6 ++-- src/datatypes.c | 44 ++--- src/datatypes.h | 13 +++-- src/libvirt-domain-snapshot.c | 7 ++--- src/libvirt_private.syms| 1 -

[PATCH 05/36] rpc: convert virNetServerProgram to GObject

Signed-off-by: Rafael Fonseca --- src/locking/lock_daemon.c | 28 ++-- src/logging/log_daemon.c| 28 ++-- src/lxc/lxc_controller.c| 13 +--- src/remote/remote_daemon.c | 52 ++--- src/remote/remote_daem

[PATCH 08/36] bhyve: convert virBhyveDriverConfig to GObject

Signed-off-by: Rafael Fonseca --- src/bhyve/bhyve_capabilities.c | 3 +-- src/bhyve/bhyve_conf.c | 34 +- src/bhyve/bhyve_driver.c | 3 ++- src/bhyve/bhyve_utils.h| 11 +-- 4 files changed, 29 insertions(+), 22 deletions(-) diff --g

[PATCH 01/36] util: virresctrl: convert classes to GObject

Signed-off-by: Rafael Fonseca --- src/conf/capabilities.c | 3 +- src/conf/domain_conf.c | 21 +++--- src/util/virresctrl.c | 137 ++-- src/util/virresctrl.h | 15 +++-- tests/virresctrltest.c | 3 +- 5 files changed, 97 insertions(+), 82 deletions(

[PATCH 12/36] conf: convert virDomainChrSourceDef to GObject

Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c | 35 --- src/conf/domain_conf.h | 9 - src/qemu/qemu_domain.c | 7 --- src/qemu/qemu_process.c | 3 +-- src/qemu/qemu_virtiofs.c | 12 +--- 5 files changed, 34 insertions(+), 32

[PATCH 00/36] convert virObjects to GObject

This patch series convert various simple instances of virObject to a GObject equivalent. virDomain is still WIP because it causes some linking problem I am still investigating. virObjects that work as parent class to other objects will be covered in a next patchset. Rafael Fonseca (36): util:

[PATCH 15/36] datatypes: convert virDomainCheckpoint to GObject

Signed-off-by: Rafael Fonseca --- src/conf/virdomaincheckpointobjlist.c | 6 ++-- src/datatypes.c | 44 --- src/datatypes.h | 14 ++--- src/libvirt-domain-checkpoint.c | 7 ++--- src/libvirt_private.syms

Re: [libvirt-jenkins-ci PATCH 3/5] guests: Introduce the new 'gitlab' flavor

On Fri, 2020-04-03 at 09:38 +0200, Erik Skultety wrote: > On Tue, Mar 31, 2020 at 05:23:32PM +0200, Andrea Bolognani wrote: > > On Thu, 2020-03-26 at 14:33 +0100, Erik Skultety wrote: > > > +++ b/guests/playbooks/update/tasks/gitlab.yml > > > @@ -0,0 +1,64 @@ > > > +--- > > > +- name: Look up Gitla

Re: [libvirt PATCH] github: enable lockdown of issues and merge requests

On Fri, Apr 03, 2020 at 08:55:11AM -0500, Eric Blake wrote: > On 4/3/20 5:38 AM, Daniel P. Berrangé wrote: > > Libvirt uses GitHub as an automated read-only mirror. The goals were to > > have a disaster recovery backup for libvirt.org, a way to make it easy > > for people to clone their own private

Re: [PATCH 00/15] move validations out of qemu_domain.c

On a Friday in 2020, Daniel Henrique Barboza wrote: Ping On 3/26/20 6:31 PM, Daniel Henrique Barboza wrote: po/POTFILES.in |1 + src/qemu/Makefile.inc.am |2 + src/qemu/qemu_domain.c | 3895 ++ src/qemu/qemu_validate.c | 3592

[PATCH] cpu.c: Use g_autoptr and g_autofree in virCPUDataParse

Signed-off-by: Seeteena Thoufeek --- src/cpu/cpu.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index 631c755..e556ffe 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -772,40 +772,36 @@ virCPUDataPtr virCPUDataParse(const

Re: [PATCH 08/15] qemu: move qemuDomainDeviceDefValidateVideo() to qemu_validate.c

On a Thursday in 2020, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 98 +--- src/qemu/qemu_validate.c | 96 +++ src/qemu/qemu_validate.h | 2 + 3 files changed, 99 insert

Re: [PATCH 09/15] qemu: move qemuDomainDeviceDefValidateDisk() to qemu_validate.c

On a Thursday in 2020, Daniel Henrique Barboza wrote: This function will remain public due to its usage in qemublocktest.c even after moving qemuDomainDeviceDefValidate(). The position of its header in qemu_validate.h is no accident. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_doma

Re: [PATCH 07/15] qemu: move qemuDomainDeviceDefValidateHostdev() to qemu_validate.c

On a Thursday in 2020, Daniel Henrique Barboza wrote: This function alone requires other 3 static functions to be moved as well, thus let's move it in its own patch. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 190 +-- src/qemu/qemu_v

Re: [PATCH 06/15] qemu: move qemuDomainChrDefValidate() to qemu_validate.c

On a Thursday in 2020, Daniel Henrique Barboza wrote: qemuDomainChrDefValidate() has a lot of static helpers functions that needed to be moved as well. Other functions from qemuDomainDeviceDefValidate() that were also moved: - qemuValidateDomainSmartcardDef - qemuValidateDomainRNGDef - qemuValid

Re: [PATCH 05/15] qemu: move qemuDomainDeviceDefValidateAddress() to qemu_validate.c

qemuDomainDeviceDefValidateNetwork in the commit summary On a Thursday in 2020, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 146 +-- src/qemu/qemu_validate.c | 144 ++

Re: [PATCH 04/15] qemu: move qemuDomainDeviceDefValidateAddress() to qemu_validation.c

s/validation/validate/ in the commit summary On a Thursday in 2020, Daniel Henrique Barboza wrote: The next big task is to move qemuDomainDeviceDefValidate() to qemu_validation.c, which is a function that calls a lot of other static helper functions. This patch starts it by moving qemuDomainDevi

Re: [PATCH 14/15] qemu: move remaining qemuDomainDeviceDefValidate() helpers

On a Thursday in 2020, Daniel Henrique Barboza wrote: This will allow to move qemuDomainDeviceDefValidate() itself in the next patch in a cleaner way. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 392 +-- src/qemu/qemu_validate.c | 376

Re: [PATCH 15/15] qemu: move qemuValidateDomainDeviceDef() to qemu_validate.c

On a Thursday in 2020, Daniel Henrique Barboza wrote: Now that all its helper functions are in qemu_validate.c, we can move the function itself. The helpers can become static again since they're all in the same file. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 128 +---

Re: [PATCH 13/15] qemu: move qemuDomainDeviceDefValidateSound() to qemu_validate.c

On a Thursday in 2020, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 76 +--- src/qemu/qemu_validate.c | 76 src/qemu/qemu_validate.h | 2 ++ 3 files changed, 79 inse

Re: [PATCH 12/15] qemu: move qemuDomainDeviceDefValidateFS() to qemu_validate.c

On a Thursday in 2020, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 119 +-- src/qemu/qemu_validate.c | 119 +++ src/qemu/qemu_validate.h | 4 ++ 3 files changed, 124 in

Re: [PATCH 11/15] qemu: move qemuDomainDeviceDefValidateGraphics() to qemu_validate.c

On a Thursday in 2020, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 177 +-- src/qemu/qemu_validate.c | 175 ++ src/qemu/qemu_validate.h | 5 ++ 3 files changed, 181 ins

Re: [libvirt-jenkins-ci PATCH 2/5] guests: templates: Introduce a gitlab-runner RC init service template

On Fri, Apr 03, 2020 at 03:50:21PM +0200, Andrea Bolognani wrote: > On Fri, 2020-04-03 at 09:21 +0200, Erik Skultety wrote: > > On Tue, Mar 31, 2020 at 04:42:10PM +0200, Andrea Bolognani wrote: > > > On Thu, 2020-03-26 at 14:33 +0100, Erik Skultety wrote: > > > > +gitlab_runner_start() > > > > +{ >

Re: [PATCH 10/15] qemu: move qemuValidateDomainDeviceDefController() to qemu_validate.c

On a Thursday in 2020, Daniel Henrique Barboza wrote: Move the function and all its static helper functions. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 804 +-- src/qemu/qemu_validate.c | 804 +++ s

Re: [PATCH] rng: Support encryption and slices element in snapshot XML

On Wed, Apr 01, 2020 at 10:10:12PM +0800, Han Han wrote: > Signed-off-by: Han Han I added some minimalistic commit message, tweaked the subject according to Daniel's note and pushed the patch. Reviewed-by: Erik Skultety

Re: [libvirt PATCH] github: enable lockdown of issues and merge requests

On 4/3/20 5:38 AM, Daniel P. Berrangé wrote: Libvirt uses GitHub as an automated read-only mirror. The goals were to have a disaster recovery backup for libvirt.org, a way to make it easy for people to clone their own private copy of libvirt Git, and finally as a way to interact with apps like Tr

Re: [libvirt-jenkins-ci PATCH 2/5] guests: templates: Introduce a gitlab-runner RC init service template

On Fri, 2020-04-03 at 09:21 +0200, Erik Skultety wrote: > On Tue, Mar 31, 2020 at 04:42:10PM +0200, Andrea Bolognani wrote: > > On Thu, 2020-03-26 at 14:33 +0100, Erik Skultety wrote: > > > +gitlab_runner_start() > > > +{ > > > +export USER=${user} > > > +export HOME=${user_home} > > > +

Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

On Fri, Apr 03, 2020 at 02:36:35PM +0200, Peter Krempa wrote: > On Fri, Apr 03, 2020 at 14:34:29 +0200, Pavel Mores wrote: > > On Tue, Mar 31, 2020 at 12:06:15PM +0200, Peter Krempa wrote: > > > On Tue, Mar 31, 2020 at 11:18:29 +0200, Pavel Mores wrote: > > > > > > > +} > > > > + > > >

Re: [PATCH 03/15] qemu: move qemuDomainValidateDef() to qemu_validate.c

On a Thursday in 2020, Daniel Henrique Barboza wrote: After moving most of static functions qemuDomainValidateDef() uses, move the last remaining static and qemuDomainValidateDef() itself to qemu_validation.c. I'd rather squash this with the previous patch. Signed-off-by: Daniel Henrique Bar

Re: [PATCH 01/15] qemu: introducing qemu_validate.c/h

On 4/3/20 10:21 AM, Ján Tomko wrote: Moving the first functions seems more important than the fact that we are introducing a new file. qemu: move qemuDomainDefValidateFeatures to qemu_validate On a Thursday in 2020, Daniel Henrique Barboza wrote: While moving validations from qemu_command t

Re: [PATCH 01/15] qemu: introducing qemu_validate.c/h

Moving the first functions seems more important than the fact that we are introducing a new file. qemu: move qemuDomainDefValidateFeatures to qemu_validate On a Thursday in 2020, Daniel Henrique Barboza wrote: While moving validations from qemu_command to qemu_domain, it was suggested that we s

Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

On Tue, Mar 31, 2020 at 12:06:15PM +0200, Peter Krempa wrote: > On Tue, Mar 31, 2020 at 11:18:29 +0200, Pavel Mores wrote: > > > +} > > + > > +if (flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN) > > +topPath = disk->src->path; > > +else > > +

Re: [libvirt PATCH 3/3] qemu: block: external snapshot-delete implementation for straightforward cases

On Fri, Apr 03, 2020 at 14:34:29 +0200, Pavel Mores wrote: > On Tue, Mar 31, 2020 at 12:06:15PM +0200, Peter Krempa wrote: > > On Tue, Mar 31, 2020 at 11:18:29 +0200, Pavel Mores wrote: > > > > > +} > > > + > > > +if (flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN) > > > +

Re: [PATCH 00/15] move validations out of qemu_domain.c

Ping On 3/26/20 6:31 PM, Daniel Henrique Barboza wrote: This is a suggestion made by Peter in [1], in the review discussion of a series in which I started moving qemuCaps validation from qemu_command.c to qemu_domain.c [2]. I'll quote here what he said back then: "My only suggestion is that aft

Re: [PATCH] qemu_checkpoint.c: Use g_autofree in qemuCheckpointPrepare()

On a Friday in 2020, Seeteena Thoufeek wrote: This is the only instance of g_autofree change applicable for qemu_checkpoint.c Signed-off-by: Seeteena Thoufeek --- src/qemu/qemu_checkpoint.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) Reviewed-by: Ján Tomko and pu

Re: [libvirt-jenkins-ci PATCH 2/7] lcitool: Configure ccache using environment variables

On Mon, Mar 30, 2020 at 01:18:49PM +0100, Daniel P. Berrangé wrote: > On Mon, Mar 30, 2020 at 02:11:29PM +0200, Andrea Bolognani wrote: > > On Mon, 2020-03-30 at 12:45 +0100, Daniel P. Berrangé wrote: > > > On Fri, Mar 27, 2020 at 08:34:54PM +0100, Andrea Bolognani wrote: > > > > +export CCACHE_MAX

[PATCH] qemu_checkpoint.c: Use g_autofree in qemuCheckpointPrepare()

This is the only instance of g_autofree change applicable for qemu_checkpoint.c Signed-off-by: Seeteena Thoufeek --- src/qemu/qemu_checkpoint.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c index 3a5

Re: [libvirt-jenkins-ci PATCH] lcitool: Fix $PYTHON value in environment

On Fri, Apr 03, 2020 at 01:19:41PM +0200, Andrea Bolognani wrote: > Starting with commit > > commit d76f41ece09b9aaf492553fe466c30a22c78e509 > Author: Andrea Bolognani > Date: Fri Mar 27 17:21:26 2020 +0100 > > lcitool: Include paths in the inventory > > Figuring them out at run

[libvirt-jenkins-ci PATCH] lcitool: Fix $PYTHON value in environment

Starting with commit commit d76f41ece09b9aaf492553fe466c30a22c78e509 Author: Andrea Bolognani Date: Fri Mar 27 17:21:26 2020 +0100 lcitool: Include paths in the inventory Figuring them out at runtime is neat, but in practice they don't change frequently enough for it to be n

[libvirt PATCH] github: enable lockdown of issues and merge requests

Libvirt uses GitHub as an automated read-only mirror. The goals were to have a disaster recovery backup for libvirt.org, a way to make it easy for people to clone their own private copy of libvirt Git, and finally as a way to interact with apps like Travis. The project description was set to a mes

  1   2   >