[libvirt PATCH 6/9] conf: Advertise migratable attribute for CPU in domcaps

2020-06-05 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- docs/formatdomaincaps.html.in | 13 +++-- docs/schemas/domaincaps.rng| 3 +++ src/conf/domain_capabilities.c | 13 - src/conf/domain_capabilities.h | 1 + 4 files changed, 27 insertions(+), 3 deletions(-) diff --git a/docs/formatdomainc

[libvirt PATCH 8/9] qemu: Fill default value in //cpu/@migratable attribute

2020-06-05 Thread Jiri Denemark
Before QEMU introduced migratable CPU property, "-cpu host" included all features that could be enabled on the host, even those which would block migration. In other words, the default was equivalent to migratable=off. When the migratable property was introduced, the default changed to migratable=o

[libvirt PATCH] network: add private chains only if there are networks adding iptables rules

2020-06-05 Thread Laine Stump
Juan Quintela noticed that when he restarted libvirt he was getting extra iptables rules added by libvirt even though he didn't have any libvirt networks that used iptables rules. It turns out this also happens if the firewalld service is restarted. The extra rules are just the private chains, and

[libvirt PATCH 0/9] qemu: Add support for -cpu host, migratable=on|off

2020-06-05 Thread Jiri Denemark
Jiri Denemark (9): conf: Use g_auto* in virCPUDefParseXML qemu: Probe for .migratable property of a CPU qemu: Probe for migrtability support in CPU expansion qemu: Avoid probing unsupported migratable CPU expansion conf: Introduce migratable attribute for the element conf: Advertise

[libvirt PATCH 2/9] qemu: Probe for .migratable property of a CPU

2020-06-05 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 3 +++ tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps

Re: [PATCH] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-05 Thread Igor Mammedov
On Thu, 4 Jun 2020 07:22:51 -0500 Eric Blake wrote: > On 6/2/20 3:41 AM, Igor Mammedov wrote: > > Deprecation period is run out and it's a time to flip the switch > > introduced by cd5ff8333a. Disable legacy option for new machine > > types (since 5.1) and amend documentation. > > > > '-numa no

[PATCH v2 3/8] conf: Add firmware blob configuration

2020-06-05 Thread Michal Privoznik
QEMU has -fw_cfg which allows users to tweak how firmware configures itself and/or provide new configuration blobs. Introduce new type "fwcfg" that will hold these new blobs. It's possible to either specify new value as a string or provide a filename which contents then serve as the value. Signe

[libvirt PATCH 4/9] qemu: Avoid probing unsupported migratable CPU expansion

2020-06-05 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 1 + .../caps_2.10.0.s390x.replies | 22 - .../caps_2.11.0.s390x.replies | 22 - .../caps_2.12.0.s390x.replies | 22 - .../caps_2.8.0.s390x.rep

[libvirt PATCH 5/9] conf: Introduce migratable attribute for the element

2020-06-05 Thread Jiri Denemark
The attribute is only allowed for host-passthrough CPUs and it can be used to request only migratable or all supported features to be enabled in the virtual CPU. Signed-off-by: Jiri Denemark --- docs/formatdomain.html.in | 14 -- docs/schemas/domaincommon.rng | 5 + src/conf

[libvirt PATCH 7/9] qemu: Advertise migratable attribute for CPU in domcaps

2020-06-05 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 11 ++- tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml| 6 +- tests/domaincapsdata/qemu_1.5.3.x86_64.xml| 6 +- tests/domaincapsdata/qemu_1.6.0-q35.x86_64.xml| 6 +- tests/d

[libvirt PATCH 1/9] conf: Use g_auto* in virCPUDefParseXML

2020-06-05 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/conf/cpu_conf.c | 130 +--- 1 file changed, 50 insertions(+), 80 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 1d02e23175..25648a946c 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.

[libvirt PATCH 9/9] qemu: Pass migratable=on|off property for -cpu host

2020-06-05 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_command.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 419eca5675..d9e99d9d1a 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6254,6 +6254,21 @@ qe

[PATCH v2] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-05 Thread Igor Mammedov
Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types. Signed-off-by: Igor Mammedov Reviewed-

[libvirt PATCH] docs: backing chains: fix qemu-img invocation

2020-06-05 Thread Ján Tomko
The example was missing the 'create' command. Signed-off-by: Ján Tomko Reported-by: Roland Clobus --- Pushed as trivial. docs/kbase/backing_chains.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/kbase/backing_chains.rst b/docs/kbase/backing_chains.rst index c112f2b

[PATCH v3] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-05 Thread Igor Mammedov
Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types. Signed-off-by: Igor Mammedov Reviewed-

Re: [PATCH v2] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200605121342.534811-1-imamm...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash ex

Re: [PATCH v2] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200605121342.534811-1-imamm...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-06-05 Thread Alex Williamson
On Fri, 5 Jun 2020 11:22:24 +0100 "Dr. David Alan Gilbert" wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > On Wed, 3 Jun 2020 01:24:43 -0400 > > Yan Zhao wrote: > > > > > On Tue, Jun 02, 2020 at 09:55:28PM -0600, Alex Williamson wrote: > > > > On Tue, 2 Jun 2020 23:19:48

Re: [PATCH 4/5] qemu: Prefer -numa cpu over -numa node,cpus=

2020-06-05 Thread Igor Mammedov
On Thu, 4 Jun 2020 10:58:01 +0200 Michal Privoznik wrote: > On 5/27/20 3:58 PM, Igor Mammedov wrote: > > On Tue, 26 May 2020 17:31:09 +0200 > > Michal Privoznik wrote: > > > >> On 5/26/20 4:51 PM, Igor Mammedov wrote: > >>> On Mon, 25 May 2020 10:05:08 +0200 > >>> Michal Privoznik wrote: >

Re: [libvirt PATCH v2 0/3] news: Convert to reStructuredText

2020-06-05 Thread Ján Tomko
On a Wednesday in 2020, Andrea Bolognani wrote: browse: https://gitlab.com/abologna/libvirt/-/tree/news-convert-cleanup git fetch: https://gitlab.com/abologna/libvirt.git news-convert-cleanup Changes since [v1] * use '*' for all bullet points, regardless of how deep they're nested; * pat

[libvirt PATCH] qemu: fix typo s/readaehad/readahead/

2020-06-05 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- Pushed as trivial typo fix src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 10f16e9b3b..3239ac1a52 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-06-05 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Wed, 3 Jun 2020 01:24:43 -0400 > Yan Zhao wrote: > > > On Tue, Jun 02, 2020 at 09:55:28PM -0600, Alex Williamson wrote: > > > On Tue, 2 Jun 2020 23:19:48 -0400 > > > Yan Zhao wrote: > > > > > > > On Tue, Jun 02, 2020 at 04:55:27PM -06

[PATCH] qemu: blockcommit: Fix placement of qemuDomainDiskBlockJobIsSupported

2020-06-05 Thread Peter Krempa
Commit b50a8354f6d added call to qemuDomainDiskBlockJobIsSupported prior to filling the 'disk' variable resulting in a crash when attempting a block commit. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/q

Re: Minor typo on https://libvirt.org/kbase/backing_chains.html

2020-06-05 Thread Ján Tomko
On a Monday in 2020, Michal Privoznik wrote: On 6/1/20 5:40 PM, Roland Clobus wrote: Hello all, I've found a minor typo on https://libvirt.org/kbase/backing_chains.html In the section 'Manual image creation' the word 'create' was missing from the command line: Current: qemu-img -f qcow2 -F qc

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-06-05 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Fri, 5 Jun 2020 11:22:24 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > On Wed, 3 Jun 2020 01:24:43 -0400 > > > Yan Zhao wrote: > > > > > > > On Tue, Jun 02, 2020 at 09:55:28P

[libvirt PATCH 3/9] qemu: Probe for migrtability support in CPU expansion

2020-06-05 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 12 +++- src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 + tests/qemucapabilitie

Disable some unit tests

2020-06-05 Thread Ani Sinha
Hi : Is there a recommended way to disable some unit tests in Libvirt ? We some broken tests which we want to fix incrementally but while we do that, we want to keep running other non-broken tests. thanks Ani

[PATCH v2 6/8] secdrivers: Relabel firmware config files

2020-06-05 Thread Michal Privoznik
For the case where -fw_cfg uses a file, we need to set the seclabels on it to allow QEMU the access. While QEMU allows writing into the file (if specified on the command line), so far we are enabling reading only and thus we can use read only label (in case of SELinux). Signed-off-by: Michal Privo

[PATCH v2 0/8] Expose QEMU's -fw_cfg

2020-06-05 Thread Michal Privoznik
v2 of: https://www.redhat.com/archives/libvir-list/2020-June/msg00139.html diff to v1: - Changed domain XML, pre Dan's suggestion - Documented the feature in news Michal Prívozník (8): domain_conf: Format NS always last virSysinfoParseXML: Mangle ctxt inside virSysinfoParseXML() conf: Add

[PATCH v2 4/8] qemu: Validate firmware blob configuration

2020-06-05 Thread Michal Privoznik
There are recommendations and limitations to the name of the config blobs we need to follow [1]. Firstly, we don't want users to change any value only add new blobs. This means, that the name must have "opt/" prefix and at the same time must not begin with "opt/ovmf" nor "opt/org.qemu" as these ar

[libvirt PATCH] gitlab-ci: Enable FreeBSD native builds

2020-06-05 Thread Erik Skultety
The runners have already been registered to the libvirt gitlab CI, we just need to enable building on them. Apart from adding respective CI job labels, the native job had to be tweaked so that the build dir inside the git repo is deleted before the build runs to always star with a clean environment

Handling merge requests from Weblate translation

2020-06-05 Thread Daniel P . Berrangé
The libvirt project is now converted to use Weblate for translation. Weblate has its own fork of libvirt git repos. With weblate managing translations, NEVER, under any circumstances should anyone change the .po files in libvirt.git directly. This will result in merge conflicts with Weblate that n

[libvirt-tck PATCH] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests

2020-06-05 Thread Erik Skultety
With the introduction of automated CI pipelines, we are now ready to switch to using merge requests for the project. With this switch we no longer wish to have patches sent to the mailing list, and thus the git-publish config is removed. Signed-off-by: Erik Skultety --- I was notified by jtomko,

[libvirt PATCH] gitlab: fix potfile job for new location

2020-06-05 Thread Daniel P . Berrangé
Since we're storing the libvirt.pot file in git now, we should pull from the source dir, not the build dir. Signed-off-by: Daniel P. Berrangé --- Pushed as CI fix .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 149334ed6f

[PATCH v2 2/8] virSysinfoParseXML: Mangle ctxt inside virSysinfoParseXML()

2020-06-05 Thread Michal Privoznik
There's no need to set ctxt->node outside of the function. The function can set it itself - it has all the info needed. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_con

[PATCH v2 8/8] news: Document -fw_cfg

2020-06-05 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- docs/news.xml | 12 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 18d96af048..d89ba778e1 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,18 @@ + + + Allow firmware

[PATCH v2 7/8] qemu: Generate command line for -fw_cfg

2020-06-05 Thread Michal Privoznik
This is pretty straightforward and self explanatory. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1837990 Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 44 +++ tests/qemuxml2argvdata/smbios-type-fwcfg.args | 38 tes

[PATCH v2 5/8] qemu: Introduce fw_cfg capability

2020-06-05 Thread Michal Privoznik
This capability tracks whether QEMU supports -fw_cfg command line option, more specifically whether it allows specifying filename. There are some releases of QEMU which support -fw_cfg but not filename. If this is ever a problem we can refine the capability later on. Signed-off-by: Michal Privozn

[PATCH v2 1/8] domain_conf: Format NS always last

2020-06-05 Thread Michal Privoznik
I think that since is kind of a hack, it doesn't deserve place in the front row. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1cdc7971fc..e84fbe1e21

Re: [libvirt PATCH] qemu: don't reject interface update when switching to/from bridged network

2020-06-05 Thread Daniel Henrique Barboza
On 6/3/20 4:20 PM, Laine Stump wrote: If virDomainUpdateDeviceFlags() was used to update an , and the interface type changed from type='network' where the network was an unmanaged bridge (so actualType == bridge) to type='bridge' (i.e. actualType *also* == bridge), the update would fail due to

Re: [PATCH 4/5] qemu: Prefer -numa cpu over -numa node,cpus=

2020-06-05 Thread Michal Privoznik
On 5/27/20 3:58 PM, Igor Mammedov wrote: On Tue, 26 May 2020 17:31:09 +0200 Michal Privoznik wrote: On 5/26/20 4:51 PM, Igor Mammedov wrote: On Mon, 25 May 2020 10:05:08 +0200 Michal Privoznik wrote: This is a problem. The domain XML that is provided can't be changed, mostly because mg

Re: [libvirt PATCH] gitdm: Add missing entries

2020-06-05 Thread Michal Privoznik
On 6/2/20 10:55 AM, Andrea Bolognani wrote: A few new individuals have contributed to libvirt since the last time the gitdm configuration was updated. Signed-off-by: Andrea Bolognani --- docs/gitdm/groups/unaffiliated | 4 1 file changed, 4 insertions(+) Reviewed-by: Michal Privoznik

Re: [PATCH 2/2] qemu: format address wdith on intel-iommu command line

2020-06-05 Thread Peter Krempa
On Thu, Jun 04, 2020 at 09:42:43 +0200, Menno Lageman wrote: > Format the address width attribute. Depending on the version of > QEMU it is named 'aw-bits' or 'x-aw-bits'. > > Signed-off-by: Menno Lageman > --- > src/qemu/qemu_capabilities.c | 6 > src/qemu/qemu_capabiliti

Re: [PATCH] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-05 Thread Eric Blake
On 6/2/20 3:41 AM, Igor Mammedov wrote: Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types

Re: [PATCH] conf: force 8 byte alignment for virObjectEvent

2020-06-05 Thread Michal Privoznik
On 6/3/20 12:22 PM, Daniel P. Berrangé wrote: We need to be able to cast from virObjectEventPtr to one of its many subclasses. Some of these subclasses have 8 byte alignment on 32-bit platforms, but virObjectEventPtr only has 4 byte alignment. Previously the virObject base class had 8 byte align

Re: [libvirt PATCH] qemu: don't reject interface update when switching to/from bridged network

2020-06-05 Thread Michal Privoznik
On 6/3/20 9:20 PM, Laine Stump wrote: If virDomainUpdateDeviceFlags() was used to update an , and the interface type changed from type='network' where the network was an unmanaged bridge (so actualType == bridge) to type='bridge' (i.e. actualType *also* == bridge), the update would fail due to th

Re: [PATCH 35/40] libxl: convert libxlMigrationDstArgs to GObject

2020-06-05 Thread Rafael Fonseca
On Thu, Jun 4, 2020 at 11:16 AM Daniel P. Berrangé wrote: > > On Mon, May 18, 2020 at 05:16:29PM +0200, Rafael Fonseca wrote: > > On Mon, May 18, 2020 at 3:28 PM Rafael Fonseca wrote: > > > > > > On Mon, May 18, 2020 at 11:31 AM Daniel P. Berrangé > > > wrote: > > > > > > > > On Sun, May 17, 20

Re: [PATCH 2/2] qemu: format address wdith on intel-iommu command line

2020-06-05 Thread Menno Lageman
On 04/06/2020 10:38, Peter Krempa wrote: On Thu, Jun 04, 2020 at 09:42:43 +0200, Menno Lageman wrote: Format the address width attribute. Depending on the version of QEMU it is named 'aw-bits' or 'x-aw-bits'. Signed-off-by: Menno Lageman --- src/qemu/qemu_capabilities.c | 6

[libvirt PATCH] conf: fix alignment in virObjectEvent to be 8 not 4 bytes

2020-06-05 Thread Daniel P . Berrangé
The previous fix accidentally picked up a debug change that put alignment back at 4, not 8, bytes as it claimed: commit 37ae0426420a2f682cc96ee457a8cae9c0db27d3 Author: Daniel P. Berrangé Date: Wed Jun 3 11:18:23 2020 +0100 conf: force 8 byte alignment for virObjectEvent Signed-off-

Re: [PATCH] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-05 Thread Michal Privoznik
On 6/2/20 10:41 AM, Igor Mammedov wrote: Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine type

Re: [PATCH 35/40] libxl: convert libxlMigrationDstArgs to GObject

2020-06-05 Thread Daniel P . Berrangé
On Mon, May 18, 2020 at 05:16:29PM +0200, Rafael Fonseca wrote: > On Mon, May 18, 2020 at 3:28 PM Rafael Fonseca wrote: > > > > On Mon, May 18, 2020 at 11:31 AM Daniel P. Berrangé > > wrote: > > > > > > On Sun, May 17, 2020 at 11:03:57PM +0200, Rafael Fonseca wrote: > > > > On Fri, May 15, 2020

Re: [PATCH 2/2] qemu: format address wdith on intel-iommu command line

2020-06-05 Thread Menno Lageman
On 04/06/2020 11:43, Peter Krempa wrote: On Thu, Jun 04, 2020 at 11:34:52 +0200, Menno Lageman wrote: On 04/06/2020 10:38, Peter Krempa wrote: On Thu, Jun 04, 2020 at 09:42:43 +0200, Menno Lageman wrote: Format the address width attribute. Depending on the version of QEMU it is named 'aw-bits'

Re: [PATCH 2/2] qemu: format address wdith on intel-iommu command line

2020-06-05 Thread Peter Krempa
On Thu, Jun 04, 2020 at 11:34:52 +0200, Menno Lageman wrote: > On 04/06/2020 10:38, Peter Krempa wrote: > > On Thu, Jun 04, 2020 at 09:42:43 +0200, Menno Lageman wrote: > > > Format the address width attribute. Depending on the version of > > > QEMU it is named 'aw-bits' or 'x-aw-bits'. > > > > >