Signed-off-by: Han Han
---
docs/formatdomain.html.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index f3a639b972..6b67a09bb3 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -4092,7 +4092,8 @
On Thu, Jul 16, 2020 at 11:57:13 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/meson.build| 51 ++
> src/remote/Makefile.inc.am | 41 --
> 2 files changed, 51 insertions(+), 41 deletions(-)
>
> dif
On Thu, Jul 16, 2020 at 11:56:56 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/locking/Makefile.inc.am | 13 -
> src/locking/meson.build | 17 +
> 2 files changed, 17 insertions(+), 13 deletions(-)
[...]
> diff --git a/src/locking/meson.bui
Please forget it and review the V3.
Sorry :-(
>
> Shmem device support property role with 'master'(master=on) or
> 'peer'(master=off, default mode), which controls to copy the
> shared memory on migration to the destination host or not. see
> https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/
The shmem 'name' specifies the shared memory path in '/dev/shm/',
however, we may need to change it to avoid filename conflict
when VM migrate to other host. This patch remove shmem name
consistency check.
Signed-off-by: Wang Xin
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
Role(master or peer) controls how the domain behaves on migration.
For more details about migration with ivshmem, see
https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/system/ivshmem.rst;hb=HEAD
It's a optional attribute in libvirt, and qemu will choose default
role for ivshmem device if the us
Shmem device support property role with 'master'(master=on) or
'peer'(master=off, default mode), which controls to copy the
shared memory on migration to the destination host or not. see
https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/system/ivshmem.rst;hb=HEAD
The 1st patch add attribute 'r
The shmem 'name' specifies the shared memory path in '/dev/shm/',
however, we may need to change it to avoid filename conflict
when VM migrate to other host. This patch remove shmem name
consistency check.
Signed-off-by: Wang Xin
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
Shmem device support property role with 'master'(master=on) or
'peer'(master=off, default mode), which controls to copy the
shared memory on migration to the destination host or not. see
https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/system/ivshmem.rst;hb=HEAD
The 1st patch add attribute 'r
Role(master or peer) controls how the domain behaves on migration.
For more details about migration with ivshmem, see
https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/system/ivshmem.rst;hb=HEAD
It's a optional attribute in libvirt, and qemu will choose default
role for ivshmem device if the us
>From c328ff62b11d58553fd2032a85fd3295e009b3d3 Mon Sep 17 00:00:00 2001
From: Bihong Yu
Date: Fri, 17 Jul 2020 16:55:12 +0800
Subject: [PATCH] qemu: clear residual QMP caps processes during QEMU driver
initialization
In some cases, the QMP capabilities processes possible residue. So we need to
c
On 7/23/20 8:59 AM, Daniel P. Berrangé wrote:
On Thu, Jul 23, 2020 at 03:08:41PM +0200, Peter Krempa wrote:
On Thu, Jul 23, 2020 at 14:00:40 +0100, Daniel Berrange wrote:
On Thu, Jul 23, 2020 at 02:57:32PM +0200, Peter Krempa wrote:
On Mon, Jul 20, 2020 at 18:33:19 +0100, Daniel Berrange wrote
On Thu, Jul 23, 2020 at 03:08:41PM +0200, Peter Krempa wrote:
> On Thu, Jul 23, 2020 at 14:00:40 +0100, Daniel Berrange wrote:
> > On Thu, Jul 23, 2020 at 02:57:32PM +0200, Peter Krempa wrote:
> > > On Mon, Jul 20, 2020 at 18:33:19 +0100, Daniel Berrange wrote:
> > > > btrfs defaults to performing
On 7/22/20 7:21 PM, Daniel P. Berrangé wrote:
GCC 10 complains about "desc" possibly being a NULL dereference. Even
though it is a false positive, we can easily avoid it.
Signed-off-by: Daniel P. Berrangé
---
tools/vsh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Mi
On 7/22/20 7:21 PM, Daniel P. Berrangé wrote:
The mingw header define time() as a static inline function and this
causes a duplicate definition build failure. Since we're not using the
LD_PRELOAD at all on Mingw, we ideally wouldn't compile any of the
mock libraries. Rather than change the build
On 7/20/20 7:33 PM, Daniel P. Berrangé wrote:
We already support a "nocow" flag for storage volumes, but this requires
extra work by the mgmt app or user when creating images on btrfs. We
want to "do the right thing" out of the box for btrfs.
We achieve this by changint the storage pool code so
On 7/20/20 6:32 PM, Daniel P. Berrangé wrote:
We first had a proposal to add a "check" attribute for MAC addresses
https://www.redhat.com/archives/libvir-list/2020-July/msg00617.html
For reasons I don't understand this was then replaced by a "type"
attribute
https://www.redhat.com/archiv
On Wed, Jul 22, 2020 at 01:51:15PM -0400, Laine Stump wrote:
> On 7/22/20 1:21 PM, Daniel P. Berrangé wrote:
> > Historically we avoided -fstack-protector* since it resulted in a broken
> > build on Mingw. In GCC 10 in Fedora though, we have the opposite problem,
> > getting a broken build if we do
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-chardev.rst | 682 +
docs/formatdomain-devices.rst | 684 +-
docs/meson.build | 1 +
3 files changed, 684 insertions(+), 683 deletions(-)
create mode 100644 do
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-sound.rst | 45 +++
docs/formatdomain-devices.rst | 47 +
docs/meson.build| 1 +
3 files changed, 47 insertions(+), 46 deletions(-)
create mode 100644 docs/for
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-tpm.rst | 94 ++
docs/formatdomain-devices.rst | 96 +--
docs/meson.build | 1 +
3 files changed, 96 insertions(+), 95 deletions(-)
create mode 100644 docs/form
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-memory.rst | 151 ++
docs/formatdomain-devices.rst| 154 +--
docs/meson.build | 1 +
3 files changed, 153 insertions(+), 153 deletions(-)
create mode 100644 doc
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-hostdev.rst | 337 +
docs/formatdomain-devices.rst | 339 +-
docs/meson.build | 1 +
3 files changed, 339 insertions(+), 338 deletions(-)
create mode 100644 do
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-interface.rst | 1258 ++
docs/formatdomain-devices.rst | 1260 +--
docs/meson.build|1 +
3 files changed, 1260 insertions(+), 1259 deletions(-)
create mode 1006
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-graphics.rst | 244
docs/formatdomain-devices.rst | 246 +
docs/meson.build | 1 +
3 files changed, 246 insertions(+), 245 deletions(-)
create mode 100644 d
Start splitting out part of into smaller sections.
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-lease.rst | 35 +++
docs/formatdomain-devices.rst | 37 +
docs/meson.build| 1 +
3 files changed, 37 insert
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-rng.rst | 76 ++
docs/formatdomain-devices.rst | 78 +--
docs/meson.build | 1 +
3 files changed, 78 insertions(+), 77 deletions(-)
create mode 100644 docs/form
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-nvram.rst | 26 ++
docs/formatdomain-devices.rst | 28 +---
docs/meson.build| 1 +
3 files changed, 28 insertions(+), 27 deletions(-)
create mode 100644 docs/forma
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-iommu.rst | 54
docs/formatdomain-devices.rst | 56 +
docs/meson.build| 1 +
3 files changed, 56 insertions(+), 55 deletions(-)
create mode 100644 docs/fo
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-hub.rst | 23 +++
docs/formatdomain-devices.rst | 25 +
docs/meson.build | 1 +
3 files changed, 25 insertions(+), 24 deletions(-)
create mode 100644 docs/formatdomain-devi
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-memballoon.rst | 69 +++
docs/formatdomain-devices.rst| 71 +---
docs/meson.build | 1 +
3 files changed, 71 insertions(+), 70 deletions(-)
create mode 100644 do
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-panic.rst | 44 +++
docs/formatdomain-devices.rst | 46 +
docs/meson.build| 1 +
3 files changed, 46 insertions(+), 45 deletions(-)
create mode 100644 docs/for
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-vsock.rst | 22 ++
docs/formatdomain-devices.rst | 24 +---
docs/meson.build| 1 +
3 files changed, 24 insertions(+), 23 deletions(-)
create mode 100644 docs/formatdomain-
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-shmem.rst | 50
docs/formatdomain-devices.rst | 51 +
docs/meson.build| 1 +
3 files changed, 52 insertions(+), 50 deletions(-)
create mode 100644 docs/fo
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-watchdog.rst | 63 +
docs/formatdomain-devices.rst | 65 +-
docs/meson.build | 1 +
3 files changed, 65 insertions(+), 64 deletions(-)
create mode 100644 docs
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-smartcard.rst | 71
docs/formatdomain-devices.rst | 73 +
docs/meson.build| 1 +
3 files changed, 73 insertions(+), 72 deletions(-)
create mode 100644 doc
Start splitting out part of into smaller sections.
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-virtio.rst | 59 +++
docs/formatdomain-devices.rst| 61 +---
docs/meson.build | 1 +
3 files changed, 61 inse
Start splitting out part of into smaller sections.
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-controller.rst | 305 ++
docs/formatdomain-devices.rst| 307 +--
docs/meson.build | 1 +
3 files changed, 30
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-video.rst | 101 +++
docs/formatdomain-devices.rst | 103 +---
docs/meson.build| 1 +
3 files changed, 103 insertions(+), 102 deletions(-)
create mode 100644 docs
Start splitting out part of into smaller sections.
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-filesystem.rst | 169 ++
docs/formatdomain-devices.rst| 171 +--
docs/meson.build | 1 +
3 files changed, 17
Start splitting out part of into smaller sections.
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-disk.rst | 821
docs/formatdomain-devices.rst | 822 +
docs/meson.build | 1 +
3 files changed, 823 inse
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-input.rst | 46 +++
docs/formatdomain-devices.rst | 48 +
docs/meson.build| 1 +
3 files changed, 48 insertions(+), 47 deletions(-)
create mode 100644 docs/for
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-redirdev.rst | 50 +
docs/formatdomain-devices.rst | 52 +-
docs/meson.build | 1 +
3 files changed, 52 insertions(+), 51 deletions(-)
create mode 100644 docs
Start splitting out part of into smaller sections.
Signed-off-by: Peter Krempa
---
docs/formatdomain-devices-address.rst | 92 ++
docs/formatdomain-devices.rst | 94 +--
docs/meson.build | 1 +
3 files changed, 94 ins
Docutils doesn't generate for inline literals (``blah``) in rst
but rather puts them in the '.literal' class. Add a selector for making
them bold as well.
Signed-off-by: Peter Krempa
---
docs/generic.css | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/generic.css b/docs
Prepare for adding per-file properties.
Signed-off-by: Peter Krempa
---
docs/meson.build | 46 +-
1 file changed, 25 insertions(+), 21 deletions(-)
diff --git a/docs/meson.build b/docs/meson.build
index c70669e071..001b1fe6f0 100644
--- a/docs/meson.b
Prepare for splitting out parts of RST documents into separate files by
introducing 'includes' property in the build system. While the include
itself is handled by docutils, it allows us to declare dependencies
between the files so that they are rebuilt properly.
Signed-off-by: Peter Krempa
---
This is full version of:
https://www.redhat.com/archives/libvir-list/2020-July/msg00717.html
where I've split out all the subelements into individual files.
This version is also based on top of Pavel's rewrite to the meson build
system to minimize his conflicts and also it was simpler to achieve
Just convert 'docs_html_in_files' into 'docs_html_in_gen'. The target
definitions for those were almost the same.
Signed-off-by: Peter Krempa
---
docs/meson.build | 37 -
1 file changed, 8 insertions(+), 29 deletions(-)
diff --git a/docs/meson.build b/docs/me
On Thu, Jul 23, 2020 at 14:00:40 +0100, Daniel Berrange wrote:
> On Thu, Jul 23, 2020 at 02:57:32PM +0200, Peter Krempa wrote:
> > On Mon, Jul 20, 2020 at 18:33:19 +0100, Daniel Berrange wrote:
> > > btrfs defaults to performing copy-on-write for files. This is often
> > > undesirable for VM images
ping, I think we need to get this series merged before the release
freeze, or revert the original broken vmx canges.
On Mon, Jul 20, 2020 at 05:32:14PM +0100, Daniel P. Berrangé wrote:
> We first had a proposal to add a "check" attribute for MAC addresses
>
> https://www.redhat.com/archives/li
On Mon, Jul 20, 2020 at 18:33:18 +0100, Daniel Berrange wrote:
> We already support a "nocow" flag for storage volumes, but this requires
> extra work by the mgmt app or user when creating images on btrfs. We
> want to "do the right thing" out of the box for btrfs.
>
> We achieve this by changint
On Mon, Jul 20, 2020 at 18:33:22 +0100, Daniel Berrange wrote:
> The storage pool code now attempts to disable COW by default on btrfs,
> but management applications may wish to override this behaviour. Thus we
> introduce a concept of storage pool features:
>
>
>
>
>
> If the feature
On Thu, Jul 23, 2020 at 14:57:38 +0200, Peter Krempa wrote:
> On Mon, Jul 20, 2020 at 18:33:19 +0100, Daniel Berrange wrote:
> > btrfs defaults to performing copy-on-write for files. This is often
> > undesirable for VM images, so we need to be able to control whether this
> > behaviour is used.
>
On Mon, Jul 20, 2020 at 18:33:19 +0100, Daniel Berrange wrote:
> btrfs defaults to performing copy-on-write for files. This is often
> undesirable for VM images, so we need to be able to control whether this
> behaviour is used.
>
> The virFileSetCOW() will allow for this. We use a tristate, since
On Thu, Jul 23, 2020 at 02:57:32PM +0200, Peter Krempa wrote:
> On Mon, Jul 20, 2020 at 18:33:19 +0100, Daniel Berrange wrote:
> > btrfs defaults to performing copy-on-write for files. This is often
> > undesirable for VM images, so we need to be able to control whether this
> > behaviour is used.
On a Thursday in 2020, Andrea Bolognani wrote:
The Cirrus CI integration was modeled after the Travis CI jobs,
but those were limited to macOS where the test suite is currently
still broken. FreeBSD can run the full distcheck just fine, so
let's do that.
Fixes: 6190c14151c3e2cf5c30b9df9131697f5c
On Thu, Jul 23, 2020 at 12:18:45 +0200, Peter Krempa wrote:
> On Thu, Jul 16, 2020 at 11:56:40 +0200, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/meson.build | 1 +
> > src/qemu/Makefile.inc.am | 106 ---
> > src/{
On Thu, Jul 16, 2020 at 11:56:40 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/meson.build | 1 +
> src/qemu/Makefile.inc.am | 106 ---
> src/{ => qemu}/libvirt_qemu_probes.d | 0
> src/qemu/meson.build
I keep qemu VM event loop exiting synchronously but add code to avoid deadlock
that can be caused by this approach. I guess it is worth having synchronous
exiting of threads in this case to avoid crashes.
Patches that are already positively reviewed has appropriate 'Reviewed-by'
lines.
Changes f
virNetServerClose and virNetServerShutdownWait are used to start net server
threads shutdown and wait net server threads to actually finish respectively
during net daemon shutdown procedure.
Signed-off-by: Nikolay Shirokovskiy
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Daniel Henrique Barboza
Currently we have issues like [1] on libvirtd shutdown as we cleanup while RPC
and other threads are still running. Let's finish all threads other then main
before cleanup.
The approach to finish threads is suggested in [2]. In order to finish RPC
threads serving API calls we let the event loop ru
Signed-off-by: Nikolay Shirokovskiy
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Daniel Henrique Barboza
---
src/libvirt_remote.syms | 1 -
src/rpc/virnetdaemon.c | 13 -
src/rpc/virnetdaemon.h | 2 --
3 files changed, 16 deletions(-)
diff --git a/src/libvirt_remote.syms b/src/
The function is used to set shutdown prepare and wait callbacks. Prepare
callback is used to inform other threads of the daemon that the daemon will be
closed soon so that they can start to shutdown. Wait callback is used to wait
for other threads to actually finish.
Signed-off-by: Nikolay Shiroko
This hunk was introduced in [1] in order to avoid loosing
events from monitor on stopping qemu process. But as explained
in [2] on destroy we won't get neither EOF nor any other
events as monitor is just closed. In case of crash/shutdown
we won't get any more events as well and qemuDomainObjStopWor
Stop just send signal for threads to exit when they finish with
current task. Drain waits when all threads will finish.
Signed-off-by: Nikolay Shirokovskiy
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Daniel Henrique Barboza
---
src/libvirt_private.syms | 2 ++
src/util/virthreadpool.c | 43 +
We are dropping the only reference here so that the event loop thread
is going to be exited synchronously. In order to avoid deadlocks we
need to unlock the VM so that any handler being called can finish
execution and thus even loop thread be finished too.
Signed-off-by: Nikolay Shirokovskiy
---
Second unref was added in [1]. We don't need it actually as
we pass free callback to virNetSocketAddIOCallback thus
when we call virNetSocketRemoveIOCallback the extra ref for
callback will be dropped without extra efforts.
[1] 355d8f470f9: virNetServerServiceClose: Don't leak sockets
Signed-off-
Even if we have no priority threads on pool creation we can add them thru
virThreadPoolSetParameters later.
Signed-off-by: Nikolay Shirokovskiy
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Daniel Henrique Barboza
---
src/util/virthreadpool.c | 22 +++---
1 file changed, 7 inser
It useful to be sure no thread is running after we drop all references to
virEventThread. Otherwise in order to avoid crashes we need to synchronize some
other way or we make extra references in event handler callbacks to all the
object in use. And some of them are not prepared to be refcounted.
S
Signed-off-by: Nikolay Shirokovskiy
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Daniel Henrique Barboza
---
src/util/virthreadpool.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/util/virthreadpool.h b/src/util/virthreadpool.h
index dd1aaf3..cb800dc 100644
--- a/src/util/virthreadp
stateShutdownPrepare is supposed to inform driver that it will be closed soon
so that the driver can prepare and finish all background threads quickly on
stateShutdownWait call.
Signed-off-by: Nikolay Shirokovskiy
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Daniel Henrique Barboza
---
scripts
On shutdown we just stop accepting new jobs for worker thread so that on
shutdown wait we can exit worker thread faster. Yes we basically stop
processing of events for VMs but we are going to do so anyway in case of daemon
shutdown.
At the same time synchronous event processing that some API calls
On Thu, Jul 23, 2020 at 11:47:00AM +0200, Peter Krempa wrote:
> On Thu, Jul 16, 2020 at 11:56:28 +0200, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina
> > ---
>
> [...]
>
> > diff --git a/src/admin/meson.build b/src/admin/meson.build
> > index cf2f206e34a..31d1a437fbe 100644
> > --- a/src/a
On Thu, Jul 16, 2020 at 11:56:29 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/Makefile.am | 1 -
> src/cpu_map/Makefile.inc.am | 78 -
> src/cpu_map/meson.build | 75 +++
> src/meson.build
On Thu, Jul 16, 2020 at 11:56:28 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
[...]
> diff --git a/src/admin/meson.build b/src/admin/meson.build
> index cf2f206e34a..31d1a437fbe 100644
> --- a/src/admin/meson.build
> +++ b/src/admin/meson.build
> @@ -48,3 +48,5 @@ admin_driver_
On Thu, Jul 23, 2020 at 11:15:49AM +0200, Peter Krempa wrote:
> On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
>
> With the most recent version I've fetched from your repository I'm
> seeing the following test failure when building with 'gcc'. 'clang'
> builds fine.
Dan already repor
The Cirrus CI integration was modeled after the Travis CI jobs,
but those were limited to macOS where the test suite is currently
still broken. FreeBSD can run the full distcheck just fine, so
let's do that.
Fixes: 6190c14151c3e2cf5c30b9df9131697f5c3b64b9
Signed-off-by: Andrea Bolognani
---
Test
On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote:
With the most recent version I've fetched from your repository I'm
seeing the following test failure when building with 'gcc'. 'clang'
builds fine.
The output from the failed tests:
11/154 check-virnetprotocolFAIL
>From 3ad3fae4f2562a11bef8dcdd25b6a7e0b00d4e2c Mon Sep 17 00:00:00 2001
From: Hao Wang
Date: Sat, 18 Jul 2020 15:43:30 +0800
Subject: [PATCH] client: fix memory leak in client msg
When closing client->waitDispatch in virNetClientIOEventLoopRemoveAll
or virNetClientIOEventLoopRemoveDone, VIR_FREE(
As `qemuDomainJobInfo` had attributes specific to qemu hypervisor's
jobs, we added it to `privateData` structure.
Supporting functions of `qemuDomainJobInfo` were also moved from
`qemu_domainjob` to `qemu_domain`.
Functions `qemuDomainCurrentJobInfoInit` and
`qemuDomainJobInfoSetOperation` were i
On a Tuesday in 2020, Peter Krempa wrote:
The 'commandhelper' checks effectively whether the parent process is
still around to report whether it was daemonized or not.
This creates a unlikely race condition in cases when we do actually
daemonize the process as the intermediate process used for t
On a Tuesday in 2020, Peter Krempa wrote:
Let the intermediate process linger for a moment to reproduce the
sporradic failure in 'commandtest'.
---
src/util/vircommand.c | 1 +
1 file changed, 1 insertion(+)
This breaks commandtest for me:
TEST: commandtest
5) Command Exec test4 test
On Thu, Jul 23, 2020 at 2:48 PM Peter Krempa wrote:
> On Thu, Jul 23, 2020 at 10:04:08 +0800, Han Han wrote:
> > Signed-off-by: Han Han
> > ---
> > docs/formatdomain.html.in | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/docs/formatdomain.html.in b/docs/formatd
84 matches
Mail list logo
