Re: [PATCH v2 10/13] qemu: avoid deadlock in qemuDomainObjStopWorker

2020-08-10 Thread Nikolay Shirokovskiy
On 10.08.2020 20:40, Daniel Henrique Barboza wrote: > > > On 7/23/20 7:14 AM, Nikolay Shirokovskiy wrote: >> We are dropping the only reference here so that the event loop thread >> is going to be exited synchronously. In order to avoid deadlocks we >> need to unlock the VM so that any handler

[PATCH] Xen: Improve parsing of PCI addresses in config converter

2020-08-10 Thread Jim Fehlig
There was a report on libvirt-users [1] about the domxml to/from native converter in the Xen driver not handling PCI addresses without a domain specification. This patch improves parsing of PCI addresses in the converter and allows PCI addresses with only bb:ss.f. xl.cfg(5) also allows either the d

Re: [PATCH v2 10/13] qemu: avoid deadlock in qemuDomainObjStopWorker

2020-08-10 Thread Daniel Henrique Barboza
On 7/23/20 7:14 AM, Nikolay Shirokovskiy wrote: We are dropping the only reference here so that the event loop thread is going to be exited synchronously. In order to avoid deadlocks we need to unlock the VM so that any handler being called can finish execution and thus even loop thread be fin

Re: [PATCH v2 09/13] vireventthread: exit thread synchronously on finalize

2020-08-10 Thread Daniel Henrique Barboza
On 7/23/20 7:14 AM, Nikolay Shirokovskiy wrote: It useful to be sure no thread is running after we drop all references to Nit: "It is useful to ..." Reviewed-by: Daniel Henrique Barboza virEventThread. Otherwise in order to avoid crashes we need to synchronize some other way or we make

Re: [PATCH v2 05/13] rpc: add virNetDaemonSetShutdownCallbacks

2020-08-10 Thread Daniel Henrique Barboza
On 7/23/20 7:14 AM, Nikolay Shirokovskiy wrote: The function is used to set shutdown prepare and wait callbacks. Prepare callback is used to inform other threads of the daemon that the daemon will be closed soon so that they can start to shutdown. Wait callback is used to wait for other thread

Re: [PATCH v2 08/13] qemu: don't shutdown event thread in monitor EOF callback

2020-08-10 Thread Daniel Henrique Barboza
On 7/23/20 7:14 AM, Nikolay Shirokovskiy wrote: This hunk was introduced in [1] in order to avoid loosing events from monitor on stopping qemu process. But as explained in [2] on destroy we won't get neither EOF nor any other events as monitor is just closed. In case of crash/shutdown we won't

Re: [PATCH] meson: fix some FreeBSD checks regressions

2020-08-10 Thread Roman Bogorodskiy
Pavel Hrdina wrote: > On Sat, Aug 08, 2020 at 01:22:09PM +0400, Roman Bogorodskiy wrote: > > * Add missing prerequisite headers for checking link_addr(3) > >in net/if_dl.h, > > * Add missing prerequisite headers for checking BRDGSFD, BRDGADD, > >BRDGDEL in net/if_bridgevar.h, > > * Wh

Re: [GSoC][PATCH 2/7] qemu_domainjob: added maxQueuedJobs and jobs_queued to `qemuDomainJob`

2020-08-10 Thread Erik Skultety
On Tue, Aug 04, 2020 at 08:06:44PM +0530, Prathamesh Chavan wrote: > Since the attribute `jobs_queued` was specific to jobs, > we decided to move this from `qemuDomainObjPrivate` > to `qemuDomainJobObj` structure. > > Also, reference to `maxQueuedJobs` required us to access > config of the qemu-dri

Re: [GSoC][PATCH 1/7] qemu_domain: Added `qemuDomainJobInfo` to domainJob's `privateData`

2020-08-10 Thread Erik Skultety
On Tue, Aug 04, 2020 at 08:06:43PM +0530, Prathamesh Chavan wrote: > As `qemuDomainJobInfo` had attributes specific to qemu hypervisor's > jobs, we moved the attribute `current` and `completed` from > `qemuDomainJobObj` to its `privateData` structure. > > In this process, two callback functions: `

Re: [libvirt PATCH 00/20] Use SPDX-License-Identifier

2020-08-10 Thread Neal Gompa
On Tue, Aug 4, 2020 at 1:23 PM Ján Tomko wrote: > > Replace the license blurb in every single file with: > SPDX-License-Identifier: > Coincidentally, this is also machine readable. > > This identifies the few places that use GPL-3.0 (syntax-check), > some places that mistakenly changed the blur

Re: [PATCH 0/5] remove NVDIMM auto-alignment for pSeries guests

2020-08-10 Thread Daniel Henrique Barboza
Ping On 7/30/20 4:47 PM, Daniel Henrique Barboza wrote: Hi, In [1] Andrea proposed that we should *not* auto-align down the NVDIMM size for pSeries guests. Instead we should error out and provide users with a suggested aligned value. This patch implements it. [1] https://www.redhat.com/archive

Re: [PATCH 3/4] virdevmapper: Don't use libdevmapper to obtain dependencies

2020-08-10 Thread Christian Ehrhardt
On Thu, Aug 6, 2020 at 4:21 PM Andrea Bolognani wrote: > On Thu, 2020-08-06 at 15:45 +0200, Marc Hartmayer wrote: > > On Tue, Aug 04, 2020 at 11:39 PM +0200, Andrea Bolognani < > abolo...@redhat.com> wrote: > > > This patch broke libvirt in Debian for certain setups. > > > > > > With AppArmor ena

Re: [PATCH] meson: fix some FreeBSD checks regressions

2020-08-10 Thread Pavel Hrdina
On Sat, Aug 08, 2020 at 01:22:09PM +0400, Roman Bogorodskiy wrote: > * Add missing prerequisite headers for checking link_addr(3) >in net/if_dl.h, > * Add missing prerequisite headers for checking BRDGSFD, BRDGADD, >BRDGDEL in net/if_bridgevar.h, > * When checking for ifconfig(8), set no

Re: device compatibility interface for live migration with assigned devices

2020-08-10 Thread Yan Zhao
On Wed, Aug 05, 2020 at 12:53:19PM +0200, Jiri Pirko wrote: > Wed, Aug 05, 2020 at 11:33:38AM CEST, yan.y.z...@intel.com wrote: > >On Wed, Aug 05, 2020 at 04:02:48PM +0800, Jason Wang wrote: > >> > >> On 2020/8/5 下午3:56, Jiri Pirko wrote: > >> > Wed, Aug 05, 2020 at 04:41:54AM CEST, jasow...@redha