Re: [libvirt PATCH 10/11] remote: allocate def in remoteRelayDomainEventCheckACL

On Thu, Aug 27, 2020 at 22:19:52 +0200, Ján Tomko wrote: > Signed-off-by: Ján Tomko > --- > src/remote/remote_daemon_dispatch.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/src/remote/remote_daemon_dispatch.c > b/src/remote/remote_daemon_dispatch.c > index

Re: [libvirt PATCH 08/11] libxl: allocate d_config

On Thu, Aug 27, 2020 at 22:19:50 +0200, Ján Tomko wrote: > clang reports: > > stack frame size of 2152 bytes in function 'libxlDomainStart' > > This is mostly due to the d_config variable: > > sizeof(libxl_domain_config) = 1232 > > Use g_new0 to allocate it and bring the frame size down. >

Re: [libvirt PATCH 3/8] build-aux: vc-list-files: remove non-git support

On Thu, Aug 27, 2020 at 03:27:00PM +0200, Ján Tomko wrote: > Delete support for other VCSs than git. > > This also removes a http: link. > > Signed-off-by: Ján Tomko > --- > build-aux/vc-list-files | 24 > 1 file changed, 24 deletions(-) > > diff --git a/build-aux/vc-list

Re: [libvirt PATCH 0/8] Use https:// more

On Thu, Aug 27, 2020 at 03:26:57PM +0200, Ján Tomko wrote: > Ján Tomko (8): > docs: tlscerts: fix link to certtool invocation > tools: wireshark: fix link to wireshark repo > build-aux: vc-list-files: remove non-git support > vbox: do not repeat the innotek namespace url > Prefer https: f

Re: [libvirt PATCH 8/8] Prefer https: everywhere where possible

On Thu, Aug 27, 2020 at 03:27:05PM +0200, Ján Tomko wrote: > Use https: links for websites that support them. > > The URIs which are used as namespace identifiers > are left alone. > > Signed-off-by: Ján Tomko > --- > docs/acl.html.in | 2 +- > docs/aclpolkit.html.in

[PATCH] meson: Only check for openwsman if hyperv is enabled

Running meson configure with '-Ddriver_hyperv=disabled' fails with meson.build:1252:0: ERROR: Dependency "openwsman" not found, tried pkgconfig and cmake openwsman is only required if the hyperv driver is enabled. Don't check for it if hyperv is disabled. Signed-off-by: Jim Fehlig --- Ther

[libvirt PATCH 09/11] lxc: virLXCProcessStart: use allocated buffers

Lower the stack frame by using allocated buffers. Signed-off-by: Ján Tomko --- src/lxc/lxc_process.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index fc59c2e5af..78509a718e 100644 --- a/src/lxc/lxc_proces

[libvirt PATCH 08/11] libxl: allocate d_config

clang reports: stack frame size of 2152 bytes in function 'libxlDomainStart' This is mostly due to the d_config variable: sizeof(libxl_domain_config) = 1232 Use g_new0 to allocate it and bring the frame size down. Signed-off-by: Ján Tomko --- src/libxl/libxl_domain.c | 24 +--

[libvirt PATCH 10/11] remote: allocate def in remoteRelayDomainEventCheckACL

Signed-off-by: Ján Tomko --- src/remote/remote_daemon_dispatch.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c index 53d17a8f4a..84cc45e1ac 100644 --- a/src/remote/remote_daemon_dispatch.c ++

[libvirt PATCH 11/11] build: lower maximum frame size to 1972

This number is the closest multiple of 1 above the largest frame value reported by clang in the current codebase. It is unrelated to the closure of the last trolleybus line in the UK: https://en.wikipedia.org/wiki/Trolleybuses_in_Bradford Signed-off-by: Ján Tomko --- meson.build | 7 +++

[libvirt PATCH 05/11] conf: introduce virDomainDefClockParse

Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 185 +++-- 1 file changed, 102 insertions(+), 83 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 79998635ac..656277731c 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/dom

[libvirt PATCH 06/11] conf: introduce virDomainDefControllersParse

Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 122 +++-- 1 file changed, 70 insertions(+), 52 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 656277731c..8e2e1eadaa 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/doma

[libvirt PATCH 03/11] conf: introduce virDomainDefTunablesParse

Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 129 - 1 file changed, 75 insertions(+), 54 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 94def18f8a..62f9b6316e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/doma

[libvirt PATCH 04/11] conf: introduce virDomainDefLifecycleParse

Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 86 -- 1 file changed, 50 insertions(+), 36 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 62f9b6316e..79998635ac 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/doma

[libvirt PATCH 07/11] esx: esxConnectOpen: use allocated buffer

Signed-off-by: Ján Tomko --- src/esx/esx_driver.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 3fb7a3b62c..9158a2bc89 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -813,7 +813,7 @@ esxConnectOpen(vir

[libvirt PATCH 00/11] lower maximum frame size

Ján Tomko (11): conf: split out virDomainDefParseIDs conf: split out virDomainDefParseMemory conf: introduce virDomainDefTunablesParse conf: introduce virDomainDefLifecycleParse conf: introduce virDomainDefClockParse conf: introduce virDomainDefControllersParse esx: esxConnectOpen: us

[libvirt PATCH 02/11] conf: split out virDomainDefParseMemory

Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 209 ++--- 1 file changed, 114 insertions(+), 95 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 189f0ac71f..94def18f8a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/dom

[libvirt PATCH 01/11] conf: split out virDomainDefParseIDs

Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 139 +++-- 1 file changed, 79 insertions(+), 60 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5d3ae8bb28..189f0ac71f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/doma

[RFC] Add basic driver for the Cloud-Hypervisor

This patch adds support for the following initial VM actions using the Cloud-Hypervsior API: * vm.create * vm.delete * vm.boot * vm.shutdown * vm.reboot * vm.pause * vm.resume To use the Cloud-Hypervisor driver, the v0.9.0 (the as of now current) release of Cloud-Hypervisor is required to b

Re: [libvirt PATCH] libxl: do not include math.h

On 8/27/20 7:02 AM, Ján Tomko wrote: The include was introduced by: commit 3d6fe99c5c3b862db1b345da3598a920f1079b6e Add vcpu functions to libxl driver which used ceil() and floor(), but these were later removed by: commit 3eb869a04bdeaddbe10e74568540e865fb79e412 libxl: avoid compi

Re: [PATCH] docs: add kbase entry for migrationinternals

On a Thursday in 2020, Fangge Jin wrote: Commit c051e56d27 added migrationinternals.rst in kbase, but the entry was missing. Signed-off-by: Fangge Jin --- docs/kbase.rst | 4 1 file changed, 4 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH] RFC: Add support for vDPA network devices

I got some feedback from John Ferlan on a different forum about missing handling of migration and qemu capabilities. I'm adding this to my patch, but I'd appreciate any additional feedback, particularly on the xml format and the managed=yes/node-device questions below. On Mon, 2020-08-24 at 16:33

[PATCH] news: mention bhyve sound support

Signed-off-by: Roman Bogorodskiy --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2d30d5a5e8..9ded7731f8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -25,6 +25,11 @@ v6.7.0 (unreleased) the ``device_model_args`` setting in xl.cfg(5). The libvirt xen

Re: [PATCH] docs: add kbase entry for migrationinternals

On 8/20/20 12:09 PM, Fangge Jin wrote: Commit c051e56d27 added migrationinternals.rst in kbase, but the entry was missing. Signed-off-by: Fangge Jin --- docs/kbase.rst | 4 1 file changed, 4 insertions(+) Reviewed-by: Michal Privoznik And I think it's safe for freeze but I remember

[libvirt PATCH 2/8] tools: wireshark: fix link to wireshark repo

It seems wireshark has migrated to gitlab in the meantime. Point there instead of to the dead svn repo. Signed-off-by: Ján Tomko --- tools/wireshark/samples/libvirt-sample.pdml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/wireshark/samples/libvirt-sample.pdml b/tool

[libvirt PATCH 7/8] Prefer https: for libguestfs.org links

Signed-off-by: Ján Tomko --- docs/apps.html.in | 10 +- docs/kbase/secureusage.rst | 2 +- docs/pci-hotplug.html.in | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/apps.html.in b/docs/apps.html.in index 606c4c3fc5..92f7950b07 100644 --- a/docs/apps

[libvirt PATCH 8/8] Prefer https: everywhere where possible

Use https: links for websites that support them. The URIs which are used as namespace identifiers are left alone. Signed-off-by: Ján Tomko --- docs/acl.html.in | 2 +- docs/aclpolkit.html.in| 2 +- docs/advanced-tests.rst | 4 ++-- docs/api.

[libvirt PATCH 0/8] Use https:// more

Ján Tomko (8): docs: tlscerts: fix link to certtool invocation tools: wireshark: fix link to wireshark repo build-aux: vc-list-files: remove non-git support vbox: do not repeat the innotek namespace url Prefer https: for Wikipedia links Prefer https: for Red Hat websites Prefer https:

[libvirt PATCH 6/8] Prefer https: for Red Hat websites

The list archives, people.redhat.com and bugzilla all support https. Signed-off-by: Ján Tomko --- docs/apps.html.in | 2 +- docs/best-practices.rst| 2 +- docs/bugs.html.in | 6 +++--- docs/testtck.html.in | 2 +- src/qemu/qemu_domain.c | 2 +- src/remote/remote_d

[libvirt PATCH 4/8] vbox: do not repeat the innotek namespace url

Also, remove the url from the translatable string, reducing it to the generic message already used by virXMLNamespaceRegister. Signed-off-by: Ján Tomko --- src/vbox/vbox_snapshot_conf.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/vbox/vbox_snapshot_conf.c

[libvirt PATCH 5/8] Prefer https: for Wikipedia links

Signed-off-by: Ján Tomko --- docs/formatdomain.rst| 2 +- docs/internals/rpc.html.in | 2 +- docs/remote.html.in | 2 +- docs/securityprocess.html.in | 2 +- docs/tlscerts.html.in| 2 +- src/rpc/virnetclient.c | 2 +- src/util/virarch.h | 72 ++

[libvirt PATCH 3/8] build-aux: vc-list-files: remove non-git support

Delete support for other VCSs than git. This also removes a http: link. Signed-off-by: Ján Tomko --- build-aux/vc-list-files | 24 1 file changed, 24 deletions(-) diff --git a/build-aux/vc-list-files b/build-aux/vc-list-files index af6b1c0f8a..31014d3b7a 100755 --- a/b

[libvirt PATCH 1/8] docs: tlscerts: fix link to certtool invocation

The docs have moved to gnutls.org. Signed-off-by: Ján Tomko --- docs/tlscerts.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tlscerts.html.in b/docs/tlscerts.html.in index 3eea686daa..7d82451741 100644 --- a/docs/tlscerts.html.in +++ b/docs/tlscerts.html.in @@ -

[libvirt PATCH] libxl: do not include math.h

The include was introduced by: commit 3d6fe99c5c3b862db1b345da3598a920f1079b6e Add vcpu functions to libxl driver which used ceil() and floor(), but these were later removed by: commit 3eb869a04bdeaddbe10e74568540e865fb79e412 libxl: avoid compiler warning which did not remove the includ

[libvirt PATCH] docs: formatdomain: fix `since` tag

Fix the `since` tag for the disk target. Signed-off-by: Ján Tomko --- Pushed as trivial. docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 318e39177a..cb5ee8316f 100644 --- a/docs/formatdomain.rst +++ b/

Re: [RFC] apparmor: add subprofile for virtiofsd

On Wed, Aug 26, 2020 at 10:41:15AM +0200, Christian Ehrhardt wrote: > This is a continuation of > https://www.redhat.com/archives/libvir-list/2020-August/msg00804.html > https://www.redhat.com/archives/libvir-list/2020-August/msg00922.html > > It still has too many weak points left, but should be

Re: [PATCH] meson: don't install sysconf files unconditionally

On Wed, Aug 26, 2020 at 06:00:26PM +0400, Roman Bogorodskiy wrote: > There's no need to install sysconf files when init script installation > was not requested, i.e. when configured with init_script=none. > > Signed-off-by: Roman Bogorodskiy > --- > src/meson.build | 16 +--- > 1 fil

[PATCH RFC v3 08/14] target/riscv: Handler KVM_EXIT_RISCV_SBI exit

Use char-fe handler console sbi call, which implement early console io while apply 'earlycon=sbi' into kernel parameters. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 42 - target/riscv/sbi_ecall_interface.h | 72 +

[PATCH RFC v3 13/14] target/riscv: Implement virtual time adjusting with vm state changing

We hope that virtual time adjusts with vm state changing. When a vm is stopped, guest virtual time should stop counting and kvm_timer should be stopped. When the vm is resumed, guest virtual time should continue to count and kvm_timer should be restored. Signed-off-by: Yifei Jiang Signed-off-by:

[PATCH RFC v3 07/14] hw/riscv: PLIC update external interrupt by KVM when kvm enabled

Only support supervisor external interrupt currently. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- hw/riscv/sifive_plic.c | 31 ++- target/riscv/kvm.c | 19 +++ target/riscv/kvm_riscv.h | 1 + 3 files changed, 42 insertions(+), 9

[PATCH RFC v3 12/14] target/riscv: Add kvm_riscv_get/put_regs_timer

Add kvm_riscv_get/put_regs_timer to synchronize virtual time context from KVM. The frequency of virtual time is not supported by KVM_SET_ONE_REG, So it's useless to synchronize the frequency of virtual time. To set register of RISCV_TIMER_REG(state) will occur a error from KVM on kvm_timer_state =

[PATCH RFC v3 05/14] arget/riscv: Implement kvm_arch_put_registers

Put GPR CSR and FP registers to kvm by KVM_SET_ONE_REG ioctl Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 142 - 1 file changed, 141 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c in

[PATCH RFC v3 11/14] target/riscv: Support riscv cpu vmstate

Describe gpr, fpr and csr in vmstate_riscv_cpu. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/cpu.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index d8c32a8f84..b698f4adbb 100644 --- a

[PATCH RFC v3 09/14] target/riscv: Add host cpu type

Currently, host cpu is inherited simply. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/cpu.c | 6 ++ target/riscv/cpu.h | 1 + 2 files changed, 7 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 266e70cc47..d8c32a8f84 100644 --- a/target/risc

[PATCH RFC v3 02/14] target/riscv: Add target/riscv/kvm.c to place the public kvm interface

Add target/riscv/kvm.c to place kvm_arch_* function needed by kvm/kvm-all.c. Meanwhile, add kvm support in configure file. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin Reviewed-by: Alistair Francis --- configure| 1 + target/riscv/kvm.c | 128 +++

[PATCH RFC v3 01/14] linux-header: Update linux/kvm.h

Update linux-headers/linux/kvm.h from https://github.com/kvm-riscv/linux. Only use this header file, so here do not update all linux headers by update-linux-headers.sh until above KVM series is accepted. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- linux-headers/linux/kvm.h | 8

[PATCH RFC v3 03/14] target/riscv: Implement function kvm_arch_init_vcpu

Get isa info from kvm while kvm init. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c index 8c386d9acf..7983f43f3f 100644 --- a/targ

[PATCH RFC v3 04/14] target/riscv: Implement kvm_arch_get_registers

Get GPR CSR and FP registers from kvm by KVM_GET_ONE_REG ioctl. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 150 - 1 file changed, 149 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c

[PATCH RFC v3 06/14] target/riscv: Support start kernel directly by KVM

Get kernel and fdt start address in virt.c, and pass them to KVM when cpu reset. In addition, add kvm_riscv.h to place riscv specific interface. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- hw/riscv/virt.c | 8 target/riscv/cpu.c | 4 target/riscv/cpu.

[PATCH RFC v3 00/14] Add riscv kvm accel support

This series adds both riscv32 and riscv64 kvm support, and implements migration based on riscv. It is based on temporarily unaccepted kvm: https://github.com/kvm-riscv/linux Compared to RFC v2, the migration is supported in this series. The new added migration feature also requires the following p

[PATCH RFC v3 14/14] target/riscv: Support virtual time context synchronization

Add virtual time context description to vmstate_riscv_cpu. After cpu being loaded, virtual time context is updated to KVM. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/cpu.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/target/riscv/cpu.c b/target/ris

[PATCH RFC v3 10/14] target/riscv: Add sifive_plic vmstate

Add sifive_plic vmstate for supporting sifive_plic migration. Current vmstate framework only supports one structure parameter as num field to describe variable length arrays, so introduce num_enables. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- hw/riscv/sifive_plic.c | 24 +

Re: [libvirt PATCH 0.5/2] meson: link libm

On Wed, Aug 26, 2020 at 04:35:10PM -0400, Laine Stump wrote: > > (So here is a separate patch to add linking of libm. Care to ACK it? > Also, what are peoples' opinions of pushing these patches now, so that > they'll be in the upcoming release? I've put them on a private gitlab > b

[question] cpumap: why 'mpx' removed from Cooperlake model?

Hi, Jiri I just compared the cpu features between the 'x86_Cooperlake.xml ' and 'x86_Cascadelake-Server.xml', the feature 'mpx' seems removed from the Cooperlake model. Is there a reason? And what rules do we follow to add or remove CPU features? Regards, Xin