On 9/2/20 3:25 PM, Jonathon Jongsma wrote:
Enable for qemu domains. This provides basic
support and does not support hotplug or migration.
Is there something specifically preventing hotplug, or you just haven't
implemented it yet?
(How does that work with FD passing, anyway? I haven't rea
On 9/2/20 3:25 PM, Jonathon Jongsma wrote:
Recent versions of qemu added the -netdev vhost-vdpa device. This
capability allows libvirt to know whether this is supported.
Looks like you haven't rebased since the capabilities file was added for
qemu 5.2.0, as the capabilitiestest fails.
With
On 9/2/20 3:25 PM, Jonathon Jongsma wrote:
This patch adds new schema and adds support for parsing and formatting
domain configurations that include vdpa devices.
vDPA network devices allow high-performance networking in a virtual
machine by providing a wire-speed data path. These devices requir
On 9/2/20 3:45 PM, Jonathon Jongsma wrote:
Rather than use the names "fial" and "kep", use "fail" and "keep". In
the DO_TEST() macro, to prevent the preprocessor replacing the struct
member names during assignment, use the names "fail_" and "keep_"
instead.
Heh.
Reviewed-by: Laine Stump
and
The summary of commit msg could be more direct:
news: qemu: Support TLS for NBD connections for pull mode backup
And then you can skip the body of commit msg.
On Thu, Sep 3, 2020 at 10:59 AM Yanqiu Zhang wrote:
> Support TLS for NBD connections for pull mode backup.
>
> Signed-off-by: Yanqiu Zh
Support TLS for NBD connections for pull mode backup.
Signed-off-by: Yanqiu Zhang
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e4b71e6563..d0b16e28fc 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -161,6 +161,12 @@ v6.6.0 (2020-08-02)
The secret
Pavel Hrdina wrote:
> On Wed, Sep 02, 2020 at 05:47:43PM +0200, Michal Privoznik wrote:
> > As it turned out my previous commits which switched from HAVE_ to
> > WITH_ and dropped stdarg.h detection were a bit too aggressive.
> > Because of reasons described in 9ea3424a178 we need to define
> >
Ján Tomko wrote:
> On a Wednesday in 2020, Daniel P. Berrangé wrote:
> >On Wed, Sep 02, 2020 at 02:07:54PM +0200, Michal Privoznik wrote:
> >> As it turns out, one of my previous commits in which I removed
> >> checking for stdarg.h was too aggressive. Long story short, the
> >> readline public
Use g_autoptr() in virCPUppc64VendorPtr and remove the now
uneeded 'cleanup' label.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index b003e48bed..6c73145
Next patch will use g_autoptr() in virCPUppc64ModelPtr pointers
for some cleanups.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index 7113c8ac33..02ee4b0ffd 100644
--- a/src/cpu/cpu_pp
We don't need to call virCPUppc64DataFree() in a cleanup label.
This function is already assigned to the 'dataFree' interface
of cpuDriverPPC64, and it will be called by virCPUDataFree(), the
autocleanup function of virCPUDataPtr, via driver->dataFree.
Signed-off-by: Daniel Henrique Barboza
---
Introduce virCPUppc64Model and virCPUppc64ModelPtr types to
improve code readability.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 34 ++
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
Next patch will use g_autoptr() in virCPUppc64VendorPtr pointers
for some cleanups.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index 2a7c955781..b003e48bed 100644
--- a/src/cpu/cpu_p
This allows for a label removal in ppc64ModelParse().
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 33 +
1 file changed, 13 insertions(+), 20 deletions(-)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index bc9d399939..0c140b33e4 1006
Use autocleanup with virCPUppc64MapPtr to simplify existing
code. Remove labels when possible.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 47 ++---
1 file changed, 14 insertions(+), 33 deletions(-)
diff --git a/src/cpu/cpu_ppc64.c b/
Hi,
While reading and studying cpu_ppc64.c I noticed that it
lacks the 'sophistication' that cpu_x86.c and cpu_arm.c
enjoys. This is my attempt to tidy it up a bit, adding some
typedefs and g_auto* cleanups to make it more up to par
with cpu_x86.c
Daniel Henrique Barboza (12):
cpu_ppc64.c: us
Next patch will use g_autoptr() in virCPUppc64MapPtr pointers
for some cleanups.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index 261fe3dbe6..607b5bc322 100644
--- a/src/cpu/cpu_ppc6
Introduce virCPUppc64Map and virCPUppc64MapPtr types to
improve code readability.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index ca
Introduce virCPUppc64Vendor and virCPUppc64VendorPtr types to
improve code readability.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index 5b34c00a1
Use autocleanup with virCPUppc64ModelPtr to simplify existing
code. Remove the 'error' label in ppc64ModelCopy() since it is
now obsolete.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/src
Using g_autoptr() in virCPUDef pointers allows for more
cleanups in ppc64Compute() and virCPUppc64Baseline()
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 55 +
1 file changed, 20 insertions(+), 35 deletions(-)
diff --git a/src/cpu/
Rather than use the names "fial" and "kep", use "fail" and "keep". In
the DO_TEST() macro, to prevent the preprocessor replacing the struct
member names during assignment, use the names "fail_" and "keep_"
instead.
Signed-off-by: Jonathon Jongsma
---
tests/qemuhotplugtest.c | 18 +---
Enable for qemu domains. This provides basic
support and does not support hotplug or migration.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_command.c | 28 --
src/qemu/qemu_command.h | 3 +-
src/qemu/qemu_domain.c
Recent versions of qemu added the -netdev vhost-vdpa device. This
capability allows libvirt to know whether this is supported.
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 3 +++
tests/qemucapabi
This patch adds new schema and adds support for parsing and formatting
domain configurations that include vdpa devices.
vDPA network devices allow high-performance networking in a virtual
machine by providing a wire-speed data path. These devices require a
vendor-specific host driver but the data
vDPA network devices allow high-performance networking in a virtual
machine by providing a wire-speed data path. These devices require a
vendor-specific host driver but the data path follows the virtio
specification.
The support for vDPA devices was recently added to qemu. This allows
libvirt to s
On Tue, Sep 1, 2020 at 3:40 AM Jiri Denemark wrote:
>
> On Sat, Aug 29, 2020 at 20:09:18 -0400, Neal Gompa wrote:
> > The conditional was incorrectly overriding %_vpath_builddir when
> > %rhel is not defined, which led to surprising behavior when the
> > global %_vpath_builddir path is set on Fedo
The systemd .socket unit files we ship for libvirt daemons use
SocketMode=0666 on the assumption that libvirt is built with
polkit which provides access control.
Some people, however, may have explicitly turned off polkit at
build time and not realize that leaves them insecure unless
they also cha
On Wed, Sep 02, 2020 at 05:47:43PM +0200, Michal Privoznik wrote:
> As it turned out my previous commits which switched from HAVE_ to
> WITH_ and dropped stdarg.h detection were a bit too aggressive.
> Because of reasons described in 9ea3424a178 we need to define
> HAVE_STDARG_H before including re
Ping.
On Fri, Aug 07, 2020 at 06:40:48PM +0100, Daniel P. Berrangé wrote:
> We have long had a problem with use of netcat for ssh tunnelling because
> there's no guarantee the UNIX socket path the client builds will match
> the UNIX socket path the remote host uses. We don't even allow session
> m
On 9/1/20 4:15 PM, Han Han wrote:
Since QEMU 1.5.3, the ib700 watchdog device has no options for address,
and not address in device tree:
$ /usr/libexec/qemu-kvm -version
QEMU emulator version 1.5.3 (qemu-kvm-1.5.3-175.el7), Copyright (c) 2003-2008
Fabrice Bellard
$ /usr/libexec/qemu-kvm -devic
On Wed, Sep 02, 2020 at 06:23:32PM +0200, Thomas Huth wrote:
> On 05/08/2020 12.22, Thomas Huth wrote:
> > libvirt currently silently allows and some
> > other timer tags in the guest XML definition for timers that do not
> > exist on non-x86 systems. We should not silently ignore these tags
> > s
On 9/2/20 3:58 PM, Christian Ehrhardt wrote:
In c9ec7088 "storage: extend preallocation flags support for qemu-img"
the option to fallocate was added and meant to be active when (quote):
"the XML described storage matches its "
Up until recently 81a3042a12 "storage_util: fix qemu-img sparse all
On 8/5/20 12:22 PM, Thomas Huth wrote:
libvirt currently silently allows and some
other timer tags in the guest XML definition for timers that do not
exist on non-x86 systems. We should not silently ignore these tags
since the users might not get what they expected otherwise.
Note: The error is
On Wed, Sep 02, 2020 at 06:26:02PM +0200, Thomas Huth wrote:
> On 07/08/2020 18.22, Thomas Huth wrote:
> > On 20/07/2020 12.22, Thomas Huth wrote:
> >> qemuAgentFSInfoToPublic() currently only sets the devAlias for PCI devices.
> >> However, the QEMU guest agent could also provide the device name i
On 07/08/2020 18.22, Thomas Huth wrote:
> On 20/07/2020 12.22, Thomas Huth wrote:
>> qemuAgentFSInfoToPublic() currently only sets the devAlias for PCI devices.
>> However, the QEMU guest agent could also provide the device name in the
>> "dev" field of the response for other devices instead (well,
On 05/08/2020 12.22, Thomas Huth wrote:
> libvirt currently silently allows and some
> other timer tags in the guest XML definition for timers that do not
> exist on non-x86 systems. We should not silently ignore these tags
> since the users might not get what they expected otherwise.
> Note: The
As it turned out my previous commits which switched from HAVE_ to
WITH_ and dropped stdarg.h detection were a bit too aggressive.
Because of reasons described in 9ea3424a178 we need to define
HAVE_STDARG_H before including readline otherwise macos build
fails. Honestly, I still don't fully understa
On 7/27/20 10:28 AM, zhengchuan wrote:
From 935ec812b822ca978631e72bb9b9a5d00df24a42 Mon Sep 17 00:00:00 2001
From: Zheng Chuan
Date: Mon, 27 Jul 2020 14:39:05 +0800
Subject: [PATCH] migration: fix xml file residual during vm crash with
migration
when migration is cancelled (such as kill -9
On 7/27/20 5:28 AM, zhengchuan wrote:
From 935ec812b822ca978631e72bb9b9a5d00df24a42 Mon Sep 17 00:00:00 2001
From: Zheng Chuan
Date: Mon, 27 Jul 2020 14:39:05 +0800
Subject: [PATCH] migration: fix xml file residual during vm crash with
migration
I think the wording here would be 'fix res
In c9ec7088 "storage: extend preallocation flags support for qemu-img"
the option to fallocate was added and meant to be active when (quote):
"the XML described storage matches its "
Up until recently 81a3042a12 "storage_util: fix qemu-img sparse allocation"
the compared allocation size was an or
On a Wednesday in 2020, Daniel P. Berrangé wrote:
On Wed, Sep 02, 2020 at 02:07:54PM +0200, Michal Privoznik wrote:
As it turns out, one of my previous commits in which I removed
checking for stdarg.h was too aggressive. Long story short, the
readline public headers rely on stdarg.h and what is
On 9/2/20 2:20 PM, Daniel P. Berrangé wrote:
On Wed, Sep 02, 2020 at 02:07:54PM +0200, Michal Privoznik wrote:
As it turns out, one of my previous commits in which I removed
checking for stdarg.h was too aggressive. Long story short, the
readline public headers rely on stdarg.h and what is worse
On 8/4/20 4:21 AM, Yilu Lin wrote:
From e28cb2a03a670e4c0e7641f68f9d9f3accb00ae0 Mon Sep 17 00:00:00 2001
From: Yilu Lin
Date: Tue, 4 Aug 2020 02:42:00 -0400
Subject: [PATCH] fix vm schizencephaly when heartbeat stoped
Signed-off-by: Yilu Lin
If keepalive messages lost in finish step, vm
On Wed, Sep 02, 2020 at 02:07:54PM +0200, Michal Privoznik wrote:
> As it turns out, one of my previous commits in which I removed
> checking for stdarg.h was too aggressive. Long story short, the
> readline public headers rely on stdarg.h and what is worse, they
> expect us to declare the autotool
Hello Libvirt community
This is my first time working on a GSoC project with Libvirt. SaltStack is an
open-source project that facilitates configuration management for IT
infrastructures and Virt is a module of SaltStack.
The following 9 PRs summerizes the work I have done during this summer. T
As it turns out, one of my previous commits in which I removed
checking for stdarg.h was too aggressive. Long story short, the
readline public headers rely on stdarg.h and what is worse, they
expect us to declare the autotools style of macro (HAVE_STDARG_H)
if the header file exists. If we don't do
On Tue, Sep 01, 2020 at 09:49:46AM +0200, Bjoern Walk wrote:
> Bjoern Walk [2020-08-24, 01:59PM +0200]:
> > This series enables support for channel subsystem (CSS) devices,
> > Direct Access Storage Devices (DASDs) in the node_device driver and
> > adds support to create vfio-ccw mdev devices in t
On 9/2/20 11:56 AM, Ján Tomko wrote:
On a Tuesday in 2020, Michal Privoznik wrote:
In meson.build, we check for presence of unshare() function
explicitly (even though there is the function usability check a
few hundred lines below), but never have any code depending on
HAVE_UNSHARE. The same ap
On Wed, Sep 02, 2020 at 11:53:37AM +0200, Jiri Denemark wrote:
On Tue, Sep 01, 2020 at 16:36:59 +0200, Martin Kletzander wrote:
This allows:
a) migration without access to network
b) complete control of the migration stream
c) easy migration between containerised libvirt daemons on the sam
On Wed, Sep 02, 2020 at 11:53:37 +0200, Jiri Denemark wrote:
> On Tue, Sep 01, 2020 at 16:36:59 +0200, Martin Kletzander wrote:
> > This allows:
> >
> > a) migration without access to network
> >
> > b) complete control of the migration stream
> >
> > c) easy migration between containerised l
On a Tuesday in 2020, Andrea Bolognani wrote:
vim seems to be able to process the file just fine without a
modeline, so it's probably fair to assume Emacs doesn't need
any extra help either.
Signed-off-by: Andrea Bolognani
---
AUTHORS.rst.in | 5 -
1 file changed, 5 deletions(-)
Reviewed-
On a Tuesday in 2020, Andrea Bolognani wrote:
Now that we have moved to Meson, we are no longer required to
use a specific name for this file, and since the rest of our
documentation is in reStructuredText format and uses a matching
file extension, we can give the AUTHORS file the same treatment.
On a Tuesday in 2020, Michal Privoznik wrote:
In meson.build, we check for presence of unshare() function
explicitly (even though there is the function usability check a
few hundred lines below), but never have any code depending on
HAVE_UNSHARE. The same applies to stdarg.h and sys/sysctl.h
head
On Tue, Sep 01, 2020 at 16:36:59 +0200, Martin Kletzander wrote:
> This allows:
>
> a) migration without access to network
>
> b) complete control of the migration stream
>
> c) easy migration between containerised libvirt daemons on the same host
>
> Resolves: https://bugzilla.redhat.com/16
On Wed, Sep 02, 2020 at 09:12:36AM +0100, Daniel P. Berrangé wrote:
On Tue, Sep 01, 2020 at 04:36:59PM +0200, Martin Kletzander wrote:
This allows:
a) migration without access to network
b) complete control of the migration stream
c) easy migration between containerised libvirt daemons on
On Tue, Sep 01, 2020 at 04:36:59PM +0200, Martin Kletzander wrote:
> This allows:
>
> a) migration without access to network
>
> b) complete control of the migration stream
>
> c) easy migration between containerised libvirt daemons on the same host
>
> Resolves: https://bugzilla.redhat.com/
On Wed, Aug 05, 2020 at 08:02:41PM +0400, Roman Bogorodskiy wrote:
> BSD sed(1) and GNU sed(1) syntax are not compatible, and as
> syntax-check.mk uses the GNU flavor, set SED variable to
> 'gsed' by default.
>
> Signed-off-by: Roman Bogorodskiy
> ---
> build-aux/syntax-check.mk | 8
>
On Tue, Sep 01, 2020 at 04:08:04PM +0200, Pavel Hrdina wrote:
> If someone runs `meson setup --buildtype plain` meson ignores
> warning_level=2 that is in our meson.build file. The implication is
> that Meson will not automatically add -Wall which enables -Wformat.
>
> This breaks building libvirt
Since Nautilus ceph supports separate image namespaces within a pool for
tenant isolation and QEMU adds it as a rbd blockdev options from 5.0.0.
The source name with format "//" could be used to
access a rbd image with namespace.
Add unit tests for this attribute.
https://bugzilla.redhat.com/show
Signed-off-by: Han Han
---
docs/formatdomain.rst | 12 +---
src/conf/domain_conf.c| 35 +++
src/util/virstoragefile.c | 1 +
src/util/virstoragefile.h | 1 +
4 files changed, 42 insertions(+), 7 deletions(-)
diff --git a/docs/formatdomain.rst b/d
Signed-off-by: Han Han
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e4b71e6563..8537da1747 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -20,6 +20,14 @@ v6.8.0 (unreleased)
attribute of the device's element can be used to disable the
The capability flag will be used for rbd namespace option. The rbd namespace
is introduced since ceph Nautilus and qemu v5.0.0.
Signed-off-by: Han Han
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 3 +++
tests/qemucapabilities
v4: https://www.redhat.com/archives/libvir-list/2020-August/msg00351.html
Difference from v4:
- rebase to last master tree
- parse namspace from name attribute and update the documents
- add caps test xml for 5.2.0 x86_64
- adapt to DO_TEST_CAPS_ARCH_LATEST in qemuxml2xmltest in case of the
test
On Tue, Sep 01, 2020 at 04:37:06PM -0600, Jim Fehlig wrote:
> On 9/1/20 8:08 AM, Pavel Hrdina wrote:
> > If someone runs `meson setup --buildtype plain` meson ignores
> > warning_level=2 that is in our meson.build file. The implication is
> > that Meson will not automatically add -Wall which enable
65 matches
Mail list logo
