Default issue template for libvirt.git

2020-12-06 Thread Peter Krempa
Hi, we've recently added templates for issues for the libvirt repo [1]. Unfortunately gitlab made a weird design decision, where the default template is not actually picked from the templates comitted to the repository, but needs to be added in the repo config in the web-ui into a separate textar

Re: Re: [RFCv2 05/46] util: Add helper functions for 'bool' and 'time_t' and cooperate with xmlgen

2020-12-06 Thread Shi Lei
On 2020-12-05 at 02:02, DanielP. Berrangé wrote: >On Fri, Sep 04, 2020 at 11:34:57AM +0800, Shi Lei wrote: >> Signed-off-by: Shi Lei >> --- >>  src/libvirt_private.syms |  3 +++ >>  src/util/virstring.c | 57 >>  src/util/virstring.h |  9 +++ >> 

Re: Re: [RFCv2 01/46] scripts: Add a tool to generate xml parse/format functions

2020-12-06 Thread Shi Lei
On 2020-12-05 at 01:22, DanielP. Berrangé wrote: >On Fri, Sep 04, 2020 at 11:34:53AM +0800, Shi Lei wrote: >> This tool is used to generate parsexml/formatbuf functions. >> It is based on libclang and its python-binding. >> Some directives (such as genparse, xmlattr, etc.) need to be added on >> th

Re: Re: [RFCv2 00/46] RFC: Generate parsexml/formatbuf functions based on directives

2020-12-06 Thread Shi Lei
On 2020-12-05 at 01:41, DanielP. Berrangé wrote: >On Fri, Sep 04, 2020 at 11:34:52AM +0800, Shi Lei wrote: >> V1 here: >> [https://www.redhat.com/archives/libvir-list/2020-June/msg00357.html] > > >> For those new and changed directives, illustrate them by an example: >> >> struct _virDomainGraphic

Re: Re: [RFCv2 02/46] maint: Check python3-clang

2020-12-06 Thread Shi Lei
On 2020-12-04 at 21:01, DanielP. Berrangé wrote: >On Fri, Sep 04, 2020 at 11:34:54AM +0800, Shi Lei wrote: >> Make sure python3-clang has been installed. >> >> Signed-off-by: Shi Lei >> --- >>  meson.build | 5 + >>  1 file changed, 5 insertions(+) >> >> diff --git a/meson.build b/meson.build >

Re: Ping: [PATCH] Qemu: migration: Not bind RAM info with active migration status

2020-12-06 Thread zhukeqian
Hi Daniel, This patch has received ACK from Daniel Henrique Barboza, and waits for your ACK. Do you have any additional suggestion on it? Thanks, Keqian On 2020/12/4 16:12, zhukeqian wrote: > Hi folks, > > Kindly ping. I found that this patch is not applied. > Has reviewed by Daniel Henrique Ba

Re: Ping: [PATCH] Qemu: migration: Not bind RAM info with active migration status

2020-12-06 Thread zhukeqian
Hi Daniel, On 2020/12/4 22:42, Daniel Henrique Barboza wrote: > > > On 12/4/20 5:12 AM, zhukeqian wrote: >> Hi folks, >> >> Kindly ping. I found that this patch is not applied. >> Has reviewed by Daniel Henrique Barboza and Daniel P. Berrangé. > > > It has my ACK, but looking into the messages

Re: [PATCH] spec: keep existing nwfilters uuid on update

2020-12-06 Thread Laine Stump
On 12/3/20 12:31 PM, Andrea Bolognani wrote: On Thu, 2020-12-03 at 17:39 +0100, Michal Privoznik wrote: On 10/26/20 10:21 AM, Nikolay Shirokovskiy wrote: -cp %{_datadir}/libvirt/nwfilter/*.xml %{_sysconfdir}/libvirt/nwfilter/ +# keep existing filters uuid on update +for dfile in %{_datadir}/lib