We were able to get the testing environment running after some
trial-and-error. The issue was that the version of libtirpc was out of
date, causing an error in meson.build when the XDR dependency was being
read. By updating the libtirpc-dev package we were able to start building
locally. However, w
And return the actual extracted value in a parameter. This way we can later
return success even without any extracted value.
Signed-off-by: Martin Kletzander
---
src/esx/esx_driver.c | 31 ++-
src/vmware/vmware_conf.c | 10 +-
src/vmx/vmx.c| 2
The positive branch can just return and the huge negative part does not need to
be indented an extra level. Best viewed with `-w`.
Signed-off-by: Martin Kletzander
---
src/esx/esx_driver.c | 144 +--
1 file changed, 72 insertions(+), 72 deletions(-)
diff
This is perfectly valid in VMWare and the VM just boots with an empty drive. We
used to just skip the whole drive before, but since we changed how we parse
empty cdrom drives this results in an error. Make it behave more closer to
VMWare.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=190
This is perfectly valid in VMWare and the VM just boots with an empty drive. We
used to just skip the whole drive before, but since we changed how we parse
empty cdrom drives this now results in an error and the user not being able to
even dump the XML. Instead of erroring out, just keep the driv
There's only one variable to clean-up, others are just tokens inside that
variable, but it is nicer anyway. Positive returns have not been converted
because the function will change soon and it would not make much sense.
Signed-off-by: Martin Kletzander
---
tests/vmx2xmltest.c | 9 +++--
1
This will be used later.
Signed-off-by: Martin Kletzander
---
src/esx/esx_driver.c | 13 +
src/vmware/vmware_conf.c | 2 +-
src/vmx/vmx.c| 12 +++-
src/vmx/vmx.h| 5 -
tests/vmx2xmltest.c | 13 -
5 files changed, 33 insertion
On Mon, Dec 21, 2020 at 01:09:13PM +0100, Ján Tomko wrote:
On a Monday in 2020, Martin Kletzander wrote:
This is perfectly valid in VMWare and the VM just boots with an empty drive. We
used to just skip the whole drive before, but since we changed how we parse
empty cdrom drives this now result
On Mon, 2020-12-21 at 12:48 +0100, Martin Kletzander wrote:
> This is perfectly valid in VMWare and the VM just boots with an empty
> drive. We
> used to just skip the whole drive before, but since we changed how we
> parse
> empty cdrom drives this now results in an error and the user not
> being
On a Monday in 2020, Martin Kletzander wrote:
This is perfectly valid in VMWare and the VM just boots with an empty drive. We
used to just skip the whole drive before, but since we changed how we parse
empty cdrom drives this now results in an error and the user not being able to
even dump the X
On Mon, Dec 21, 2020 at 09:01:36AM +0100, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
Reviewed-by: Martin Kletzander
---
docs/coding-style.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/coding-style.rst b/docs/coding-style.rst
index b3ac070fac..55dfa196a
This is perfectly valid in VMWare and the VM just boots with an empty drive. We
used to just skip the whole drive before, but since we changed how we parse
empty cdrom drives this now results in an error and the user not being able to
even dump the XML. Instead of erroring out, just keep the driv
On Fri, Dec 18, 2020 at 15:14:01 -0600, Ryan Gahagan wrote:
> On Thu, Dec 17, 2020 at 8:00 AM Peter Krempa wrote:
>
> > Also note that the upstream test-suite run in the CI does actually
> > provide the expected output. Obviously you can't use the ENV variable to
> > automatically overwrite your
Signed-off-by: Tim Wiederhake
---
docs/coding-style.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/coding-style.rst b/docs/coding-style.rst
index b3ac070fac..55dfa196a2 100644
--- a/docs/coding-style.rst
+++ b/docs/coding-style.rst
@@ -939,7 +939,7 @@ ok:
Although l
14 matches
Mail list logo
