Re: [PATCH] NEWS: Mention notable changes

On Tue, Apr 27, 2021 at 09:12:01 -0500, jjong...@redhat.com wrote: > On Tue, 2021-04-27 at 15:37 +0200, Peter Krempa wrote: > > Add entries for deprecation_behavior, improving of errors from > > virsh's > > snapshot helpers and other bugfixes. > > > > Signed-off-by: Peter Krempa > > --- > > NEWS

[PATCH v1] Add basic driver for the Cloud-Hypervisor

Cloud-Hypervisor is a KVM virtualization using hypervisor. It functions similarly to qemu and the libvirt Cloud-Hypervisor driver uses a very similar structure to the libvirt driver. The biggest difference from the libvirt perspective is that the "monitor" socket is seperated into two sockets one

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

On Mon, Jan 11, 2021 at 03:33:32PM -0500, Igor Mammedov wrote: > It is not safe to pretend that emulated NVDIMM supports > persistence while backend actually failed to enable it > and used non-persistent mapping as fall back. > Instead of falling-back, QEMU should be more strict and > error out wit

Re: [libvirt PATCH v2 4/6] virDomainFeaturesDefParse: Use virXMLPropTristateSwitch

On a Tuesday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 141 +++-- 1 file changed, 37 insertions(+), 104 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH v2 6/6] virDomainAudioSDLParse: Use virXMLProp*

On a Tuesday in 2021, Tim Wiederhake wrote: This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `bufferCount`. `bufferCount` does not benefit from being referable as e.g. "-7" for requesting 4294967289 buffers, as this value is distinctly o

Re: [libvirt PATCH v2 5/6] virDomainFeaturesDefParse: Use virXMLPropEnum

On a Tuesday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c| 174 +++--- .../qemuxml2argvdata/aarch64-gic-invalid.err | 2 +- 2 files changed, 64 insertions(+), 112 deletions(-) Reviewed-by: Ján Tomko Jano signa

Re: [libvirt PATCH v2 3/6] virDomainFeaturesDefParse: Use virXMLPropUInt

On a Tuesday in 2021, Tim Wiederhake wrote: This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `retries`. UINT_MAX holds no special significance for this attribute and is distinctly out of range for normal use. Signed-off-by: Tim Wiederhak

Re: [libvirt PATCH v2 2/6] virDomainSoundDefParseXML: Use virXMLProp*

On a Tuesday in 2021, Tim Wiederhake wrote: This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `id`. `id` must be greater than 0 and does not benefit from being referable as e.g. "-7" for host audio backend 4294967289, as this value is dis

Re: [libvirt PATCH v2 1/6] virDomainGraphicsDefParseXMLSpice: Use virXMLProp*

On a Tuesday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 251 ++--- 1 file changed, 59 insertions(+), 192 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9d98f487ea..822426bc4e 10064

Re: [libvirt PATCH v2 00/11] Refactor more XML parsing boilerplate code, part V

On a Friday in 2021, Tim Wiederhake wrote: For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Changes since V1: * Split up patch for virDomainControllerDefParseXML * Code style fixes Tim Wiederhake (11): virXMLPropEnum: Fix return value virDomainContr

Re: [libvirt PATCH] NEWS: mention persistent mediated devices

On a Tuesday in 2021, Jonathon Jongsma wrote: Signed-off-by: Jonathon Jongsma --- NEWS.rst | 11 +++ 1 file changed, 11 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 08/10] conf: domain: Register autoptr cleanup function for virDomainDeviceDef

in the subject, I think you meant to say virDomainShmemDef? On Tue, 2021-04-27 at 17:04 +0200, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- > src/conf/domain_conf.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h > index 58

[libvirt PATCH 09/10] virDomainShmemDef: Use g_auto*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 37 +++-- 1 file changed, 15 insertions(+), 22 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a6547cad8e..2f7878da2b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/doma

[libvirt PATCH 10/10] virDomainRedirFilterUSBDevDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 66 +++--- 1 file changed, 17 insertions(+), 49 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2f7878da2b..805494ca11 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 08/10] conf: domain: Register autoptr cleanup function for virDomainDeviceDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 581ccb05a9..8133d19fca 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3270,6 +3270,7 @@ void virDomainHubDefFree

[libvirt PATCH 07/10] virDomainShmemDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 52 ++ 1 file changed, 12 insertions(+), 40 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8b2a6dcf58..a6547cad8e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 06/10] virDomainShmemDef: Change type of role to virDomainShmemRole

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 4 +++- src/conf/domain_conf.h | 2 +- src/qemu/qemu_command.c | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 72d5545068..8b2a6dcf58 100644 --- a/src/conf/dom

[libvirt PATCH 05/10] virDomainShmemDef: Change type of model to virDomainShmemModel

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c| 4 +++- src/conf/domain_conf.h| 2 +- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_hotplug.c | 4 ++-- src/qemu/qemu_validate.c | 5 + src/security/virt-aa-helper.c | 4 6 files changed, 16 insert

[libvirt PATCH 02/10] virDomainAudioCommonParse: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attributes `voices` (typically 1), `bufferLength` (measured in milliseconds), `frequency` (in Hz, typically 44100), and `channels` (typically 2 for stereo). None of these properties benefit from or ha

[libvirt PATCH 04/10] virDomainMemballoonDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 57 +- 1 file changed, 17 insertions(+), 40 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5ce7a09848..c9134c86c5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf

[libvirt PATCH 03/10] virDomainMemballoonDef: Change type of model to virDomainMemballoonModel

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 4 +++- src/conf/domain_conf.h | 2 +- src/libxl/libxl_conf.c | 8 +++- src/qemu/qemu_domain_address.c | 2 +- src/qemu/qemu_monitor.c| 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git

[libvirt PATCH 01/10] virDomainAudioIOCommon: Change type of format to virDomainAudioFormat

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 - src/conf/domain_conf.h | 2 +- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9d98f487ea..d8e34e79b0 100644 --- a/src/conf/domain_conf.c +++ b/src/co

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part VII

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainAudioIOCommon: Change type of format to virDomainAudioFormat virDomainAudioCommonParse: Use virXMLProp* virDomainMemballoonDef: Change type of model to virDomainMemb

Re: [PATCH] NEWS: Mention notable changes

On Tue, 2021-04-27 at 15:37 +0200, Peter Krempa wrote: > Add entries for deprecation_behavior, improving of errors from > virsh's > snapshot helpers and other bugfixes. > > Signed-off-by: Peter Krempa > --- > NEWS.rst | 48 > 1 file changed, 48 in

Re: [libvirt PATCHv2 0/3] docs: qemu: add socket for virtiofs filesystems

On Fri, 2021-04-23 at 12:03 +0200, Ján Tomko wrote: > Ján Tomko (3): > docs: document new socket attribute for virtiofs > docs: virtiofs: add section about externally-launched virtiofsd > NEWS: qemu: add socket for virtiofs filesystems > > NEWS.rst| 6 ++ > docs/formatd

[PATCH] NEWS: Mention notable changes

Add entries for deprecation_behavior, improving of errors from virsh's snapshot helpers and other bugfixes. Signed-off-by: Peter Krempa --- NEWS.rst | 48 1 file changed, 48 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 5f8b0ae02d..4a5e2c9

[libvirt PATCH] NEWS: mention persistent mediated devices

Signed-off-by: Jonathon Jongsma --- NEWS.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 5f8b0ae02d..f64b24a0e6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -18,6 +18,17 @@ v7.3.0 (unreleased) The xen driver now supports domains with more than 4TB of

Re: [PATCH] qapi: deprecate drive-backup

On Mon, Apr 26, 2021 at 01:34:17PM -0400, John Snow wrote: > On 4/23/21 8:59 AM, Vladimir Sementsov-Ogievskiy wrote: > > Modern way is using blockdev-add + blockdev-backup, which provides a > > lot more control on how target is opened. [...] > 1) Let's add a sphinx reference to > https://qemu-pro

[libvirt PATCH v2 6/6] virDomainAudioSDLParse: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `bufferCount`. `bufferCount` does not benefit from being referable as e.g. "-7" for requesting 4294967289 buffers, as this value is distinctly out of range for normal use. Signed-off-by: Ti

[libvirt PATCH v2 4/6] virDomainFeaturesDefParse: Use virXMLPropTristateSwitch

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 141 +++-- 1 file changed, 37 insertions(+), 104 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b1e5115c7e..4c7affe5af 100644 --- a/src/conf/domain_conf.c +++ b/src/con

[libvirt PATCH v2 5/6] virDomainFeaturesDefParse: Use virXMLPropEnum

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c| 174 +++--- .../qemuxml2argvdata/aarch64-gic-invalid.err | 2 +- 2 files changed, 64 insertions(+), 112 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4c7affe5af..145

[libvirt PATCH v2 2/6] virDomainSoundDefParseXML: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `id`. `id` must be greater than 0 and does not benefit from being referable as e.g. "-7" for host audio backend 4294967289, as this value is distinctly out of range for normal use. Addition

[libvirt PATCH v2 0/6] Refactor more XML parsing boilerplate code, part VI

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html V1: https://listman.redhat.com/archives/libvir-list/2021-April/msg01184.html Changes since V1: * Split up "virDomainFeaturesDefParse" * Added missing VIR_XML_PROP_NONZERO * Some line break changes * Menti

[libvirt PATCH v2 3/6] virDomainFeaturesDefParse: Use virXMLPropUInt

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `retries`. UINT_MAX holds no special significance for this attribute and is distinctly out of range for normal use. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 8 +++- 1

[libvirt PATCH v2 1/6] virDomainGraphicsDefParseXMLSpice: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 251 ++--- 1 file changed, 59 insertions(+), 192 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9d98f487ea..822426bc4e 100644 --- a/src/conf/domain_conf.c +++ b/src/con

Entering freeze for libvirt-7.3.0

I have just tagged v7.3.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

[libvirt PATCH 3/3] cpu-data.py: Automatically adjust command line for kcpuid

kcpuid does not have a "-1" flag. Signed-off-by: Tim Wiederhake --- tests/cputestdata/cpu-data.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cputestdata/cpu-data.py b/tests/cputestdata/cpu-data.py index 4305aacf35..d8a89ebc2a 100755 --- a/tests/cputestdata/cpu-data

[libvirt PATCH 1/3] cpu-data.py: Factor out cpuid parsing

Preparation for next patch. Signed-off-by: Tim Wiederhake --- tests/cputestdata/cpu-data.py | 44 +++ 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/tests/cputestdata/cpu-data.py b/tests/cputestdata/cpu-data.py index df71132c25..ac4d0ff8e7 100755

[libvirt PATCH 0/3] cpu-data.py: Add support for kcpuid

Linux 5.13 introduces "kcpuid", a tool similar to cpuid, which we depend on for cpu-data collection with tests/cputestdata/cpu-data.py. This series adds support for kcpuid to cpu-data.py. See also https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools= /arch/x86/kcpuid and

[libvirt PATCH 2/3] cpu-data.py: Parse kcpuid output

Linux 5.13 introduces "kcpuid", a tool similar to "cpuid", see https://lore.kernel.org/lkml/1614928878-86075-1-git-send-email-feng.t...@intel.com/ Output formats of cpuid and kcpuid differ slightly. This adds support for the latter. Signed-off-by: Tim Wiederhake --- tests/cputestdata/cpu-data.p