Re: [PATCH 3/3] qemu: capabilities: Fill SDL graphics support only when it's really supported

On Tue, Jun 15, 2021 at 21:40:16 +0200, Thomas Huth wrote: > On 15/06/2021 18.05, Peter Krempa wrote: > > virQEMUCapsFillDomainDeviceGraphicsCaps fills data needed both for > > validation of the graphics type and also for correct display in the > > (dom)capablities XML. > > > > Signal the support

Re: [PATCH 3/3] qemu: capabilities: Fill SDL graphics support only when it's really supported

On 15/06/2021 18.05, Peter Krempa wrote: virQEMUCapsFillDomainDeviceGraphicsCaps fills data needed both for validation of the graphics type and also for correct display in the (dom)capablities XML. Signal the support for SDL only when qemu has the capability. Please replace SDL here and in the

Re: [PATCH 00/22] Fix hotplug of disks with iothreads and s390 cruft cleanup

On 6/11/21 4:48 PM, Peter Krempa wrote: This series consists of 3 parts: Part 1, patches 1-3: These are fixes to the virCommand->string conversion, namely two bugs: - VIR_TEST_REGENERATE_OUTPUT would produce new files with missing end newline - memleak in bhyves xml->native c

Re: [libvirt PATCH 3/3] nodedev: handle mdevctl errors consistently

On Tue, Jun 15, 2021 at 11:28:40 -0500, Jonathon Jongsma wrote: > Currently, we have two different types of mdevctl errors: > 1. the command cannot be executed due to some error > 2. the command is executed, but returns an error status > > These two different failures are handled differently. Sc

Re: [libvirt PATCH 2/3] nodedev: Handle NULL command variable

On Tue, Jun 15, 2021 at 11:28:39 -0500, Jonathon Jongsma wrote: > In commit 68580a51, I removed the checks for NULL cmd variables because > virCommandRun() already handles the case where it is called with a NULL > cmd. Unfortunately, it handles this case by raising a generic error > which is both u

Re: [libvirt PATCH 1/3] nodedev: Remove useless device name from error message

On Tue, Jun 15, 2021 at 11:28:38 -0500, Jonathon Jongsma wrote: > At the point where the error message is emitted, the field def->name is > still set to "new device", so the error message becomes: > > Unable to start mediated device 'new device': ... > > Since the name doesn't contain anything

Re: [PATCH] virFindFileInPath: Don't pass NULL to g_canonicalize_filename()

On Tue, Jun 15, 2021 at 18:05:49 +0200, Michal Privoznik wrote: > If given file is not found in $PATH then g_find_program_in_path() > returns NULL. However, g_canonicalize_filename() does not accept > NULL as input. > > Fixes: 65c2901906b5e2d707f9184ff3719a5375bab427 > Signed-off-by: Michal Privoz

[libvirt PATCH 3/3] nodedev: handle mdevctl errors consistently

Currently, we have two different types of mdevctl errors: 1. the command cannot be executed due to some error 2. the command is executed, but returns an error status These two different failures are handled differently. Scenario 1 calls virReportError() from within nodeDeviceGetMdevctlCommand()

[libvirt PATCH 2/3] nodedev: Handle NULL command variable

In commit 68580a51, I removed the checks for NULL cmd variables because virCommandRun() already handles the case where it is called with a NULL cmd. Unfortunately, it handles this case by raising a generic error which is both unhelpful and overwrites our existing error message. So for example, when

[libvirt PATCH 1/3] nodedev: Remove useless device name from error message

At the point where the error message is emitted, the field def->name is still set to "new device", so the error message becomes: Unable to start mediated device 'new device': ... Since the name doesn't contain anything useful, just omit it from the error message altogether. Signed-off-by: Jona

[libvirt PATCH 0/3] mdev tweaks

A few minor fixes to mdev support in the nodedev driver Jonathon Jongsma (3): nodedev: Remove useless device name from error message nodedev: Handle NULL command variable nodedev: handle mdevctl errors consistently src/node_device/node_device_driver.c | 45 ++-- 1 f

[PATCH] virFindFileInPath: Don't pass NULL to g_canonicalize_filename()

If given file is not found in $PATH then g_find_program_in_path() returns NULL. However, g_canonicalize_filename() does not accept NULL as input. Fixes: 65c2901906b5e2d707f9184ff3719a5375bab427 Signed-off-by: Michal Privoznik --- src/util/virfile.c | 2 ++ 1 file changed, 2 insertions(+) diff -

[PATCH 1/3] qemu: capabilities: Un-retire QEMU_CAPS_EGL_HEADLESS

egl-headless graphics can be compiled out in qemu so we need to be able to know whether the given qemu version support it. Base the capability on the presence of the 'egl-headless' member in 'query-display-options' or imply it if 'query-display-options' is not supported as we implied it before for

[PATCH 2/3] tests: qemuxml2*: Add QEMU_CAPS_EGL_HEADLESS to fake-caps tests using egl-headless graphics

Next commit will modify the code so that it validates whether egl-headless is present. Certain tests need to get the egl-headless capability to keep working properly. Signed-off-by: Peter Krempa --- tests/qemuxml2argvtest.c | 9 ++--- tests/qemuxml2xmltest.c | 8 +--- 2 files changed, 1

[PATCH 3/3] qemu: capabilities: Fill SDL graphics support only when it's really supported

virQEMUCapsFillDomainDeviceGraphicsCaps fills data needed both for validation of the graphics type and also for correct display in the (dom)capablities XML. Signal the support for SDL only when qemu has the capability. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 3 ++- 1 file

[PATCH 0/3] qemu: Handle the egl-headless capability properly

Similarly to my previous series dealing with SDL graphics, 'egl-headless' should be getting exactly the same treatment. Peter Krempa (3): qemu: capabilities: Un-retire QEMU_CAPS_EGL_HEADLESS tests: qemuxml2*: Add QEMU_CAPS_EGL_HEADLESS to fake-caps tests using egl-headless graphics qemu:

[PATCH] gitlab-ci: Don't build docs in 'sanitizer' jobs

Docs are not sanitized, thus there's no point in building them. Signed-off-by: Peter Krempa --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index b5930a0a46..3fa616261e 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -86,

Re: [libvirt PATCH 0/4] remote: switch to modular daemons by default

On 6/10/21 3:43 PM, Daniel P. Berrangé wrote: > This series first improves driver probing when using modular daemons. > > Currently when URI is NULL, we connect to virtproxyd and it looks > at which UNIX sockets exist and what binaries exist, to decide which > modular hypervisor daemon to connect

Re: [PATCH 2/2] virStorageBackendRBDGetVolNames: Refactor cleanup in 'rbd_list' version

On 6/15/21 4:16 PM, Peter Krempa wrote: > Use automatic memory freeing for the string list so that we can remove > the cleanup section. > > Signed-off-by: Peter Krempa > --- > src/storage/storage_backend_rbd.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > Reviewed-by:

Re: [PATCH 1/2] virStorageBackendRBDGetVolNames: Fix memory leak in 'rbd_list2' version

On 6/15/21 4:16 PM, Peter Krempa wrote: > The 'rbd_image_spec_t' struct has two string members 'id' and > 'name'. We only stole the 'name' members thus the 'id's as well as the > whole list would be leaked on success. > > Restructure the code so that we copy out the image names and call > rbd_imag

[PATCH 2/2] virStorageBackendRBDGetVolNames: Refactor cleanup in 'rbd_list' version

Use automatic memory freeing for the string list so that we can remove the cleanup section. Signed-off-by: Peter Krempa --- src/storage/storage_backend_rbd.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_

[PATCH 1/2] virStorageBackendRBDGetVolNames: Fix memory leak in 'rbd_list2' version

The 'rbd_image_spec_t' struct has two string members 'id' and 'name'. We only stole the 'name' members thus the 'id's as well as the whole list would be leaked on success. Restructure the code so that we copy out the image names and call rbd_image_spec_list_cleanup on success rather than on error.

[PACH 0/2] virStorageBackendRBDGetVolNames: Fix memory leak and clean up

Peter Krempa (2): virStorageBackendRBDGetVolNames: Fix memory leak in 'rbd_list2' version virStorageBackendRBDGetVolNames: Refactor cleanup in 'rbd_list' version src/storage/storage_backend_rbd.c | 28 +--- 1 file changed, 9 insertions(+), 19 deletions(-) --

Re: [PATCH 4/4] qemu: capabilities: Fill SDL graphics support only when it's really supported

On Tue, Jun 15, 2021 at 12:56:29 +0200, Thomas Huth wrote: > On 15/06/2021 12.01, Peter Krempa wrote: > > virQEMUCapsFillDomainDeviceGraphicsCaps fills data needed both for > > validation of the graphics type and also for correct display in the > > (dom)capablities XML. > > > > Signal the support

Re: [PATCH 00/13] String list handling cleanup in qemu capabilities code

On 6/15/21 12:27 PM, Peter Krempa wrote: > Peter Krempa (13): > qemuMonitorJSONParsePropsList: Refactor cleanup > qemuMonitorJSONGetObjectProps: Refactor cleanup > qemuMonitorJSONGetMigrationCapabilities: Refactor cleanup > qemuMonitorJSONGetCommands: Refactor cleanup > qemuMonitorJSONGet

Re: [PATCH] syntax-check: Only prohibit empty first lines in non-empty files

On 6/15/21 12:42 PM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > build-aux/syntax-check.mk | 5 +++-- > src/esx/README| 1 - > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [PATCH 4/4] qemu: capabilities: Fill SDL graphics support only when it's really supported

On 15/06/2021 12.01, Peter Krempa wrote: virQEMUCapsFillDomainDeviceGraphicsCaps fills data needed both for validation of the graphics type and also for correct display in the (dom)capablities XML. Signal the support for SDL only when qemu has the capability. Signed-off-by: Peter Krempa ---

Re: [PATCH 1/2] test_driver: Implement virNodeGetSecurityModel

On Mon, Jun 07, 2021 at 03:38:18PM +0800, Luke Yue wrote: Signed-off-by: Luke Yue --- src/test/test_driver.c | 32 tests/virshtest.c | 2 ++ 2 files changed, 34 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ea5a5005e7..2651

Re: [PATCH] test_driver: Implement virDomainGetMessages

On Mon, Jun 14, 2021 at 09:13:17PM +0800, Luke Yue wrote: Signed-off-by: Luke Yue --- src/test/test_driver.c | 53 ++ 1 file changed, 53 insertions(+) Similarly to the other patch with virDomainGetSecurityLabelList() this one should also test the added c

Re: [PATCH 2/2] virfile: Simplify virFindFileInPath() with g_find_program_in_path()

On Mon, Jun 07, 2021 at 02:10:48PM +0800, Luke Yue wrote: Signed-off-by: Luke Yue --- src/util/virfile.c | 48 +++--- 1 file changed, 3 insertions(+), 45 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 7fe357ab16..14b45f4e1b 100644

Re: [PATCH 1/2] Replace virFileAbsPath() with g_canonicalize_filename()

On Mon, Jun 07, 2021 at 02:10:47PM +0800, Luke Yue wrote: Signed-off-by: Luke Yue --- src/libvirt-domain.c | 16 src/libvirt_private.syms | 1 - src/util/virfile.c | 23 +-- src/util/virfile.h | 3 --- src/util/virlog.c| 2 +- 5 files ch

Re: [PATCH 2/2] test_driver: Implement virDomainGetSecurityLabel

On Mon, Jun 07, 2021 at 03:38:19PM +0800, Luke Yue wrote: Signed-off-by: Luke Yue Reviewed-by: Martin Kletzander signature.asc Description: PGP signature

[PATCH] ci: Also perform `brew upgrade` on MacOS

Signed-off-by: Martin Kletzander --- @Andrea: if you have a good explanation you'd like to put in the commit message, I'd me glad to add it (or you can do that as well). Thanks .gitlab-ci.yml | 2 ++ ci/cirrus/build.yml | 1 + 2 files changed, 3 insertions(+) diff --git a/.gitlab-ci.yml b

Re: [PATCH] test_driver: Implement virDomainGetSecurityLabelList

On Mon, Jun 14, 2021 at 09:12:57PM +0800, Luke Yue wrote: Signed-off-by: Luke Yue --- src/test/test_driver.c | 41 + 1 file changed, 41 insertions(+) This patch looks fine, but it would be good to have tests for it also. The good thing is that thanks to

[PATCH] syntax-check: Only prohibit empty first lines in non-empty files

Signed-off-by: Martin Kletzander --- build-aux/syntax-check.mk | 5 +++-- src/esx/README| 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 1037d10cd279..eda89f40add3 100644 --- a/build-aux/syntax-check.mk +

[PATCH 12/13] qemuMonitorJSONGetStringArray: Don't return element count

There's just one caller who cares (testQemuMonitorJSONGetTPMModels). Fix it and remove the counting of elements. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 2 +- tests/qemumonitorjsontest.c | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/

[PATCH 13/13] qemuMonitorJSONGetStringListProperty: Don't return element count

The only caller doesn't care about the number of elements in the string list so we don't have to calculate it. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_jso

[PATCH 08/13] testQemuMonitorJSONGetTPMModels: Refactor cleanup

Use automatic memory freeing and remove the cleanup section.t Signed-off-by: Peter Krempa --- tests/qemumonitorjsontest.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 5d03f83787..ab589135ba

[PATCH 11/13] virQEMUCapsProbeQMPTPM: Refactor handling of string lists

This refactors multiple aspects of the function: 1) Use automatic memory freeing 2) Remove need to check element count in the returned arrays 3) Fixes questionable code linebreaks 4) Removes reuse of variables Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 33 ---

[PATCH 06/13] qemuMonitorJSONGetObjectTypes: Refactor cleanup

Use automatic memory clearing to simplify the control flow. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index c25e282d51..

[PATCH 07/13] testQemuMonitorJSONGetCommands: Refactor cleanup

Use g_auto(GStrv) for clearing the string list and thus remove the 'cleanup' section and 'ret' variable. Signed-off-by: Peter Krempa --- tests/qemumonitorjsontest.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumo

[PATCH 10/13] virQEMUCapsProcessStringFlags: Don't require 'nvalues'

All callers pass in NULL-terminated string lists. Remove the 'nvalues' argument and fix all callers. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/src/qemu/qemu_capabilities.

[PATCH 05/13] qemuMonitorJSONGetStringArray: Refactor cleanup

Use automatic memory clearing to simplify the control flow. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 683b389670.

[PATCH 09/13] qemu: capabilities: Use g_auto(GStrv) instead of virStringListFreeCount

All the capability getters which return a string list do in fact return a NULL-terminated list so we can use g_auto(GStrv) to free it. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_c

[PATCH 03/13] qemuMonitorJSONGetMigrationCapabilities: Refactor cleanup

Use automatic memory clearing and remove the cleanup section. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 64696da

[PATCH 04/13] qemuMonitorJSONGetCommands: Refactor cleanup

Use automatic memory freeing to simplify the control flow. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index f0d67f8f20..683b38

[PATCH 01/13] qemuMonitorJSONParsePropsList: Refactor cleanup

Use 'g_auto' for @proplist and remove @ret. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 46aa3330a8..3e7a61c52c 100644 --- a/src/qem

[PATCH 02/13] qemuMonitorJSONGetObjectProps: Refactor cleanup

Use 'g_autoptr' for the two temporary JSON objects and remove the cleanup section. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c ind

[PATCH 00/13] String list handling cleanup in qemu capabilities code

Peter Krempa (13): qemuMonitorJSONParsePropsList: Refactor cleanup qemuMonitorJSONGetObjectProps: Refactor cleanup qemuMonitorJSONGetMigrationCapabilities: Refactor cleanup qemuMonitorJSONGetCommands: Refactor cleanup qemuMonitorJSONGetStringArray: Refactor cleanup qemuMonitorJSONGetObj

Re: [PATCH] docs: add a link to Gitlab on the contributing page

On 6/14/21 10:23 AM, Simon Chopin wrote: > I expect to find a link to the repositories when clicking on > "Contribute", this patch fixes this. The wording is directly inspired by > the one on the hacking page. > > Signed-off-by: Simon Chopin > --- > docs/contribute.html.in | 7 --- > 1 file

Re: [PATCH 0/4] qemu: Handle the SDL capability properly

On 6/15/21 12:01 PM, Peter Krempa wrote: > Thomas' recent qemu patch strives to add proper detectability of SDL > support: > > https://listman.redhat.com/archives/libvir-list/2021-June/msg00398.html > > This series is the libvirt counterpart. > > Note that all capability files we have for now cl

Re: [PATCH 00/22] Fix hotplug of disks with iothreads and s390 cruft cleanup

On 6/11/21 4:48 PM, Peter Krempa wrote: > This series consists of 3 parts: > > Part 1, patches 1-3: > > These are fixes to the virCommand->string conversion, namely two bugs: > - VIR_TEST_REGENERATE_OUTPUT would produce new files with missing end > newline > - memleak in bhyves xml

[PATCH 3/4] tests: qemuxml2*: Add QEMU_CAPS_SDL to fake-caps tests using SDL graphics

Next commit will modify the code so that it validates whether SDL is present. Certain tests need to get the SDL capability to keep working properly. Signed-off-by: Peter Krempa --- tests/qemuxml2argvtest.c | 9 + tests/qemuxml2xmltest.c | 7 --- 2 files changed, 9 insertions(+), 7 d

[PATCH 4/4] qemu: capabilities: Fill SDL graphics support only when it's really supported

virQEMUCapsFillDomainDeviceGraphicsCaps fills data needed both for validation of the graphics type and also for correct display in the (dom)capablities XML. Signal the support for SDL only when qemu has the capability. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 3 ++- 1 file

[PATCH 0/4] qemu: Handle the SDL capability properly

Thomas' recent qemu patch strives to add proper detectability of SDL support: https://listman.redhat.com/archives/libvir-list/2021-June/msg00398.html This series is the libvirt counterpart. Note that all capability files we have for now claim support so the actual effect of this patch will be se

[PATCH 2/4] qemu: capabilities: Un-retire QEMU_CAPS_SDL

SDL graphics can be compiled out in qemu so we need to be able to know whether the given qemu version support it. Base the capability on the presence of the 'sdl' member in 'query-display-options' or imply it if 'query-display-options' is not supported as we implied it before for all versions. Si

[PATCH 1/4] qemu: capabilities: Introduce QEMU_CAPS_QUERY_DISPLAY_OPTIONS

The command allows to query various display-related options. The absence of the command will be used to imply certain video-related capabilities before we would be able to detect them. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabil

Re: [PATCH v2 10/10] vircaps2xmltest: Introduce HMAT test case

On 6/14/21 8:26 PM, Martin Kletzander wrote: > On Thu, Jun 10, 2021 at 03:57:19PM +0200, Michal Privoznik wrote: >> This test was generated on a guest with the following NUMA >> configuration: >> >>    >> >>    >> >> >>    >>    >> >> >>

[PATCH v2] ui: Make the DisplayType enum entries conditional

Libvirt's "domcapabilities" command has a way to state whether certain graphic frontends are available in QEMU or not. Originally, libvirt looked at the "--help" output of the QEMU binary to determine whether SDL was available or not (by looking for the "-sdl" parameter in the help text), but since

Re: [PATCH 01/22] util: command: Introduce virCommandToStringBuf

On 6/11/21 4:48 PM, Peter Krempa wrote: > The new version allows passing a virBuffer to format the string into. > This will be helpful in solving a memory lean in wrong usage of *leak Jano > virCommandToString and also in tests where we need to add a newline > after the command in certain cases.

Re: [libvirt PATCH 0/4] remote: switch to modular daemons by default

On Mon, Jun 14, 2021 at 05:22:22PM -0600, Jim Fehlig wrote: > On 6/10/21 7:43 AM, Daniel P. Berrangé wrote: > > This series first improves driver probing when using modular daemons. > > > > Currently when URI is NULL, we connect to virtproxyd and it looks > > at which UNIX sockets exist and what b

Re: [libvirt PATCH v2 6/6] tests: add launch-security-sev test with latest capabilities

On Mon, Jun 14, 2021 at 16:58:14 +0200, Pavel Hrdina wrote: > QEMU 6.0.0 introduced `confidential-guest-support` -machine option as > a replacement for `memory-encryption`. In order to test it use 6.0.0 > capabilities as well. > > Signed-off-by: Pavel Hrdina > --- > .../launch-security-sev.x86_6

Re: [libvirt] [PATCH 09/12] virsh-volume: Introduce virshStorageVolKeyCompleter

On 6/15/21 2:38 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > tools/virsh-completer-volume.c | 53 ++ > tools/virsh-completer-volume.h | 5 > 2 files changed, 58 insertions(+) > > diff --git a/tools/virsh-completer-volume.c b/tools/virsh-completer-volume

Re: [libvirt] [PATCH 04/12] virsh: Use VIR_ENUM_* for --target argument in cmdDomPMSuspend

On 6/15/21 2:38 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > tools/virsh-domain.c | 10 ++ > tools/virsh-domain.h | 1 + > 2 files changed, 3 insertions(+), 8 deletions(-) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c > index 0100652e76..3fb37ea5e6 100644 > --- a/tool

Re: [libvirt PATCH v2 4/6] tests: add AMD SEV bits into qemu-6.0.0 replies

On Mon, Jun 14, 2021 at 16:58:12 +0200, Pavel Hrdina wrote: > Currently we only have AMD SEV bits in qemu-2.12.0 replies which is way > too old to test new features that require AMD SEV as well. > > Signed-off-by: Pavel Hrdina > --- > tests/domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 5 +++

Re: [libvirt] [PATCH 00/12] virsh bash completion improvement

On 6/15/21 2:38 AM, Lin Ma wrote: > Lin Ma (12): > virsh: Add comp-methods completion to migrate command > virsh: Use VIR_ENUM_* for --target argument in cmdNodeSuspend > virsh: Add target completion to nodesuspend command > virsh: Use VIR_ENUM_* for --target argument in cmdDomPMSuspend >

Re: [libvirt PATCH v2 2/6] qemu_capabilities: detect if confidential-guest-support is available

On Mon, Jun 14, 2021 at 16:58:10 +0200, Pavel Hrdina wrote: > virQEMUCapsProbeQMPMachineProps currently skips any not supported > machine type which includes `none` as well. > > In order to start probing that machine type we need to add an exception > to not skip it when probing QEMU capabilities.

Re: [libvirt PATCH v2 1/6] qemu_capabilities: introduce confidential-guest-support capability

On Mon, Jun 14, 2021 at 16:58:09 +0200, Pavel Hrdina wrote: > In libvirt we already use `query-command-line-options` QMP command but > that is useless as it doesn't provide correct data for `-machine` > option. So we need a new and better way to get that data. > > We already use `qom-list-properti

Re: [libvirt PATCH] qemu_hotplug: Report VIR_ERR_DEVICE_MISSING when device is not found

On Mon, Jun 14, 2021 at 11:18:37 +0100, Lee Yarwood wrote: > 126db34a81bc9f9f9710408f88cceaa1e34bbbd7 had previously switched various > flows over to this from VIR_ERR_OPERATION_FAILED. > > This change simply does the same for qemuDomainDetachPrepDisk, > qemuDomainDetachPrepInput and qemuDomainDet