Hi Michal,
I tried to test the virtio-mem with upstream version v7.7.0-136-g9b49c2c6d3
adding the current patch
(with qemu-6.1.0-7.fc36.x86_64) -
8388608
1179648
1179648
qemu64
...
0
2048
131072
When libxlAutostartDomain was introduced with commit fb92307f0d, one hunk
mistakenly added a call site in libxlStateReload. Domains should not be
autostarted when reloading the driver, so remove the offending hunk.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_driver.c | 4
1 file changed,
On 9/14/21 04:23, Michal Prívozník wrote:
On 9/14/21 12:10 AM, Jim Fehlig wrote:
On reload, the libxl driver calls virDomainObjListLoadAllConfigs to load
all configs from /etc/libvirt/libxl/ but incorrectly passes 'true' for
the liveStatus parameter, resulting in error messages such as
libvirtd
Hi Michal,
> The patch is correct, but what we already have is qemuExtDevicesStop()
> being called from qemuProcessStop(). The former will eventually call
> qemuTPMEmulatorStop() which should kill the swtmp process, shouldn't it?
I'd missed this and that's great to hear, because it means the
upst
On a Tuesday in 2021, Jim Fehlig wrote:
When libxlAutostartDomain was introduced with commit fb92307f0d, one hunk
mistakenly added a call site in libxlStateReload. Domains should not be
autostarted when reloading the driver, so remove the offending hunk.
Signed-off-by: Jim Fehlig
---
src/libxl/
On a Sunday in 2021, Michal Privoznik wrote:
The array of virtual functions @vfs in
virNodeDeviceGetPCISRIOVCaps() is allocated twice: the first time
during its declaration and the second time inside
virPCIGetVirtualFunctions() which leads to a memleak:
==16691== 1,128 bytes in 47 blocks are def
On a Friday in 2021, Michal Privoznik wrote:
When documenting our public API in some places we use '@' to
refer to the variable. For instance:
* This API tries to set guest time to the given value. The time
* to set (@seconds and @nseconds) should be in seconds relative
* to the Epoch of 1970-01
On Mon, Sep 13, 2021 at 05:32:32PM -0400, Michael S. Tsirkin wrote:
> On Mon, Sep 13, 2021 at 12:04:04PM -0500, Mike Christie wrote:
> > I just realized I forgot to cc the virt list so adding now.
> >
> > Christian see the very bottom for a different fork patch.
> >
> > On 7/12/21 7:05 AM, Stefan
On 14.09.21 14:34, David Hildenbrand wrote:
On 13.09.21 16:52, Michal Privoznik wrote:
v4 of:
https://listman.redhat.com/archives/libvir-list/2021-June/msg00679.html
diff to v4:
- Rebased onto current master
- Worked in David's suggestions, e.g. rename from to
, implemented offline memory
On Fri, Sep 10, 2021 at 05:36:58PM +0200, Andrea Bolognani wrote:
> It's been out for a bit.
>
> Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/368763275
>
> Andrea Bolognani (2):
> ci: Add Debian 11 builds
> ci: Regenerate configuration from manifest
>
> .../debian-11-cross
On Tue, Sep 14, 2021 at 04:37:10PM +0200, Peter Krempa wrote:
> These are no longer referenced by any existing test as of:
>
> os-firmware-invalid-type -> a9b1375d7d2f7d240dce09c5f8b62e568e386051
> tseg-explicit-size -> 604990a1758bfdc302f3c576c5766c0763912dfd
>
> Signed-off-by: Peter Krempa
> -
Issuing simple QMP commands is pain as they need to be wrapped by the
JSON wrapper:
{ "execute": "COMMAND" }
and optionally also:
{ "execute": "COMMAND", "arguments":...}
For simple commands without arguments we can add syntax sugar to virsh
which allows simple usage of QMP and additionally p
These are no longer referenced by any existing test as of:
os-firmware-invalid-type -> a9b1375d7d2f7d240dce09c5f8b62e568e386051
tseg-explicit-size -> 604990a1758bfdc302f3c576c5766c0763912dfd
Signed-off-by: Peter Krempa
---
.../qemuxml2argvdata/os-firmware-invalid-type.x86_64-latest.err | 1 -
On Thu, Sep 09, 2021 at 03:58:28PM +0100, Stefan Hajnoczi wrote:
> A number of legacy issues make the virtiofs kbase article hard to
> understand. Most users don't need to configure NUMA or a memory backend
> other than memfd. Move that information to the bottom of the article so
> the recommended
On Tue, Sep 14, 2021 at 03:28:12PM +0200, Tim Wiederhake wrote:
>
> Adding G_GNUC_UNUSED at the usage sites (of which there will be a
> couple hundred), will disable unused variable detection irregardless of
> used compiler, just to work around a bug in one single compiler.
AFAIK, there is /no/ u
On Tue, Sep 14, 2021 at 03:28:06PM +0200, Tim Wiederhake wrote:
> On Fri, 2021-09-10 at 14:35 +0200, Ján Tomko wrote:
> > On a Friday in 2021, Tim Wiederhake wrote:
> > > Workaround for a bug in clang. Clang emits an unused-variable warning
> > > if the variable is only accessed on scope exit by a
On Fri, 2021-09-10 at 14:35 +0200, Ján Tomko wrote:
> On a Friday in 2021, Tim Wiederhake wrote:
> > Workaround for a bug in clang. Clang emits an unused-variable warning
> > if the variable is only accessed on scope exit by a destructor
> > function.
> > Note that gcc does not exhibit this behavio
On Mon, Sep 13, 2021 at 17:52:49 +0300, Nikolay Shirokovskiy wrote:
> ср, 8 сент. 2021 г. в 12:27, Peter Krempa :
>
> > On Tue, Aug 31, 2021 at 16:46:25 +0300, Nikolay Shirokovskiy wrote:
[...]
> > A rather big set of problems which we will necessarily encounter when
> > implementing this comes
On Fri, 2021-09-10 at 14:36 +0200, Ján Tomko wrote:
> On a Friday in 2021, Tim Wiederhake wrote:
> > Signed-off-by: Tim Wiederhake
> > ---
> > src/util/virxml.h | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/src/util/virxml.h b/src/util/virxml.h
> > index 06fb7ae
On Fri, 2021-09-10 at 13:33 +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 10, 2021 at 02:26:32PM +0200, Tim Wiederhake wrote:
> > On Fri, 2021-09-10 at 11:53 +0100, Daniel P. Berrangé wrote:
> > > On Fri, Sep 10, 2021 at 12:45:43PM +0200, Tim Wiederhake wrote:
> > > > Workaround for a bug in clang
On 13.09.21 16:52, Michal Privoznik wrote:
Nothing special is happening here. All important changes were
done when for 'virtio-pmem' (adjusting the code to put virtio
memory on PCI bus, generating alias using
qemuDomainDeviceAliasIndex(). The only bit that might look
suspicious is no prealloc for
On 13.09.21 16:52, Michal Privoznik wrote:
v4 of:
https://listman.redhat.com/archives/libvir-list/2021-June/msg00679.html
diff to v4:
- Rebased onto current master
- Worked in David's suggestions, e.g. rename from to
, implemented offline memory update, implemented --node
argument to vir
zhanglei (5):
domain: add interface information to 'virDomainGetGuestInfo'
virsh: add interface information to guestinfo command
qemu: refactor 'qemuAgentGetInterfaces'
qemu: add guest interface information in 'qemuDomainGetGuestInfo'
NEWS: add guest interface information in 'virDomain
The new parameter group returns information about network interfaces
Signed-off-by: zhanglei
---
docs/manpages/virsh.rst | 12 ++--
src/libvirt-domain.c| 2 +-
tools/virsh-domain.c| 6 ++
3 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/docs/manpages/virsh.rs
Support return guest interface information from guest agent
Signed-off-by: zhanglei
---
src/qemu/qemu_driver.c | 88 +-
1 file changed, 87 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5071faab5e..38a12d18
Signed-off-by: zhanglei
---
include/libvirt/libvirt-domain.h | 1 +
src/libvirt-domain.c | 12
2 files changed, 13 insertions(+)
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index 7ef8ac51e5..b088847725 100644
--- a/include/libvirt/li
Signed-off-by: zhanglei
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 4521499db7..050f22afee 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -19,6 +19,11 @@ v7.8.0 (unreleased)
* **Improvements**
+ * qemu: Report guest interface information in ``vir
Add report_unsupported parameter to qemuAgentGetInterfaces
Signed-off-by: zhanglei
---
src/qemu/qemu_agent.c | 9 ++---
src/qemu/qemu_agent.h | 3 ++-
src/qemu/qemu_driver.c | 2 +-
tests/qemuagenttest.c | 2 +-
4 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu
Sorry I did not notify to this e-mail thread, I resent patches following there
3 reviews on Sep/09 03:35 UTC. I'm glad if you could review it.
-Original Message-
From: Peter Krempa
Sent: Wednesday, September 8, 2021 8:33 PM
To: 成川 弘樹
Cc: libvir-list@redhat.com; 大岩 朗
Subject: Re: [PATC
On Tue, Sep 14, 2021 at 05:43:15 -0500, Or Ozeri wrote:
> Starting from ceph Pacific, RBD has built-in support for image-level
> encryption.
> qemu 6.1 added support for this encryption using a new "encrypt" property
> to the RBD qdict.
> This commit extends the libvirt XML API to allow the user t
Starting from ceph Pacific, RBD has built-in support for image-level encryption.
qemu 6.1 added support for this encryption using a new "encrypt" property
to the RBD qdict.
This commit extends the libvirt XML API to allow the user to choose between
the existing qemu encryption engine, and the new l
On 9/13/21 8:16 AM, Nick Chevsky wrote:
> Launch swtpm(8) with the --terminate switch, which guarantees that
> the daemon will shut itself down when QEMU dies (current behavior).
> We had so far been getting this "for free" (i.e. without --terminate)
> due to a defect in upstream's connection handl
On 9/10/21 3:59 PM, Andrea Bolognani wrote:
> After recent changes.
>
> Andrea Bolognani (2):
> ci: Restore information about Coverity integration
> ci: Avoid use of magic constants
>
> ci/README.rst | 22 ++
> ci/util.py| 3 ++-
> 2 files changed, 24 insertions(+),
On 9/14/21 12:10 AM, Jim Fehlig wrote:
> On reload, the libxl driver calls virDomainObjListLoadAllConfigs to load
> all configs from /etc/libvirt/libxl/ but incorrectly passes 'true' for
> the liveStatus parameter, resulting in error messages such as
>
> libvirtd[21053]: XML error: unexpected root
Now, that there is no user of $PROG_PATH macros the meson script
can be changed so that it doesn't set those macros. It's
redundant as $PROG macro contains the same value.
Signed-off-by: Michal Privoznik
---
meson.build | 2 --
1 file changed, 2 deletions(-)
diff --git a/meson.build b/meson.bui
Due to the way we detect programs at runtime there's no
difference between $PROG and $PROG_PATH macros that come from
meson-config.h. Either both are set to the path found during
configure or both are set to just "$prog", e.g.:
#define EBTABLES "/sbin/ebtables"
#define EBTABLES_PATH "/sbin/ebt
Pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/370312403
Michal Prívozník (3):
lib: Use $PROG instead of $PROG_PATH
meson: Don't set $PROG_PATH macros
meson: Enable ZFS storage backend more often
meson.build | 24 +-
src/util/virfirewall.c | 8 ++--
Currently, the ZFS storage backend is enabled only if both zfs
and zpool binaries were found during configure phase. This is not
consistent with our attempts to move dependencies on binaries
from compile to runtime. And also it is inconsistent with other
backends, e.g. vstorage.
Signed-off-by: Mic
On Tue, Sep 14, 2021 at 15:56:44 +0800, zhanglei wrote:
Please describe your changes in more detail.
> Signed-off-by: zhanglei
> ---
> src/qemu/qemu_agent.c | 9 +++--
> src/qemu/qemu_agent.h | 3 +-
> src/qemu/qemu_driver.c | 89 +-
> tests/qemuagent
On Tue, Sep 14, 2021 at 15:56:43 +0800, zhanglei wrote:
> Signed-off-by: zhanglei
> ---
> docs/manpages/virsh.rst | 12 ++--
> tools/virsh-domain.c| 6 ++
> 2 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
> ind
On Tue, Sep 14, 2021 at 15:56:42 +0800, zhanglei wrote:
We usually ask for commit message, e.g.:
"The new parameter group returns information about network interfaces".
> Signed-off-by: zhanglei
> ---
> include/libvirt/libvirt-domain.h | 1 +
> src/libvirt-domain.c | 13 ++
zhanglei (4):
domain: add interface information to 'virDomainGetGuestInfo'
virsh: add interface information to guestinfo command
qemu: report guest interface information in 'qemuDomainGetGuestInfo'
NEWS: qemu: report guest interfaces information in
'virDomainGetGuestInfo'
NEWS.rst
Signed-off-by: zhanglei
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 4521499db7..9288597f18 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -19,6 +19,11 @@ v7.8.0 (unreleased)
* **Improvements**
+ * qemu: Report guest interfaces information in ``vi
Signed-off-by: zhanglei
---
src/qemu/qemu_agent.c | 9 +++--
src/qemu/qemu_agent.h | 3 +-
src/qemu/qemu_driver.c | 89 +-
tests/qemuagenttest.c | 2 +-
4 files changed, 96 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/q
On Monday, 13 September 2021 13:30:45 CEST Nir Soffer wrote:
> On Mon, Sep 13, 2021 at 11:04 AM Peter Krempa wrote:
> > On Fri, Sep 10, 2021 at 22:04:01 +0300, Nir Soffer wrote:
> > > On Fri, Sep 10, 2021 at 4:35 PM Peter Krempa wrote:
> > > > We don't support all startup policies with all source
Signed-off-by: zhanglei
---
include/libvirt/libvirt-domain.h | 1 +
src/libvirt-domain.c | 13 +
2 files changed, 14 insertions(+)
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index 7ef8ac51e5..b088847725 100644
--- a/include/libvirt/l
Signed-off-by: zhanglei
---
docs/manpages/virsh.rst | 12 ++--
tools/virsh-domain.c| 6 ++
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 9561b3f59d..dd186ab14d 100644
--- a/docs/manpages/virsh.rst
+++ b/doc
On 9/14/21 12:01 AM, Jim Fehlig wrote:
> On Xen, libvirt runs in a VM (typically dom0) and does not have an accurate
> picture of numa and cpu topology of the underlying physical machine using
> the "usual" mechanisms. numa info and cpu toplogy are retrieved from libxl
> and used to populate the li
48 matches
Mail list logo
