DanPB,
Could you please reiterate the suggestion regarding the placement of the
pci root hotplug xml you made in the irc channel?
On Fri, Sep 24, 2021 at 02:16 Laine Stump wrote:
> On 9/11/21 11:26 PM, Ani Sinha wrote:
> > Hi all:
> >
> > This patchset introduces libvirt xml support for the foll
24.09.2021 18:10, Kevin Wolf wrote:
Am 24.09.2021 um 16:02 hat Vladimir Sementsov-Ogievskiy geschrieben:
24.09.2021 12:04, Kevin Wolf wrote:
DeviceState.id is a pointer to a string that is stored in the QemuOpts
object DeviceState.opts and freed together with it. We want to create
devices witho
On Fri, Sep 24, 2021 at 11:04:27AM +0200, Kevin Wolf wrote:
> We want to switch both from QemuOpts to the keyval parser in the future,
> which results in some incompatibilities, mainly around list handling.
> Mark the non-JSON version of both as unstable syntax so that management
> tools switch to
On Fri, Sep 24, 2021 at 11:04:26AM +0200, Kevin Wolf wrote:
> Like we already do for -object, introduce support for JSON syntax in
> -device, which can be kept stable in the long term and guarantees that a
> single code path with identical behaviour is used for both QMP and the
> command line. Comp
On Fri, Sep 24, 2021 at 11:04:25AM +0200, Kevin Wolf wrote:
> Directly call qdev_device_add_from_qdict() for QMP device_add instead of
> first going through QemuOpts and converting back to QDict.
>
> Note that this changes the behaviour of device_add, though in ways that
> should be considered bug
On Fri, Sep 24, 2021 at 11:04:24AM +0200, Kevin Wolf wrote:
> QDicts are both what QMP natively uses and what the keyval parser
> produces. Going through QemuOpts isn't useful for either one, so switch
> the main device creation function to QDicts. By sharing more code with
> the -object/object-add
Hi All!
I'd like to revive discussion on this series. It LGTM with the exception of a
few small nits in 2/3. AFAICT, all concerns were addressed. Are there any
objections to removing these files? Have all distro maintainers spoken their peace?
If there are no objections, it would be nice to g
On 8/2/21 05:18, Olaf Hering wrote:
sysconfig files are owned by the admin of the host. They have the
liberty to put anything they want into these files. This makes it
difficult to provide different built-in defaults.
Remove the sysconfig file and place the current desired default into
the servi
On Fri, Sep 24, 2021 at 11:04:20AM +0200, Kevin Wolf wrote:
> The only thing the string visitor adds compared to a keyval visitor is
> list support. git grep for 'visit_start_list' and 'visit.*List' shows
> that devices don't make use of this.
>
> In a world with a QAPIfied command line interface,
24.09.2021 12:04, Kevin Wolf wrote:
Use QTAILQ_FOREACH_SAFE() so that the current QemuOpts can be deleted
while iterating through the whole list.
Signed-off-by: Kevin Wolf
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On Fri, Sep 24, 2021 at 11:04:17AM +0200, Kevin Wolf wrote:
> ERRP_GUARD() makes debugging easier by making sure that &error_abort
> still fails at the real origin of the error instead of
> error_propagate().
>
> Signed-off-by: Kevin Wolf
> ---
> qom/object.c| 7 +++
> qom/objec
24.09.2021 12:04, Kevin Wolf wrote:
object_property_add_child() fails (with &error_abort) if an object with
the same name already exists. As long as QemuOpts is in use for -device
and device_add, it catches duplicate IDs before qdev_set_id() is even
called. However, for enabling non-QemuOpts code
24.09.2021 12:04, Kevin Wolf wrote:
DeviceState.id is a pointer to a string that is stored in the QemuOpts
object DeviceState.opts and freed together with it. We want to create
devices without going through QemuOpts in the future, so make this a
separately allocated string.
Signed-off-by: Kevin
24.09.2021 12:04, Kevin Wolf wrote:
The iothread isn't called 'iothread0', but 'thread0'. Depending on the
order that properties are parsed, the error message may change from the
expected one to another one saying that the iothread doesn't exist.
Signed-off-by: Kevin Wolf
Reviewed-by: Vladimi
24.09.2021 12:04, Kevin Wolf wrote:
iothread is a string property, so None (= JSON null) is not a valid
value for it. Pass the empty string instead to get the default iothread.
Signed-off-by: Kevin Wolf
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
24.09.2021 12:04, Kevin Wolf wrote:
ERRP_GUARD() makes debugging easier by making sure that &error_abort
still fails at the real origin of the error instead of
error_propagate().
Signed-off-by: Kevin Wolf
---
qom/object.c| 7 +++
qom/object_interfaces.c | 17 ++--
Added by QEMU commit:
b96feb2cb9 "9pfs: local: Add support for custom fmode/dmode in 9ps
mapped security modes"
in 2.10.0
Signed-off-by: Ján Tomko
---
src/qemu/qemu_validate.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 7e4090
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 -
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 -
tests/qemucapabilitiesdata/caps_2
Even though we only allow this option on x86,
all QEMUs report the command line option.
Added in QEMU v1.1:
6a48ffaaa7 "kvm: Activate in-kernel irqchip support"
Remove the pointless capability.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_validate.c | 7 ---
1 file changed, 7 deletions(-)
d
Now that it's no longer used, remove probing for it
and mark it as deprecated.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 -
tests/qemuc
Applies on top of my seccomp sandbox series.
Ján Tomko (4):
qemu: assume QEMU_CAPS_MACHINE_KERNEL_IRQCHIP
qemu: Deprecate QEMU_CAPS_MACHINE_KERNEL_IRQCHIP
qemu: assume QEMU_CAPS_FSDEV_CREATEMODE
qemu: deprecate QEMU_CAPS_FSDEV_CREATEMODE
src/qemu/qemu_capabilities.c
This patch also includes use of an early return in case of an
error. I think the changes make the functions more readable.
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 26 ++
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/tools/virsh-domain
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 62
1 file changed, 22 insertions(+), 40 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 0d482f9e15..1da9b183bf 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh
I removed else branches after return/break as they are not
necessary and the code looks cleaner without them.
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 1692197d1a..3c496d845a 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -5883,13 +5883,13 @@ c
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 84 +---
1 file changed, 33 insertions(+), 51 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 1da9b183bf..1692197d1a 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index edee548d8a..0d482f9e15 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -659,12 +659,9 @@ cmdAtta
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index bee3346eb0..edee548d8a 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -245,18
This is partially v2 of:
https://listman.redhat.com/archives/libvir-list/2021-September/msg00728.html
Diff to v1:
* split changes into smaller patches
Kristina Hanicova (7):
virsh: domain: use early return in virshDomainDefine()
virsh: domain: remove nested 'if' in cmdAttachDisk()
virsh: do
Am 24.09.2021 um 16:02 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 24.09.2021 12:04, Kevin Wolf wrote:
> > DeviceState.id is a pointer to a string that is stored in the QemuOpts
> > object DeviceState.opts and freed together with it. We want to create
> > devices without going through QemuOpts
Am Fri, 24 Sep 2021 08:49:55 -0600
schrieb Jim Fehlig :
> Needs rebased again :-).
Sadly, yes...
Olaf
pgp2jGPfmD95H.pgp
Description: Digitale Signatur von OpenPGP
Assume the presence of the 'sandbox' option is enough,
no need to look at the parameters.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 4f18a2488a..bf
It contains too many negations and conditions that are
no longer relevant now that we only support QEMU >= 2.11.
Signed-off-by: Ján Tomko
---
src/qemu/qemu.conf | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
index 8722dc169
Signed-off-by: Ján Tomko
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 -
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 -
tests/qemucapabilitiesdata/caps_2
There is no QEMU we support that would need the old syntax
for -sandbox on.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index fa9998a191..48df8818a6 100644
--- a/src/qemu/qemu_comma
Inspired by Peter's q-c-l-o cleanups.
Ján Tomko (5):
qemu: always assume QEMU_CAPS_SECCOMP_BLACKLIST
qemu: conf: simplify seccomp_sandbox comment
qemu: seccomp: remove dead code
qemu: capabilities: deprecate QEMU_CAPS_SECCOMP_BLACKLIST
qemu: capabilities: do not look at parameters for sa
elevateprivileges was introduced by QEMU commit:
73a1e64725 "seccomp: add elevateprivileges argument to command line"
released in 2.11.0
and later made conditional on SECCOMP support by:
9d0fdecbad sandbox: disable -sandbox if CONFIG_SECCOMP undefined
Use the existence of the sandbox option as a w
Kevin Wolf writes:
> ERRP_GUARD() makes debugging easier by making sure that &error_abort
> still fails at the real origin of the error instead of
> error_propagate().
>
> Signed-off-by: Kevin Wolf
Yes.
The code you patch uses error_propagate() to work around functions not
returning distinct e
On Fri, Sep 24, 2021 at 11:03 AM Michal Prívozník
wrote:
> On 9/24/21 1:30 AM, Kristina Hanicova wrote:
> > Function returned false when everything ended successfully, there
> > was a missing check for a return value. This patch fixes that.
> >
> > Signed-off-by: Kristina Hanicova
> > ---
> > t
On a Friday in 2021, Michal Privoznik wrote:
Both function description and function itself mention check for
OOM which can't happen really. There was a bug in glib where
g_strdup_*() might have not aborted on OOM, but we have our own
implementation when dealing with broken glib (see
vir_g_strdup_
On a Friday in 2021, Michal Prívozník wrote:
On 9/24/21 1:25 AM, Kristina Hanicova wrote:
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 99 +---
1 file changed, 47 insertions(+), 52 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/vi
Both function description and function itself mention check for
OOM which can't happen really. There was a bug in glib where
g_strdup_*() might have not aborted on OOM, but we have our own
implementation when dealing with broken glib (see
vir_g_strdup_printf()). Therefore, checking for OOM is redun
On Thu, Sep 23, 2021 at 11:23:38AM +0200, Tim Wiederhake wrote:
> When building with "CC=clang", "-Db_sanitize=address,undefined", and
> "-Dbuildtype=debug", the following error occurs:
>
> ../src/conf/nwfilter_conf.c:2190:1: error: stack frame size of 10616
> bytes in function 'virNWFilte
The iothread isn't called 'iothread0', but 'thread0'. Depending on the
order that properties are parsed, the error message may change from the
expected one to another one saying that the iothread doesn't exist.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/051| 2 +-
tests/qemu-iotest
It's still a long way until we'll have QAPIfied devices, but there are
some improvements that we can already make now to make the future switch
easier.
One important part of this is having code paths without QemuOpts, which
we want to get rid of and replace with the keyval parser in the long
run.
object_property_add_child() fails (with &error_abort) if an object with
the same name already exists. As long as QemuOpts is in use for -device
and device_add, it catches duplicate IDs before qdev_set_id() is even
called. However, for enabling non-QemuOpts code paths, we need to make
sure that the
DeviceState.id is a pointer to a string that is stored in the QemuOpts
object DeviceState.opts and freed together with it. We want to create
devices without going through QemuOpts in the future, so make this a
separately allocated string.
Signed-off-by: Kevin Wolf
---
include/hw/qdev-core.h
The only thing the string visitor adds compared to a keyval visitor is
list support. git grep for 'visit_start_list' and 'visit.*List' shows
that devices don't make use of this.
In a world with a QAPIfied command line interface, the keyval visitor is
used to parse the command line. In order to mak
Directly call qdev_device_add_from_qdict() for QMP device_add instead of
first going through QemuOpts and converting back to QDict.
Note that this changes the behaviour of device_add, though in ways that
should be considered bug fixes:
QemuOpts ignores differences between data types, so you could
We want to switch both from QemuOpts to the keyval parser in the future,
which results in some incompatibilities, mainly around list handling.
Mark the non-JSON version of both as unstable syntax so that management
tools switch to JSON and we can later make the change without breaking
things.
Sign
Like we already do for -object, introduce support for JSON syntax in
-device, which can be kept stable in the long term and guarantees that a
single code path with identical behaviour is used for both QMP and the
command line. Compared to the QemuOpts based code, the parser contains
less surprises
QDicts are both what QMP natively uses and what the keyval parser
produces. Going through QemuOpts isn't useful for either one, so switch
the main device creation function to QDicts. By sharing more code with
the -object/object-add code path, we can even reduce the code size a
bit.
This commit doe
Use QTAILQ_FOREACH_SAFE() so that the current QemuOpts can be deleted
while iterating through the whole list.
Signed-off-by: Kevin Wolf
---
util/qemu-option.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/qemu-option.c b/util/qemu-option.c
index 61cb4a97bd..eedd089
On 9/24/21 1:30 AM, Kristina Hanicova wrote:
> Function returned false when everything ended successfully, there
> was a missing check for a return value. This patch fixes that.
>
> Signed-off-by: Kristina Hanicova
> ---
> tools/virsh-domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion
iothread is a string property, so None (= JSON null) is not a valid
value for it. Pass the empty string instead to get the default iothread.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/245 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/245 b/tests
ERRP_GUARD() makes debugging easier by making sure that &error_abort
still fails at the real origin of the error instead of
error_propagate().
Signed-off-by: Kevin Wolf
---
qom/object.c| 7 +++
qom/object_interfaces.c | 17 ++---
2 files changed, 9 insertions(+), 15
On 9/24/21 1:30 AM, Kristina Hanicova wrote:
> Signed-off-by: Kristina Hanicova
> ---
> tools/virsh-domain.c | 14 --
> 1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index 2730acfba5..cfa0016296 100644
> --- a/tools/vi
On Fri, Sep 24, 2021 at 10:02:07 +0200, Michal Prívozník wrote:
> On 9/24/21 1:49 AM, Kristina Hanicova wrote:
> > Signed-off-by: Kristina Hanicova
> > ---
> > tools/virsh-interface.c | 15 ++-
> > tools/virsh-network.c | 17 ++---
> > 2 files changed, 12 insertions(+),
On 9/24/21 1:49 AM, Kristina Hanicova wrote:
> This is partially v2 of:
> https://listman.redhat.com/archives/libvir-list/2021-September/msg00731.html
>
> Diff to v1:
> * split changes into smaller patches
>
> Kristina Hanicova (4):
> virsh: remove variable 'ret' and use early return if possibl
On 9/24/21 1:49 AM, Kristina Hanicova wrote:
> Signed-off-by: Kristina Hanicova
> ---
> tools/virsh-interface.c | 15 ++-
> tools/virsh-network.c | 17 ++---
> 2 files changed, 12 insertions(+), 20 deletions(-)
>
> diff --git a/tools/virsh-interface.c b/tools/virsh-inte
On 9/24/21 1:25 AM, Kristina Hanicova wrote:
> Signed-off-by: Kristina Hanicova
> ---
> tools/virsh-domain.c | 99 +---
> 1 file changed, 47 insertions(+), 52 deletions(-)
>
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index f876f30cc5..b64
On 9/24/21 1:25 AM, Kristina Hanicova wrote:
> This is v2 of patch:
> https://listman.redhat.com/archives/libvir-list/2021-September/msg00730.html
>
> Diff to v1:
> * split the previous patch into more smaller ones to make the code
> review easier
> * small code quality alternations I did not no
62 matches
Mail list logo
