Error messages must conform to spec as specified here:
https://www.libvirt.org/coding-style.html#error-message-format
This change makes some error messages conform to the spec above.
Fixes: 8eadf82fb5 ("conf: introduce option to enable/disable pci hotplug on
pci-root controller")
Signed-off-by:
On Wed, 20 Oct 2021, Laine Stump wrote:
> On 10/18/21 12:31 AM, Ani Sinha wrote:
> > Error messages must conform to spec as specified here:
> > https://www.libvirt.org/coding-style.html#error-message-format
> >
> > This change encloses format specifiers in quotes and unbreaks error
> > messages
On 10/18/21 12:31 AM, Ani Sinha wrote:
Error messages must conform to spec as specified here:
https://www.libvirt.org/coding-style.html#error-message-format
This change encloses format specifiers in quotes and unbreaks error messages.
Fixes: 8eadf82fb5 ("conf: introduce option to enable/disable
Hi,
Yes, the work is in progress. Now. I'm working with a proper solution for
the eBPF RSS helper.
On Wed, Oct 20, 2021 at 3:23 PM Nikolay Shirokovskiy <
nshirokovs...@virtuozzo.com> wrote:
> Hi, Andrew.
>
> We in Virtuozzo are interested in this functionality too. Do you plan to
> continue your
Thanks a lot, much appreciated!
Best Regards,
Dmitrii Shcherbakov
LP/oftc: dmitriis
On Wed, Oct 20, 2021 at 7:21 PM Daniel P. Berrangé wrote:
>
> Since the issues i pointed out are minimal, I've just made them
> myself and will push this once I see gitlab CI passing for it.
>
>
> Regards,
> Dan
Hi, Andrew.
We in Virtuozzo are interested in this functionality too. Do you plan to
continue your work on it?
Nikolay
пн, 16 авг. 2021 г. в 15:00, Andrew Melnichenko :
> Ping
>
> On Wed, Jul 28, 2021 at 11:17 AM Andrew Melnychenko
> wrote:
>
>> This series of patches add RSS property support
On Wed, Oct 20, 2021 at 11:30:30AM +0300, Dmitrii Shcherbakov wrote:
> Add support for deserializing the binary PCI/PCIe VPD format and
> exposing VPD resources as XML elements in a new nested capability
> of PCI/PCIe devices called 'vpd'.
>
> The series contains the following incremental changes:
On Wed, Oct 20, 2021 at 11:30:31AM +0300, Dmitrii Shcherbakov wrote:
> Add support for deserializing the binary PCI/PCIe VPD format and storing
> results in memory.
>
> The VPD format is specified in "I.3. VPD Definitions" in PCI specs
> (2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in
On Wed, Oct 20, 2021 at 11:30:34AM +0300, Dmitrii Shcherbakov wrote:
> Describes the format of the newly added VPD capability and gives and
> example for a real-world device.
>
> Signed-off-by: Dmitrii Shcherbakov
> ---
> docs/drvnodedev.html.in | 69 +
>
On Wed, Oct 20, 2021 at 11:30:31AM +0300, Dmitrii Shcherbakov wrote:
> Add support for deserializing the binary PCI/PCIe VPD format and storing
> results in memory.
>
> The VPD format is specified in "I.3. VPD Definitions" in PCI specs
> (2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in
On Wed, Oct 20, 2021 at 03:44:48PM +0200, Ján Tomko wrote:
> On a Wednesday in 2021, Andrea Bolognani wrote:
> > tests: Add replies for QEMU 6.2.0 on aarch64
> > conf: Make virDomainDeviceInfoFormat() const correct
> > qemu: Make qemuBuildDeviceAddressProps() const correct
> > qemu: Make qemuBu
On Thu, Oct 7, 2021 at 10:41 PM Ján Tomko wrote:
>
> On a Thursday in 2021, Ioanna Alifieraki wrote:
> >This commit aims to address the bug reported in [1] and [2].
> >If the profile is corrupted (0-size) the VM cannot be launched.
> >To overcome this check if the profile exists and if it has 0 s
On 10/20/21 1:18 PM, Peter Krempa wrote:
> On Wed, Oct 20, 2021 at 13:07:59 +0200, Michal Prívozník wrote:
>> On 10/6/21 3:32 PM, Igor Mammedov wrote:
>>> On Thu, 30 Sep 2021 14:08:34 +0200
>>> Peter Krempa wrote:
>
> [...]
>
>> 2) In my experiments I try to mimic what libvirt does. Here's my cm
On a Wednesday in 2021, Andrea Bolognani wrote:
The first patch adds QEMU replies and as such has been aggressively
snipped to deal with mailing list message size limits. Grab the
unabriged version with
$ git fetch https://gitlab.com/abologna/libvirt.git virtio-iommu
As noted in patch 10, the
This is needed so that IOMMU devices can have addresses.
Existing IOMMU devices (intel-iommu and SMMUv3) are system
devices and as such don't have an address associated to them, but
virtio-iommu is a PCI device and needs one.
Signed-off-by: Andrea Bolognani
---
docs/schemas/domaincommon.rng | 6
The device is configured to be an integrated endpoint, as is
necessary for it to function correctly.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain_address.c | 6 +-
.../virtio-iommu-aarch64.aarch64-latest.xml | 4 +++-
.../virtio-iommu-
This new flag can be used to convince the PCI address assignment
algorithm to place a device directly on the root bus. It will be
used to implement support for virtio-iommu, which needs to be an
integrated device in order to work correctly.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_add
virtio-iommu doesn't work without ACPI, so we need to make sure
the latter is enabled.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_validate.c | 6 ++
.../virtio-iommu-no-acpi.x86_64-latest.err| 1 +
tests/qemuxml2argvdata/virtio-iommu-no-acpi.xml |
The altered code is functionally equivalent to the previous one,
but it's already laid down in a way that will make further
changes easier and less messy.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c| 18 +-
src/qemu/qemu_domain_address.c | 23 +
Signed-off-by: Andrea Bolognani
---
docs/formatdomain.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 9bf59936e5..ed9fc735a5 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -7986,8 +7986,9 @@ Exampl
Signed-off-by: Andrea Bolognani
---
NEWS.rst | 4
1 file changed, 4 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index f3b9e5f0cb..07971a6c42 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -40,6 +40,10 @@ v7.9.0 (unreleased)
domain definition when the guest was first started).This setting i
https://bugzilla.redhat.com/show_bug.cgi?id=1653327
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 12 +++-
.../virtio-iommu-aarch64.aarch64-latest.args | 1 +
.../virtio-iommu-x86_64.x86_64-latest.args | 1 +
3 files change
These represent valid uses of the device.
Signed-off-by: Andrea Bolognani
---
.../virtio-iommu-aarch64.aarch64-latest.args | 34 +++
.../qemuxml2argvdata/virtio-iommu-aarch64.xml | 20 +++
.../virtio-iommu-x86_64.x86_64-latest.args| 30
.../qemuxml2a
virtio-iommu needs to be an integrated device, and our address
assignment code will make sure that is the case. If the user has
provided an explicit address, however, we should make sure any
addresses pointing to a different bus are rejected.
Signed-off-by: Andrea Bolognani
---
...io-iommu-inval
virtio-iommu is a PCI device and attempts to use a different
address type should be rejected.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_validate.c | 7 +++
...mmu-invalid-address-type.x86_64-latest.err | 1 +
.../virtio-iommu-invalid-address-type.xml | 20 +
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_validate.c | 8
.../qemuxml2argvdata/virtio-iommu-x86_64.x86_64-6.1.0.err | 1 +
tests/qemuxml2argvtest.c | 1 +
3 files changed, 10 insertions(+)
create mode 100644 tests
This will make it possible to limit changes to a single spot
later on, and is also just an overall nicer way to create and
destroy objects.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 29 +
src/conf/domain_conf.h | 3 +++
2 files changed, 28 insertio
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_validate.c | 8
...irtio-iommu-wrong-machine.x86_64-latest.err | 1 +
.../virtio-iommu-wrong-machine.xml | 18 ++
tests/qemuxml2argvtest.c | 1 +
4 files changed,
Signed-off-by: Andrea Bolognani
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c | 1 +
src/conf/domain_conf.h | 1 +
src/qemu/qemu_command.c| 4
src/qemu/qemu_domain_address.c | 6 ++
src/qemu/qemu_validate.c | 3 +++
6 files changed, 16 ins
This capability detects the availability of the boot-bypass
property of the virtio-iommu-pci device.
This property was only introduced in QEMU 6.2 but, since the
device has been around for much longer, we end up querying its
properties for several more releases. As I don't have convenient
access t
This involves a bit of a hack, but is overall preferable to
forcing callers to pass non-const devdata as argument.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qem
This capability detects the availability of the virtio-iommu-pci
device.
Note that, while this device is present even in somewhat old
versions of QEMU, it's only some recent changes that made it
actually usable for our purposes.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_capabilities.c
There doesn't seem to be a reason for IOMMUs not to be handled
by this function.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a3f0a27058..0618343b79 100644
Signed-off-by: Andrea Bolognani
---
src/conf/domain_addr.c | 4 ++--
src/conf/domain_addr.h | 4 ++--
src/conf/domain_conf.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
index 53b39923e8..fe6520cf3a 100644
--- a/src/conf/do
The first patch adds QEMU replies and as such has been aggressively
snipped to deal with mailing list message size limits. Grab the
unabriged version with
$ git fetch https://gitlab.com/abologna/libvirt.git virtio-iommu
As noted in patch 10, the QEMU feature this series enables has not
yet bee
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 1084f5acc7..035943fa96 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -359,7 +359,7
These were generated using a QEMU binary built from commit
v6.1.0-1552-g362534a643
Notably, this causes the arguments of -device to be generated
in JSON format.
Signed-off-by: Andrea Bolognani
---
.../qemu_6.2.0-virt.aarch64.xml | 184 +
tests/domaincapsdata/qemu_6.2.0.aarch64.x
On 10/19/21 3:43 PM, Stefan Berger wrote:
> Using swtpm v0.7.0 we can run swtpm_setup to create default config files
> for swtpm_setup and swtpm-localca in session mode. Now a user can start
> a VM with an attached TPM without having to run this program on the
> command line before. This program ne
On Wed, Oct 20, 2021 at 13:07:59 +0200, Michal Prívozník wrote:
> On 10/6/21 3:32 PM, Igor Mammedov wrote:
> > On Thu, 30 Sep 2021 14:08:34 +0200
> > Peter Krempa wrote:
[...]
> 2) In my experiments I try to mimic what libvirt does. Here's my cmd
> line:
>
> qemu-system-x86_64 \
> -S \
> -preco
On 10/6/21 3:32 PM, Igor Mammedov wrote:
> On Thu, 30 Sep 2021 14:08:34 +0200
> Peter Krempa wrote:
>
>> On Tue, Sep 21, 2021 at 16:50:31 +0200, Michal Privoznik wrote:
>>> QEMU is trying to obsolete -numa node,cpus= because that uses
>>> ambiguous vCPU id to [socket, die, core, thread] mapping.
On Wed, Oct 20, 2021 at 01:05:20PM +0200, Ján Tomko wrote:
> On a Monday in 2021, Daniel P. Berrangé wrote:
> > The repo-lockdown service used to run as a bot outside GitHub, but has
> > now switched to using the GitHub Actions workflow framework. This
> > requires use of a new configuration file.
On a Monday in 2021, Daniel P. Berrangé wrote:
The repo-lockdown service used to run as a bot outside GitHub, but has
now switched to using the GitHub Actions workflow framework. This
requires use of a new configuration file.
Signed-off-by: Daniel P. Berrangé
---
.github/lockdown.yml
On a Wednesday in 2021, Daniel P. Berrangé wrote:
The non-released distros have reasonably frequent package installation
failures that can last for days at a time. This makes them unsuitable
for use as gating CI jobs.
This ensures all of the jobs in Debian Sid, Fedora Rawhide, openSUSE
Tumblewee
On a Wednesday in 2021, Daniel P. Berrangé wrote:
The layering of the cross containers is fixed to move arch specific
ccache setup out of the common base layer.
A missing Cirrus CI variable substitution is added, though this is
irrelevant given libvirt's package list.
Signed-off-by: Daniel P. B
The non-released distros have reasonably frequent package installation
failures that can last for days at a time. This makes them unsuitable
for use as gating CI jobs.
This ensures all of the jobs in Debian Sid, Fedora Rawhide, openSUSE
Tumbleweed and FreeBSD Current are marked "allow-failure: tru
The layering of the cross containers is fixed to move arch specific
ccache setup out of the common base layer.
A missing Cirrus CI variable substitution is added, though this is
irrelevant given libvirt's package list.
Signed-off-by: Daniel P. Berrangé
---
ci/containers/debian-10-cross-aarch64.
On 10/19/21 4:43 PM, Peter Krempa wrote:
> Patch 1 fixes the bug this series is about, patch 2 fixes same thing in
> the bulk stats. Patches 3-6 remove some pointless cleanup sections and
> patches 7-8 remove the 'backingChain' argument as we always want to
> fetch all stats.
>
> Peter Krempa (8):
Add helper functions to virpci to provide means of checking for a VPD
file presence and for VPD resource retrieval using the PCI VPD parser.
The added test assesses the basic functionality of VPD retrieval while
the full parser is tested by virpcivpdtest.
Signed-off-by: Dmitrii Shcherbakov
---
Add support for deserializing the binary PCI/PCIe VPD format and
exposing VPD resources as XML elements in a new nested capability
of PCI/PCIe devices called 'vpd'.
The series contains the following incremental changes:
* The PCI VPD parser module, in-memory resource representation
and tests;
*
Add support for deserializing the binary PCI/PCIe VPD format and storing
results in memory.
The VPD format is specified in "I.3. VPD Definitions" in PCI specs
(2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in PCIe 4.0
notes, the PCI Local Bus and PCIe VPD formats are binary compatible
an
* XML serialization and deserialization of PCI VPD;
* PCI VPD capability flags added and used in relevant places;
* XML to XML tests for the added capability.
Signed-off-by: Dmitrii Shcherbakov
---
docs/schemas/nodedev.rng | 96 ++
include/libvirt/libvirt-nodedev.h
Signed-off-by: Dmitrii Shcherbakov
---
NEWS.rst | 22 ++
1 file changed, 22 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index f3b9e5f0cb..e7b7dfb4f0 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -40,6 +40,28 @@ v7.9.0 (unreleased)
domain definition when the guest was first
Describes the format of the newly added VPD capability and gives and
example for a real-world device.
Signed-off-by: Dmitrii Shcherbakov
---
docs/drvnodedev.html.in | 69 +
docs/formatnode.html.in | 63 -
2 files changed
53 matches
Mail list logo
