On Sat, Nov 20, 2021 at 5:51 PM Yifei Jiang wrote:
>
> Add asm-riscv/kvm.h for RISC-V KVM, and update linux/kvm.h
>
> Signed-off-by: Yifei Jiang
> Signed-off-by: Mingwang Li
Acked-by: Alistair Francis
Alistair
> ---
> linux-headers/asm-riscv/kvm.h | 128 ++
>
On Mon, 2021-11-22 at 18:12 +0100, Peter Krempa wrote:
> Apart from code simplification the refactor of 'model' fixes an
> unlikely
> memory leak of the string if a duplicate model is found.
>
> While the coversion of 'label' variable may seem unnecessary it will
> come in handy in the next patch.
On Mon, 2021-11-22 at 18:12 +0100, Peter Krempa wrote:
> virXPathStringLimit doesn't give callers a way to differentiate
> between
> the queried XPath being empty and the length limit being exceeded.
>
> This means that callers are either overwriting the error message or
> ignoring it altogether.
On Mon, 2021-11-22 at 18:12 +0100, Peter Krempa wrote:
> (...)
> diff --git a/src/util/virseclabel.h b/src/util/virseclabel.h
> index eca4d09d24..7e62f8a2e2 100644
> --- a/src/util/virseclabel.h
> +++ b/src/util/virseclabel.h
> @@ -43,6 +43,7 @@ struct _virSecurityLabelDef {
> };
>
>
> +
> /* S
On Mon, Nov 22, 2021 at 18:12:29 +0100, Peter Krempa wrote:
> Apart from code simplification the refactor of 'model' fixes an unlikely
> memory leak of the string if a duplicate model is found.
>
> While the coversion of 'label' variable may seem unnecessary it will
> come in handy in the next pat
virXPathStringLimit doesn't give callers a way to differentiate between
the queried XPath being empty and the length limit being exceeded.
This means that callers are overwriting the error message.
Move the length checks into the caller.
Signed-off-by: Peter Krempa
---
src/conf/node_device_con
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 99bee98df8..ee44bbbd4b 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -7808,7
virXPathStringLimit doesn't give callers a way to differentiate between
the queried XPath being empty and the length limit being exceeded.
This means that the callers is completely ignoring the error.
Move the length check into the caller.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c
Apart from code simplification the refactor of 'model' fixes an unlikely
memory leak of the string if a duplicate model is found.
While the coversion of 'label' variable may seem unnecessary it will
come in handy in the next patch.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 14 +++
Signed-off-by: Peter Krempa
---
src/util/virseclabel.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/util/virseclabel.h b/src/util/virseclabel.h
index 18447051fc..77bf6da2c3 100644
--- a/src/util/virseclabel.h
+++ b/src/util/virseclabel.h
@@ -63,4 +63,7 @@ virSecurityDeviceLabelDefCo
The functions have very difficult semantics where callers are not able
to tell whether the property is missing or failed the length check. Only
the latter produces errors.
Since usage of the functions was phased out, remove them completely to
avoid further broken code.
Signed-off-by: Peter Krempa
Use separate variables for 'model' and 'relabel' properties.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 20
src/util/virseclabel.h | 1 +
2 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 24de
The functions have API which is impossible to be use correctly by
callers. Refactor callers and remove the functions.
Note that this patchset preserves semantics of the callers (except for
removing duplicate or ignored errors). Some of the callers look fishy,
but that is not addressed here.
Peter
Use the appropriate enum type instead of an int and fix the XML parser
and one missing fully populated switch.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 14 +-
src/security/security_selinux.c | 3 ++-
src/util/virseclabel.h | 2 +-
3 files changed,
virXPathStringLimit doesn't give callers a way to differentiate between
the queried XPath being empty and the length limit being exceeded.
This means that callers are either overwriting the error message or
ignoring it altogether.
Move the length checks into the caller.
Signed-off-by: Peter Krem
The function produces an error which is ignored in this code path.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d6eefed398..17ba810467 100644
--- a/src/conf/do
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index df0d033d0b..99bee98df8 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -7802,7 +7802,7 @@ vir
'seclabel->label', 'seclabel->imagelabel' and 'seclabel->baselabel' are
populated by stealing the pointer from the 'p' temporary string. Remove
the extra step.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff
在 2021/11/22 22:48, Peter Krempa 写道:
On Sat, Nov 20, 2021 at 03:20:44 -0500, huang...@chinatelecom.cn wrote:
From: "Hyman Huang(黄勇)"
Ping for this series.
I still keep thinking the dirty ring feature is something good to
have for libvirt.
qemu-6.1 has supported dirty ring feature and foll
在 2021/11/22 16:55, Peter Krempa 写道:
On Sat, Nov 20, 2021 at 03:20:48 -0500, huang...@chinatelecom.cn wrote:
From: Hyman Huang(黄勇)
dirty ring feature was introduced in qemu-6.1, this patch add
corresponding feature named 'dirty-ring', which enable
dirty ring feature when starting vm.
to en
在 2021/11/22 16:54, Peter Krempa 写道:
On Sat, Nov 20, 2021 at 03:20:47 -0500, huang...@chinatelecom.cn wrote:
From: Hyman Huang(黄勇)
introduce dirty_ring_size in struct "_virDomainDef" to hold
the ring size configured by user, and pass dirty_ring_size
when building qemu commandline if dirty r
在 2021/11/22 16:50, Peter Krempa 写道:
On Sat, Nov 20, 2021 at 03:20:47 -0500, huang...@chinatelecom.cn wrote:
From: Hyman Huang(黄勇)
introduce dirty_ring_size in struct "_virDomainDef" to hold
the ring size configured by user, and pass dirty_ring_size
when building qemu commandline if dirty r
On a Sunday in 2021, Martin Kletzander wrote:
The reason for this is twofold:
- the polkit build option is documented for UNIX socket access checks
- there is no server-side change or dbus call done when enabling this as it only
starts a polkit agent on the client-side (actually only in virsh)
On a Sunday in 2021, Martin Kletzander wrote:
Trying to connect once without a polkit agent will generate an error on the
server side which seems too rough given it only serves the purpose of the client
(virsh in this case) to figure out that an agent is needed. Thankfully we can
just try runnin
On a Sunday in 2021, Martin Kletzander wrote:
It does not need a tty to work, it opens its controlling terminal for user
interaction and with this patch even crazy things like this work:
echo 'list --name' | virsh -q >/dev/null
Signed-off-by: Martin Kletzander
---
src/util/virpolkit.c | 4 ++-
On a Sunday in 2021, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander
---
src/util/virpolkit.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Sunday in 2021, Martin Kletzander wrote:
With this function we can decide whether to try running the polkit text agent
only if it is available, removing a potential needless error saying that the
agent binary does not exist, which is useful especially when running the agent
before knowing wh
On a Sunday in 2021, Martin Kletzander wrote:
Automatic "Ptr " -> " *" also wreaked havoc in comments. Fix it and while at it
reword the sentence so it is clear that the object is newly allocated.
Signed-off-by: Martin Kletzander
---
src/util/virpolkit.c | 2 +-
1 file changed, 1 insertion(+),
On a Sunday in 2021, Martin Kletzander wrote:
It only redundantly reflects whether pkagent != NULL.
Signed-off-by: Martin Kletzander
---
tools/virsh.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On Sat, Nov 20, 2021 at 03:20:44 -0500, huang...@chinatelecom.cn wrote:
> From: "Hyman Huang(黄勇)"
>
> Ping for this series.
>
> I still keep thinking the dirty ring feature is something good to
> have for libvirt.
>
> qemu-6.1 has supported dirty ring feature and followed up with the
> commit 0
On Tue, Nov 16, 2021 at 03:30:02PM +0100, Peter Krempa wrote:
> On Mon, Nov 15, 2021 at 17:22:46 +0100, Pavel Hrdina wrote:
> > Now that we always restart QEMU process the loadvm code is unused and
> > can be dropped.
> >
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/qemu/qemu_snapshot.c | 96
On 11/16/21 00:05, Praveen K Paladugu wrote:
>
>
> I started refactoring this commit to have shared methods between qemu
> and ch drviers for cgroup management. While doing so, I realized, I
> still need a mechanism to identify what the underlying driver is : ch/qemu.
>
> An example of it is the
On 11/22/21 10:30, Peter Krempa wrote:
> On Fri, Nov 05, 2021 at 10:35:19 +0100, Michal Privoznik wrote:
>> It may come handy to be able to tweak TCG options, in this
>> specific case the size of translation block cache size (tb-size).
>> Since we can expect more knobs to tweak let's put them under
On Mon, Nov 22, 2021 at 12:32:03 +0100, Pavel Hrdina wrote:
> On Tue, Nov 16, 2021 at 03:17:56PM +0100, Peter Krempa wrote:
> > On Mon, Nov 15, 2021 at 17:22:45 +0100, Pavel Hrdina wrote:
> > > Our compatibility check code isn't complete and there are cases where it
> > > fails to detect incompatib
On a Friday in 2021, Pavel Hrdina wrote:
Git bisect took me to commit where incorrect usage of ATTRIBUTE_NONNULL
was introduced and caused coverity scan to fail. This patch fixes the
issue where the index starts from 1 and not 0 and two other different
cases.
Signed-off-by: Pavel Hrdina
---
src
On Tue, Nov 16, 2021 at 03:17:56PM +0100, Peter Krempa wrote:
> On Mon, Nov 15, 2021 at 17:22:45 +0100, Pavel Hrdina wrote:
> > Our compatibility check code isn't complete and there are cases where it
> > fails to detect incompatible configuration and the revert fails. In
> > addition future suppor
Martin Kletzander wrote:
> On Sun, Nov 21, 2021 at 07:58:55PM +0400, Roman Bogorodskiy wrote:
> >Recently, FreeBSD has got sched_get/setaffinity(3) implementations and
> >the sched.h header as well [1]. To make these routines visible,
> >users have to define _WITH_CPU_SET_T.
> >
> >This breaks c
On Mon, Nov 22, 2021 at 11:03:53AM +0100, Martin Kletzander wrote:
> On Mon, Nov 22, 2021 at 09:23:01AM +, Daniel P. Berrangé wrote:
> > On Sun, Nov 21, 2021 at 12:10:08AM +0100, Martin Kletzander wrote:
> > > The reason for this is twofold:
> > >
> > > - the polkit build option is documented
On Mon, Nov 22, 2021 at 09:23:01AM +, Daniel P. Berrangé wrote:
On Sun, Nov 21, 2021 at 12:10:08AM +0100, Martin Kletzander wrote:
The reason for this is twofold:
- the polkit build option is documented for UNIX socket access checks
- there is no server-side change or dbus call done when e
On Mon, Nov 22, 2021 at 10:34:38AM +0100, Martin Kletzander wrote:
> On Mon, Nov 22, 2021 at 09:18:41AM +, Daniel P. Berrangé wrote:
> > On Sun, Nov 21, 2021 at 12:04:26AM +0100, Martin Kletzander wrote:
> > > This eliminates one incorrect parsing implementation.
> >
> > Please explain what wa
On Fri, Nov 05, 2021 at 10:35:20 +0100, Michal Privoznik wrote:
> Alright, here's the deal: to enable tb-cache one has to use
> '-accel tcg,tb-size=' which then conflicts with '-machine
> accel=tcg'. But sure, we can use the old -accel in this specific
> case.
The above is all wrong after the refa
On Mon, Nov 22, 2021 at 09:18:41AM +, Daniel P. Berrangé wrote:
On Sun, Nov 21, 2021 at 12:04:26AM +0100, Martin Kletzander wrote:
This eliminates one incorrect parsing implementation.
Please explain what was being done wrongly / what was the
effect of the bug ?
One of the implementatio
On Fri, Nov 05, 2021 at 10:35:19 +0100, Michal Privoznik wrote:
> It may come handy to be able to tweak TCG options, in this
> specific case the size of translation block cache size (tb-size).
> Since we can expect more knobs to tweak let's put them under
> common element, like this:
>
>
>
On Sun, Nov 21, 2021 at 12:10:08AM +0100, Martin Kletzander wrote:
> The reason for this is twofold:
>
> - the polkit build option is documented for UNIX socket access checks
>
> - there is no server-side change or dbus call done when enabling this as it
> only
> starts a polkit agent on the c
On Sun, Nov 21, 2021 at 12:04:26AM +0100, Martin Kletzander wrote:
> This eliminates one incorrect parsing implementation.
Please explain what was being done wrongly / what was the
effect of the bug ?
>
> Signed-off-by: Martin Kletzander
> ---
> src/qemu/qemu_driver.c | 33 ++--
在 2021/11/22 16:43, Peter Krempa 写道:
On Sat, Nov 20, 2021 at 03:20:46 -0500, huang...@chinatelecom.cn wrote:
From: Hyman Huang(黄勇)
QEMU greater than 2.9.0 support '-accel' option, change the way
of assembling commandline from "accel=kvm" to "-accel kvm" when
specifying accelerator.
Signed-
On Fri, Nov 05, 2021 at 10:35:18 +0100, Michal Privoznik wrote:
> We currently use -machine accel=XXX which is just a syntax sugar
> for -accel XXX. The former doesn't allow specifying arguments for
> accelerator, because all arguments passed to -machine are
> treated as arguments of machine itself
On Fri, Nov 05, 2021 at 10:35:17 +0100, Michal Privoznik wrote:
> The domain accelerator was validated in qemuValidateDomainDef()
> which calls virQEMUCapsIsVirtTypeSupported() which reports proper
> error if QEMU is not capable of KVM/TCG. There is no point in
> doing the validation again when bui
On Sat, Nov 20, 2021 at 03:20:48 -0500, huang...@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇)
>
> dirty ring feature was introduced in qemu-6.1, this patch add
> corresponding feature named 'dirty-ring', which enable
> dirty ring feature when starting vm.
>
> to enable the feature, libvirt add
On Sat, Nov 20, 2021 at 03:20:47 -0500, huang...@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇)
>
> introduce dirty_ring_size in struct "_virDomainDef" to hold
> the ring size configured by user, and pass dirty_ring_size
> when building qemu commandline if dirty ring feature enabled.
>
> Signed-
On Sat, Nov 20, 2021 at 03:20:47 -0500, huang...@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇)
>
> introduce dirty_ring_size in struct "_virDomainDef" to hold
> the ring size configured by user, and pass dirty_ring_size
> when building qemu commandline if dirty ring feature enabled.
>
> Signed-
On Sat, Nov 20, 2021 at 03:20:46 -0500, huang...@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇)
>
> QEMU greater than 2.9.0 support '-accel' option, change the way
> of assembling commandline from "accel=kvm" to "-accel kvm" when
> specifying accelerator.
>
> Signed-off-by: Hyman Huang(黄勇)
> --
On Sat, Nov 20, 2021 at 03:20:45 -0500, huang...@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇)
>
> since the "-machine" option for accelerators is legacy, "-accel" option
> may be a better mechanism. following are details:
> https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f7385...
53 matches
Mail list logo
