Re: [PATCH 2/2] virnettlscontext: Don't pass static key length to gnutls_dh_params_generate2()

2021-12-21 Thread Ani Sinha
On Tue, 21 Dec 2021, Michal Privoznik wrote: > As encryption norms get more strict it's easy to fall on the > insecure side. For instance, so far we are generating 2048 bits > long prime for Diffie-Hellman keys. Some systems consider this > not long enough. While we may just keep increasing the

Re: [PATCH 1/2] virnettlscontext: Drop gnutls_dh_set_prime_bits()

2021-12-21 Thread Ani Sinha
On Tue, 21 Dec 2021, Michal Privoznik wrote: > According to the gnutls_dh_set_prime_bits() manpage: > > The function has no effect in server side. > > Therefore, don't call it when creating server side context. > > Signed-off-by: Michal Privoznik Reviewed-by: Ani Sinha > --- > src/rpc/vi

Re: [PATCH] docs: Remove dependency on external resources

2021-12-21 Thread Andrea Bolognani
On Tue, Dec 21, 2021 at 03:04:49AM -0800, Andrea Bolognani wrote: > I agree that the current situation is a bit messy, especially with > most images having both an SVG and a PNG variant and with all the > icons included to optimize for various clients. > > For the former we could just move everythi

[libvirt PATCH v2 6/6] docs: Move font definitions with other CSS files

2021-12-21 Thread Andrea Bolognani
We have a subdirectory specifically for CSS files now, so it makes sense to have the stylesheet that defines fonts to be there too. Signed-off-by: Andrea Bolognani --- docs/{fonts/stylesheet.css => css/fonts.css} | 18 +- docs/css/main.css| 2 +- docs

[libvirt PATCH v2 4/6] docs: Move all icons to a subdirectory

2021-12-21 Thread Andrea Bolognani
This unclutters the top-level docs directory. Signed-off-by: Andrea Bolognani --- docs/browserconfig.xml | 2 +- docs/{ => icons}/android-chrome-192x192.png | Bin docs/{ => icons}/android-chrome-256x256.png | Bin docs/{ => icons}/apple-touch-icon.png | Bin docs/{

[libvirt PATCH v2 5/6] docs: Move all CSS files to a subdirectory

2021-12-21 Thread Andrea Bolognani
This unclutters the top-level docs directory. Signed-off-by: Andrea Bolognani --- docs/{ => css}/generic.css | 0 docs/{ => css}/libvirt.css | 4 ++-- docs/{ => css}/main.css| 2 +- docs/css/meson.build | 16 docs/{ => css}/mobile.css | 2 +- docs/meson.build

[libvirt PATCH v2 3/6] docs: Move all images to a subdirectory

2021-12-21 Thread Andrea Bolognani
This unclutters the top-level docs directory. Signed-off-by: Andrea Bolognani Reviewed-by: Ani Sinha --- docs/api.rst | 6 ++--- docs/goals.html.in| 2 +- docs/{ => images}/event_loop_simple.png | Bin docs/{ => images}/even

[libvirt PATCH v2 2/6] docs: Add pointing to favicon.ico

2021-12-21 Thread Andrea Bolognani
It's not strictly necessary when the icon lives in the top-level directory of the website, as browsers will fall back to that path when the element is absent, but it's still considered good practice to spell out the path explicitly. Signed-off-by: Andrea Bolognani --- docs/page.xsl | 1 + 1 fil

[libvirt PATCH v2 0/6] docs: Unclutter top-level directory

2021-12-21 Thread Andrea Bolognani
Note that the icons part is untested, because testing it properly would require uploading the generated website to some publicly-accessible location and browsing it using various devices. I have, however, looked at a few popular websites and I've seen them use icons that are not in the top-level di

[libvirt PATCH v2 1/6] docs: Drop structures.svg

2021-12-21 Thread Andrea Bolognani
It was introduced in ff4ede005567 but it doesn't seem to have ever actually been used anywhere. Signed-off-by: Andrea Bolognani Reviewed-by: Ani Sinha --- docs/structures.svg | 187 1 file changed, 187 deletions(-) delete mode 100644 docs/structures

[PATCH 1/2] virnettlscontext: Drop gnutls_dh_set_prime_bits()

2021-12-21 Thread Michal Privoznik
According to the gnutls_dh_set_prime_bits() manpage: The function has no effect in server side. Therefore, don't call it when creating server side context. Signed-off-by: Michal Privoznik --- src/rpc/virnettlscontext.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/rpc/virnettlscon

[PATCH 0/2] gnutls: Be more clever about DH key size

2021-12-21 Thread Michal Privoznik
See 2/2 for explanation. Ideally, we wouldn't use gnutls_dh_params_generate2() at all, per [1]. But that would require bumping minimal required version to gnutls-3.6.0 and I'm not sure how available it is in OSes we support. Therefore, for now let's stick with patch 2/2. 1: https://www.gnutls.org

[PATCH 2/2] virnettlscontext: Don't pass static key length to gnutls_dh_params_generate2()

2021-12-21 Thread Michal Privoznik
As encryption norms get more strict it's easy to fall on the insecure side. For instance, so far we are generating 2048 bits long prime for Diffie-Hellman keys. Some systems consider this not long enough. While we may just keep increasing the value passed to the corresponding gnutls_* function, tha

Re: [libvirt PATCH 2/2] docs: Move all images to a subdirectory

2021-12-21 Thread Ani Sinha
On Tue, Dec 21, 2021 at 17:09 Andrea Bolognani wrote: > This unclutters the toplevel docs directory. > > Signed-off-by: Andrea Bolognani Reviewed-by: Ani Sinha > --- > docs/api.rst | 6 ++--- > docs/goals.html.in| 2 +- > doc

Re: [PATCH v6 1/4] rpm: fix %preun of virtnetworkd

2021-12-21 Thread Ani Sinha
On Tue, 21 Dec 2021, Olaf Hering wrote: > Fixes: 50eae3f8859c746aa474401b38902fa500f23fad ("rpm: handle > enabling/disabling modular daemons post/postun-install") > > Signed-off-by: Olaf Hering Reviewed-by: Ani Sinha > --- > libvirt.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH v6 2/4] libvirt.spec: relocate pre script of daemon-driver-qemu

2021-12-21 Thread Ani Sinha
On Tue, 21 Dec 2021, Olaf Hering wrote: > Reduce the delta in an upcoming change. > No change in behavior intended. > > Signed-off-by: Olaf Hering Reviewed-by: Ani Sinha > --- > libvirt.spec.in | 32 +++- > 1 file changed, 15 insertions(+), 17 deletions(-) > > d

Re: [libvirt PATCH 1/2] docs: Drop structures.svg

2021-12-21 Thread Ani Sinha
On Tue, 21 Dec 2021, Andrea Bolognani wrote: > It was introduced in ff4ede005567 but it doesn't seem to have > ever actually been used anywhere. > > Signed-off-by: Andrea Bolognani Reviewed-by: Ani Sinha > --- > docs/structures.svg | 187 > 1 fi

[libvirt PATCH 2/2] docs: Move all images to a subdirectory

2021-12-21 Thread Andrea Bolognani
This unclutters the toplevel docs directory. Signed-off-by: Andrea Bolognani --- docs/api.rst | 6 ++--- docs/goals.html.in| 2 +- docs/{ => images}/event_loop_simple.png | Bin docs/{ => images}/event_loop_simple.svg |

[libvirt PATCH 0/2] docs: Move all images to a subdirectory

2021-12-21 Thread Andrea Bolognani
Andrea Bolognani (2): docs: Drop structures.svg docs: Move all images to a subdirectory docs/api.rst | 6 +- docs/goals.html.in| 2 +- docs/{ => images}/event_loop_simple.png | Bin docs/{ => images}/event_loop_simple.s

[libvirt PATCH 1/2] docs: Drop structures.svg

2021-12-21 Thread Andrea Bolognani
It was introduced in ff4ede005567 but it doesn't seem to have ever actually been used anywhere. Signed-off-by: Andrea Bolognani --- docs/structures.svg | 187 1 file changed, 187 deletions(-) delete mode 100644 docs/structures.svg diff --git a/docs/

[PATCH v6 4/4] NEWS: mention removal of sysconfig

2021-12-21 Thread Olaf Hering
Signed-off-by: Olaf Hering --- NEWS.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e7d5316721..9255113df4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -44,6 +44,16 @@ v8.0.0 (unreleased) * **Improvements** + * packaging: sysconfig files no longer in

[PATCH v6 3/4] remove sysconfig files

2021-12-21 Thread Olaf Hering
sysconfig files are owned by the admin of the host. They have the liberty to put anything they want into these files. This makes it difficult to provide different built-in defaults. Remove the sysconfig file and place the current desired default into the service file. Local customizations can now

[PATCH v6 1/4] rpm: fix %preun of virtnetworkd

2021-12-21 Thread Olaf Hering
Fixes: 50eae3f8859c746aa474401b38902fa500f23fad ("rpm: handle enabling/disabling modular daemons post/postun-install") Signed-off-by: Olaf Hering --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index f6c705564a..16be1e173

[PATCH v6 2/4] libvirt.spec: relocate pre script of daemon-driver-qemu

2021-12-21 Thread Olaf Hering
Reduce the delta in an upcoming change. No change in behavior intended. Signed-off-by: Olaf Hering --- libvirt.spec.in | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 16be1e173e..7bd74da2c9 100644 ---

[PATCH v6 0/4] remove sysconfig files

2021-12-21 Thread Olaf Hering
fix virtnetworkd avoid duplicate %posttrans sections (berrange) add comment to %libvirt_sc_pre (berrange) rebased to adc0eaead0ebe11f38798e431d2748bfe9b54a30 Olaf Hering (4): rpm: fix %preun of virtnetworkd libvirt.spec: relocate pre script of daemon-driver-qemu remove sysconfig files NEWS

Re: [PATCH] docs: Remove dependency on external resources

2021-12-21 Thread Andrea Bolognani
On Tue, Dec 21, 2021 at 10:46:34AM +0100, Peter Krempa wrote: > Well, I'd prefer if the image files don't clutter the main docs > directory, because it's already too many files in there. Since it's > already a mess, I don't really have too much ground to stand on. > > I'll try to de-messify it once

Re: [PATCH 1/7] docs: formatstorage: Convert to RST

2021-12-21 Thread Peter Krempa
On Sun, Dec 19, 2021 at 14:03:44 +0100, Ján Tomko wrote: > On a Friday in 2021, Peter Krempa wrote: > > Apart from the bulk conversion itself, the section names 'general > > metadata' and 'target elements' were duplicated between the storage pool > > and storage volume sections. To prevent heading

Re: [PATCH] docs: Remove dependency on external resources

2021-12-21 Thread Peter Krempa
On Tue, Dec 21, 2021 at 01:35:21 -0800, Andrea Bolognani wrote: > On Tue, Dec 21, 2021 at 10:09:17AM +0100, Michal Prívozník wrote: > > On 12/20/21 19:45, Andrea Bolognani wrote: > > > Any further thoughts? I'd like to get this merged, be it in one shape > > > or another :) > > > > I'd say it's oka

Re: [PATCH] docs: Remove dependency on external resources

2021-12-21 Thread Andrea Bolognani
On Tue, Dec 21, 2021 at 10:09:17AM +0100, Michal Prívozník wrote: > On 12/20/21 19:45, Andrea Bolognani wrote: > > Any further thoughts? I'd like to get this merged, be it in one shape > > or another :) > > I'd say it's okay. It's just a bunch of pictures. > > Reviewed-by: Michal Privoznik Thanks

Re: [PATCH] docs: Remove dependency on external resources

2021-12-21 Thread Michal Prívozník
On 12/20/21 19:45, Andrea Bolognani wrote: > On Fri, Dec 10, 2021 at 03:07:10AM -0800, Andrea Bolognani wrote: >> On Fri, Dec 10, 2021 at 11:41:29AM +0100, Peter Krempa wrote: docs/event_loop_simple.png | Bin 0 -> 16043 bytes docs/event_loop_simple.svg | 398