On 2/1/22 15:43, Michal Privoznik wrote:
> When virNodeDeviceObjListRemove() is called, the passed
> virNodeDeviceObj is removed from internal list of node devices
> and then unrefed and unlocked. While the former is warranted (the
> object was refed at the beginning of the function) the unlock is
On 2/2/22 01:06, Martin Kletzander wrote:
> On Tue, Feb 01, 2022 at 05:23:33PM +0100, Tim Wiederhake wrote:
>> On Tue, 2022-02-01 at 16:07 +, Daniel P. Berrangé wrote:
>>> On Tue, Feb 01, 2022 at 03:25:55PM +0100, Martin Kletzander wrote:
>>> > On Tue, Feb 01, 2022 at 02:20:17PM +0100, Tim Wied
On Tue, Feb 01, 2022 at 05:23:33PM +0100, Tim Wiederhake wrote:
On Tue, 2022-02-01 at 16:07 +, Daniel P. Berrangé wrote:
On Tue, Feb 01, 2022 at 03:25:55PM +0100, Martin Kletzander wrote:
> On Tue, Feb 01, 2022 at 02:20:17PM +0100, Tim Wiederhake wrote:
> > Signed-off-by: Tim Wiederhake
> >
The current implementation of the workaround for yajl's broken
pkg-config file accidentally overwrites the value of includedir
that is later used by the installation process. Rename the
local variable to avoid this issue.
Fixes: c97075e1e46e9305d62620d8b05046aae0139438
Closes: https://gitlab.com/l
On 2/1/22 18:22, Praveen K Paladugu wrote:
>
>
> On 1/28/2022 10:05 AM, Michal Prívozník wrote:
>> On 1/25/22 17:19, Praveen K Paladugu wrote:
>>> This patchset adds support for cgroup management of ch threads. This
>>> version
>>> correctly manages cgroups for vcpu and emulator threads created b
On 2/1/22 17:59, Erik Skultety wrote:
> On Tue, Feb 01, 2022 at 05:23:52PM +0100, Michal Prívozník wrote:
>> On 2/1/22 17:18, Erik Skultety wrote:
>>> On Mon, Jan 31, 2022 at 03:53:42PM +0100, Michal Privoznik wrote:
There are few places where the g_steal_pointer() is open coded.
Switch t
With respect to the permissions topic mentioned in patch 3/3, I'm
currently working on some patches that aim to improve that situation
as well.
Andrea Bolognani (3):
rpm: Move /etc/libvirt from -daemon to -libs
rpm: Move /var/lib/libvirt from -libs to -daemon
rpm: List more directories
lib
This has two advantages: it makes it possible for the admin to
ask rpm what package they belong to, and results in them ending
up with stricter permissions than they would have if we let
libvirt create them at runtime.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 29
The server, not the client, uses local storage.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 58c2fafac6..ce82def2af 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1683,6 +16
Files like libvirt.conf influence the behavior of the library
itself. The daemon depends on the library, so the directory is
guaranteed to be present both on the client side and on the
server side.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 3 +--
1 file changed, 1 insertion(+), 2 del
On 1/28/2022 10:05 AM, Michal Prívozník wrote:
On 1/25/22 17:19, Praveen K Paladugu wrote:
This patchset adds support for cgroup management of ch threads. This version
correctly manages cgroups for vcpu and emulator threads created by ch. cgroup
management for iothreads is not yet supported.
On Tue, Feb 01, 2022 at 05:23:52PM +0100, Michal Prívozník wrote:
> On 2/1/22 17:18, Erik Skultety wrote:
> > On Mon, Jan 31, 2022 at 03:53:42PM +0100, Michal Privoznik wrote:
> >> There are few places where the g_steal_pointer() is open coded.
> >> Switch them to calling the g_steal_pointer() func
On 2/1/22 17:18, Erik Skultety wrote:
> On Mon, Jan 31, 2022 at 03:53:42PM +0100, Michal Privoznik wrote:
>> There are few places where the g_steal_pointer() is open coded.
>> Switch them to calling the g_steal_pointer() function instead.
>> Generated by the following spatch:
>>
>> @ rule1 @
>>
On Tue, 2022-02-01 at 16:07 +, Daniel P. Berrangé wrote:
> On Tue, Feb 01, 2022 at 03:25:55PM +0100, Martin Kletzander wrote:
> > On Tue, Feb 01, 2022 at 02:20:17PM +0100, Tim Wiederhake wrote:
> > > Signed-off-by: Tim Wiederhake
> > > ---
> > > src/lxc/lxc_driver.c | 6 +++---
> > > 1 file cha
On Mon, Jan 31, 2022 at 03:53:41PM +0100, Michal Privoznik wrote:
> Inside the testPCIVPDResourceCustomCompareIndex() function we
> have two variables @a and @b, both marked as g_autoptr(). Then,
> towards the end of the function b->value is freed and set to
> a->value. This is to make sure
> virPC
On Mon, Jan 31, 2022 at 03:53:40PM +0100, Michal Privoznik wrote:
> There are a few places where a variable is VIR_FREE()-d and then
> explicitly set to NULL. This is not necessary since VIR_FREE()
> does that for us.
>
> Signed-off-by: Michal Privoznik
> ---
Reviewed-by: Erik Skultety
On Mon, Jan 31, 2022 at 03:53:39PM +0100, Michal Privoznik wrote:
> In testDomainSetBlockIoTune() the info.group_name is strdup()-ed
> and just after the whole @info structure is passed to
> virDomainDiskSetBlockIOTune() the @group_name member is set to
> NULL. This creates a memleak, because
> vir
On Mon, Jan 31, 2022 at 03:53:42PM +0100, Michal Privoznik wrote:
> There are few places where the g_steal_pointer() is open coded.
> Switch them to calling the g_steal_pointer() function instead.
> Generated by the following spatch:
>
> @ rule1 @
> expression a, b;
> @@
> <...
> - b =
On Tue, Feb 01, 2022 at 02:20:17PM +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> src/lxc/lxc_driver.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr
On Tue, Feb 01, 2022 at 03:25:55PM +0100, Martin Kletzander wrote:
> On Tue, Feb 01, 2022 at 02:20:17PM +0100, Tim Wiederhake wrote:
> > Signed-off-by: Tim Wiederhake
> > ---
> > src/lxc/lxc_driver.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/lxc/lxc_d
On Tue, Feb 01, 2022 at 02:20:16PM +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> src/bhyve/bhyve_driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flic
On Tue, Feb 01, 2022 at 02:20:15PM +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> src/conf/virchrdev.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c
> index c9b2134e3b..8610f0ac5c 100644
> --- a/
On Tue, Feb 01, 2022 at 02:20:14PM +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> src/conf/virchrdev.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.co
On Tue, Feb 01, 2022 at 02:20:13PM +0100, Tim Wiederhake wrote:
> Modeled after "WITH_QEMU_LOCK_GUARD" (see qemu's include/qemu/lockable.h).
>
> See comment for typical usage.
>
> Signed-off-by: Tim Wiederhake
> ---
> src/util/virobject.h | 22 ++
> 1 file changed, 22 insert
On Tue, Feb 01, 2022 at 02:20:12PM +0100, Tim Wiederhake wrote:
> Typical usage:
> void foobar(virObjectLockable *obj)
> {
> VIR_LOCK_GUARD lock = virObjectLockGuard(obj);
> /* `obj` is locked, and released automatically on scope exit */
>
> ...
> }
>
> Signed-
On Tue, Feb 01, 2022 at 02:20:11PM +0100, Tim Wiederhake wrote:
> Modeled after "WITH_QEMU_LOCK_GUARD" (see qemu's include/qemu/lockable.h).
>
> See comment for typical usage.
>
> Signed-off-by: Tim Wiederhake
> ---
> src/util/virthread.h | 21 +
> 1 file changed, 21 inserti
On Tue, Feb 01, 2022 at 02:20:10PM +0100, Tim Wiederhake wrote:
> Locks a virMutex on creation and unlocks it in its destructor.
>
> The VIR_LOCK_GUARD macro is used instead of "g_auto(virLockGuard)" to
> work around a clang issue (see https://bugs.llvm.org/show_bug.cgi?id=3888
> and https://bugs.
On Tue, Feb 01, 2022 at 02:20:09PM +0100, Tim Wiederhake wrote:
> Using the two-step idiom to force resolution of other macros, e.g.:
>
> #define bar BAR
> CONCAT_(foo, bar) // foobar
> CONCAT(foo, bar) // fooBAR
>
> Signed-off-by: Tim Wiederhake
> ---
> src/internal.h | 3 +++
>
When virNodeDeviceObjListRemove() is called, the passed
virNodeDeviceObj is removed from internal list of node devices
and then unrefed and unlocked. While the former is warranted (the
object was refed at the beginning of the function) the unlock is
not. In fact, it's wrong from conceptual POV. We
MIPS Malta (and no other supported MIPS machine) has a PCI bus.
Signed-off-by: Lubomir Rintel
---
src/qemu/qemu_domain.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 0bae9b9202..b7aad65048 100644
--- a/src/
Identifies all of various MIPS sub-architectures: 32-bit or 64-bit,
little-endian or big-endian.
Signed-off-by: Lubomir Rintel
---
src/util/virarch.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/util/virarch.h b/src/util/virarch.h
index 528f84f8a5..81b1b27a57 100644
--- a/src/uti
This identifies various MIPS Malta machines, be it 32-bit or 64-bit,
little-endian or big-endian.
Signed-off-by: Lubomir Rintel
---
src/qemu/qemu_domain.c | 21 +
src/qemu/qemu_domain.h | 1 +
2 files changed, 22 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/
My day started like this:
# virt-install --connect qemu:///system --arch mips --machine malta --memory
256 --disk none --import
Using default --name vm-mips
Starting install...
ERRORXML error: No PCI buses available
Needless to say, it ended up completely ruined.
Chained to this
On Tue, Feb 01, 2022 at 01:48:54PM +, Daniel P. Berrangé wrote:
> On Tue, Feb 01, 2022 at 02:22:16PM +0100, Erik Skultety wrote:
> > ...
> > > > +x86_64-centos-stream-9:
> > > > + extends: .native_build_job
> > > > + needs:
> > > > +- x86_64-centos-stream-9-container
> > > > + allow_fail
On Tue, Feb 01, 2022 at 02:20:17PM +0100, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/lxc/lxc_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index 7bc39120ee..42053de9c3 100644
--- a/src/lxc/lxc_driver
On Tue, Feb 01, 2022 at 02:20:08PM +0100, Tim Wiederhake wrote:
V1: https://listman.redhat.com/archives/libvir-list/2021-August/msg00823.html
V2: https://listman.redhat.com/archives/libvir-list/2021-September/msg00249.html
V3: https://listman.redhat.com/archives/libvir-list/2021-September/msg0096
On Tue, Feb 01, 2022 at 02:22:16PM +0100, Erik Skultety wrote:
> ...
> > > +x86_64-centos-stream-9:
> > > + extends: .native_build_job
> > > + needs:
> > > +- x86_64-centos-stream-9-container
> > > + allow_failure: false
> > > + variables:
> > > +NAME: centos-stream-9
> >
> > Bearing i
On Tue, Feb 01, 2022 at 12:36:11PM +, Daniel P. Berrangé wrote:
> On Mon, Jan 31, 2022 at 07:01:01PM +0100, Erik Skultety wrote:
> > Create an integration child pipeline in this stage which will trigger a
> > multi-project CI build of Perl bindings which are required by the TCK
> > test suite.
On Mon, Jan 31, 2022 at 04:21:36PM +0100, Kashyap Chamarthy wrote:
> On Mon, Jan 31, 2022 at 02:36:46PM +, Daniel P. Berrangé wrote:
> > On Mon, Jan 31, 2022 at 03:00:33PM +0100, Kashyap Chamarthy wrote:
> > > On Mon, Jan 31, 2022 at 12:55:09PM +, Daniel P. Berrangé wrote:
>
> [...]
>
> >
Signed-off-by: Tim Wiederhake
---
src/bhyve/bhyve_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index f291f12e50..47ee98e650 100644
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
@@ -87,7 +87,8 @
Signed-off-by: Tim Wiederhake
---
src/conf/virchrdev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c
index c9b2134e3b..8610f0ac5c 100644
--- a/src/conf/virchrdev.c
+++ b/src/conf/virchrdev.c
@@ -291,10 +291,10 @@ void virCh
Signed-off-by: Tim Wiederhake
---
src/conf/virchrdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c
index b5477b03d5..c9b2134e3b 100644
--- a/src/conf/virchrdev.c
+++ b/src/conf/virchrdev.c
@@ -237,12 +237,10 @@ static void vir
Modeled after "WITH_QEMU_LOCK_GUARD" (see qemu's include/qemu/lockable.h).
See comment for typical usage.
Signed-off-by: Tim Wiederhake
---
src/util/virobject.h | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/util/virobject.h b/src/util/virobject.h
index dc1ce66a
Using the two-step idiom to force resolution of other macros, e.g.:
#define bar BAR
CONCAT_(foo, bar) // foobar
CONCAT(foo, bar) // fooBAR
Signed-off-by: Tim Wiederhake
---
src/internal.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/internal.h b/src/internal.h
index
...
> > +x86_64-centos-stream-9:
> > + extends: .native_build_job
> > + needs:
> > +- x86_64-centos-stream-9-container
> > + allow_failure: false
> > + variables:
> > +NAME: centos-stream-9
>
> Bearing in mind that c9s is an unreleased distro, we might
> find ourselves needing allow_fa
Modeled after "WITH_QEMU_LOCK_GUARD" (see qemu's include/qemu/lockable.h).
See comment for typical usage.
Signed-off-by: Tim Wiederhake
---
src/util/virthread.h | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/util/virthread.h b/src/util/virthread.h
index 6cdaf2820
V1: https://listman.redhat.com/archives/libvir-list/2021-August/msg00823.html
V2: https://listman.redhat.com/archives/libvir-list/2021-September/msg00249.html
V3: https://listman.redhat.com/archives/libvir-list/2021-September/msg00964.html
V4: https://listman.redhat.com/archives/libvir-list/2022-Ja
Signed-off-by: Tim Wiederhake
---
src/lxc/lxc_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index 7bc39120ee..42053de9c3 100644
--- a/src/lxc/lxc_driver.c
+++ b/src/lxc/lxc_driver.c
@@ -4045,9 +4045,9 @@ lxcDomainDet
Typical usage:
void foobar(virObjectLockable *obj)
{
VIR_LOCK_GUARD lock = virObjectLockGuard(obj);
/* `obj` is locked, and released automatically on scope exit */
...
}
Signed-off-by: Tim Wiederhake
---
src/libvirt_private.syms | 1 +
src/util/virobject.c
Locks a virMutex on creation and unlocks it in its destructor.
The VIR_LOCK_GUARD macro is used instead of "g_auto(virLockGuard)" to
work around a clang issue (see https://bugs.llvm.org/show_bug.cgi?id=3888
and https://bugs.llvm.org/show_bug.cgi?id=43482).
Typical usage:
void function(virMut
On Tue, Feb 01, 2022 at 01:38:53PM +0100, Michal Privoznik wrote:
> When updating am NWFilter, rebuilding of all NWFilters is
> triggered. This happens in virNWFilterObjListAssignDef() by
> calling virNWFilterTriggerRebuild(). Now consider another thread,
> that's currently executing virNWFilterBin
When updating am NWFilter, rebuilding of all NWFilters is
triggered. This happens in virNWFilterObjListAssignDef() by
calling virNWFilterTriggerRebuild(). Now consider another thread,
that's currently executing virNWFilterBindingCreateXML() over the
same NWFilter.
What happens is that this second
On Mon, Jan 31, 2022 at 07:01:01PM +0100, Erik Skultety wrote:
> Create an integration child pipeline in this stage which will trigger a
> multi-project CI build of Perl bindings which are required by the TCK
> test suite.
> In general, this stage will install all the necessary build artifacts
> an
On Mon, Jan 31, 2022 at 07:00:59PM +0100, Erik Skultety wrote:
> Signed-off-by: Erik Skultety
> ---
> ci/containers/centos-stream-9.Dockerfile | 87
> ci/gitlab.yml| 14
> ci/manifest.yml | 3 +
> 3 files changed,
On Mon, Jan 31, 2022 at 07:00:58PM +0100, Erik Skultety wrote:
> The meson version provided by the package managing system satisfies our
> minimum requirement.
>
> Signed-off-by: Erik Skultety
> ---
> ci/gitlab.yml | 1 -
> ci/manifest.yml | 2 --
> 2 files changed, 3 deletions(-)
Reviewed-by
On Tue, Feb 01, 2022 at 01:16:47PM +0100, Peter Krempa wrote:
> The service files were copied out of the service file for libvirtd and
> the name of the corresponding manpage was not fixed.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2045959
> Signed-off-by: Peter Krempa
> ---
> sr
The service files were copied out of the service file for libvirtd and
the name of the corresponding manpage was not fixed.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2045959
Signed-off-by: Peter Krempa
---
src/ch/virtchd.service.in | 2 +-
src/interface/virtinterfaced.s
On a Tuesday in 2022, Michal Privoznik wrote:
The idea behind virNWFilterBindingObjNew() is to create and
return an object of virNWFilterBindingObjClass class. The class
is virObjectLockable (and the corresponding
_virNWFilterBindingObj structure has virObjectLockable parent).
But for some reason
The idea behind virNWFilterBindingObjNew() is to create and
return an object of virNWFilterBindingObjClass class. The class
is virObjectLockable (and the corresponding
_virNWFilterBindingObj structure has virObjectLockable parent).
But for some reason plain virObjectNew() is called. This is wrong
b
Cc libvir-list since this will (intentionally) break compatibility
with current libvirt code that looks for "/machine/unattached/device[0]"
in the assumption it is the first CPU.
On Tue, Feb 01, 2022 at 12:35:06AM +0100, Philippe Mathieu-Daudé wrote:
> Previously CPUs were exposed in the QOM tree
Hi,
The patches doesn't apply on master anymore due to new capabilities being
added in mainline, so I've rebased the patches with latest master here in case
someone wants to test them:
https://gitlab.com/danielhb/libvirt/-/tree/pnv_v2
Thanks,
Daniel
On 1/25/22 17:48, Daniel Henrique Bar
There should be a way to show no intent in programming a VLAN at all
(including clearing it). This allows handling error conditions
differently when VLAN clearing is explicit (vlan id == 0) vs implicit
(vlanid == NULL - try to clear it if possible).
Signed-off-by: Dmitrii Shcherbakov
---
src/hyp
SmartNIC DPUs may not expose some privileged eswitch operations
to the hypervisor hosts. For example, this happens with Bluefield
devices running in the ECPF (default) mode [1] for security reasons. While
VF MAC address programming is possible via an RTM_SETLINK operation,
trying to set a VLAN ID i
This has a benefit of being able to handle error codes for those
operations separately which is useful when drivers allow setting a MAC
address but do not allow setting a VLAN (which is the case with some
SmartNIC DPUs).
Signed-off-by: Dmitrii Shcherbakov
---
src/libvirt_private.syms | 7 ++
s
SmartNIC DPUs may not expose some privileged eswitch operations
to the hypervisor hosts. For example, this happens with Bluefield
devices running in the ECPF (default) mode for security reasons. While
VF MAC address programming is possible via an RTM_SETLINK operation,
trying to set a VLAN ID in th
65 matches
Mail list logo
