On Tue, Mar 8, 2022 at 10:28 PM Michael S. Tsirkin wrote:
>
> On Tue, Mar 08, 2022 at 10:15:49PM +0530, Ani Sinha wrote:
> >
> > Change log:
> > v2: rebased the patchset. Laine's response is appended at the end.
> >
> > I am re-introducing the patchset for which got
> > reverted here few months b
Hi,
On Thu, Apr 21, 2022 at 03:13:05PM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:07:57 +0200, Victor Toso wrote:
> > Either create or append to existing docstring, the version (git tag)
> > that a given macro was introduced in the format:
> >
> > Since: v1.2.3
> >
> > Signed-of
Signed-off-by: Claudio Fontana
---
src/util/iohelper.c | 131 +---
1 file changed, 75 insertions(+), 56 deletions(-)
diff --git a/src/util/iohelper.c b/src/util/iohelper.c
index c13746a547..1584321839 100644
--- a/src/util/iohelper.c
+++ b/src/util/iohelpe
this is in preparation for a minor refactoring of the copy
function itself out of runIO().
Signed-off-by: Claudio Fontana
---
src/util/iohelper.c | 95 +
1 file changed, 53 insertions(+), 42 deletions(-)
diff --git a/src/util/iohelper.c b/src/util/ioh
changes v1 -> v2:
* fix missing write
changes v2 -> v3:
* move error reporting back into the copy function
* split into two patches, one introducing the IO parameters struct,
and another introducing the new function.
Claudio Fontana (2):
iohelper: introduce new struct to carry copy operati
Hi,
On Thu, Apr 21, 2022 at 11:45:05AM -0700, Andrea Bolognani wrote:
> On Thu, Apr 21, 2022 at 08:34:10PM +0200, Victor Toso wrote:
> > Not sure I understood what is preferable. For all functions and
> > typdefs and macros, it should be:
> >
> > Line
> > 1 /**
> > 2 * type_name:
> > 3 *
>
On Thu, Apr 21, 2022 at 08:34:10PM +0200, Victor Toso wrote:
> Not sure I understood what is preferable. For all functions and
> typdefs and macros, it should be:
>
> Line
> 1 /**
> 2 * type_name:
> 3 *
> 4 * Maybe some comment.
> 5 *
> 6 * Maybe something about return value.
> 7
Hi,
On Thu, Apr 21, 2022 at 03:52:58PM +0200, Peter Krempa wrote:
> On Thu, Apr 21, 2022 at 15:51:25 +0200, Peter Krempa wrote:
> > On Wed, Apr 20, 2022 at 21:08:09 +0200, Victor Toso wrote:
> > > This commit is similar to "docs: Fix generated documentation of
> > > virConnectListAllNodeDeviceFlag
Hi,
On Thu, Apr 21, 2022 at 06:21:06AM -0700, Andrea Bolognani wrote:
> On Wed, Apr 20, 2022 at 09:08:02PM +0200, Victor Toso wrote:
> > @@ -4815,6 +4821,9 @@ typedef void
> > (*virConnectDomainEventGenericCallback)(virConnectPtr conn,
> > *
> > * The callback signature to use when registerin
On 4/21/22 5:42 PM, Daniel P. Berrangé wrote:
> On Sat, Mar 26, 2022 at 06:06:37PM +0100, Claudio Fontana wrote:
>> while doing research with alternative implementations of runIO,
>> it seemed necessary to do some refactoring, in order to separate
>> parameter setting from the actual copy, so that
Hi,
On Thu, Apr 21, 2022 at 03:48:51PM +0200, Peter Krempa wrote:
> On Thu, Apr 21, 2022 at 15:43:55 +0200, Peter Krempa wrote:
> > On Wed, Apr 20, 2022 at 21:08:07 +0200, Victor Toso wrote:
> > > This commit is similar to "docs: Fix generated documentation of
> > > virConnectListAllNodeDeviceFlag
Hi,
On Thu, Apr 21, 2022 at 03:14:05PM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:07:58 +0200, Victor Toso wrote:
> > Either create or append to existing docstring, the version (git tag)
> > that a given macro was introduced in the format:
> >
> > Since: v1.2.3
> >
> > Signed-of
Hi,
On Thu, Apr 21, 2022 at 06:43:56PM +0200, Peter Krempa wrote:
> On Thu, Apr 21, 2022 at 15:05:06 +0200, Peter Krempa wrote:
> > On Wed, Apr 20, 2022 at 21:07:56 +0200, Victor Toso wrote:
> > > Either create or append to existing docstring, the version (git tag)
> > > that a given enum value wa
Hi,
On Thu, Apr 21, 2022 at 02:02:25PM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:07:51 +0200, Victor Toso wrote:
> > We should allow strings (not the functions) in the format of
> > "virDomainFree" and friends.
> >
> > This fixes an error in latter commit "scripts: apibuild: parse
>
On Thu, Apr 21, 2022 at 02:11:03PM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:07:50 +0200, Victor Toso wrote:
> > It doesn't need to fail the test if a reentrant function is found in
> > a comment.
>
> That is true, but your patch doesn't do exactly that.
>
> If I add the following c
On 4/21/22 7:08 PM, Daniel P. Berrangé wrote:
> On Thu, Apr 14, 2022 at 09:54:16AM +0200, Claudio Fontana wrote:
>> RFC, starting point for discussion.
>>
>> Sketch API changes to allow parallel Saves, and open up
>> and implementation for QEMU to leverage multifd migration to files,
>> with option
On Thu, Apr 21, 2022 at 01:56:19PM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:08:16 +0200, Victor Toso wrote:
> > This patch adds 'version' parameter to generated XML API for functions
> > and functypes.
> >
> > The 'version' metadata has been added with e0e0bf6628 by parsing .syms
>
On 4/21/22 6:52 PM, Daniel P. Berrangé wrote:
> On Thu, Apr 21, 2022 at 05:27:09PM +0100, Daniel P. Berrangé wrote:
>> On Tue, Apr 12, 2022 at 11:18:15AM +0200, Claudio Fontana wrote:
>>> align the "save" with the "restore" code,
>>> by only using the wrapper when using --bypass-cache.
>>>
>>> This
On Thu, Apr 21, 2022 at 04:04:20PM +0200, Peter Krempa wrote:
> On Thu, Apr 21, 2022 at 06:59:14 -0700, Andrea Bolognani wrote:
> > On Thu, Apr 21, 2022 at 03:42:31PM +0200, Peter Krempa wrote:
> > > One more thing to consider is (not visible in this snipped patch as we
> > > see only a typedef) is
On Thu, Apr 14, 2022 at 09:54:16AM +0200, Claudio Fontana wrote:
> RFC, starting point for discussion.
>
> Sketch API changes to allow parallel Saves, and open up
> and implementation for QEMU to leverage multifd migration to files,
> with optional multifd compression.
>
> This allows to improve
On Thu, Apr 21, 2022 at 05:27:09PM +0100, Daniel P. Berrangé wrote:
> On Tue, Apr 12, 2022 at 11:18:15AM +0200, Claudio Fontana wrote:
> > align the "save" with the "restore" code,
> > by only using the wrapper when using --bypass-cache.
> >
> > This avoids a copy, resulting in better performance.
On Thu, Apr 21, 2022 at 15:05:06 +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:07:56 +0200, Victor Toso wrote:
> > Either create or append to existing docstring, the version (git tag)
> > that a given enum value was introduced in the format:
> >
> > Since: v1.2.3
> >
> > Signed-off-
On Thu, Apr 21, 2022 at 12:35:27PM -0400, Tyler Fanelli wrote:
> On 4/20/22 5:45 AM, Daniel P. Berrangé wrote:
> > > > But as is it's not clear what this buys us over the launch measurement
> > > > we already report with virDomainGetLaunchSecurityInfo
> > > >
> > > >
> > > > If we figure out what
On 4/20/22 5:45 AM, Daniel P. Berrangé wrote:
On Thu, Apr 14, 2022 at 02:46:38PM -0400, Tyler Fanelli wrote:
On 4/11/22 10:57 AM, Cole Robinson wrote:
Maybe the extra key signing is a security fix or something. I haven't
figured it out.
Signing with the PEK also allows a user to verify the roo
On Tue, Apr 12, 2022 at 11:18:15AM +0200, Claudio Fontana wrote:
> align the "save" with the "restore" code,
> by only using the wrapper when using --bypass-cache.
>
> This avoids a copy, resulting in better performance.
>
> Signed-off-by: Claudio Fontana
> ---
> src/qemu/qemu_saveimage.c | 6 +
On Thu, Apr 21, 2022 at 04:55:53PM +0200, Claudio Fontana wrote:
> a ping on this one;
>
> this change makes sense to me, and makes performance better in specific
> cases, by avoiding --bypass-cache before reaching the "cache trashing" state.
>
> However, before virsh save was guarenteed to go t
On Sat, Mar 26, 2022 at 06:06:37PM +0100, Claudio Fontana wrote:
> while doing research with alternative implementations of runIO,
> it seemed necessary to do some refactoring, in order to separate
> parameter setting from the actual copy, so that alternative
> copy methods can be researched and ho
On Tue, Apr 05, 2022 at 02:52:59PM +0300, Nikolay Shirokovskiy wrote:
> From: Maxim Nestratov
>
> This is a quite an old (created at 2016) patch fixing an issue for at
> that time contemporary Fedora 23. virsh reboot returns success (yet
> after hanging for a while), VM is rebooted sucessfully to
On Mon, Apr 04, 2022 at 02:45:41PM -0400, Cole Robinson wrote:
> On 2/16/22 8:17 AM, Michal Prívozník wrote:
> > On 2/15/22 19:54, Daniel P. Berrangé wrote:
> >> There are a mind bending number of possible ways to configure the
> >> firmware with/without NVRAM. Only a small portion are tested and
>
On Wed, Apr 20, 2022 at 21:08:03 +0200, Victor Toso wrote:
> Either create or append to existing docstring, the version (git tag)
> that a given function was introduced in the format:
>
> Since: v1.2.3
>
> Signed-off-by: Victor Toso
> ---
> include/libvirt/libvirt-qemu.h | 3 +++
> src/lib
On Wed, Apr 20, 2022 at 21:08:04 +0200, Victor Toso wrote:
> Either create or append to existing docstring, the version (git tag)
> that a given function was introduced in the format:
>
> Since: v1.2.3
>
> Signed-off-by: Victor Toso
> ---
> src/libvirt-lxc.c | 12
> 1 file chan
On Fri, Apr 08, 2022 at 10:48:50 -0700, Rohit Kumar wrote:
> This patch adds unit test for network backed NVRAM
>
> Example:
>
>
>
>
>
>
> Signed-off-by: Prerna Saxena
> Signed-off-by: Florian Schmidt
> Signed-off-by: Rohit Kumar
> ---
> .../bios-nvram-network.x86_64-latest.args
On Thu, Apr 21, 2022 at 16:52:54 +0200, Peter Krempa wrote:
> On Fri, Apr 08, 2022 at 10:48:46 -0700, Rohit Kumar wrote:
> > Remote store NVRAM feature is being enabled only
> > if it supports 'blockdev' capability.
> >
> > Signed-off-by: Prerna Saxena
> > Signed-off-by: Florian Schmidt
> > Sign
On Fri, Apr 08, 2022 at 10:48:49 -0700, Rohit Kumar wrote:
> Updating the doc as now NVRAM can be remote as well.
>
> Signed-off-by: Prerna Saxena
> Signed-off-by: Florian Schmidt
> Signed-off-by: Rohit Kumar
> ---
> docs/formatdomain.rst | 43 +++
> 1 f
On Fri, Apr 08, 2022 at 10:48:48 -0700, Rohit Kumar wrote:
> This patch updates NVRAM element schema to support
> network backed NVRAM. It introduces 'type' attribute
> to NVRAM element.
>
> Signed-off-by: Prerna Saxena
> Signed-off-by: Florian Schmidt
> Signed-off-by: Rohit Kumar
> ---
> src/
On Fri, Apr 08, 2022 at 10:48:47 -0700, Rohit Kumar wrote:
> Moving diskSourceNetwork and diskSourceFile's Source definition
> under 'define' element, so that it will be easier to reuse it
> at multiple places.
>
> Signed-off-by: Prerna Saxena
> Signed-off-by: Florian Schmidt
> Signed-off-by: Ro
A ping on this one, if it is something interesting.
My research has not identified great benefits in using other alternative APIs,
but this refactoring might be better looking code anyway?
Thanks,
Claudio
On 3/26/22 6:06 PM, Claudio Fontana wrote:
> while doing research with alternative impleme
a ping on this one;
this change makes sense to me, and makes performance better in specific cases,
by avoiding --bypass-cache before reaching the "cache trashing" state.
However, before virsh save was guarenteed to go through iohelper, now it is not.
The iohelper was guaranteeing a virFileDataS
On Fri, Apr 08, 2022 at 10:48:46 -0700, Rohit Kumar wrote:
> Remote store NVRAM feature is being enabled only
> if it supports 'blockdev' capability.
>
> Signed-off-by: Prerna Saxena
> Signed-off-by: Florian Schmidt
> Signed-off-by: Rohit Kumar
> ---
> src/qemu/qemu_validate.c | 22 +++
On Fri, Apr 08, 2022 at 10:48:45 -0700, Rohit Kumar wrote:
> This patch introduces the logic to support remote NVRAM and
> adds 'type' attribute to nvram element.
>
> Sample XML with new annotation:
>
>
>
>
>
>
>
> or
>
>
>
>
[1]
>
> Signed-off-by: Prerna Saxena
> Signed-o
Thanks for the review, Peter!
Can you please look at patch 2nd of this patch series too ? It will be
easier if I make all the necessary changes, if any, at once.
On 20/04/22 6:18 pm, Peter Krempa wrote:
On Fri, Apr 08, 2022 at 10:48:44 -0700, Rohit Kumar wrote:
Currently, libvirt allows only
On Thu, Apr 21, 2022 at 06:59:14 -0700, Andrea Bolognani wrote:
> On Thu, Apr 21, 2022 at 03:42:31PM +0200, Peter Krempa wrote:
> > One more thing to consider is (not visible in this snipped patch as we
> > see only a typedef) is that we already do have the version info for
> > functions in the gen
On Thu, Apr 21, 2022 at 03:42:31PM +0200, Peter Krempa wrote:
> One more thing to consider is (not visible in this snipped patch as we
> see only a typedef) is that we already do have the version info for
> functions in the generated API xml. So ... do we even want to be adding
> them to the commen
On Wed, Apr 20, 2022 at 21:08:10 +0200, Victor Toso wrote:
> This commit is similar to "docs: Fix generated documentation of
> virConnectListAllNodeDeviceFlags", check it out for more info.
>
> Signed-off-by: Victor Toso
> ---
> include/libvirt/libvirt-domain.h | 13 ++---
> 1 file chang
On Thu, Apr 21, 2022 at 15:51:25 +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:08:09 +0200, Victor Toso wrote:
> > This commit is similar to "docs: Fix generated documentation of
> > virConnectListAllNodeDeviceFlags", check it out for more info.
> >
> > Signed-off-by: Victor Toso
> > --
On Wed, Apr 20, 2022 at 21:08:09 +0200, Victor Toso wrote:
> This commit is similar to "docs: Fix generated documentation of
> virConnectListAllNodeDeviceFlags", check it out for more info.
>
> Signed-off-by: Victor Toso
> ---
> include/libvirt/libvirt-domain.h | 14 +++---
> 1 file chan
On Wed, Apr 20, 2022 at 21:08:08 +0200, Victor Toso wrote:
> This commit is similar to "docs: Fix generated documentation of
> virConnectListAllNodeDeviceFlags", check it out for more info.
Similarly to my previous point. Commit names can change, it's better to
just repeat the root cause.
>
> Si
On Thu, Apr 21, 2022 at 15:43:55 +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:08:07 +0200, Victor Toso wrote:
> > This commit is similar to "docs: Fix generated documentation of
> > virConnectListAllNodeDeviceFlags", check it out for more info.
Actually, this paragraph is inaccurate sin
On Wed, Apr 20, 2022 at 21:08:07 +0200, Victor Toso wrote:
> This commit is similar to "docs: Fix generated documentation of
> virConnectListAllNodeDeviceFlags", check it out for more info.
>
> Using git diff --word-diff to show the fixed output xml (redacted).
>
>[-type='virStorageVolInf
On Thu, Apr 21, 2022 at 06:21:06 -0700, Andrea Bolognani wrote:
> On Wed, Apr 20, 2022 at 09:08:02PM +0200, Victor Toso wrote:
> > @@ -4815,6 +4821,9 @@ typedef void
> > (*virConnectDomainEventGenericCallback)(virConnectPtr conn,
> > *
> > * The callback signature to use when registering for a
On Wed, Apr 20, 2022 at 21:08:00 +0200, Victor Toso wrote:
> Either create or append to existing docstring, the version (git tag)
> that a given typedef was introduced in the format:
>
> Since: v1.2.3
>
> Signed-off-by: Victor Toso
> ---
> include/libvirt/libvirt-qemu.h | 18 +++
On Wed, Apr 20, 2022 at 09:08:02PM +0200, Victor Toso wrote:
> @@ -4815,6 +4821,9 @@ typedef void
> (*virConnectDomainEventGenericCallback)(virConnectPtr conn,
> *
> * The callback signature to use when registering for an event of type
> * VIR_DOMAIN_EVENT_ID_RTC_CHANGE with virConnectDomain
On Wed, Apr 20, 2022 at 21:07:58 +0200, Victor Toso wrote:
> Either create or append to existing docstring, the version (git tag)
> that a given macro was introduced in the format:
>
> Since: v1.2.3
>
> Signed-off-by: Victor Toso
> ---
> include/libvirt/libvirt-admin.h | 60
On Wed, Apr 20, 2022 at 21:07:57 +0200, Victor Toso wrote:
> Either create or append to existing docstring, the version (git tag)
> that a given macro was introduced in the format:
>
> Since: v1.2.3
>
> Signed-off-by: Victor Toso
> ---
> include/libvirt/libvirt-domain.h | 663 +
On Wed, Apr 20, 2022 at 21:07:56 +0200, Victor Toso wrote:
> Either create or append to existing docstring, the version (git tag)
> that a given enum value was introduced in the format:
>
> Since: v1.2.3
>
> Signed-off-by: Victor Toso
> ---
> include/libvirt/libvirt-admin.h | 8
>
On Wed, Apr 20, 2022 at 21:07:55 +0200, Victor Toso wrote:
> Either create or append to existing docstring, the version (git tag)
> that a given enum value was introduced in the format:
>
> Since: v1.2.3
>
> Signed-off-by: Victor Toso
> ---
> include/libvirt/libvirt-qemu.h | 18 +---
On Wed, Apr 20, 2022 at 21:07:53 +0200, Victor Toso wrote:
> virConnectAuthPtrDefault is the only variable that we export and
> with the documentation being at the C file, it makes harder to find
> it.
>
> With this patch, the documentation of this variable can be found by
> those who look at the
On Wed, Apr 20, 2022 at 21:07:52 +0200, Victor Toso wrote:
> scripts/apibuild.py does not handle well enum's with comments
> between values. The outcome depends on whether the enum value has
> its own docstring or not and if there is spaces between the enum
> values or not.
>
> Either way, virCon
On Wed, Apr 20, 2022 at 21:07:50 +0200, Victor Toso wrote:
> It doesn't need to fail the test if a reentrant function is found in
> a comment.
That is true, but your patch doesn't do exactly that.
If I add the following code:
@@ -83,6 +83,12 @@ virshCatchDisconnect(virConnectPtr conn,
c
On Wed, Apr 20, 2022 at 21:07:51 +0200, Victor Toso wrote:
> We should allow strings (not the functions) in the format of
> "virDomainFree" and friends.
>
> This fixes an error in latter commit "scripts: apibuild: parse
> 'Since' for functions" as it uses this function names as keys
> in a diction
On Wed, Apr 20, 2022 at 21:08:16 +0200, Victor Toso wrote:
> This patch adds 'version' parameter to generated XML API for functions
> and functypes.
>
> The 'version' metadata has been added with e0e0bf6628 by parsing .syms
> files. This commit does not override that but it will warn if there is
>
On Wed, Apr 20, 2022 at 21:08:05 +0200, Victor Toso wrote:
> Either create or append to existing docstring, the version (git tag)
> that a given function was introduced in the format:
>
> Since: v1.2.3
>
> Signed-off-by: Victor Toso
> ---
> include/libvirt/libvirt-admin.h | 3 ++
> src/adm
On 4/21/22 03:48, Justin Gatzen wrote:
> When is the only usage of the qemu namespace the entire
> section is mistakenly removed. Add check for use count.
>
> Signed-off-by: Justin Gatzen
> ---
> src/qemu/qemu_domain.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: M
63 matches
Mail list logo
