On a Friday in 2022, Peter Krempa wrote:
The crash is fixed by properly instantiating the auth object.
Also this series cleans up some problems noticed along the way.
Peter Krempa (11):
conf: schema: Fix alignment in 'diskSourceNetworkProtocolHTTPS' schema
definition
qemuDomainValidateStor
[Cc +libvirt folks]
On Thu, 14 Apr 2022 03:46:52 -0700
Yi Liu wrote:
> With the introduction of iommufd[1], the linux kernel provides a generic
> interface for userspace drivers to propagate their DMA mappings to kernel
> for assigned devices. This series does the porting of the VFIO devices
> o
On a Friday in 2022, Peter Krempa wrote:
Reject encryption requests for unsupported image format types.
Add negative test for the rejected cases as well as modify
'disk-network-rbd-encryption' case to validate that with librbd
encryption the format doesn matter.
*doesn't
Jano
Signed-off-by
This is the multifd save prototype in its first semi-functional state,
(save direction only),
with surely a lot of rough edges as I am not very familiar with the
libvirt code base yet or its rules.
It seems to work for me, but take a look if this is something
realistic to pursue further, whether
add new API in order to be able to extend parameters to the domain
save operation. We will use it to fit the existing arguments of
VirDomainSaveFlags, and then add parallel saves functionality.
Signed-off-by: Claudio Fontana
---
include/libvirt/libvirt-domain.h | 9 ++
src/driver-hypervisor
implement a function similar to qemuMigrationSrcToFile
that migrates to multiple files using QEMU multifd.
Signed-off-by: Claudio Fontana
---
src/qemu/qemu_capabilities.c | 1 +
src/qemu/qemu_migration.c| 129 ---
src/qemu/qemu_migration.h| 7 +
Signed-off-by: Claudio Fontana
---
docs/manpages/virsh.rst | 23 ++-
tools/virsh-domain.c| 49 +
2 files changed, 57 insertions(+), 15 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index d2e6528533..8d077b3
where it can be reused by other helpers.
No changes other than the move.
Signed-off-by: Claudio Fontana
---
src/util/iohelper.c | 178 +--
src/util/meson.build | 2 +
src/util/runio.c | 214 +++
src/util/runio.h |
Signed-off-by: Claudio Fontana
---
src/qemu/qemu_saveimage.c | 30 --
1 file changed, 28 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c
index 6a65d72fb3..bb23788a5e 100644
--- a/src/qemu/qemu_saveimage.c
+++ b/src/qemu
Signed-off-by: Claudio Fontana
---
src/remote/remote_driver.c | 1 +
src/remote/remote_protocol.x | 17 -
src/remote_protocol-structs | 9 +
3 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 7e
this helper listens on a unix socket which is provided to QEMU
for multifd migration to/from files.
The file descriptors are passed as command line parameters.
Signed-off-by: Claudio Fontana
---
src/libvirt_private.syms | 1 +
src/util/meson.build | 13 +++
src/util/multifd-helper.c |
use zstd which is the only really interesting one.
Signed-off-by: Claudio Fontana
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_migration.c| 6
src/qemu/qemu_migration_params.c | 49
src/qemu/qe
add arguments to runio to allow read/write from/to arbitrary
file descriptors, as opposed to just stdin and stdout.
Signed-off-by: Claudio Fontana
---
src/util/iohelper.c | 2 +-
src/util/runio.c| 6 +++---
src/util/runio.h| 17 -
3 files changed, 20 insertions(+), 5 de
make the qemuDomainSaveParametersFlags minimally functional
by preparing the files for the multifd channels, but stop short of
using them, relying on normal migration to file for now.
Signed-off-by: Claudio Fontana
---
src/qemu/qemu_saveimage.c | 256 +++---
src/q
Signed-off-by: Claudio Fontana
---
src/qemu/qemu_driver.c| 66 ---
src/qemu/qemu_saveimage.c | 2 ++
src/qemu/qemu_saveimage.h | 1 +
src/qemu/qemu_snapshot.c | 2 +-
4 files changed, 66 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_driver.c
Either create or append to existing docstring, the version (git tag)
that a given typedef was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/libvirt/libvirt
scripts/apibuild.py did not consider exporting external variable's
comments into the XML API. This commits fixes that.
Noe that the way that CParser is designed, it is currently possible to
lose a parsed comment when parsing other fields as self.comment in
several places. I've added a comment to h
So we can use for comments that are being hold in helper variables.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index b86d20e364..40ee0a3c63 100755
--- a/scripts/a
This patch adds 'version' parameter to the generated XML API for
macros
It'll require, for new additions, to add a comment with the version
that the macro was added. An example bellow of code diff and
the change in the generated XML.
Note that the Since tag is removed from the comment as there is
This patch adds 'version' parameter to generated XML API for functions
and functypes.
The 'version' metadata has been added with e0e0bf6628 by parsing .syms
files. This commit does not override that but it will warn if there is
not 'Since' metadata with new additions.
There is not clear benefit f
Removed the TODO as we can rely to the serialize_typedef() the job to
report missing comments.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index 19e897b1ba..ddc2fff7af 1007
This patch adds 'version' parameter to the generated XML API for
typedefs
It'll require, for new additions, to add a comment with the version
that the typedef value was added. An example bellow of code diff and
the change in the generated XML.
Note that the Since tag is removed from the comment a
Either create or append to existing docstring, the version (git tag)
that a given function was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 2 ++
src/admin/libvirt-admin.c | 62 +
2 files chan
This patch adds 'version' parameter to the generated XML API for
enums.
It'll require, for new additions, to add a comment with the version
that the enum value was added.
Note that the Since tag is removed from the comment as there is a
proper field for it in the XML.
Signed-off-by: Victor Toso
Either create or append to existing docstring, the version (git tag)
that a given macro was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 40 +
1 file changed, 40 insertions(+)
diff --git a/include/l
Either create or append to existing docstring, the version (git tag)
that a given enum value was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/libvirt
Follow up patch will add Since metadata to enum values of
virStorageVolWipeAlgorithm.
This patch is necessary to avoid breaking the build with
syntax-check.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-storage.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a
This was a mistake on my side in the v3 iteration of the series. I've
introduced the wrong version number in v3 10/30 and fixed later in v3
21/30. Apologies.
Fixes: 034432e47b
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
scripts/apibuild.py does not handle well enum's with comments between
values. The outcome depends on whether the enum value has its own
docstring or not and if there is spaces between the enum values or
not.
This commit removes some generic comments that I have spotted.
Signed-off-by: Victor Toso
Hi,
The 4th is coming!
v3: https://listman.redhat.com/archives/libvir-list/2022-April/230200.html
v2: https://listman.redhat.com/archives/libvir-list/2022-April/230097.html
v1: https://listman.redhat.com/archives/libvir-list/2022-April/229881.html
I tried to be more careful this time
This was a mistake on my side in the v3 iteration of the series. I've
introduced the wrong version number in v3 10/30 and fixed later in v3
20/30. Apologies.
Fixes: 034432e47b
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
This was a mistake on my side in the v3 iteration of the series. I've
introduced the wrong version number in v3 10/30 and fixed later in v3
22/30. Apologies.
Fixes: 034432e47b
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
This was a mistake on my side in the v3 iteration of the series. I've
introduced the wrong version number in v3 10/30 and fixed later in v3
19/30. Apologies.
Fixes: 034432e47b
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-storage.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 4/22/22 14:23, Peter Krempa wrote:
> After this series only 2 non-generated HTML files remain:
> - index.html.in
> - 404.html.in
>
> It is possible to convert these but the utility of doing so may not be
> great for now.
>
> Additionally this series cleans up some long-broken links and remov
On Fri, Apr 22, 2022 at 10:05:41AM -0700, Andrea Bolognani wrote:
> On Fri, Apr 22, 2022 at 06:54:25PM +0200, Victor Toso wrote:
> > The itching to change the code all around is still here. I
> > actually created another (local) branch to put some fixes and
> > removing dead code... but I knew if I
On Fri, Apr 22, 2022 at 06:54:25PM +0200, Victor Toso wrote:
> The itching to change the code all around is still here. I
> actually created another (local) branch to put some fixes and
> removing dead code... but I knew if I started reworking things it
> would consume more time to reach the end go
Hi,
On Fri, Apr 22, 2022 at 09:36:30AM -0700, Andrea Bolognani wrote:
> On Wed, Apr 20, 2022 at 09:08:18PM +0200, Victor Toso wrote:
> > def serialize_variable(self, output, name):
> > id = self.idx.variables[name]
> > -if id.info is not None:
> > -output.write("
On Wed, Apr 20, 2022 at 09:08:18PM +0200, Victor Toso wrote:
> def serialize_variable(self, output, name):
> id = self.idx.variables[name]
> -if id.info is not None:
> -output.write("\n" %
> (
> -name, self.modulename_file(id.header), id.info))
On Fri, Apr 22, 2022 at 16:05:57 +0200, Michal Prívozník wrote:
> On 4/22/22 14:23, Peter Krempa wrote:
> > Adjust links in the process.
> >
> > Note that the conversion to the table is temporary and upcoming patch
> > will modify it for better readability.
> >
> > Signed-off-by: Peter Krempa
>
The iSCSI hostdev code doesn't require the check for the empty drive
and the check for the protocol because those are already guaranteed at
that point.
In qemuDomainSecretStorageSourcePrepare we don't need to check the
network disk type either as it's now guaranteed by the definition
validator.
T
The code already handles this so we just need to allow it in the schema.
Signed-off-by: Peter Krempa
---
src/conf/schemas/domaincommon.rng | 12
1 file changed, 12 insertions(+)
diff --git a/src/conf/schemas/domaincommon.rng
b/src/conf/schemas/domaincommon.rng
index c68acaa222..8a
Extend the 'disk-cdrom-network' to cover this instance. This also
validates that the parameters of -blockdev conform to the QAPI schema.
Also add the xml2xml variant of this test case.
Signed-off-by: Peter Krempa
---
.../disk-cdrom-network.x86_64-4.1.0.args | 6 +-
.../disk-cdrom-network.
Separate it so that further addition can target 'ftp' only.
Signed-off-by: Peter Krempa
---
src/conf/schemas/domaincommon.rng | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/src/conf/schemas/domaincommon.rng
b/src/conf/schemas/domaincommon.rng
index bf4
Since we are already checking that the encryption format can be only
_LUKS and _LUKS2 this wrapper function doesn't make much sense any more.
The only one caller can do this internally.
The move of virStorageSourceIsEmpty is correct as there are no secrets
to setup if the disk is empty anyways.
The validation should be the only point to decide whether authentication
is supported for a disk backing protocol. The rest of the code can then
simply always enable it.
This also fixes a crash when authentication is requested e.g. for a HTTP
backed disk as the blockdev props formatter expects tha
Remove the impossible error message about the 'qcow2' encryption format
not being supported. We validated before that it can't happen.
Additionally the code can be simplified by removing error handling from
impossible code paths as the last resort is virJSONValueCreate not
allowing NULL argument w
Only certain disk protocols support authentication. Add validation for
this field.
Signed-off-by: Peter Krempa
---
src/conf/domain_validate.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c
index 6819
Reject encryption requests for unsupported image format types.
Add negative test for the rejected cases as well as modify
'disk-network-rbd-encryption' case to validate that with librbd
encryption the format doesn matter.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c
Move the two ad-hoc checks below into the block which already tests
whether encryption is requested.
If we first disallow the old-style qcow2 encryption we can remove a
whole block of validation later on.
Also the capability check for qcow2+luks can be simplified by moving it
into the same block.
Signed-off-by: Peter Krempa
---
src/conf/schemas/domaincommon.rng | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/schemas/domaincommon.rng
b/src/conf/schemas/domaincommon.rng
index c0c14fe558..bf4d6e4b6f 100644
--- a/src/conf/schemas/domaincommon.rng
+++ b/src/conf/s
The crash is fixed by properly instantiating the auth object.
Also this series cleans up some problems noticed along the way.
Peter Krempa (11):
conf: schema: Fix alignment in 'diskSourceNetworkProtocolHTTPS' schema
definition
qemuDomainValidateStorageSource: Reorganize encryption config
On Fri, Apr 22, 2022 at 04:45:37PM +0200, Michal Privoznik wrote:
> When one thread is trying to reload NWFilter driver (by running
> nwfilterStateReload()) but there's another thread that's
> concurrently running nwfilterStateCleanup() a crash may occur.
> This is despite nwfilterStateReload() che
When one thread is trying to reload NWFilter driver (by running
nwfilterStateReload()) but there's another thread that's
concurrently running nwfilterStateCleanup() a crash may occur.
This is despite nwfilterStateReload() checking for driver !=
NULL, because is done so without @driverMutex held. A
On Fri, Apr 22, 2022 at 07:21:11AM -0700, Andrea Bolognani wrote:
> On Fri, Apr 22, 2022 at 10:20:11AM +0200, Peter Krempa wrote:
> > Based on discussions on individual patches I've applied the feedback I
> > had including Andrea's request to remove the extra empty line on the
> > following patches
On Fri, Apr 22, 2022 at 10:20:11AM +0200, Peter Krempa wrote:
> Based on discussions on individual patches I've applied the feedback I
> had including Andrea's request to remove the extra empty line on the
> following patches:
>
> docstring: Fix generated documentation of virStorageVolInfoFlags
> d
On 4/22/22 14:23, Peter Krempa wrote:
> Adjust links in the process.
>
> Note that the conversion to the table is temporary and upcoming patch
> will modify it for better readability.
>
> Signed-off-by: Peter Krempa
> ---
> docs/meson.build | 2 +-
> docs/uri.html.in | 507 ---
On 4/22/22 14:23, Peter Krempa wrote:
> After this series only 2 non-generated HTML files remain:
> - index.html.in
> - 404.html.in
>
> It is possible to convert these but the utility of doing so may not be
> great for now.
>
> Additionally this series cleans up some long-broken links and remov
On Fri, Apr 22, 2022 at 14:46:48 +0200, Andrea Bolognani wrote:
>
>
> Andrea Bolognani (2):
> include: Fix vertical spacing inside comments
> include: Fix vertical spacing between comments and symbols
Oops, I probably forgot to run my regex on some of the files :D
Thanks for fixing up after
On Fri, Apr 22, 2022 at 10:20:11AM +0200, Peter Krempa wrote:
> Based on discussions on individual patches I've applied the feedback I
> had including Andrea's request to remove the extra empty line on the
> following patches:
>
> docstring: Fix generated documentation of virStorageVolInfoFlags
> d
Andrea Bolognani (2):
include: Fix vertical spacing inside comments
include: Fix vertical spacing between comments and symbols
include/libvirt/libvirt-common.h.in | 1 -
include/libvirt/libvirt-domain-checkpoint.h | 6 -
include/libvirt/libvirt-domain-snapshot.h | 7 -
inclu
There should be no empty lines between a docstring comment and
the symbol it documents.
Signed-off-by: Andrea Bolognani
---
include/libvirt/libvirt-common.h.in | 1 -
include/libvirt/libvirt-domain.h| 15 ---
include/libvirt/libvirt-host.h | 7 ---
include/libvirt/libv
There should be no empty lines between the Since tag in a
docstring comment and the end marker.
Signed-off-by: Andrea Bolognani
---
include/libvirt/libvirt-domain-checkpoint.h | 6 -
include/libvirt/libvirt-domain-snapshot.h | 7 -
include/libvirt/libvirt-domain.h| 139
The 'codeofconduct' anchor is unused as of 523f2de82e0f523bd552947 .
Signed-off-by: Peter Krempa
---
docs/governance.rst | 5 -
1 file changed, 5 deletions(-)
diff --git a/docs/governance.rst b/docs/governance.rst
index df90ce678d..44dd54d4a0 100644
--- a/docs/governance.rst
+++ b/docs/gove
After this series only 2 non-generated HTML files remain:
- index.html.in
- 404.html.in
It is possible to convert these but the utility of doing so may not be
great for now.
Additionally this series cleans up some long-broken links and removes
unneeded raw HTML passthrough to declare anchors.
Modify the gitlab templates linking to it and remove the raw HTML.
Note that also the default template needs to be changed directly in
gitlab.
Signed-off-by: Peter Krempa
---
.gitlab/issue_templates/bug.md | 2 +-
docs/bugs.rst | 5 -
2 files changed, 1 insertion(+), 6 dele
Add a new heading 'Local hypervisor URIs' and move the sections about
'qemu', 'xen' and 'test' under it.
Signed-off-by: Peter Krempa
---
docs/uri.rst | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/docs/uri.rst b/docs/uri.rst
index 97a72dc37d..71
Most of the anchors that were forward ported to formatdomain.rst when it
was converted are not actually referenced by our documentation. Since
it's now quite some time after the conversion was done we can remove
them.
Signed-off-by: Peter Krempa
---
docs/formatdomain.rst | 112 --
Modify the name of the 'IRC discussion' paragraph to just 'IRC' so that
the links keep working and remove the raw HTML anchors.
Adjustment is needed for documents which were using the '#email' anchor
which has now become '#mailing-lists'.
Signed-off-by: Peter Krempa
---
docs/contact.rst
We now have an paragraph about default URI choice if the passed pointer
is NULL. Add the two related bits from the 'NULL and empty string URIs'
from the legacy section to the current one and remove the old stuff.
Signed-off-by: Peter Krempa
---
docs/uri.rst | 25 -
1 file
Avoid the table and add a brief description of the transport protocol.
Signed-off-by: Peter Krempa
---
docs/uri.rst | 474 +--
1 file changed, 228 insertions(+), 246 deletions(-)
diff --git a/docs/uri.rst b/docs/uri.rst
index 714a0c4c21..4efd63408
Mention the legacy 'xen' string usage under the Xen hypervisor uri
section.
Signed-off-by: Peter Krempa
---
docs/uri.rst | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/docs/uri.rst b/docs/uri.rst
index 80c2d780c3..97a72dc37d 100644
--- a/docs/uri.rst
+++ b/
Signed-off-by: Peter Krempa
---
docs/kbase/tlscerts.rst | 4 +-
docs/meson.build| 2 +-
docs/remote.html.in | 297
docs/remote.rst | 219 +
4 files changed, 222 insertions(+), 300 deletions(-)
delete mod
Adjust links in the process.
Note that the conversion to the table is temporary and upcoming patch
will modify it for better readability.
Signed-off-by: Peter Krempa
---
docs/meson.build | 2 +-
docs/uri.html.in | 507 ---
docs/uri.rst | 447 +++
From: Pavel Hrdina
Signed-off-by: Pavel Hrdina
Signed-off-by: Peter Krempa
---
docs/meson.build | 2 +-
docs/storage.html.in | 833 ---
docs/storage.rst | 790
3 files changed, 791 insertions(+), 834 del
The paragraph talks about lack of fine grained access control which was
already added a long time ago.
Signed-off-by: Peter Krempa
---
docs/remote.rst | 10 --
1 file changed, 10 deletions(-)
diff --git a/docs/remote.rst b/docs/remote.rst
index 100df95e1f..933166144d 100644
--- a/docs/r
The anchor name was not fixed when the 'formatstorage' document was
converted to rst.
Signed-off-by: Peter Krempa
---
docs/formatsecret.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/formatsecret.rst b/docs/formatsecret.rst
index bb2217041a..03c2836843 10064
When the setup of TLS certs was originally split out of
'docs/remote.html' ( df99aa311a33e87d4 ) links refering to it were not
fixed.
Adjust them to point to the correct document.
Signed-off-by: Peter Krempa
---
docs/drvesx.rst| 5 ++---
tools/virt-pki-validate.in | 10 +-
From: Pavel Hrdina
Signed-off-by: Pavel Hrdina
Signed-off-by: Peter Krempa
---
docs/storage.html.in | 96 ++--
1 file changed, 48 insertions(+), 48 deletions(-)
diff --git a/docs/storage.html.in b/docs/storage.html.in
index b2cf343933..8fb2cec9bd 100644
On Fri, Apr 22, 2022 at 01:40:20PM +0200, Claudio Fontana wrote:
> On 4/22/22 10:19 AM, Daniel P. Berrangé wrote:
> > On Thu, Apr 21, 2022 at 08:06:40PM +0200, Claudio Fontana wrote:
> >> On 4/21/22 7:08 PM, Daniel P. Berrangé wrote:
> >>> On Thu, Apr 14, 2022 at 09:54:16AM +0200, Claudio Fontana w
In the past, we did set VLAN tag on .
However, during rewrite (v8.1.0-rc1~191) virNetDevSetVfConfig()
was changed and a condition that was responsible for calling
a function that sets VLAN tag was changed accidentally resulting
in VLAN tag not being set anymore.
However, because of other changes i
*** BLURB HERE ***
Michal Prívozník (2):
virNetDevSetVfMac: Fix error message on invalid args
virnetdev: Fix regression in setting VLAN tag
src/util/virnetdev.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
--
2.35.1
If virNetDevSetVfMac() is called with either @macaddr or
@allowRetry arguments NULL an error is reported, because this is
considered invalid use. However, the error message is not
informative as it could be.
Signed-off-by: Michal Privoznik
---
src/util/virnetdev.c | 4 +++-
1 file changed, 3 ins
On 4/22/22 10:19 AM, Daniel P. Berrangé wrote:
> On Thu, Apr 21, 2022 at 08:06:40PM +0200, Claudio Fontana wrote:
>> On 4/21/22 7:08 PM, Daniel P. Berrangé wrote:
>>> On Thu, Apr 14, 2022 at 09:54:16AM +0200, Claudio Fontana wrote:
RFC, starting point for discussion.
Sketch API chang
Hi,
On Fri, Apr 22, 2022 at 02:13:50AM -0700, Andrea Bolognani wrote:
> On Thu, Apr 21, 2022 at 08:24:39PM +0200, Victor Toso wrote:
> > On Thu, Apr 21, 2022 at 03:48:51PM +0200, Peter Krempa wrote:
> > > Actually, this paragraph is inaccurate since the commits were renamed.
> > >
> > > I'd prefer
On Fri, Apr 22, 2022 at 10:44:05AM +0200, Victor Toso wrote:
> On Fri, Apr 22, 2022 at 01:29:07AM -0700, Andrea Bolognani wrote:
> > On Thu, Apr 21, 2022 at 09:12:10PM +0200, Victor Toso wrote:
> > > Yeah. I'd instead suggest to move documentation to the top of
> > > typedef enum, in a similar fash
On Thu, Apr 21, 2022 at 08:24:39PM +0200, Victor Toso wrote:
> On Thu, Apr 21, 2022 at 03:48:51PM +0200, Peter Krempa wrote:
> > Actually, this paragraph is inaccurate since the commits were renamed.
> >
> > I'd prefer a standalone description of what's going on so since this
> > patch is okay itse
Hi,
On Fri, Apr 22, 2022 at 01:29:07AM -0700, Andrea Bolognani wrote:
> On Thu, Apr 21, 2022 at 09:12:10PM +0200, Victor Toso wrote:
> > On Thu, Apr 21, 2022 at 11:45:05AM -0700, Andrea Bolognani wrote:
> > > On Thu, Apr 21, 2022 at 08:34:10PM +0200, Victor Toso wrote:
> > > > For enum values, if
Hi,
On Fri, Apr 22, 2022 at 10:20:11AM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 21:07:49 +0200, Victor Toso wrote:
> > Hi,
> >
>
> Based on discussions on individual patches I've applied the feedback I
> had including Andrea's request to remove the extra empty line on the
> following
On Thu, Apr 21, 2022 at 09:12:10PM +0200, Victor Toso wrote:
> On Thu, Apr 21, 2022 at 11:45:05AM -0700, Andrea Bolognani wrote:
> > On Thu, Apr 21, 2022 at 08:34:10PM +0200, Victor Toso wrote:
> > > For enum values, if they are multiple line comments, I try to
> > > follow the above too. Otherwise
On Wed, Apr 20, 2022 at 21:07:49 +0200, Victor Toso wrote:
> Hi,
>
Based on discussions on individual patches I've applied the feedback I
had including Andrea's request to remove the extra empty line on the
following patches:
docstring: Fix generated documentation of virStorageVolInfoFlags
docstr
On Thu, Apr 21, 2022 at 08:06:40PM +0200, Claudio Fontana wrote:
> On 4/21/22 7:08 PM, Daniel P. Berrangé wrote:
> > On Thu, Apr 14, 2022 at 09:54:16AM +0200, Claudio Fontana wrote:
> >> RFC, starting point for discussion.
> >>
> >> Sketch API changes to allow parallel Saves, and open up
> >> and i
On Thu, Apr 21, 2022 at 18:08:36 +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 14, 2022 at 09:54:16AM +0200, Claudio Fontana wrote:
> > RFC, starting point for discussion.
> >
> > Sketch API changes to allow parallel Saves, and open up
> > and implementation for QEMU to leverage multifd migration
92 matches
Mail list logo
