[PATCH RESEND] apibuild: Fix self.waring method call

The parameters of self.warning is inconsistent with it's definition, So fix it. Signed-off-by: luzhipeng --- scripts/apibuild.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/apibuild.py b/scripts/apibuild.py index 2a343208c5..23a66734ac 100755 --- a/scripts/apibuil

[PATCH 2/5] docs: formatdomain: Add the introduced versions of net rss attrs

Signed-off-by: Han Han --- docs/formatdomain.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 9be305f3e6..11ecb77c66 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -5295,7 +5295,7 @@ following attribut

[PATCH 0/5] Some docs updates

Han Han (5): docs: apps: Add desktop app gnome-boxes docs: formatdomain: Add the introduced versions of net rss attrs news: Add news for rss and rss_hash_report attributes docs: drivers: Mention KVM/HVF in the link of qemu driver docs: drvqemu: Fix the syntax typo of Hypervisor.framewor

[PATCH 4/5] docs: drivers: Mention KVM/HVF in the link of qemu driver

Signed-off-by: Han Han --- docs/drivers.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drivers.rst b/docs/drivers.rst index b6a426be6a..b9dccdf5d2 100644 --- a/docs/drivers.rst +++ b/docs/drivers.rst @@ -19,7 +19,7 @@ The hypervisor drivers currently supported by lib

[PATCH 5/5] docs: drvqemu: Fix the syntax typo of Hypervisor.framework link

Signed-off-by: Han Han --- docs/drvqemu.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drvqemu.rst b/docs/drvqemu.rst index 6368a91fb9..a7c1975ed6 100644 --- a/docs/drvqemu.rst +++ b/docs/drvqemu.rst @@ -20,7 +20,7 @@ Project Links - The `KVM

[PATCH 3/5] news: Add news for rss and rss_hash_report attributes

Signed-off-by: Han Han --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7903449f9b..941a264e41 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -46,6 +46,11 @@ v8.3.0 (2022-05-02) This IOMMU device can be used with both Q35 and ARM virt guests. + *

[PATCH 1/5] docs: apps: Add desktop app gnome-boxes

Signed-off-by: Han Han --- docs/apps.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/apps.rst b/docs/apps.rst index a21e2249ea..536e9436b2 100644 --- a/docs/apps.rst +++ b/docs/apps.rst @@ -144,6 +144,9 @@ Desktop applications `qt-remote-viewer

[PATCH v2 0/1] ppc64: update qemucapabilities for 7.0.0 release

Hi, Sending this patch per Andrea's suggestion in the v1 review. Changes in v2: - create the caps using a P9 host with lots and lots of extra libraries and QEMU features enabled - v1 link: https://listman.redhat.com/archives/libvir-list/2022-May/230686.html Daniel Henrique Barboza (1): tests:

Re: [libvirt PATCH] NEWS: Mention improved heuristics for CPU baseline

On Fri, May 06, 2022 at 05:32:52PM +0200, Jiri Denemark wrote: > + * Improve heuristics for computing baseline CPU models > + > +Both virConnectBaselineHypervisorCPU and virConnectBaselineCPU were You can enclose the names of the APIs in double backticks for nicer HTML rendering. Reviewed-by

Re: [libvirt PATCH 0/5] ci: Add an integration test job utilizing upstream QEMU

On Fri, May 06, 2022 at 05:35:15PM +0200, Erik Skultety wrote: > Since QEMU doesn't maintain a spec file in upstream, we cannot build RPM > artifacts as part of the CI as we do for libvirt. Instead of hard-coding the > build steps for QEMU though patch 3/5 pulls in QEMU's CI job template which > me

[libvirt PATCH 1/5] ci: Separate the integration job template to a separate file

Future patches will do more code extraction to the template using YAML anchors so it's better that templates would live separately from the job definitions. Signed-off-by: Erik Skultety --- ci/integration-template.yml | 52 +++ ci/integration.yml | 54 ++-

[libvirt PATCH 5/5] ci: Add a Fedora integration test job utilizing upstream QEMU

Signed-off-by: Erik Skultety --- ci/integration.yml | 16 1 file changed, 16 insertions(+) diff --git a/ci/integration.yml b/ci/integration.yml index a71df41694..4978d3cf02 100644 --- a/ci/integration.yml +++ b/ci/integration.yml @@ -64,3 +64,19 @@ fedora-35-tests: LIBVIRT_

[libvirt PATCH 4/5] ci: Add a new integration job template for the upstream QEMU scenario

YAML anchors don't work with Shell conditions structures, so we cannot simply pull in the QEMU build template conditionally like we do for the other anchors. Instead we have to 'subclass' the .integration_tests template and inject the QEMU building bits. Signed-off-by: Erik Skultety --- ci/integ

[libvirt PATCH 2/5] ci: Break off the integration_tests template into more templates

There's quite a lot happening int the .integration_tests template already even without adding upstream QEMU build to the mix. Let's break the template into more pieces which can be put together using the YAML anchors. Signed-off-by: Erik Skultety --- ci/integration-template.yml | 76

[libvirt PATCH 3/5] ci: Introduce a template for upstream QEMU build

Rather than writing down the steps to build QEMU from source ourselves let's recycle what upstream QEMU uses in their CI. This has the obvious advantage that if QEMU changes something in their upstream CI build process we'll pull the change automatically. Since YAML anchors cannot be used in a cros

[libvirt PATCH 0/5] ci: Add an integration test job utilizing upstream QEMU

Since QEMU doesn't maintain a spec file in upstream, we cannot build RPM artifacts as part of the CI as we do for libvirt. Instead of hard-coding the build steps for QEMU though patch 3/5 pulls in QEMU's CI job template which means we'll remain in sync if QEMU makes changes to its build process. E

[libvirt PATCH] NEWS: Mention improved heuristics for CPU baseline

Signed-off-by: Jiri Denemark --- NEWS.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 4a213682a4..70fbfc0108 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -21,6 +21,15 @@ v8.4.0 (unreleased) * **Bug fixes** + * Improve heuristics for computing baseline C

Re: [libvirt RFCv7 00/40] multifd save restore prototype

On Fri, May 06, 2022 at 03:10:44PM +0200, Claudio Fontana wrote: > This is v7 of the multifd save prototype, rebased on post 8.3.0 release, > which features more splits and better support for multifd compression. snip I've pushed the following patches to get them out of the way docs: update refs

Re: [libvirt RFCv7 34/40] qemu: saveimage: add multifd-compression field to save format

On 5/6/22 4:32 PM, Claudio Fontana wrote: > One thing I was thinking about, beyond what is in this patch, > > is that for the QEMU driver we could save the number of channels used for the > --parallel save in the qemu SaveImage header as well. > > This way, on restore libvirt would automatically

Re: [libvirt RFCv7 34/40] qemu: saveimage: add multifd-compression field to save format

One thing I was thinking about, beyond what is in this patch, is that for the QEMU driver we could save the number of channels used for the --parallel save in the qemu SaveImage header as well. This way, on restore libvirt would automatically know how many file it needs to load, and the user do

Re: [libvirt RFCv7 12/40] tools: make use of params in doSave

On 5/6/22 3:24 PM, Daniel P. Berrangé wrote: > On Fri, May 06, 2022 at 03:19:31PM +0200, Claudio Fontana wrote: >> whops this is pretty wrong. >> >> On 5/6/22 3:10 PM, Claudio Fontana wrote: >>> Signed-off-by: Claudio Fontana >>> --- >>> tools/virsh-domain.c | 25 ++--- >>> 1

Re: [libvirt RFCv7 12/40] tools: make use of params in doSave

On Fri, May 06, 2022 at 03:19:31PM +0200, Claudio Fontana wrote: > whops this is pretty wrong. > > On 5/6/22 3:10 PM, Claudio Fontana wrote: > > Signed-off-by: Claudio Fontana > > --- > > tools/virsh-domain.c | 25 ++--- > > 1 file changed, 18 insertions(+), 7 deletions(-) >

Re: [libvirt RFCv7 12/40] tools: make use of params in doSave

whops this is pretty wrong. On 5/6/22 3:10 PM, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > tools/virsh-domain.c | 25 ++--- > 1 file changed, 18 insertions(+), 7 deletions(-) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c > index ba492e807e.

[libvirt RFCv7 28/40] qemu: implement qemuSaveImageLoadMultiFd

use multifd to restore parallel saves. Signed-off-by: Claudio Fontana --- src/qemu/qemu_driver.c| 12 +++- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_migration.h | 6 ++ src/qemu/qemu_saveimage.c | 119 +- src/qemu/qemu_saveimage.h | 9 ++- 5 f

[libvirt RFCv7 22/40] qemu: saveimage: convert qemuSaveImageOpen to use virQEMUSaveFd

all the logic to open a fd, create a wrapper etc, is boilerplate code that is best reused, so change the Open function to take an existing already initialized virQEMUSaveFd. Adapt all callers of qemuSaveImageOpen. Signed-off-by: Claudio Fontana --- src/qemu/qemu_driver.c| 100 ++

[libvirt RFCv7 35/40] qemu: saveimage: add parallel compression argument to ImageCreate

Signed-off-by: Claudio Fontana --- src/qemu/qemu_driver.c| 11 ++- src/qemu/qemu_saveimage.c | 1 + src/qemu/qemu_saveimage.h | 1 + src/qemu/qemu_snapshot.c | 2 +- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c inde

[libvirt RFCv7 17/40] libvirt: add new VIR_DOMAIN_SAVE_PARALLEL flag and parameter

in order to enable parallel save functionality, we will need an opportune new flag and a parameter to specify the number of extra connections to use. Signed-off-by: Claudio Fontana --- include/libvirt/libvirt-domain.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/includ

[libvirt RFCv7 24/40] qemu: saveimage: wire up saveimage code with the multifd helper

use the multifd helper and the new virQEMUSaveFd APIs for multifd. Signed-off-by: Claudio Fontana --- src/qemu/qemu_saveimage.c | 43 +++ 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c index

[libvirt RFCv7 31/40] docs: update refs to virDomainSaveParams and virDomainRestoreParams

Signed-off-by: Claudio Fontana --- docs/formatsnapshot.rst | 5 +++-- include/libvirt/libvirt-domain.h | 1 + src/libvirt-domain.c | 6 +++--- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/formatsnapshot.rst b/docs/formatsnapshot.rst index 9b874e4890..dd

[libvirt RFCv7 20/40] qemu: saveimage: introduce virQEMUSaveFd

use this data type to encapsulate the pathname, file descriptor, wrapper, and need to unlink. This will make management of the resources associated with an FD used for QEMU save/restore much easier, reducing the amount of explicit cleanup required. Signed-off-by: Claudio Fontana --- src/qemu/qe

[libvirt RFCv7 30/40] tools: add parallel parameter to virsh restore command

Signed-off-by: Claudio Fontana --- docs/manpages/virsh.rst | 11 ++- tools/virsh-domain.c| 19 +++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index e9012b85d1..3bf9b54806 100644 --- a/docs/manpages/v

[libvirt RFCv7 38/40] qemu: saveimage: implement multifd-compression in parallel save

Signed-off-by: Claudio Fontana --- src/qemu/qemu_migration.c | 17 + src/qemu/qemu_migration.h | 2 +- src/qemu/qemu_saveimage.c | 13 +++-- 3 files changed, 25 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 12b7e84

[libvirt RFCv7 14/40] multifd-helper: new helper for parallel save/restore

For the save direction, this helper listens on a unix socket which QEMU connects to for multifd migration to files. For the restore direction, this helper connects to a unix socket QEMU listens at for multifd migration from files. The file descriptors are passed as command line parameters. Signe

[libvirt RFCv7 36/40] qemu: saveimage: add stub support for multifd compression parameter

Signed-off-by: Claudio Fontana --- src/qemu/qemu_driver.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 473ec49bea..4685b280c0 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2812,6 +2812,7 @@ qe

[libvirt RFCv7 34/40] qemu: saveimage: add multifd-compression field to save format

Signed-off-by: Claudio Fontana --- src/qemu/qemu_saveimage.c | 19 ++- src/qemu/qemu_saveimage.h | 5 +++-- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c index 35a75069e8..c0920c5baa 100644 --- a/src/qemu/qem

[libvirt RFCv7 25/40] qemu: capabilities: add multifd to the probed migration capabilities

Signed-off-by: Claudio Fontana --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 3 +++ tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/ca

[libvirt RFCv7 26/40] qemu: implement qemuMigrationSrcToFilesMultiFd

implement a function similar to qemuMigrationSrcToFile that migrates to multiple files using QEMU multifd. Signed-off-by: Claudio Fontana --- src/qemu/qemu_migration.c| 131 --- src/qemu/qemu_migration.h| 7 ++ src/qemu/qemu_migration_params.c | 22

[libvirt RFCv7 21/40] qemu: saveimage: convert qemuSaveImageCreate to use virQEMUSaveFd

now that we introduced virQEMUSaveFd, use it in the creation of a new save image. Signed-off-by: Claudio Fontana --- src/qemu/qemu_saveimage.c | 54 --- 1 file changed, 17 insertions(+), 37 deletions(-) diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_s

[libvirt RFCv7 40/40] qemu: saveimage: restore compressed parallel saves

Signed-off-by: Claudio Fontana --- src/qemu/qemu_saveimage.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c index 8f589d1cce..3d339e6eaa 100644 --- a/src/qemu/qemu_saveimage.c +++ b/src/qemu/qemu_saveimage.c @@ -638,6 +

[libvirt RFCv7 39/40] tools: add parallel-compression parameter to virsh save command

this completes the save side of the parallel compression support. Signed-off-by: Claudio Fontana --- docs/manpages/virsh.rst | 4 tools/virsh-domain.c| 12 2 files changed, 16 insertions(+) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 3bf9b54806..9

[libvirt RFCv7 06/40] virfile: add comment about the use of SEEK_END in virFileDiskCopy

Signed-off-by: Claudio Fontana Reviewed-by: Daniel P. Berrangé --- src/util/virfile.c | 4 1 file changed, 4 insertions(+) diff --git a/src/util/virfile.c b/src/util/virfile.c index 8b07db6679..a9fcac1af9 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -4741,6 +4741,10 @@ virFi

[libvirt RFCv7 19/40] qemu: add stub support for VIR_DOMAIN_SAVE_PARALLEL in restore

and its companion param VIR_SAVE_PARAM_PARALLEL_CONNECTIONS. Signed-off-by: Claudio Fontana --- src/qemu/qemu_driver.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e276a66815..ff2be6ffe9 100644 --- a/src

[libvirt RFCv7 00/40] multifd save restore prototype

This is v7 of the multifd save prototype, rebased on post 8.3.0 release, which features more splits and better support for multifd compression. changes from v6: * improved error path handling, with error messages and especially cancellation of qemu process on error during restore. * split patc

[libvirt RFCv7 11/40] remote: Add RPC support for the virDomainRestoreParams API

Signed-off-by: Claudio Fontana Reviewed-by: Daniel P. Berrangé --- src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 14 +- src/remote_protocol-structs | 8 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/re

[libvirt RFCv7 13/40] tools: make use of params in cmdRestore

Signed-off-by: Claudio Fontana --- tools/virsh-domain.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index be5679df0f..18498540f6 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5316,14

[libvirt RFCv7 33/40] libvirt: add new VIR_SAVE_PARAM_PARALLEL_COMPRESSION

Signed-off-by: Claudio Fontana --- include/libvirt/libvirt-domain.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 5e858f854b..1ae8b1c77d 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt

[libvirt RFCv7 37/40] qemu: migration: expose qemuMigrationParamsSetString

change from static to external linkage, and move the function close to the other similar ones, near qemuMigrationParamsSetULL. Signed-off-by: Claudio Fontana --- src/qemu/qemu_migration_params.c | 47 +++- src/qemu/qemu_migration_params.h | 5 2 files changed, 2

[libvirt RFCv7 15/40] qemu: add implementation for virDomainSaveParams API

Signed-off-by: Claudio Fontana --- src/qemu/qemu_driver.c | 53 ++ 1 file changed, 53 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 464c080409..4a74713738 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @

[libvirt RFCv7 32/40] qemu: add migration parameter multifd-compression

add it to both capabilities and migration parameters Signed-off-by: Claudio Fontana --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_migration_params.c | 2 ++ src/qemu/qemu_migration_params.h

[libvirt RFCv7 27/40] qemu: add parameter to qemuMigrationDstRun to skip waiting

The distinction on whether to wait for the migration completion or not was made on the async job type, but with the future addition of multifd migration from files, we need a way to avoid waiting, so we can prepare multifd migration parameters before starting the transfers. Adapt all callers. Si

[libvirt RFCv7 29/40] tools: add parallel parameter to virsh save command

Signed-off-by: Claudio Fontana --- docs/manpages/virsh.rst | 23 +-- tools/virsh-domain.c| 19 +++ 2 files changed, 36 insertions(+), 6 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index e73e590754..e9012b85d1 100644 --- a/do

[libvirt RFCv7 08/40] libvirt: introduce virDomainRestoreParams public API

add new API in order to be able to extend parameters to the domain restore operation. We will use it to fit the existing arguments of VirDomainRestoreFlags for now. Signed-off-by: Claudio Fontana Reviewed-by: Daniel P. Berrangé --- include/libvirt/libvirt-domain.h | 4 +++ src/driver-hyperviso

[libvirt RFCv7 09/40] remote: Add RPC support for the virDomainSaveParams API

Signed-off-by: Claudio Fontana Reviewed-by: Daniel P. Berrangé --- src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 17 - src/remote_protocol-structs | 9 + 3 files changed, 26 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/sr

[libvirt RFCv7 23/40] qemu: saveimage: add virQEMUSaveFd APIs for multifd

add APIs to Create, Close and Free MultiFD files to associate with multifd channels. Signed-off-by: Claudio Fontana --- src/qemu/qemu_saveimage.c | 87 +++ src/qemu/qemu_saveimage.h | 11 + 2 files changed, 98 insertions(+) diff --git a/src/qemu/qemu_save

[libvirt RFCv7 03/40] iohelper: move runIO function to virfile.c

where it can be reused by other helpers. No changes other than the move. Note that this makes iohelper now dependent on -lutil and -lacl. Signed-off-by: Claudio Fontana --- src/util/iohelper.c | 175 src/util/meson.build | 5 ++ src/util/virfile.c |

[libvirt RFCv7 04/40] virfile: rename runIO to virFileDiskCopy

Signed-off-by: Claudio Fontana --- src/util/iohelper.c | 2 +- src/util/virfile.c | 10 +- src/util/virfile.h | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/util/iohelper.c b/src/util/iohelper.c index b3aaf82b9f..ce10ccb905 100644 --- a/src/util/iohelper.c

[libvirt RFCv7 12/40] tools: make use of params in doSave

Signed-off-by: Claudio Fontana --- tools/virsh-domain.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ba492e807e..be5679df0f 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -4203,6 +

[libvirt RFCv7 18/40] qemu: add stub support for VIR_DOMAIN_SAVE_PARALLEL in save

and its companion param VIR_SAVE_PARAM_PARALLEL_CONNECTIONS Signed-off-by: Claudio Fontana --- src/qemu/qemu_driver.c| 17 +++-- src/qemu/qemu_saveimage.c | 1 + src/qemu/qemu_saveimage.h | 1 + src/qemu/qemu_snapshot.c | 2 +- 4 files changed, 14 insertions(+), 7 deletions(-

[libvirt RFCv7 16/40] qemu: add implementation for virDomainRestoreParams API

Signed-off-by: Claudio Fontana --- src/qemu/qemu_driver.c | 51 -- 1 file changed, 44 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4a74713738..e3582f62a7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu

[libvirt RFCv7 07/40] libvirt: introduce virDomainSaveParams public API

create an alternative to virDomainSaveFlags that is more extendible via parameters. Signed-off-by: Claudio Fontana Reviewed-by: Daniel P. Berrangé --- include/libvirt/libvirt-domain.h | 26 + src/driver-hypervisor.h | 7 + src/libvirt-domain.c | 48

[libvirt RFCv7 10/40] gendispatch: add DomainRestoreParams as requiring conn argument

in preparation for the addition of DomainRestoreParams, add it to the list of methods requiring a conn first argument. Signed-off-by: Claudio Fontana Reviewed-by: Daniel P. Berrangé --- src/rpc/gendispatch.pl | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/rpc/gendis

[libvirt RFCv7 05/40] virfile: change virFileDiskCopy arguments to extend beyond stdin, stdout

Signed-off-by: Claudio Fontana --- src/util/iohelper.c | 17 +--- src/util/virfile.c | 64 +++-- src/util/virfile.h | 2 +- 3 files changed, 46 insertions(+), 37 deletions(-) diff --git a/src/util/iohelper.c b/src/util/iohelper.c index ce10ccb90

[libvirt RFCv7 02/40] iohelper: refactor copy operation as a separate function

Signed-off-by: Claudio Fontana Reviewed-by: Daniel P. Berrangé --- src/util/iohelper.c | 131 +--- 1 file changed, 75 insertions(+), 56 deletions(-) diff --git a/src/util/iohelper.c b/src/util/iohelper.c index c13746a547..1584321839 100644 --- a/src/util/

[libvirt RFCv7 01/40] iohelper: introduce new struct to carry copy operation parameters

this is in preparation for a minor refactoring of the copy function itself out of runIO(). Signed-off-by: Claudio Fontana Reviewed-by: Daniel P. Berrangé --- src/util/iohelper.c | 95 + 1 file changed, 53 insertions(+), 42 deletions(-) diff --git a/s

Re: [libvirt PATCH] ci: Move clang/asan/ubsan jobs to Ubuntu 22.04

On 5/6/22 14:40, Andrea Bolognani wrote: > Using an updated toolchain means we're likely to catch more > issues. > > Signed-off-by: Andrea Bolognani > --- > ci/gitlab.yml | 16 > ci/manifest.yml | 6 +++--- > 2 files changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Mi

[libvirt PATCH] ci: Move clang/asan/ubsan jobs to Ubuntu 22.04

Using an updated toolchain means we're likely to catch more issues. Signed-off-by: Andrea Bolognani --- ci/gitlab.yml | 16 ci/manifest.yml | 6 +++--- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/ci/gitlab.yml b/ci/gitlab.yml index f93f6222e8..07ad36809d

Re: Test failures on macOS 12

On Fri, May 06, 2022 at 11:10:44AM +0100, Daniel P. Berrangé wrote: > On Fri, May 06, 2022 at 03:00:14AM -0700, Andrea Bolognani wrote: > > I'm trying to enable CI coverage for macOS 12, but I'm running into a > > couple of issues that I'm not sure how to handle. > > > > Note that the test suite cu

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

On 5/6/22 1:54 PM, Daniel P. Berrangé wrote: > On Fri, May 06, 2022 at 01:51:53PM +0200, Claudio Fontana wrote: >> On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: >>> On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: where it can be reused by other helpers. No changes other th

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

On Fri, May 06, 2022 at 01:51:53PM +0200, Claudio Fontana wrote: > On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: > > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: > >> where it can be reused by other helpers. > >> No changes other than the move. > >> > >> Note that this makes iohe

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

On Fri, May 06, 2022 at 01:48:33PM +0200, Claudio Fontana wrote: > On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: > > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: > >> where it can be reused by other helpers. > >> No changes other than the move. > >> > >> Note that this makes iohe

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

On Fri, May 06, 2022 at 01:29:57PM +0200, Claudio Fontana wrote: > On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: > > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: > >> where it can be reused by other helpers. > >> No changes other than the move. > >> > >> Note that this makes iohe

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: >> where it can be reused by other helpers. >> No changes other than the move. >> >> Note that this makes iohelper now dependent on -lutil, because unused >> (for iohelper) parts of virfi

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: >> where it can be reused by other helpers. >> No changes other than the move. >> >> Note that this makes iohelper now dependent on -lutil, because unused >> (for iohelper) parts of virfi

Re: [PATCH 1/3] tests: qemucapabilities: update ppc64 qemu caps for 7.0.0 release

On Fri, May 06, 2022 at 07:01:53AM -0300, Daniel Henrique Barboza wrote: > On 5/6/22 04:51, Andrea Bolognani wrote: > > It'd be great if the capabilities were updated to the actual 7.0.0 > > release, even if the changes are small. > > From 7.0.0-rc2 to what I've done (after installing a bunch of op

Re: [libvirt RFCv6 00/27] multifd save restore prototype

Hi Daniel, will repost a v7 today with many more improvements, in terms of split and in terms of multifd-compression. Thanks! Claudio On 5/5/22 2:52 PM, Claudio Fontana wrote: > This a respin of the multifd save prototype, > rebased on post 8.3.0 release. > > There are still quite a few rough

Re: [libvirt RFCv6 05/27] virfile: change virFileDiskCopy arguments to extend beyond stdin, stdout

On 5/6/22 1:03 PM, Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 02:52:19PM +0200, Claudio Fontana wrote: >> Signed-off-by: Claudio Fontana >> --- >> src/util/iohelper.c | 17 +- >> src/util/virfile.c | 82 ++--- >> src/util/virfile.h | 2 +

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

On 5/6/22 1:02 PM, Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: >> where it can be reused by other helpers. >> No changes other than the move. >> >> Note that this makes iohelper now dependent on -lutil, because unused >> (for iohelper) parts of virfi

Re: [libvirt RFCv6 12/27] remote: Add RPC support for the virDomainRestoreParams API

On Thu, May 05, 2022 at 02:52:26PM +0200, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > src/remote/remote_driver.c | 1 + > src/remote/remote_protocol.x | 14 +- > src/remote_protocol-structs | 8 > 3 files changed, 22 insertions(+), 1 deletion(-) Revi

Re: [libvirt RFCv6 11/27] gendispatch: add DomainRestoreParams as requiring conn argument

On Thu, May 05, 2022 at 02:52:25PM +0200, Claudio Fontana wrote: > in preparation for the addition of DomainRestoreParams, > add it to the list of methods requiring a conn first argument. > > Signed-off-by: Claudio Fontana > --- > src/rpc/gendispatch.pl | 5 - > 1 file changed, 4 insertions(

Re: [libvirt RFCv6 10/27] remote: Add RPC support for the virDomainSaveParams API

On Thu, May 05, 2022 at 02:52:24PM +0200, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > src/remote/remote_driver.c | 1 + > src/remote/remote_protocol.x | 17 - > src/remote_protocol-structs | 9 + > 3 files changed, 26 insertions(+), 1 deletion(-)

Re: [libvirt RFCv6 09/27] libvirt: introduce virDomainRestoreParams public API

On Thu, May 05, 2022 at 02:52:23PM +0200, Claudio Fontana wrote: > add new API in order to be able to extend parameters to the domain > restore operation. We will use it to fit the existing arguments of > VirDomainRestoreFlags for now. > > Signed-off-by: Claudio Fontana > --- > include/libvirt/l

Re: [libvirt RFCv6 08/27] libvirt: introduce virDomainSaveParams public API

On Thu, May 05, 2022 at 02:52:22PM +0200, Claudio Fontana wrote: > create an alternative to virDomainSaveFlags that is more > extendible via parameters. > > Signed-off-by: Claudio Fontana > --- > include/libvirt/libvirt-domain.h | 26 + > src/driver-hypervisor.h | 7 +++

Re: [libvirt RFCv6 05/27] virfile: change virFileDiskCopy arguments to extend beyond stdin, stdout

On Thu, May 05, 2022 at 02:52:19PM +0200, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > src/util/iohelper.c | 17 +- > src/util/virfile.c | 82 ++--- > src/util/virfile.h | 2 +- > 3 files changed, 64 insertions(+), 37 deletions

Re: [libvirt RFCv6 06/27] virfile: add comment about the use of SEEK_END in virFileDiskCopy

On Thu, May 05, 2022 at 02:52:20PM +0200, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > src/util/virfile.c | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/d

Re: [libvirt RFCv6 04/27] virfile: rename runIO to virFileDiskCopy

On Thu, May 05, 2022 at 02:52:18PM +0200, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > src/util/iohelper.c | 2 +- > src/util/virfile.c | 2 +- > src/util/virfile.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Dan

Re: [libvirt RFCv6 03/27] iohelper: move runIO function to virfile.c

On Thu, May 05, 2022 at 02:52:17PM +0200, Claudio Fontana wrote: > where it can be reused by other helpers. > No changes other than the move. > > Note that this makes iohelper now dependent on -lutil, because unused > (for iohelper) parts of virfile.c contain calls to openpty(3). Needs -lacl too

Re: [PATCH 0/2] testutils*: Hide some global variables

On Fri, May 06, 2022 at 08:59:25AM +0200, Michal Privoznik wrote: > Pipeline: > > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/532708775 > > Michal Prívozník (2): > testutils: Write setter for virTestHostArch global variable > testutilsqemu: Write getter/setter for CPU def global va

Re: Test failures on macOS 12

On Fri, May 06, 2022 at 03:00:14AM -0700, Andrea Bolognani wrote: > I'm trying to enable CI coverage for macOS 12, but I'm running into a > couple of issues that I'm not sure how to handle. > > Note that the test suite currently passes on macOS 11[1], so these > failures have to be a consequence t

Re: [PATCH 0/2] test: Link qemuhotplugmock with test_utils_qemu and test_utils

On 5/6/22 12:06, Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 01:20:54PM +0200, Ján Tomko wrote: >> On a Monday in 2022, Michal Privoznik wrote: >>> This is an alternative version to: >>> >>> https://listman.redhat.com/archives/libvir-list/2022-April/230092.html >>> >>> Michal Prívozník (2):

Re: [PATCH 0/2] test: Link qemuhotplugmock with test_utils_qemu and test_utils

On Thu, May 05, 2022 at 01:20:54PM +0200, Ján Tomko wrote: > On a Monday in 2022, Michal Privoznik wrote: > > This is an alternative version to: > > > > https://listman.redhat.com/archives/libvir-list/2022-April/230092.html > > > > Michal Prívozník (2): > > test: Link qemuhotplugmock with test_u

Re: [PATCH 1/3] tests: qemucapabilities: update ppc64 qemu caps for 7.0.0 release

On 5/6/22 04:51, Andrea Bolognani wrote: On Thu, May 05, 2022 at 05:17:42PM -0300, Daniel Henrique Barboza wrote: On 5/5/22 03:59, Peter Krempa wrote: On Wed, May 04, 2022 at 14:27:16 -0300, Daniel Henrique Barboza wrote: Most significant changes happened in the ppc64-latest.args files with

Test failures on macOS 12

I'm trying to enable CI coverage for macOS 12, but I'm running into a couple of issues that I'm not sure how to handle. Note that the test suite currently passes on macOS 11[1], so these failures have to be a consequence to changes made to macOS that we haven't yet learned how to cope with. The f

Re: [libvirt PATCH 2/2] ci: Add Ubuntu 22.04

On Fri, May 06, 2022 at 10:36:10AM +0200, Michal Prívozník wrote: > On 5/6/22 10:31, Daniel P. Berrangé wrote: > >>> + ubuntu-2204: x86_64 > >> > >> Any reason we don't want to run ASAN on new Ubuntu? Or we do that only > >> for clang? > > > > We only need ASAN running on one job and which one is

Re: [libvirt PATCH 0/2] ci: Refresh, add Ubuntu 22.04

On 5/6/22 10:03, Andrea Bolognani wrote: > Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/532731034 > > Andrea Bolognani (2): > ci: Refresh configuration > ci: Add Ubuntu 22.04 > > ci/containers/ubuntu-2204.Dockerfile | 101 +++ > ci/gitlab.yml

Re: [libvirt PATCH 2/2] ci: Add Ubuntu 22.04

On 5/6/22 10:31, Daniel P. Berrangé wrote: > On Fri, May 06, 2022 at 10:29:32AM +0200, Michal Prívozník wrote: >> On 5/6/22 10:03, Andrea Bolognani wrote: >>> Signed-off-by: Andrea Bolognani >>> --- >>> ci/containers/ubuntu-2204.Dockerfile | 101 +++ >>> ci/gitlab.yml

Re: [libvirt PATCH 2/2] ci: Add Ubuntu 22.04

On Fri, May 06, 2022 at 10:29:32AM +0200, Michal Prívozník wrote: > On 5/6/22 10:03, Andrea Bolognani wrote: > > Signed-off-by: Andrea Bolognani > > --- > > ci/containers/ubuntu-2204.Dockerfile | 101 +++ > > ci/gitlab.yml| 16 + > > ci/manifes

Re: [libvirt PATCH 2/2] ci: Add Ubuntu 22.04

On 5/6/22 10:03, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > ci/containers/ubuntu-2204.Dockerfile | 101 +++ > ci/gitlab.yml| 16 + > ci/manifest.yml | 2 + > 3 files changed, 119 insertions(+) > cr

Re: [libvirt PATCH 0/3] meson: Fix handling of version scripts

On 5/5/22 18:10, Andrea Bolognani wrote: > Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/532183411 > > Andrea Bolognani (3): > meson: Refactor handling of link_args and link_depends > meson: Don't attempt to use version scripts on macOS > meson: Drop support for -Wl,-M > >

[libvirt PATCH 2/2] ci: Add Ubuntu 22.04

Signed-off-by: Andrea Bolognani --- ci/containers/ubuntu-2204.Dockerfile | 101 +++ ci/gitlab.yml| 16 + ci/manifest.yml | 2 + 3 files changed, 119 insertions(+) create mode 100644 ci/containers/ubuntu-2204.Dockerfile

[libvirt PATCH 0/2] ci: Refresh, add Ubuntu 22.04

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/532731034 Andrea Bolognani (2): ci: Refresh configuration ci: Add Ubuntu 22.04 ci/containers/ubuntu-2204.Dockerfile | 101 +++ ci/gitlab.yml| 18 - ci/manifest.yml

  1   2   >