From: Klaus Jensen
Do not report the "null uuid" (all zeros) in the namespace
identification descriptors.
Reported-by: Luis Chamberlain
Reported-by: Christoph Hellwig
Reviewed-by: Christoph Hellwig
Reviewed-by: Keith Busch
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c | 17 +++
From: Klaus Jensen
Since version 5.2 commit 6eb7a071292a ("hw/block/nvme: change controller
pci id"), the emulated NVMe controller has defaulted to a non-Intel PCI
identifier.
Deprecate the compatibility parameter so we can get rid of it once and
for all.
Reviewed-by: Philippe Mathieu-Daudé
Si
From: Dmitry Tikhov
NVMe command set specification for end-to-end data protection formatted
namespace states:
o If the Reference Tag Check bit of the PRCHK field is set to ‘1’ and
the namespace is formatted for Type 3 protection, then the
controller:
▪ should not compar
From: Klaus Jensen
The Linux kernel quirks the QEMU NVMe controller pretty heavily because
of the namespace identifier mess. Since this is now fixed, bump the
firmware revision number to allow the quirk to be disabled for this
revision.
As of now, bump the firmware revision number to be equal to
From: Klaus Jensen
We cannot provide auto-generated unique or persistent namespace
identifiers (EUI64, NGUID, UUID) easily. Since 6.1, namespaces have been
assigned a generated EUI64 of the form "52:54:00:".
This is will be unique within a QEMU instance, but not globally.
Revert that this is ass
From: Klaus Jensen
Do not default to generate an UUID for namespaces if it is not
explicitly specified.
This is a technically a breaking change in behavior. However, since the
UUID changes on every VM launch, it is not spec compliant and is of
little use since the UUID cannot be used reliably an
From: Klaus Jensen
The Identify Controller Serial Number (SN) is the serial number for the
NVM subsystem and must be the same across all controller in the NVM
subsystem.
Enforce this.
Reviewed-by: Christoph Hellwig
Reviewed-by: Keith Busch
Signed-off-by: Klaus Jensen
---
hw/nvme/nvme.h |
From: Klaus Jensen
Pass the right constant to nvme_smart_event(). The NVME_AER* values hold
the bit position in the SMART byte, not the shifted value that we expect
it to be in nvme_smart_event().
Fixes: c62720f137df ("hw/block/nvme: trigger async event during injecting smart
warning")
Acked-by
From: Dmitry Tikhov
Current implementation have problem in the read part of copy command.
Because there is no metadata mangling before nvme_dif_check invocation,
reftag error could be thrown for blocks of namespace that have not been
previously written to.
Signed-off-by: Dmitry Tikhov
Reviewed-
From: Dmitry Tikhov
Since nlbas is of type int, it does not work with large namespace size
values, e.g., 9 TB size of file backing namespace and 8 byte metadata
with 4096 bytes lbasz gives negative nlbas value, which is later
promoted to negative int64_t type value and results in negative
ns->mof
From: Dmitry Tikhov
Since there is no return after nvme_dsm_cb invocation, metadata
associated with non-zero block range is currently zeroed. Also this
behaviour leads to segfault since we schedule iocb->bh two times.
First when entering nvme_dsm_cb with iocb->idx == iocb->nr and
second because o
From: Klaus Jensen
Hi Peter,
The following changes since commit 70e975203f366f2f30daaeb714bb852562b7b72f:
Merge tag 'pull-request-2022-06-03' of https://gitlab.com/thuth/qemu into
staging (2022-06-03 06:43:38 -0700)
are available in the Git repository at:
git://git.infradead.org/qemu-nvm
On a Friday in 2022, Peter Krempa wrote:
Refactor the function to use modern XML formatting machinery.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP
On a Friday in 2022, Peter Krempa wrote:
From: Rohit Kumar
This patch adds unit tests for remote NVRAM.
Examples:
and
and
Signed-off-by: Prerna Saxena
Signed-off-by: Florian Schmidt
Signed-off-by: Rohit Kumar
---
.../bios-nvram-file.x86_64-latest.
On a Friday in 2022, Peter Krempa wrote:
From: Rohit Kumar
This patch introduces the logic to format and parse remote NVRAM.
Update NVRAM element schema, and docs for supporting network backed
NVRAM. NVRAM backed over network would give the flexibility to start
the VM on any host without havin
On a Friday in 2022, Peter Krempa wrote:
Introduce virDomainLoaderDefFormatNvram and extract the code to it so
that it's self-contained in upcoming patches adding more complex logic.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 27 +++
1 file changed, 19 inser
On a Friday in 2022, Peter Krempa wrote:
Prepare for network backed nvram by refusing the reset of nvram on boot
and don't check whether it exists. We will not support filling it from a
template.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_firmware.c | 20
1 file changed,
On a Friday in 2022, Peter Krempa wrote:
From: Rohit Kumar
Signed-off-by: Prerna Saxena
Signed-off-by: Florian Schmidt
Signed-off-by: Rohit Kumar
Signed-off-by: Peter Krempa
---
src/qemu/qemu_validate.c | 108 ++-
1 file changed, 84 insertions(+), 24 delet
On a Friday in 2022, Peter Krempa wrote:
Setup all fields for use with -blockdev.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 11 ---
src/qemu/qemu_domain.h | 3 ++-
src/qemu/qemu_process.c | 2 +-
3 files changed, 11 insertions(+), 5 deletions(-)
Reviewed-by: Ján Tomko
On a Friday in 2022, Peter Krempa wrote:
We don't really use it besides when starting up the VM so when
reconnecting this step is totally pointless.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 4
1 file changed, 4 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
D
On 6/3/22 09:36, Peter Krempa wrote:
> On Thu, Jun 02, 2022 at 22:49:15 +, Yang, Lin A wrote:
>> On 6/2/22, 11:28 AM, "Yang, Lin A" wrote:
>>> On 6/1/22, 11:37 PM, "Michal Prívozník" wrote:
>
> [...]
>
So maybe in the end libvirt CAN know the difference without having to do
any ve
On a Friday in 2022, Peter Krempa wrote:
Use the designated helpers for virStorageSource instead using the
file-based ones with a check.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_cgroup.c | 3 +--
src/qemu/qemu_namespace.c | 5 +++--
src/security/security_dac.c | 21 +
On Wed, Jun 01, 2022 at 14:49:00 +0200, Jiri Denemark wrote:
> This series implements a new VIR_MIGRATE_POSTCOPY_RESUME flag (virsh
> migrate --resume) for recovering from a failed post-copy migration.
>
> You can also fetch the series from my gitlab fork (the last RFC patch is
> missing there):
>
On a Friday in 2022, Peter Krempa wrote:
Since we now have a full virStorageSource for storing the nvram path we
don't need the extra dance of transfering the data into the 'pflash1'
*transferring
variable which was an intermediary solution to use -blockdev.
For now we keep it functionally i
On Wed, Jun 01, 2022 at 14:50:06 +0200, Jiri Denemark wrote:
> The QEMU process is already running, all we need to do is to call
> migrate-recover QMP command. Except for some checks and cookie handling,
> of course.
>
> Signed-off-by: Jiri Denemark
> Reviewed-by: Peter Krempa
> Reviewed-by: Pav
On a Friday in 2022, Peter Krempa wrote:
From: Rohit Kumar
Currently, libvirt allows only local filepaths to specify the location
of the 'nvram' image. Changing it to virStorageSource type will allow
to support remote storage for nvram.
will allow supporting
or
will allow support for
Sig
On a Friday in 2022, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Friday in 2022, Peter Krempa wrote:
Extract the internals of qemuDomainPrepareStorageSourceBlockdev into
qemuDomainPrepareStorageSourceBlockdevNodename so that we can reuse it
when instantiating the virStorageSource for pflash backing.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c
On a Friday in 2022, Peter Krempa wrote:
We need to use the 'name' variable and just overwrite it with the FD
number when FDs are passed on the monitor. Otherwise we will read NULL
path if the FD is accessed before being passed on the monitor. The idea
of this helper is to simplify the monitor co
We need to use the 'name' variable and just overwrite it with the FD
number when FDs are passed on the monitor. Otherwise we will read NULL
path if the FD is accessed before being passed on the monitor. The idea
of this helper is to simplify the monitor code so it would be
counterproductive to have
On Wed, Jun 01, 2022 at 14:50:07 +0200, Jiri Denemark wrote:
> Everything was already done in the normal Finish phase and vCPUs are
> running. We just need to wait for all remaining data to be transferred.
>
> Signed-off-by: Jiri Denemark
> Reviewed-by: Peter Krempa
> Reviewed-by: Pavel Hrdina
On Wed, Jun 01, 2022 at 14:50:06 +0200, Jiri Denemark wrote:
> The QEMU process is already running, all we need to do is to call
> migrate-recover QMP command. Except for some checks and cookie handling,
> of course.
>
> Signed-off-by: Jiri Denemark
> Reviewed-by: Peter Krempa
> Reviewed-by: Pav
On Thu, Jun 02, 2022 at 16:50:42 +0530, Rohit Kumar wrote:
>
> On 17/05/22 8:55 pm, Peter Krempa wrote:
> > On Mon, May 16, 2022 at 16:03:21 +0530, Rohit Kumar wrote:
> > > Ping.
> > >
> > > Hi Peter,
> > > can you please take a look on this v3 patchset ?
> > Yes, don't worry and please be patien
Prepare for network backed nvram by refusing the reset of nvram on boot
and don't check whether it exists. We will not support filling it from a
template.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_firmware.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --
From: Rohit Kumar
This patch adds unit tests for remote NVRAM.
Examples:
and
and
Signed-off-by: Prerna Saxena
Signed-off-by: Florian Schmidt
Signed-off-by: Rohit Kumar
---
.../bios-nvram-file.x86_64-latest.args| 37 +++
From: Rohit Kumar
Signed-off-by: Prerna Saxena
Signed-off-by: Florian Schmidt
Signed-off-by: Rohit Kumar
Signed-off-by: Peter Krempa
---
src/qemu/qemu_validate.c | 108 ++-
1 file changed, 84 insertions(+), 24 deletions(-)
diff --git a/src/qemu/qemu_valid
Refactor the function to use modern XML formatting machinery.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index b34513f943..4110109bd8 100644
--- a/sr
Introduce virDomainLoaderDefFormatNvram and extract the code to it so
that it's self-contained in upcoming patches adding more complex logic.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/sr
Use the designated helpers for virStorageSource instead using the
file-based ones with a check.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_cgroup.c | 3 +--
src/qemu/qemu_namespace.c | 5 +++--
src/security/security_dac.c | 21 +++--
src/security/security_
From: Rohit Kumar
This patch introduces the logic to format and parse remote NVRAM.
Update NVRAM element schema, and docs for supporting network backed
NVRAM. NVRAM backed over network would give the flexibility to start
the VM on any host without having to worry about where to get the latest
nv
Setup all fields for use with -blockdev.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 11 ---
src/qemu/qemu_domain.h | 3 ++-
src/qemu/qemu_process.c | 2 +-
3 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
in
We don't really use it besides when starting up the VM so when
reconnecting this step is totally pointless.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index dab298085f..3334c7d53
Extract the internals of qemuDomainPrepareStorageSourceBlockdev into
qemuDomainPrepareStorageSourceBlockdevNodename so that we can reuse it
when instantiating the virStorageSource for pflash backing.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 31 +++
src
Since we now have a full virStorageSource for storing the nvram path we
don't need the extra dance of transfering the data into the 'pflash1'
variable which was an intermediary solution to use -blockdev.
For now we keep it functionally identical to the previous impl.
Signed-off-by: Peter Krempa
This version fixes multiple problems which I'd point out when reviewing:
- virStorageSource is properly used in all places
- logic for initializing NVRAM imgages from template is fixed to avoid
touching network backed nvrams
- documentation now states the correct version
- some cleanups
- d
From: Rohit Kumar
Currently, libvirt allows only local filepaths to specify the location
of the 'nvram' image. Changing it to virStorageSource type will allow
to support remote storage for nvram.
Signed-off-by: Prerna Saxena
Signed-off-by: Florian Schmidt
Signed-off-by: Rohit Kumar
Signed-off
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 52e4ef03cd..7dc09fc101 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -10122,8 +10122,10
On Thu, Jun 02, 2022 at 22:49:15 +, Yang, Lin A wrote:
> On 6/2/22, 11:28 AM, "Yang, Lin A" wrote:
> > On 6/1/22, 11:37 PM, "Michal Prívozník" wrote:
[...]
> > > So maybe in the end libvirt CAN know the difference without having to do
> > > any version check. We have a "dialect" of XPATH th
48 matches
Mail list logo
