Re: [libvirt PATCH v2] docs: add info about factors affecting CPU compatibility

2022-07-12 Thread Michal Prívozník
On 7/12/22 18:27, Daniel P. Berrangé wrote: > While libvirt solves most of the problem of ensuring compatibility, when > there is incompatibility it can be hard for users to track down the > cause. Everything knows to check the physical CPU model, but there are a > surprisingly large number of othe

[libvirt PATCH v2] docs: add info about factors affecting CPU compatibility

2022-07-12 Thread Daniel P . Berrangé
While libvirt solves most of the problem of ensuring compatibility, when there is incompatibility it can be hard for users to track down the cause. Everything knows to check the physical CPU model, but there are a surprisingly large number of other factors influencing compatibility. Signed-off-by:

[libvirt PATCH] docs: add info about factors affecting CPU compatibility

2022-07-12 Thread Daniel P . Berrangé
While libvirt solves most of the problem of ensuring compatibility, when there is incompatibility it can be hard for users to track down the cause. Everything knows to check the physical CPU model, but there are a surprisingly large number of other factors influencing compatibility. Signed-off-by:

[PATCH 3/4] domcaps: Introduce TPM backendVersion

2022-07-12 Thread Michal Privoznik
We accept TPM version in the domain XML. However, supported version depends on the host configuration (swtpm_setup binary) and thus it may be tricky for users (or mgmt applications) chose a version. Introduce machinery for reporting supported version in domain capabilities. Signed-off-by: Michal P

[PATCH 1/4] docs: Document TPM portion of domcaps

2022-07-12 Thread Michal Privoznik
Surprisingly, we don't document TPM part of domain capabilities. Fortunately, the information exposed is pretty much self explanatory, but we should document it regardless. Signed-off-by: Michal Privoznik --- docs/formatdomaincaps.rst | 30 ++ 1 file changed, 30 inser

[PATCH 0/4] qemu: Report supported TPM version in domcaps

2022-07-12 Thread Michal Privoznik
*** BLURB HERE *** Michal Prívozník (4): docs: Document TPM portion of domcaps virtpm: Introduce TPM-1.2 and TPM-2.0 capabilieis domcaps: Introduce TPM backendVersion qemu: Report supported TPM version in domcaps docs/formatdomaincaps.rst | 36 ++ src

[PATCH 2/4] virtpm: Introduce TPM-1.2 and TPM-2.0 capabilieis

2022-07-12 Thread Michal Privoznik
These new capabilities will be used only to track whether swtpm_setup is capable of TPM-1.2 and/or TPM-2.0. Signed-off-by: Michal Privoznik --- src/util/virtpm.c | 2 ++ src/util/virtpm.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/util/virtpm.c b/src/util/virtpm.c index b898f3a6d

[PATCH 4/4] qemu: Report supported TPM version in domcaps

2022-07-12 Thread Michal Privoznik
Now that we have everything prepared, we can start detecting supported TPM versions and setting corresponding values in backendModel struct. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/340 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2103119 Signed-off-by: Michal Privoznik ---

Re: Qemu guest-reset option on device_add

2022-07-12 Thread Michal Prívozník
On 7/6/22 17:55, Simon Fairweather wrote: > Hi Michal, If you are able to implement the feature that would be great. > > Regards > Simon. Hey, I've posted patches here: https://listman.redhat.com/archives/libvir-list/2022-July/232756.html I'm not sure whether you want to build libvirt from git

[PATCH 3/5] qemu_capabilities: Track usb-host.guest-resets-all capability

2022-07-12 Thread Michal Privoznik
We will need two attributes of usb-host device to set: guest-reset and guest-resets-all. The former was introduced in QEMU v4.0.0-rc0~56^2 and the other in v4.2.0-rc1~9^2. Hence, track the latter only as it's only starting from that commit when QEMU has both attributes. Our qemucapabilitiesdata ar

[PATCH 4/5] qemu_validate: Validate that QEMU's capable of guestReset

2022-07-12 Thread Michal Privoznik
Now that we have a capability, validate that the QEMU we are talking to has everything we need for guestReset. Signed-off-by: Michal Privoznik --- src/qemu/qemu_validate.c | 8 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 39210b

[PATCH 2/5] conf: Introduce @guestReset to hostdev's

2022-07-12 Thread Michal Privoznik
Some USB devices have a buggy firmware that either crashes on device reset, or make the device unusable in some other way. Fortunately, QEMU offers a way to skip device reset either completely, or if device is not initialized yet. Expose this ability to users under: Signed-off-by

[PATCH 1/5] tests: Update hostdev-usb-* hostdev-pci-* xml2xml and xml2argv tests

2022-07-12 Thread Michal Privoznik
Currently, we have bunch of PCI/USB tests cases for qemuxml2argvtest and qemuxml2xmltest but all of them run without any capabilities. This makes is needlessly complicated when trying to extend them. Switch to DO_TEST_CAPS_LATEST(). Signed-off-by: Michal Privoznik --- .../hostdev-pci-address-dev

[PATCH 5/5] qemu: Generate cmd line for guestReset

2022-07-12 Thread Michal Privoznik
QEMU offers two attributes for handling reset requests of an USB host device: guest-reset and guest-resets-all. When combined they act as follows: 1) guest-reset=false The guest is not allowed to reset the physical USB device. 2) guest-reset=true,guest-resets-all=false The guest is allowed

[PATCH 0/5] conf: Introduce @guestReset to hostdev's

2022-07-12 Thread Michal Privoznik
There are couple of examples where this knob would be useful: https://bugs.launchpad.net/qemu/+bug/1846451 (look for those cmd line passthrough hacks), and one pretty recent request: https://listman.redhat.com/archives/libvir-list/2022-June/232611.html The last patch uses info from Kraxel's pat

[libvirt PATCH 05/10] docs: Replace testsuites article with the new 'testing' article

2022-07-12 Thread Erik Skultety
The new article provides more in-depth information on testing options in libvirt. Signed-off-by: Erik Skultety --- docs/docs.rst | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/docs/docs.rst b/docs/docs.rst index 9fd8b7c37e..b17d73743a 100644 --- a/docs/docs.rst +++ b/d

[libvirt PATCH 07/10] docs: Change the CI headline from "CI Testing" to "CI"

2022-07-12 Thread Erik Skultety
It's not just strategy the master CI article talks (or will talk in the future) about. Signed-off-by: Erik Skultety --- docs/docs.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/docs.rst b/docs/docs.rst index b17d73743a..8ca0afdc1a 100644 --- a/docs/docs.rst +++

[libvirt PATCH 10/10] docs: ci: Add a brief section on how to run the CI workload locally

2022-07-12 Thread Erik Skultety
This is just a glue to the testing article introduced in previous commits. Signed-off-by: Erik Skultety --- docs/ci.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/ci.rst b/docs/ci.rst index ea1b839eac..515a02a6f6 100644 --- a/docs/ci.rst +++ b/docs/ci.rst @@ -97,4 +97,8 @@ Assu

[libvirt PATCH 09/10] docs: ci: Add a section on how to add a new platform to libvirt CI

2022-07-12 Thread Erik Skultety
Signed-off-by: Erik Skultety --- docs/ci.rst | 39 +++ 1 file changed, 39 insertions(+) diff --git a/docs/ci.rst b/docs/ci.rst index bef023c521..ea1b839eac 100644 --- a/docs/ci.rst +++ b/docs/ci.rst @@ -41,21 +41,60 @@ In case the integration test suite fails

[libvirt PATCH 08/10] docs: ci: Add info about the two major types of jobs our CI runs

2022-07-12 Thread Erik Skultety
Signed-off-by: Erik Skultety --- docs/ci.rst | 20 1 file changed, 20 insertions(+) diff --git a/docs/ci.rst b/docs/ci.rst index d5282c4d25..bef023c521 100644 --- a/docs/ci.rst +++ b/docs/ci.rst @@ -8,6 +8,9 @@ The libvirt project uses GitLab CI for automated testing. `Here

[libvirt PATCH 03/10] docs: Provide an article on how to add a custom runner to the project

2022-07-12 Thread Erik Skultety
Since running our functional test suite in GitLab cannot make use of the shared resources it makes sense to document the process of adding own HW to run the custom libvirt executor that powers the integration suite. This article will likely make even more sense in the future with GitLab severely cu

[libvirt PATCH 02/10] docs: Provide more information about the TCK test suite

2022-07-12 Thread Erik Skultety
Most importantly, how to get it, how install dependencies and how to run it. Signed-off-by: Erik Skultety --- docs/testtck.rst | 92 ++-- 1 file changed, 81 insertions(+), 11 deletions(-) diff --git a/docs/testtck.rst b/docs/testtck.rst index 51de0956

[libvirt PATCH 01/10] docs: Move the CI dashboard to its own RST module

2022-07-12 Thread Erik Skultety
The dashboard itself simply takes away focus from everything else that makes sense to have in the CI article, so move it to it's own article and link it from the main CI article. Signed-off-by: Erik Skultety --- docs/ci-dashboard.rst | 216 ++ docs/ci.rst

[libvirt PATCH 06/10] docs: Drop the testsuites article

2022-07-12 Thread Erik Skultety
The article was replaced with a new one in previous commit, so we don't need this one anymore. Signed-off-by: Erik Skultety --- docs/meson.build| 1 - docs/testsuites.rst | 37 - 2 files changed, 38 deletions(-) delete mode 100644 docs/testsuites.rst di

[libvirt PATCH 00/10] docs: Expand documentation on the CI/testing topic

2022-07-12 Thread Erik Skultety
This series was inspired by QEMU's documentation on CI and focuses on the following: - adds documentation on how to add a custom runner to the libvirt project or its fork, mainly in context of running functional testing - replaces the old 'testsuites' article with a more detailed landing page des

[libvirt PATCH 04/10] docs: Provide an article on testing

2022-07-12 Thread Erik Skultety
Currently we don't have much information on how testing is done in libvirt and the little we have is scattered among multiple files. This patch creates a common landing page containing all important bits about testing in libvirt, providing links to respective sections which deserve their own articl

Re: [PATCH] remote: conf: Mention that 'virtproxyd' doesn't require the '--listen' flag

2022-07-12 Thread Pavel Hrdina
On Tue, Jul 12, 2022 at 12:48:30PM +0200, Peter Krempa wrote: > 'virtproxyd' doesn't have the '--listen' parameter and it's enough just > to enable the corresponding option in the config. > > The config file is generic for all the daemons and we just omit/adjust > some sections. Adding a separate

[PATCH] remote: conf: Mention that 'virtproxyd' doesn't require the '--listen' flag

2022-07-12 Thread Peter Krempa
'virtproxyd' doesn't have the '--listen' parameter and it's enough just to enable the corresponding option in the config. The config file is generic for all the daemons and we just omit/adjust some sections. Adding a separate mechanism to omit the note about the '--listen' parameter would be overk

[(pushed) PATCH] docs: formatstorage: Format XML namespace definition as code block

2022-07-12 Thread Peter Krempa
Signed-off-by: Peter Krempa --- Trivial. docs/formatstorage.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatstorage.rst b/docs/formatstorage.rst index 83d7d141ac..a8149e450c 100644 --- a/docs/formatstorage.rst +++ b/docs/formatstorage.rst @@ -470,9 +470,9 @