[libvirt PATCH v4 5/6] qemu: Add capability for virtio-gpu.blob

2022-08-18 Thread Jonathon Jongsma
Capability to determine whether this qemu supports the 'blob' option for virtio-gpu. Signed-off-by: Jonathon Jongsma --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 + tes

[libvirt PATCH v4 6/6] qemu: Implement 'blob' support for virtio gpu

2022-08-18 Thread Jonathon Jongsma
This can improve performance for some guests since it reduces copying of display data between host and guest. Requires udmabuf on the host. Signed-off-by: Jonathon Jongsma --- src/qemu/qemu_cgroup.c| 22 ++--- src/qemu/qemu_command.c | 3 ++ src

[libvirt PATCH v4 1/6] conf: Refactor video model parsing

2022-08-18 Thread Jonathon Jongsma
Factor out a separate function to parse out the element for video devices. Signed-off-by: Jonathon Jongsma --- src/conf/domain_conf.c | 95 ++ 1 file changed, 59 insertions(+), 36 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c

[libvirt PATCH v4 4/6] conf: add support for 'blob' in virtio video device

2022-08-18 Thread Jonathon Jongsma
Add the ability to enable blob resources for the virtio video device. This will accelerate the display path due to less or no copying of pixel data. Blob resource support can be enabled with e.g.: Some additional background information about blob resources: https://lists.freedes

[libvirt PATCH v4 2/6] conf: switch to virXMLProp* functions

2022-08-18 Thread Jonathon Jongsma
In virDomainVideoModelDefParseXML(), use the virXMLProp* functions rather than reimplementing them with virXPath* functions. Signed-off-by: Jonathon Jongsma --- src/conf/domain_conf.c | 78 +- 1 file changed, 23 insertions(+), 55 deletions(-) diff --git a

[libvirt PATCH v4 0/6] Add support for 'blob' to virtio video device

2022-08-18 Thread Jonathon Jongsma
Add support to libvirt for the 'blob' option for virtio video devices in qemu. Also do a little preparatory refactoring of the video device xml parsing code. I sent this series out a couple times but didn't get much review. Sending out again after fixing a few minor test- and doc-related things di

[libvirt PATCH v4 3/6] conf: use enum variable for video type

2022-08-18 Thread Jonathon Jongsma
Rather than storing the video type as an integer, use the proper enum type within the struct. Signed-off-by: Jonathon Jongsma --- src/conf/domain_conf.c | 4 +--- src/conf/domain_conf.h | 2 +- src/libxl/libxl_conf.c | 10 ++ src/libxl/libxl_domain.c | 11

Re: [libvirt PATCH] tests: Drop irrelevant CPU config from graphics-spice-timeout

2022-08-18 Thread Martin Kletzander
On Thu, Aug 18, 2022 at 04:24:30PM +0200, Jiri Denemark wrote: Resolves: https://gitlab.com/libvirt/libvirt/-/issues/243 This should not depend on the host, the issue is elsewhere, but at least for the time being ... Signed-off-by: Jiri Denemark ... it does not hurt: Reviewed-by: Martin

Re: [PATCH] qemu: Do not keep swtmp pidfile around after stopping

2022-08-18 Thread Martin Kletzander
On Thu, Aug 18, 2022 at 04:20:56PM +0200, Martin Kletzander wrote: Just like the socket, remove the pidfile when TPM emulator is being stopped. In order to make this a bit cleaner, try to remove it even if swtpm_ioctl does not exist. Forgot to mention the BZ: https://bugzilla.redhat.com/show

[libvirt PATCH] tests: Drop irrelevant CPU config from graphics-spice-timeout

2022-08-18 Thread Jiri Denemark
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/243 Signed-off-by: Jiri Denemark --- .../graphics-spice-timeout.x86_64-latest.args | 4 ++-- .../graphics-spice-timeout.xml | 18 -- .../graphics-spice-timeout.x86_64-latest.xml | 17 + 3 fi

[PATCH] qemu: Do not keep swtmp pidfile around after stopping

2022-08-18 Thread Martin Kletzander
Just like the socket, remove the pidfile when TPM emulator is being stopped. In order to make this a bit cleaner, try to remove it even if swtpm_ioctl does not exist. Signed-off-by: Martin Kletzander --- src/qemu/qemu_tpm.c | 31 ++- 1 file changed, 14 insertions(+),

Re: [PATCH] vmx: Fix leak in virVMXParseEthernet

2022-08-18 Thread Ján Tomko
On a Thursday in 2022, Martin Kletzander wrote: Commit 580538c5dd7f forgot to free switchId. Signed-off-by: Martin Kletzander --- src/vmx/vmx.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

[PATCH] vmx: Fix leak in virVMXParseEthernet

2022-08-18 Thread Martin Kletzander
Commit 580538c5dd7f forgot to free switchId. Signed-off-by: Martin Kletzander --- src/vmx/vmx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 9ad463658aa8..191f0b5e83ff 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -2920,6 +2920,7 @@ virVMXParseEther

Re: [PATCH] news: Mention esx support for new interface types

2022-08-18 Thread Erik Skultety
On Thu, Aug 18, 2022 at 12:44:41PM +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- Reviewed-by: Erik Skultety

slow live migration ram

2022-08-18 Thread Ignazio Cassano
Hello, I am using openstack rdo with kvm libvirt. Live migration is very slow when the vm is using ram intensively. If I migrate a vm that has been running on a host for a few days, it takes several minutes to migrate the memory. After the first migration, I immediately try another one on the same

[PATCH] news: Mention esx support for new interface types

2022-08-18 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 548828c60d72..468b41c1fd9a 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -24,6 +24,11 @@ v8.7.0 (unreleased) * **Improvements** + * esx: Domain XMLs can now be dumped f

Re: [PATCH v4 2/3] qemu_capabilities: add "query-stats" QMP command to the QEMU capabilities

2022-08-18 Thread Martin Kletzander
On Thu, Aug 18, 2022 at 08:47:19AM +0530, Amneesh Singh wrote: Related: https://gitlab.com/libvirt/libvirt/-/issues/276 Signed-off-by: Amneesh Singh Reviewed-by: Martin Kletzander signature.asc Description: PGP signature

Re: [PATCH v4 1/3] qemu_monitor: add qemuMonitorQueryStats

2022-08-18 Thread Martin Kletzander
On Thu, Aug 18, 2022 at 08:47:18AM +0530, Amneesh Singh wrote: Related: https://gitlab.com/libvirt/libvirt/-/issues/276 This patch adds an API for the "query-stats" QMP command. The query returns a JSON containing the statistics based on the target, which can either be vCPU or VM, and the provi

Re: [PATCH v4 3/3] qemu_driver: use qemuMonitorQueryStats to extract halt poll time

2022-08-18 Thread Martin Kletzander
On Thu, Aug 18, 2022 at 08:47:20AM +0530, Amneesh Singh wrote: This patch uses qemuMonitorQueryStats to query "halt_poll_success_ns" and "halt_poll_fail_ns" for every vCPU. The respective values for each vCPU are then added together. Signed-off-by: Amneesh Singh --- src/qemu/qemu_driver.c | 81

Re: [libvirt PATCH 0/2] tests: Fix qemuxml2argvtest failure on macOS 12

2022-08-18 Thread Ján Tomko
On a Wednesday in 2022, Andrea Bolognani wrote: As reported in https://listman.redhat.com/archives/libvir-list/2022-May/230762.html I'm still unclear on why this worked with all versions of macOS until 12, but the fix feels reasonable enough and I can't really justify digging much further. Te