Re: [PATCH v2] cpu_map: Introduce Fujitsu a64fx

2022-09-06 Thread Jiri Denemark
On Fri, Sep 02, 2022 at 03:02:37 +, Liu Yiding wrote: > Add Fujitsu a64fx as a supported cpu model. > > Signed-off-by: Liu Yiding > > --- > v2 of: > https://listman.redhat.com/archives/libvir-list/2022-August/234040.html > > diff to v1: > - Change title. > - Unify model and vendor spelling.

Re: [PATCH 0/3] Fix some coding issues

2022-09-06 Thread Kristina Hanicova
On Tue, Sep 6, 2022 at 4:14 PM Jiacheng Jiang wrote: > From: jiangjiacheng > > *** BLURB HERE *** > > jiangjiacheng (3): > conf: clean up memory containing secrets before freeing > remote: remove unnecessary return value and if branch > Fix some coding style issues > > src/conf/domain_con

[PATCH] qemu_driver: Fix order of arguments in qemuDomainGetStatsCpuProc()

2022-09-06 Thread Michal Privoznik
Just before pushing my earlier commit I've switch order of two arguments of virProcessGetStatInfo() (as suggested in review). However, I forgot to swap the arguments in qemuDomainGetStatsCpuProc() which leads to userTime and sysTime being swapped. Fixes: 044b8744d65f8571038f85685b3c4b241162977b Re

Re: [libvirt RFC 20/24] qemu_snapshot: prepare data for external snapshot deletion

2022-09-06 Thread Peter Krempa
On Tue, Aug 23, 2022 at 18:32:23 +0200, Pavel Hrdina wrote: > In order to save some CPU cycles we will collect all the necessary data > to delete external snapshot before we even start. They will be later > used by code that deletes the snapshots and updates metadata when > needed. > > With extern

Re: [PATCH] qemu: Don't report error from domblkinfo if vm is inactive

2022-09-06 Thread Hyman
在 2022/9/6 15:47, Peter Krempa 写道: On Tue, Sep 06, 2022 at 10:29:01 +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Libvirt logs and reports error when executing domblkinfo if vm configured rbd storage and in inactive state. The steps to reproduce the problem: 1. define and st

Re: [PATCH 2/2] qemu: Implement qemuDomainGetStatsCpu fallback for qemu:///session

2022-09-06 Thread Daniel P . Berrangé
On Mon, Sep 05, 2022 at 09:40:57AM +0200, Michal Privoznik wrote: > For domains started under session URI, we don't set up CGroups > (well, how could we since we're not running as root anyways). > Nevertheless, fetching CPU statistics exits early because of > lacking cpuacct controller. But with re

Re: [PATCH] qemu: Don't report error from domblkinfo if vm is inactive

2022-09-06 Thread Peter Krempa
On Tue, Sep 06, 2022 at 10:29:01 +0800, huang...@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > Libvirt logs and reports error when executing domblkinfo if vm > configured rbd storage and in inactive state. > > The steps to reproduce the problem: > 1. define and start domain with its storage