Re: [libvirt PATCH] qemu: fix memlock without vIOMMU

2022-11-18 Thread Laine Stump
On 11/17/22 3:13 PM, Jonathon Jongsma wrote: When there is no vIOMMU, vfio devices don't need to lock the entire guest memory per-device, but they still need to lock the entire guest memory to share between all vfio devices. This memory accounting is not shared with vDPA devices, so it should be

[libvirt PATCH 0/2] A few post-copy related fixes

2022-11-18 Thread Jiri Denemark
*** BLURB EVERYWHERE *** Jiri Denemark (2): qemu: Always restore post-copy migration job on reconnect qemu: Ignore failure in post-copy migration when QEMU says completed src/qemu/qemu_migration.c | 8 src/qemu/qemu_process.c | 15 ++- 2 files changed, 18 insertions(+

[libvirt PATCH 1/2] qemu: Always restore post-copy migration job on reconnect

2022-11-18 Thread Jiri Denemark
We need the restored job even in case the migration already finished even though we will stop it just a few lines below as the functions we call in between require an existing migration job. This fixes a crash on reconnect when post-copy migration finished while the daemon was not running. Signed

[libvirt PATCH 2/2] qemu: Ignore failure in post-copy migration when QEMU says completed

2022-11-18 Thread Jiri Denemark
When post-copy migration is running in Finish phase we already did everything needed and we're just waiting for all the memory to transfer to the destination. The domain is already running on there at this point. Once all data is transferred (QEMU sends a MIGRATION completed event) we're done. So i

Re: Add option to skip cpu feature and model verification in libvirt and rely on qemu 'enforce' option

2022-11-18 Thread Jiri Denemark
On Fri, Nov 18, 2022 at 10:18:59 +, John Levon wrote: > On Fri, Nov 18, 2022 at 10:52:32AM +0100, Jiri Denemark wrote: > > > > * Qemu already provide an option 'enforce' to validate if features > > > with which vm is started is exactly same as one provided and nothing > > > is silently d

Re: Add option to skip cpu feature and model verification in libvirt and rely on qemu 'enforce' option

2022-11-18 Thread manish.mishra
Hi Jiri, Thank you so much for response. On 18/11/22 3:22 pm, Jiri Denemark wrote: Hi. On Wed, Nov 16, 2022 at 22:53:18 +0530, manish.mishra wrote: We had a requirement to skip all CPU feature validations from libvirt and totally rely on Qemu for following reasons. You are mixing two differen

Re: [PATCH] cpu_arm: fix the compile warning of unexpected format

2022-11-18 Thread Ján Tomko
On a Thursday in 2022, Jiang Jiacheng wrote: These format are left unchanged when convert 'unsigned long' to 'unsigned long long', which caused compile warning. Signed-off-by: Jiang Jiacheng --- src/cpu/cpu_arm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko

Re: Add option to skip cpu feature and model verification in libvirt and rely on qemu 'enforce' option

2022-11-18 Thread John Levon
On Fri, Nov 18, 2022 at 10:52:32AM +0100, Jiri Denemark wrote: > > * Qemu already provide an option 'enforce' to validate if features > > with which vm is started is exactly same as one provided and nothing > > is silently dropped. > > Right, but it's not enough. In addition to removed feat

Re: Add option to skip cpu feature and model verification in libvirt and rely on qemu 'enforce' option

2022-11-18 Thread Jiri Denemark
Hi. On Wed, Nov 16, 2022 at 22:53:18 +0530, manish.mishra wrote: > We had a requirement to skip all CPU feature validations from libvirt > and totally rely on Qemu for following reasons. You are mixing two different things here. The "enforce" CPU checking for making sure a guest gets exactly what