Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Philippe Mathieu-Daudé
On 31/1/23 00:33, Richard Henderson wrote: On 1/30/23 13:14, Philippe Mathieu-Daudé wrote: On 30/1/23 20:19, Richard Henderson wrote: But I do question whether we need to support 64-bit guests on 32-bit hosts at all. Retaining 32-bit on 32-bit allows arm32 to emulate i686, which I suspect, bu

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Richard Henderson
On 1/30/23 13:14, Philippe Mathieu-Daudé wrote: On 30/1/23 20:19, Richard Henderson wrote: But I do question whether we need to support 64-bit guests on 32-bit hosts at all. Retaining 32-bit on 32-bit allows arm32 to emulate i686, which I suspect, but have no proof, is the limit of what users

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Philippe Mathieu-Daudé
On 30/1/23 20:19, Richard Henderson wrote: But I do question whether we need to support 64-bit guests on 32-bit hosts at all. Retaining 32-bit on 32-bit allows arm32 to emulate i686, which I suspect, but have no proof, is the limit of what users actually want. I presume you implicitly restric

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Alex Bennée
Daniel P. Berrangé writes: > On Mon, Jan 30, 2023 at 11:47:02AM +, Peter Maydell wrote: >> On Mon, 30 Jan 2023 at 11:44, Thomas Huth wrote: >> > >> > Testing 32-bit host OS support takes a lot of precious time during the QEMU >> > contiguous integration tests, and considering that many OS

Re: Zoned storage support in libvirt

2023-01-30 Thread Stefan Hajnoczi
On Mon, Jan 30, 2023 at 12:53:22PM +, Daniel P. Berrangé wrote: > On Mon, Jan 30, 2023 at 09:30:40PM +0900, Damien Le Moal wrote: > > On 1/30/23 21:21, Daniel P. Berrangé wrote: > > > On Wed, Jan 11, 2023 at 10:24:30AM -0500, Stefan Hajnoczi wrote: > > >> On Tue, Jan 10, 2023 at 03:29:47PM +000

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Richard Henderson
On 1/30/23 02:01, Daniel P. Berrangé wrote: I vaguely recall someone mentioned problems with atomic ops in the past, or was it 128-bit ints, caused implications for the codebase ? TCG_OVERSIZED_GUEST, where 32-bit host running 64-bit guest cannot run the guest except in round-robin mode. It's

Re: [PATCH v2 4/5] logging: add log cleanup for obsolete domains

2023-01-30 Thread Martin Kletzander
On Mon, Jan 30, 2023 at 09:01:17PM +0600, Oleg Vasilev wrote: On 25.01.2023 19:49, Martin Kletzander wrote: On Fri, Jan 20, 2023 at 04:50:51PM +0600, Oleg Vasilev wrote: On 09.01.2023 18:31, Martin Kletzander wrote: On Thu, Dec 15, 2022 at 01:25:49AM +0600, Oleg Vasilev wrote: Before, log

Re: [PATCH v2 4/5] logging: add log cleanup for obsolete domains

2023-01-30 Thread Oleg Vasilev
On 25.01.2023 19:49, Martin Kletzander wrote: On Fri, Jan 20, 2023 at 04:50:51PM +0600, Oleg Vasilev wrote: On 09.01.2023 18:31, Martin Kletzander wrote: On Thu, Dec 15, 2022 at 01:25:49AM +0600, Oleg Vasilev wrote: Before, logs from deleted machines have been piling up, since there were

[PATCH v3 2/5] logging: move virLogHandler to header

2023-01-30 Thread Oleg Vasilev
Signed-off-by: Oleg Vasilev --- src/logging/log_handler.c | 26 -- src/logging/log_handler.h | 31 --- 2 files changed, 28 insertions(+), 29 deletions(-) diff --git a/src/logging/log_handler.c b/src/logging/log_handler.c index 7342404b00..8fc7e

[PATCH v3 4/5] logging: add log cleanup for obsolete domains

2023-01-30 Thread Oleg Vasilev
Before, logs from deleted machines have been piling up, since there were no garbage collection mechanism. Now, virtlogd can be configured to periodically scan the log folder for orphan logs with no recent modifications and delete it. A single chain of recent and rotated logs is deleted in a single

[PATCH v3 3/5] logging: add configuration for future log cleaner

2023-01-30 Thread Oleg Vasilev
We want to specify the folder to clean and how much time can a log chain live. Signed-off-by: Oleg Vasilev --- src/logging/log_daemon_config.c | 9 + src/logging/log_daemon_config.h | 3 +++ src/logging/test_virtlogd.aug.in | 2 ++ src/logging/virtlogd.aug | 2 ++ src/loggi

[PATCH v3 5/5] logging: use the log cleaner

2023-01-30 Thread Oleg Vasilev
Actually use the log cleaner introduced by previous commit. Signed-off-by: Oleg Vasilev --- src/logging/log_handler.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/logging/log_handler.c b/src/logging/log_handler.c index 8fc7e9b2a8..a739211c7c 100644 --- a/src/logging/log_h

[PATCH v3 0/5] logging: add log cleanup for obsolete domains

2023-01-30 Thread Oleg Vasilev
Presently, logs from deleted domains remain forever. Particular motivation comes from the case when libguestfs has repeatedly created transient VMs, which in turn created plenty of logs. This takes up space and lots of files troubles filesystem navigation. More motivation in [1]. Patch solving sam

[PATCH v3 1/5] logging: refactor to store config inside log handler

2023-01-30 Thread Oleg Vasilev
Signed-off-by: Oleg Vasilev --- src/logging/log_daemon.c | 6 ++ src/logging/log_handler.c | 29 - src/logging/log_handler.h | 17 - 3 files changed, 22 insertions(+), 30 deletions(-) diff --git a/src/logging/log_daemon.c b/src/logging/log_daemon

Re: [PATCH] qemu: implement QEMU NBD source reconnect delay attribute

2023-01-30 Thread Christian Nautze
Thank you, I see your point. We could just ignore the 'enabled' attribute from the reconnect element when it's used in the NBD source context: Another solution would be do add a totally new XML element. What would be your preferred solution? Thanks again Christian On Fri, 27 Jan 2023

Re: [RFC PATCH 14/19] mm: Introduce a cgroup for pinned memory

2023-01-30 Thread Jason Gunthorpe
On Fri, Jan 27, 2023 at 11:44:19AM -1000, Tejun Heo wrote: > On Tue, Jan 24, 2023 at 04:42:43PM +1100, Alistair Popple wrote: > > If too much memory in a system is pinned or locked it can lead to > > problems such as performance degredation or in the worst case > > out-of-memory errors as such memo

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Thomas Huth
On 30/01/2023 13.43, Daniel P. Berrangé wrote: On Mon, Jan 30, 2023 at 01:22:22PM +0100, Thomas Huth wrote: On 30/01/2023 13.01, Daniel P. Berrangé wrote: On Mon, Jan 30, 2023 at 11:47:02AM +, Peter Maydell wrote: On Mon, 30 Jan 2023 at 11:44, Thomas Huth wrote: Testing 32-bit host OS s

Re: Zoned storage support in libvirt

2023-01-30 Thread Daniel P . Berrangé
On Mon, Jan 30, 2023 at 09:30:40PM +0900, Damien Le Moal wrote: > On 1/30/23 21:21, Daniel P. Berrangé wrote: > > On Wed, Jan 11, 2023 at 10:24:30AM -0500, Stefan Hajnoczi wrote: > >> On Tue, Jan 10, 2023 at 03:29:47PM +, Daniel P. Berrangé wrote: > >>> On Tue, Jan 10, 2023 at 10:19:51AM -0500,

Re: Zoned storage support in libvirt

2023-01-30 Thread Damien Le Moal
On 1/30/23 21:21, Daniel P. Berrangé wrote: > On Wed, Jan 11, 2023 at 10:24:30AM -0500, Stefan Hajnoczi wrote: >> On Tue, Jan 10, 2023 at 03:29:47PM +, Daniel P. Berrangé wrote: >>> On Tue, Jan 10, 2023 at 10:19:51AM -0500, Stefan Hajnoczi wrote: Hi Peter, Zoned storage support (

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Daniel P . Berrangé
On Mon, Jan 30, 2023 at 01:22:22PM +0100, Thomas Huth wrote: > On 30/01/2023 13.01, Daniel P. Berrangé wrote: > > On Mon, Jan 30, 2023 at 11:47:02AM +, Peter Maydell wrote: > > > On Mon, 30 Jan 2023 at 11:44, Thomas Huth wrote: > > > > > > > > Testing 32-bit host OS support takes a lot of pre

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Thomas Huth
On 30/01/2023 13.01, Daniel P. Berrangé wrote: On Mon, Jan 30, 2023 at 11:47:02AM +, Peter Maydell wrote: On Mon, 30 Jan 2023 at 11:44, Thomas Huth wrote: Testing 32-bit host OS support takes a lot of precious time during the QEMU contiguous integration tests, and considering that many OS

Re: Zoned storage support in libvirt

2023-01-30 Thread Daniel P . Berrangé
On Wed, Jan 11, 2023 at 10:24:30AM -0500, Stefan Hajnoczi wrote: > On Tue, Jan 10, 2023 at 03:29:47PM +, Daniel P. Berrangé wrote: > > On Tue, Jan 10, 2023 at 10:19:51AM -0500, Stefan Hajnoczi wrote: > > > Hi Peter, > > > Zoned storage support > > > (https://zonedstorage.io/docs/introduction/zo

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Daniel P . Berrangé
On Mon, Jan 30, 2023 at 11:47:02AM +, Peter Maydell wrote: > On Mon, 30 Jan 2023 at 11:44, Thomas Huth wrote: > > > > Testing 32-bit host OS support takes a lot of precious time during the QEMU > > contiguous integration tests, and considering that many OS vendors stopped > > shipping 32-bit v

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Peter Maydell
On Mon, 30 Jan 2023 at 11:44, Thomas Huth wrote: > > Testing 32-bit host OS support takes a lot of precious time during the QEMU > contiguous integration tests, and considering that many OS vendors stopped > shipping 32-bit variants of their OS distributions and most hardware from > the past >10 y

[RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Thomas Huth
Testing 32-bit host OS support takes a lot of precious time during the QEMU contiguous integration tests, and considering that many OS vendors stopped shipping 32-bit variants of their OS distributions and most hardware from the past >10 years is capable of 64-bit, keeping the 32-bit support alive

Re: [PATCH] virsh: Make domif-setlink work more than once

2023-01-30 Thread Ján Tomko
On a Monday in 2023, Michal Privoznik wrote: In virsh, we have this convenient domif-setlink command, which is just a wrapper over virDomainUpdateDeviceFlags() and which allows setting link state of given guest NIC. It does so by fetching corresponding XML snippet and either putting into it, OR

[PATCH] virsh: Make domif-setlink work more than once

2023-01-30 Thread Michal Privoznik
In virsh, we have this convenient domif-setlink command, which is just a wrapper over virDomainUpdateDeviceFlags() and which allows setting link state of given guest NIC. It does so by fetching corresponding XML snippet and either putting into it, OR if the element already exists setting the attr

[PATCH v2 4/6] qemu: Allow active disk snapshots for RBD disks

2023-01-30 Thread o...@il.ibm.com
From: Or Ozeri This commit removes the check disallowing users to take active disk-only snapshots of RBD disks. The actual support for this functionality was added in a previous commit. Signed-off-by: Or Ozeri --- src/qemu/qemu_snapshot.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletio

[PATCH v2 6/6] qemu: Allow mixing active internal and external active disk snapshots

2023-01-30 Thread o...@il.ibm.com
From: Or Ozeri Previous commit added support for active RBD disk snapshots, using the same qmp_transaction used also for external snapshots. The same transaction can be used to mix internal and external snapshots. To allow this, this commit simply removes the check that disallows mixing for activ

[PATCH v2 3/6] qemu: Add internal support for active disk internal snapshots

2023-01-30 Thread o...@il.ibm.com
From: Or Ozeri libvirt supports taking external disk snapshots on a running VM, using qemu's "blockdev-snapshot" command. qemu also supports "blockdev-snapshot-internal-sync" to do the same for internal snapshots. This commit wraps this (old) qemu capability to allow future libvirt users to take

[PATCH v2 5/6] qemu: Allow setting per-disk snapshot name for RBD disks

2023-01-30 Thread o...@il.ibm.com
From: Or Ozeri This commit adds the option for setting per-disk snapshot name for RBD disks. All other disk types are still disallowed to use the snapshotName attribute. Signed-off-by: Or Ozeri --- src/qemu/qemu_snapshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

Re: [libvirt PATCH] remote: Fix memory leak in remoteDomainMigrateFinish3*

2023-01-30 Thread Erik Skultety
On Fri, Jan 27, 2023 at 02:37:29PM +0100, Jiri Denemark wrote: > Theoretically, when remoteDomainMigrateFinish3* is called without a > pointer for storing migration cookie and its length (i.e., either > cookieout == NULL or cookieoutlen == NULL), we would leak the freshly > created virDomain object

Re: [PATCH 4/4] virsh: Add migrate options to set parallel compress level

2023-01-30 Thread Claudio Fontana
On 1/30/23 02:59, Jiang Jiacheng wrote: > > > On 2023/1/20 17:41, Claudio Fontana wrote: >> On 1/20/23 09:47, Jiang Jiacheng wrote: >>> Add migrate options: --compression-zlib-level >>> --compression-zstd-level >>> These options are used to set compress level for "zlib" >>> o