Re: [PATCH] virnetsshsession: Adapt to changed libssh2 API

2023-06-05 Thread Peter Krempa
On Mon, Jun 05, 2023 at 14:43:31 +0200, Michal Privoznik wrote: > In one of its commits [1] libssh2 changed the 'text' member of > LIBSSH2_USERAUTH_KBDINT_PROMPT struct from 'char' to 'unsigned > char'. But we g_strdup() the member in order to fill 'prompt' > member of virConnectCredential struct.

[PATCH] virnetsshsession: Adapt to changed libssh2 API

2023-06-05 Thread Michal Privoznik
In one of its commits [1] libssh2 changed the 'text' member of LIBSSH2_USERAUTH_KBDINT_PROMPT struct from 'char' to 'unsigned char'. But we g_strdup() the member in order to fill 'prompt' member of virConnectCredential struct. Typecast the value to avoid warnings. Also, drop @prompt variable, as it

Re: [libvirt PATCH] ci: fix Cirrus CI jobs run from merge requests

2023-06-05 Thread Michal Prívozník
On 6/5/23 12:25, Daniel P. Berrangé wrote: > Preferentially fetch from $CI_MERGE_REQUEST_REF_PATH if it is > defined, otherwise use $CI_COMMIT_REF_NAME > > Signed-off-by: Daniel P. Berrangé > --- > ci/cirrus/build.yml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Mic

[libvirt PATCH] ci: fix Cirrus CI jobs run from merge requests

2023-06-05 Thread Daniel P . Berrangé
Preferentially fetch from $CI_MERGE_REQUEST_REF_PATH if it is defined, otherwise use $CI_COMMIT_REF_NAME Signed-off-by: Daniel P. Berrangé --- ci/cirrus/build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml index 9332e968bd..519

Re: [PATCH] spec: Drop numad usage on fedora 39+

2023-06-05 Thread Michal Prívozník
On 5/23/23 19:31, Cole Robinson wrote: > numad is removed from Fedora 39. Upstream is dead > > https://src.fedoraproject.org/rpms/numad/c/a6bb891e8447e3b2a4c63774da94ad0d9b4ee50a?branch=rawhide > https://pagure.io/releng/failed-composes/issue/4990#comment-857670 > > Signed-off-by: Cole Robinson

Re: [PATCH] qemu: Set proper PCI backend for -s that are actually hostdevs

2023-06-05 Thread Martin Kletzander
On Thu, Jun 01, 2023 at 05:25:14PM +0200, Michal Prívozník wrote: On 6/1/23 15:26, Michal Privoznik wrote: When starting a domain, it's done so in two steps (actually more, but lets focus on just the following two): 1) qemuProcessPrepareDomain(), followed by 2) qemuProcessPrepareHost(). N

[PATCH] scripts: Fix the flake8 syntax-check failures

2023-06-05 Thread Han Han
Fix the syntax-check failures with the help of isort[1]: 289/316 libvirt:syntax-check / flake8 FAIL 5.24s exit status 2 [1]: https://pycqa.github.io/isort/ Signed-off-by: Han Han --- ci/util.py | 3 +-- run.in | 2 +- scripts/apibuil