Re: [PATCH] spec: Do not disable some systemd units of newly split package

2023-06-08 Thread Jim Fehlig
On 6/8/23 08:52, Andrea Bolognani wrote: On Wed, Jun 07, 2023 at 04:31:36PM +0200, Martin Kletzander wrote: Since virtproxyd was split into libvirt-daemon-proxy package it can happen that, in case a distribution has such systemd preset, when installing this package, already pre-enabled and confi

Re: [PATCH] apparmor: Add support for local profile customizations

2023-06-08 Thread Jim Fehlig
On 6/8/23 08:11, Andrea Bolognani wrote: On Tue, Jun 06, 2023 at 04:06:12PM -0600, Jim Fehlig wrote: Apparmor profiles in /etc/apparmor.d/ are config files that can and should be replaced on package upgrade, which introduces the potential to overwrite any local changes. Apparmor supports local p

Re: [PATCH] spec: Do not disable some systemd units of newly split package

2023-06-08 Thread Andrea Bolognani
On Wed, Jun 07, 2023 at 04:31:36PM +0200, Martin Kletzander wrote: > Since virtproxyd was split into libvirt-daemon-proxy package it can > happen that, in case a distribution has such systemd preset, when > installing this package, already pre-enabled and configured units like > -tls.socket and -tc

Re: [PATCH 1/2] Add discard_no_unref option for qcow2 images

2023-06-08 Thread Peter Krempa
On Tue, Jun 06, 2023 at 11:54:40 +0200, Jean-Louis Dupond wrote: > Qemu 8.1.0 will add discard_no_unref option for qcow2 images. > When this option is enabled (default=false), then it will no longer > unreference clusters when guest does a discard, but it will just free > the blocks (useful for inc

Re: [libvirt PATCH 1/5] conf: add ability to configure a vdpa block disk device

2023-06-08 Thread Jonathon Jongsma
On 6/8/23 8:44 AM, Peter Krempa wrote: On Tue, Jun 06, 2023 at 16:11:00 -0500, Jonathon Jongsma wrote: vDPA block devices can be configured as follows: Signed-off-by: Jonathon Jongsma --- docs/formatdomain.rst | 19 +-- src/ch/ch_monitor.c

Re: [PATCH] apparmor: Add support for local profile customizations

2023-06-08 Thread Andrea Bolognani
On Tue, Jun 06, 2023 at 04:06:12PM -0600, Jim Fehlig wrote: > Apparmor profiles in /etc/apparmor.d/ are config files that can and should > be replaced on package upgrade, which introduces the potential to overwrite > any local changes. Apparmor supports local profile customizations via > /etc/appar

Re: [libvirt PATCH 1/5] conf: add ability to configure a vdpa block disk device

2023-06-08 Thread Peter Krempa
On Tue, Jun 06, 2023 at 16:11:00 -0500, Jonathon Jongsma wrote: > vDPA block devices can be configured as follows: > > > > > > Signed-off-by: Jonathon Jongsma > --- > docs/formatdomain.rst | 19 +-- > src/ch/ch_monitor.c | 1 + > src/c

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-06-08 Thread Peter Krempa
On Tue, Jun 06, 2023 at 16:15:30 -0500, Jonathon Jongsma wrote: > Requires recent qemu with support for the virtio-blk-vhost-vdpa device > and the ability to pass a /dev/fdset/N path for the vdpa path (8.1.0) > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1900770 > --- > src/qemu/qemu_blo

[PATCH 4/4] meson: Use dependency().found() instead of conf.has()

2023-06-08 Thread Michal Privoznik
So far this change alone doesn't make much sense, but prepares code for upcoming change. Unfortunately, some conf.has() statements have to stay, because there's no corresponding dependency(). But that's okay. Signed-off-by: Michal Privoznik --- meson.build | 6 -- 1 file changed, 4 insertion

[PATCH 1/4] meson: acl_dep switch to dependency()

2023-06-08 Thread Michal Privoznik
The pkg-config file to libacl was introduced in 2.2.53 release. Now that every supported distro ships at least this version, we can switch meson detection to dependency(). Signed-off-by: Michal Privoznik --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.

[PATCH 3/4] meson: numactl_dep switch to dependency()

2023-06-08 Thread Michal Privoznik
The pkg-config file to libnuma was introduced in 2.0.12 release (though the comment mistakenly claims 2.0.14 version). Every supported distro ships at least this version, and thus we can switch meson detection to dependency(). Signed-off-by: Michal Privoznik --- meson.build | 3 +-- 1 file chang

[PATCH 0/4] meson: Prepare for newer meson

2023-06-08 Thread Michal Privoznik
When we switch to meson-0.57.0 or newer (which we can't do currently because of Debian 11 and Ubuntu 20.04), we can start using: libs_summary = { 'acl': acl_dep, ... } which not only reports 'YES'/'NO', but also library version: acl: YES 2.3.1 But in order to do th

[PATCH 2/4] meson: attr_dep switch to dependency()

2023-06-08 Thread Michal Privoznik
The pkg-config file to libattr was introduced in 2.4.48 release. Now that every supported distro ships at least this version, we can switch meson detection to dependency(). Signed-off-by: Michal Privoznik --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson

Re: [libvirt PATCH 4/5] qemu: consider vdpa block devices for memlock limits

2023-06-08 Thread Peter Krempa
On Tue, Jun 06, 2023 at 16:11:03 -0500, Jonathon Jongsma wrote: > vDPA block devices will also need the same consideration for memlock > limits as other vdpa devices, so consider these devices when calculating > memlock limits. > > Signed-off-by: Jonathon Jongsma > --- > src/qemu/qemu_domain.c |

Re: [libvirt PATCH 3/5] qemu: make vdpa connect function more generic

2023-06-08 Thread Peter Krempa
On Tue, Jun 06, 2023 at 16:11:02 -0500, Jonathon Jongsma wrote: > qemuInterfaceVDPAConnect() was a helper function for connecting to the > vdpa device file. But in order to support other vdpa devices besides > network interfaces (e.g. vdpa block devices) make this function a bit > more generic. >

Re: [libvirt PATCH 2/5] qemu: add virtio-blk-vhost-vdpa capability

2023-06-08 Thread Peter Krempa
On Thu, Jun 08, 2023 at 11:00:03 +0200, Peter Krempa wrote: > On Tue, Jun 06, 2023 at 16:11:01 -0500, Jonathon Jongsma wrote: > > Check whether the qemu binary supports the vdpa block driver. We can't > > rely simply on the existence of the virtio-blk-vhost-vdpa block driver > > since the first rel

Re: [libvirt PATCH 2/5] qemu: add virtio-blk-vhost-vdpa capability

2023-06-08 Thread Peter Krempa
On Tue, Jun 06, 2023 at 16:11:01 -0500, Jonathon Jongsma wrote: > Check whether the qemu binary supports the vdpa block driver. We can't > rely simply on the existence of the virtio-blk-vhost-vdpa block driver > since the first releases of qemu didn't support fd-passing for this > driver. So we hav

Re: [PATCH] spec: Do not disable some systemd units of newly split package

2023-06-08 Thread Martin Kletzander
On Thu, Jun 08, 2023 at 09:55:28AM +0200, Michal Prívozník wrote: On 6/7/23 16:31, Martin Kletzander wrote: Since virtproxyd was split into libvirt-daemon-proxy package it can happen that, in case a distribution has such systemd preset, when installing this package, already pre-enabled and confi

Re: [PATCH] spec: Do not disable some systemd units of newly split package

2023-06-08 Thread Michal Prívozník
On 6/7/23 16:31, Martin Kletzander wrote: > Since virtproxyd was split into libvirt-daemon-proxy package it can > happen that, in case a distribution has such systemd preset, when > installing this package, already pre-enabled and configured units like > -tls.socket and -tcp.socket will get disable

Re: [PATCH 3/3] qemu: Drop @unionMems argument from qemuProcessSetupPid()

2023-06-08 Thread Martin Kletzander
On Thu, Jun 08, 2023 at 09:03:04AM +0200, Michal Prívozník wrote: On 6/8/23 08:45, Martin Kletzander wrote: On Wed, Jun 07, 2023 at 04:41:01PM +0200, Michal Privoznik wrote: The @unionMems argument of qemuProcessSetupPid() function is not necessary really as all callers pass 'true'. Drop it. S

Re: [PATCH 3/3] qemu: Drop @unionMems argument from qemuProcessSetupPid()

2023-06-08 Thread Michal Prívozník
On 6/8/23 08:45, Martin Kletzander wrote: > On Wed, Jun 07, 2023 at 04:41:01PM +0200, Michal Privoznik wrote: >> The @unionMems argument of qemuProcessSetupPid() function is not >> necessary really as all callers pass 'true'. Drop it. >> >> Signed-off-by: Michal Privoznik >> --- >> src/qemu/qemu_p