Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-12 Thread Peter Xu
On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: > >> Only "defer" is recommended. After setting all migation parameters, > >> start incoming migration with "migrate-incoming uri" command. > >> > >

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-12 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: >> Only "defer" is recommended. After setting all migation parameters, >> start incoming migration with "migrate-incoming uri" command. >> >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 7 ++

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-12 Thread Peter Xu
On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: > Only "defer" is recommended. After setting all migation parameters, > start incoming migration with "migrate-incoming uri" command. > > Signed-off-by: Juan Quintela > --- > docs/about/deprecated.rst | 7 +++ > softmmu/vl.c

[RFC 6/6] migration: Deprecated old compression method

2023-06-12 Thread Juan Quintela
Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 qapi/migration.json | 92 --- migration/options.c | 13 ++ 3 files changed, 79 insertions(+), 34 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.r

[RFC 5/6] migration: Deprecate block migration

2023-06-12 Thread Juan Quintela
It is obsolete. It is better to use driver_mirror+NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Signed-off-by: Juan Quintela --- Can any of you give one example of how to use driver_mirror+NBD for deprecated.rst? Thanks, Juan. --- docs/about/deprecate

[RFC 4/6] migration: Deprecate -incoming

2023-06-12 Thread Juan Quintela
Only "defer" is recommended. After setting all migation parameters, start incoming migration with "migrate-incoming uri" command. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ softmmu/vl.c | 2 ++ 2 files changed, 9 insertions(+) diff --git a/docs/about/d

[RFC 3/6] migration: migrate 'blk' command option is deprecated.

2023-06-12 Thread Juan Quintela
Use 'migrate_set_capability block true' instead. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 11 +++ migration/migration.c | 5 + 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/docs/about/deprecated.rst b/

[RFC 2/6] migration: migrate 'inc' command option is deprecated.

2023-06-12 Thread Juan Quintela
Use 'migrate_set_parameter block_incremental true' instead. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 11 +-- migration/migration.c | 5 + 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/docs/about/deprec

[RFC 0/6] Migration deprecated parts

2023-06-12 Thread Juan Quintela
Hi this series describe the migration parts that have to be deprecated. - It is an rfc because I doubt that I did the deprecation process right. Hello Markus O:-) - skipped field: It is older than me, I have never know what it stands for. As far as I know it has always been zero. - inc/blk m

[RFC 1/6] migration: skipped field is really obsolete.

2023-06-12 Thread Juan Quintela
Has return zero for more than 10 years. Just mark it deprecated. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10 ++ qapi/migration.json | 12 ++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprec

Re: Missing https://download.libvirt.org/maven2/net/juniper

2023-06-12 Thread Daniel P . Berrangé
On Mon, Jun 12, 2023 at 12:00:39PM +0100, Nux wrote: > Hi, > > Anyone knows what happened to > https://download.libvirt.org/maven2/net/juniper ? It has gone missing. I'm not sure that would ever have existed. Our java packages are published under /org/libvirt, not /net/juniper. eg https://dow

Missing https://download.libvirt.org/maven2/net/juniper

2023-06-12 Thread Nux
Hi, Anyone knows what happened to https://download.libvirt.org/maven2/net/juniper ? It has gone missing. Thanks

Re: [PATCH 0/4] meson: Prepare for newer meson

2023-06-12 Thread Erik Skultety
On Thu, Jun 08, 2023 at 01:18:49PM +0200, Michal Privoznik wrote: > When we switch to meson-0.57.0 or newer (which we can't do currently > because of Debian 11 and Ubuntu 20.04), we can start using: > > libs_summary = { > 'acl': acl_dep, > ... > } > > which not only reports 'YES'/'NO'

Re: [PATCH 1/4] util: Parse RSS into ullp

2023-06-12 Thread Michal Prívozník
On 6/12/23 09:55, Martin Kletzander wrote: > It is used to fill an unsigned long long anyway and if it is negative > than there is really an issue somewhere. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_driver.c | 2 +- > src/util/virprocess.c | 17 ++--- > src/util/v

Re: [PATCH 0/4] Miscellaneous fixes, somehow Windows related

2023-06-12 Thread Michal Prívozník
On 6/12/23 09:55, Martin Kletzander wrote: > blurb is here, blurb is there, > blurby blurby everywhere > > Martin Kletzander (4): > util: Parse RSS into ullp > util: Remove virStrToLong_l > util: Use g_ascii_strtoll > meson-dist: Use shutil.copy for copying a file > > scripts/meson-dist.

[PATCH 2/2] docs: Move passt log file in our example XML

2023-06-12 Thread Michal Privoznik
In our passt example XML we use /var/log/passt.log as path to the log file. This is not optimal, because in case of unprivileged daemon, neither libvirt nor passt has enough permissions to create the file. Let's move the file under /tmp. Signed-off-by: Michal Privoznik --- docs/formatdomain.rst

[PATCH 1/2] qemu_passt: Precreate passt logfile

2023-06-12 Thread Michal Privoznik
There are a few situations where passt itself is unable to create a file because it runs under QEMU user (e.g. just like our example from formatdomain.rst suggests: /var/log/passt.log). If libvirtd runs with sufficient permissions (e.g. as root) it can create the file and set seclabels on it so tha

[PATCH 0/2] qemu: Handle passt logfile a bit better

2023-06-12 Thread Michal Privoznik
*** BLURB HERE *** Michal Prívozník (2): qemu_passt: Precreate passt logfile docs: Move passt log file in our example XML docs/formatdomain.rst | 2 +- src/qemu/qemu_passt.c | 40 +++- 2 files changed, 36 insertions(+), 6 deletions(-) -- 2.39.3

[PATCH 2/4] util: Remove virStrToLong_l

2023-06-12 Thread Martin Kletzander
With the last user gone this function can be abolished. It is preferable to use _ll instead since that is not a subject to 32/64 bit scaling. Signed-off-by: Martin Kletzander --- src/libvirt_private.syms | 1 - src/util/virstring.c | 19 +-- src/util/virstring.h | 5 --

[PATCH 3/4] util: Use g_ascii_strtoll

2023-06-12 Thread Martin Kletzander
This has two main advantages: - it parses the number with C locale explicitly - it behaves the same on Windows as on Linux and BSD both of which are wanted behaviours. Signed-off-by: Martin Kletzander --- src/util/virstring.c | 54 +++- 1 file changed,

[PATCH 4/4] meson-dist: Use shutil.copy for copying a file

2023-06-12 Thread Martin Kletzander
Using os.system("cp {0} {1}".format(...)) has two issues, it does not work on Windows, but more importantly it can cause issues in case one of the directories has a space in it. Signed-off-by: Martin Kletzander --- scripts/meson-dist.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-

[PATCH 1/4] util: Parse RSS into ullp

2023-06-12 Thread Martin Kletzander
It is used to fill an unsigned long long anyway and if it is negative than there is really an issue somewhere. Signed-off-by: Martin Kletzander --- src/qemu/qemu_driver.c | 2 +- src/util/virprocess.c | 17 ++--- src/util/virprocess.h | 2 +- 3 files changed, 12 insertions(+), 9

[PATCH 0/4] Miscellaneous fixes, somehow Windows related

2023-06-12 Thread Martin Kletzander
blurb is here, blurb is there, blurby blurby everywhere Martin Kletzander (4): util: Parse RSS into ullp util: Remove virStrToLong_l util: Use g_ascii_strtoll meson-dist: Use shutil.copy for copying a file scripts/meson-dist.py| 7 ++-- src/libvirt_private.syms | 1 - src/qemu/qemu

Re: [PATCH 0/2] qemu: Caps update for 'vdpa-block' and corner case hardening

2023-06-12 Thread Ján Tomko
On a Friday in 2023, Peter Krempa wrote: Peter Krempa (2): tests: qemucapabilitiesdata: Update data for qemu-8.1 dev cycle Explicitly reject unsupported storage types for legacy config generators src/libxl/xen_xl.c| 4 +- src/qemu/qemu_command.c