Re: [RFC PATCH-for-8.1] accel: Remove HAX accelerator

2023-06-23 Thread Philippe Mathieu-Daudé
On 24/6/23 01:08, Philippe Mathieu-Daudé wrote: HAX is deprecated since commits 73741fda6c ("MAINTAINERS: Abort HAXM maintenance") and 90c167a1da ("docs/about/deprecated: Mark HAXM in QEMU as deprecated"), released in v8.0.0. Per the QEMU deprecation policy, we shouldn't remove it before QEMU re

[RFC PATCH-for-8.1] accel: Remove HAX accelerator

2023-06-23 Thread Philippe Mathieu-Daudé
HAX is deprecated since commits 73741fda6c ("MAINTAINERS: Abort HAXM maintenance") and 90c167a1da ("docs/about/deprecated: Mark HAXM in QEMU as deprecated"), released in v8.0.0. Per the QEMU deprecation policy, we shouldn't remove it before QEMU release v8.2.0. However per the latest HAXM release

Re: [PATCH] apparmor: Add support for local profile customizations

2023-06-23 Thread Jim Fehlig
On 6/23/23 07:11, Andrea Bolognani wrote: On Thu, Jun 22, 2023 at 03:03:56PM -0600, Jim Fehlig wrote: On 6/22/23 11:08, Jim Fehlig wrote: On 6/22/23 08:50, Andrea Bolognani wrote: On Thu, Jun 08, 2023 at 10:37:43AM -0600, Jim Fehlig wrote: I assumed users would make VM customizations in the p

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-23 Thread Daniel P . Berrangé
On Fri, Jun 23, 2023 at 10:51:53AM -0400, Peter Xu wrote: > On Fri, Jun 23, 2023 at 09:23:18AM +0100, Daniel P. Berrangé wrote: > > On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > > > On Thu, Jun 22, 2023 at 10:59:58AM +0100, Daniel P. Berrangé wrote: > > > > I've mentioned several time

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-23 Thread Peter Xu
On Fri, Jun 23, 2023 at 09:23:18AM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > > On Thu, Jun 22, 2023 at 10:59:58AM +0100, Daniel P. Berrangé wrote: > > > I've mentioned several times before that the user should never need to > > > set this multifd

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-23 Thread Peter Xu
On Fri, Jun 23, 2023 at 08:17:46AM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 22, 2023 at 03:20:01PM -0400, Peter Xu wrote: > > On Thu, Jun 22, 2023 at 05:33:29PM +0100, Daniel P. Berrangé wrote: > > > On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > > > > I can try to move the todo

[PATCH v2] qemuDomainWaitForDeviceRemoval: recheck the value of priv->unplug.alias when timeout

2023-06-23 Thread Peter Krempa
From: zuoboqun When detaching a device, the following race condition may happen: Once qemuDomainSignalDeviceRemoval() marks the device for removal, it returns true, which means it is the caller that marked the device for removal is going to remove the device from domain definition. But qemuDomai

Re: [PATCH] qemuDomainWaitForDeviceRemoval: recheck the value of priv->unplug.alias when timeout

2023-06-23 Thread Peter Krempa
On Mon, Jun 05, 2023 at 11:59:36 +0800, zuoboqun wrote: > When detaching a device, the following race condition may happen: > Once qemuDomainSignalDeviceRemoval() marks the device for > removal, it returns true, which means it is the caller > that marked the device for removal is going to remove th

Re: [PATCH 0/3] Enable asynchronous teardown on s390x hosts

2023-06-23 Thread Boris Fiuczynski
On 6/21/23 6:54 PM, Jonathon Jongsma wrote: On 6/13/23 10:42 AM, Boris Fiuczynski wrote: Update capabilities for QEMU 8.1 on s390x, add a new capability async-teardown and make use of it when running on s390x hosts to improve memory reclaiming. Is this really something that should be enabled u

Re: [PATCH] apparmor: Add support for local profile customizations

2023-06-23 Thread Andrea Bolognani
On Thu, Jun 22, 2023 at 03:03:56PM -0600, Jim Fehlig wrote: > On 6/22/23 11:08, Jim Fehlig wrote: > > On 6/22/23 08:50, Andrea Bolognani wrote: > > > On Thu, Jun 08, 2023 at 10:37:43AM -0600, Jim Fehlig wrote: > > > > I assumed users would make VM customizations in the per-VM profiles. > > > > And

Re: [PATCH 3/3] qemu: enable asynchronous teardown on s390x hosts

2023-06-23 Thread Boris Fiuczynski
On 6/21/23 2:01 PM, Thomas Huth wrote: index a19902988c..dfdc95bfa5 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10166,6 +10166,18 @@ qemuBuildCryptoCommandLine(virCommand *cmd,   } +static int +qemuBuildTeardownCommandLine(virCommand *cmd, + 

[PATCH v3 1/3] qemu: capabilities: Introduce QEMU_CAPS_QCOW2_DISCARD_NO_UNREF

2023-06-23 Thread Peter Krempa
The qcow2 driver allows passing discards to the storage while keeping the reference of the block, and just marking it as zeroed. This can decrease the levels of fragmentation of the qcow2 metadata when discards are enabled. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c

[PATCH v3 0/3] Add support for discard_no_unref qcow2 option

2023-06-23 Thread Peter Krempa
v3: - new PATCH 1 adds a qemu capability - PATCH 2: - tweaked a few error messages - added qemu capability validation - removed invocation of test from qemusecuritytest which is not needed - PATCH 3: - added some explanation for the news entry Jean-Louis Dupond (2): Add

[PATCH v3 3/3] NEWS: Update NEWS with new discard_no_unref option

2023-06-23 Thread Peter Krempa
From: Jean-Louis Dupond Signed-off-by: Jean-Louis Dupond Reviewed-by: Peter Krempa Signed-off-by: Peter Krempa --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index c520a96177..950b188a8b 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -26,6 +26,13 @@ v9.5.

[PATCH v3 2/3] Add discard_no_unref option for qcow2 images

2023-06-23 Thread Peter Krempa
From: Jean-Louis Dupond Qemu 8.1.0 will add discard_no_unref option for qcow2 images. When this option is enabled (default=false), then it will no longer unreference clusters when guest does a discard, but it will just free the blocks (useful for incremental backups for example) and pass the disc

[PATCH] nodedev: transient mdev update on nodeDeviceCreateXML

2023-06-23 Thread Boris Fiuczynski
Update the optional mdev attributes on the new created nodedev object as they otherwise would not get set until the next mdevctl update cycle. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2143158 Signed-off-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 18 +

[PATCH] util: don't validate empty params

2023-06-23 Thread Oleg Vasilev
If there are no parameters, there is nothing to validate. If params == NULL, memcpy below results in memcpy(sorted, NULL, 0), which is UB. Found by UBSAN. Example of this codepath: virDomainBlockCopy() (where nparams == 0 is valid) -> qemuDomainBlockCopy() Signed-off-by: Oleg Vasilev --- src/ut

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-23 Thread Daniel P . Berrangé
On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > On Thu, Jun 22, 2023 at 10:59:58AM +0100, Daniel P. Berrangé wrote: > > I've mentioned several times before that the user should never need to > > set this multifd-channels parameter (nor many other parameters) on the > > destination in th

Re: [PATCH 0/4] qemu: Allow 'maxMemory' without 'slots' and fix slot validation for virtio-mem

2023-06-23 Thread Ján Tomko
On a Thursday in 2023, Peter Krempa wrote: First patch reworks memory specification to use the explicit 'size' parameter (since qemu v2.0.0-179-g6e1d3c1c85), the reset modifies memory hotplug related checks to properly handle non-DIMM devices which don't require DIMM slots. Peter Krempa (4): qe

Re: [PATCH] apparmor: Add support for local profile customizations

2023-06-23 Thread Christian Ehrhardt
On Thu, Jun 22, 2023 at 7:11 PM Jim Fehlig wrote: > > On 6/22/23 08:50, Andrea Bolognani wrote: > > On Thu, Jun 08, 2023 at 10:37:43AM -0600, Jim Fehlig wrote: > >> On 6/8/23 08:11, Andrea Bolognani wrote: > >>> Note that the Debian package has included this patch[1] for many > >>> years, and whil

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-23 Thread Daniel P . Berrangé
On Thu, Jun 22, 2023 at 03:20:01PM -0400, Peter Xu wrote: > On Thu, Jun 22, 2023 at 05:33:29PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > > > I can try to move the todo even higher. Trying to list the initial goals > > > here: > > > > > > - On