In one of my previous commits I've introduced @logfd variable
that was supposed to hold FD of passt logfile. But I've forgot to
assign the qemuDomainOpenFile() retval to it.
Fixes: 8511b96a319836700b4829816cdae27c3630060d
Signed-off-by: Michal Privoznik
---
Pushed as trivial.
src/qemu/qemu_pas
On 6/26/23 10:06, Andrea Bolognani wrote:
On Fri, Jun 16, 2023 at 03:57:37PM -0600, Jim Fehlig wrote:
On 6/16/23 02:12, Martin Kletzander wrote:
On Wed, Jun 14, 2023 at 04:45:06PM -0600, Jim Fehlig wrote:
On 6/9/23 03:05, Andrea Bolognani wrote:
Can we somehow enforce that libvirt-daemon is f
[Please CC me, I'm not subscribed to the mailinglist]
Hello,
regarding the initial patch in this thread: The patch looks good and
should go upstream IMHO. (Maybe except creating the dummy local/* files
for AppArmor 3.x - see below for details.)
A note about what you mentioned in the patch comm
On Mon, Jun 26, 2023 at 09:42:32AM -0600, Jim Fehlig wrote:
> On 6/26/23 03:52, Andrea Bolognani wrote:
> > On Fri, Jun 23, 2023 at 11:31:04AM -0600, Jim Fehlig wrote:
> > > On 6/23/23 07:11, Andrea Bolognani wrote:
> > > > However, not only you've added a few such statements in your recent
> > > >
On Fri, Jun 16, 2023 at 03:57:37PM -0600, Jim Fehlig wrote:
> On 6/16/23 02:12, Martin Kletzander wrote:
> > On Wed, Jun 14, 2023 at 04:45:06PM -0600, Jim Fehlig wrote:
> > > On 6/9/23 03:05, Andrea Bolognani wrote:
> > > > Can we somehow enforce that libvirt-daemon is fully configured before
> > >
On 6/26/23 03:52, Andrea Bolognani wrote:
On Fri, Jun 23, 2023 at 11:31:04AM -0600, Jim Fehlig wrote:
On 6/23/23 07:11, Andrea Bolognani wrote:
However, not only you've added a few such statements in your recent
commit 9b743ee19053, but I myself have done the same a couple months
back with comm
Signed-off-by: K Shiva
---
include/libvirt/virterror.h | 2 ++
src/util/virerror.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
index df13e4f11e..2910ff03da 100644
--- a/include/libvirt/virterror.h
+++ b/include/libvirt/
Adds:
- Get and Set Metadata functions to the test driver.
Signed-off-by: K Shiva
---
src/driver-network.h | 16 +
src/test/test_driver.c | 74 ++
2 files changed, 90 insertions(+)
diff --git a/src/driver-network.h b/src/driver-network.h
index 9
Added:
- Methods for relaying metadata change callbacks.
- Enums representing the same.
Signed-off-by: K Shiva
---
src/remote/remote_daemon_dispatch.c | 39 +
src/remote/remote_driver.c | 32 +++
src/remote/remote_protocol.x| 15 ++
Signed-off-by: K Shiva
---
tools/virsh-network.c | 78 ++-
1 file changed, 77 insertions(+), 1 deletion(-)
diff --git a/tools/virsh-network.c b/tools/virsh-network.c
index 42b7dba761..74712e29be 100644
--- a/tools/virsh-network.c
+++ b/tools/virsh-network.
- Fixed a typo in libvirt-domain.h
- Added test program networkmetadatatest.c
Signed-off-by: K Shiva
---
include/libvirt/libvirt-domain.h | 2 +-
tests/meson.build| 1 +
tests/networkmetadatatest.c | 297 +++
3 files changed, 299 insertions(+)
- The definition of struct virNetworkObj has been moved from
virnetworkobj.c to its header as it was needed by network_event.h.
- Added functions to parse and save the XML along with helper functions
that resolve the live/persistent state of the network.
Signed-off-by: K Shiva
---
src/conf/
Added:
- Methods to handle metadata change events.
Signed-off-by: K Shiva
---
po/POTFILES | 1 +
src/conf/network_event.c | 115 +++
src/conf/network_event.h | 11
3 files changed, 127 insertions(+)
diff --git a/po/POTFILES b/po/POTFILES
Added:
- virNetworkGetMetadata() and virNetworkSetMetadata() APIs.
- enums representing metadata type, i.e title, description or
custom metadata.
- enum representing metadata change callback event.
Signed-off-by: K Shiva
---
include/libvirt/libvirt-network.h | 51 +
src/libvirt-networ
Adds the following to Network Object:
- , and to the Network Schema,
along with appropriate XML parse methods.
- Get and Set APIs to access or modify the above.
- An async callback that notifies of metadata changes.
Resolves (GSoC 2023): https://wiki.libvirt.org/Google_Summer_of_Code_Ideas.htm
On a Monday in 2023, Michal Prívozník wrote:
On 6/12/23 10:15, Michal Privoznik wrote:
*** BLURB HERE ***
Michal Prívozník (2):
qemu_passt: Precreate passt logfile
docs: Move passt log file in our example XML
docs/formatdomain.rst | 2 +-
src/qemu/qemu_passt.c | 40 ++
Historically, the way to set PC speaker for a guest was to pass:
-soundhw pcspk
but as of QEMU commit v5.1.0-rc0~28^2~3 this is deprecated and we
should use:
-machine pcspk-audiodev=$id
instead. The old way was then removed in commit v7.1.0-rc0~99^2~3.
Now, ideally we would have a capabili
On Fri, Jun 23, 2023 at 11:22 AM Oleg Vasilev
wrote:
> If there are no parameters, there is nothing to validate.
> If params == NULL, memcpy below results in memcpy(sorted, NULL, 0),
> which is UB.
>
> Found by UBSAN. Example of this codepath: virDomainBlockCopy()
> (where nparams == 0 is valid)
On 6/11/23 21:44, K Shiva wrote:
> Adds support for the following to Network Object:
> - , and added to Network obj Schema.
> - Public Get and Set APIs, being virNetworkSetMetadata() &
> virNetworkGetMetadata().
> - An async callback that notifies of changes to Network metadata.
>
> Resolves (
On Fri, Jun 23, 2023 at 11:31:04AM -0600, Jim Fehlig wrote:
> On 6/23/23 07:11, Andrea Bolognani wrote:
> > However, not only you've added a few such statements in your recent
> > commit 9b743ee19053, but I myself have done the same a couple months
> > back with commit 7a39b04d683f, as part of enab
On 6/26/23 11:26, K Shiva wrote:
> Adds the following to Network Object:
> - , and to the Network Schema.
> - Get and Set APIs to access or modify the above.
> - An async callback that notifies of metadata changes.
>
> Resolves (GSoC 2023):
> https://wiki.libvirt.org/Google_Summer_of_Code_Ideas
On 23/06/12 01:14AM, K Shiva wrote:
> Adds support for the following to Network Object:
> - , and added to Network obj Schema.
> - Public Get and Set APIs, being virNetworkSetMetadata() &
> virNetworkGetMetadata().
> - An async callback that notifies of changes to Network metadata.
>
> Resolve
On 6/23/23 15:48, Peter Krempa wrote:
> From: zuoboqun
>
> When detaching a device, the following race condition may happen:
> Once qemuDomainSignalDeviceRemoval() marks the device for
> removal, it returns true, which means it is the caller
> that marked the device for removal is going to remove
Adds the following to Network Object:
- , and to the Network Schema.
- Get and Set APIs to access or modify the above.
- An async callback that notifies of metadata changes.
Resolves (GSoC 2023): https://wiki.libvirt.org/Google_Summer_of_Code_Ideas.html
Signed-off-by: K Shiva
---
This is a v2 o
On 6/14/23 07:21, K Shiva wrote:
> Signed-off-by: K Shiva
> ---
> This patch applies to:
> https://listman.redhat.com/archives/libvir-list/2023-June/240299.html
> src/conf/virnetworkobj.c | 8
> src/libvirt-network.c| 10 +-
> 2 files changed, 9 insertions(+), 9 deletions(-
On 6/26/23 9:25 AM, Michal Prívozník wrote:
Jonathon,
thanks for your feedback.
I am unsure where to located such a configuration option in the gust
domain XML.
A few thoughts:
1) introduce a new emulator-options element in devices and a run-with
child element with a parameter async-teardown, e
On 6/24/23 01:08, Philippe Mathieu-Daudé wrote:
HAX is deprecated since commits 73741fda6c ("MAINTAINERS: Abort
HAXM maintenance") and 90c167a1da ("docs/about/deprecated: Mark
HAXM in QEMU as deprecated"), released in v8.0.0.
Per the QEMU deprecation policy, we shouldn't remove it before
QEMU re
On a Friday in 2023, Peter Krempa wrote:
v3:
- new PATCH 1 adds a qemu capability
- PATCH 2:
- tweaked a few error messages
- added qemu capability validation
- removed invocation of test from qemusecuritytest which is not
needed
- PATCH 3:
- added some explanation for the news e
On 6/12/23 10:15, Michal Privoznik wrote:
> *** BLURB HERE ***
>
> Michal Prívozník (2):
> qemu_passt: Precreate passt logfile
> docs: Move passt log file in our example XML
>
> docs/formatdomain.rst | 2 +-
> src/qemu/qemu_passt.c | 40 +++-
> 2 files ch
On 6/23/23 15:12, Boris Fiuczynski wrote:
> On 6/21/23 6:54 PM, Jonathon Jongsma wrote:
>> On 6/13/23 10:42 AM, Boris Fiuczynski wrote:
>>> Update capabilities for QEMU 8.1 on s390x, add a new capability
>>> async-teardown and make use of it when running on s390x hosts to improve
>>> memory reclaim
30 matches
Mail list logo
