On 7/20/23 08:22, Han Han wrote:
> These two attributes are supported for vhost-user-blk as well.
>
> Signed-off-by: Han Han
> ---
> docs/formatdomain.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> index 4af0b8256
These two attributes are supported for vhost-user-blk as well.
Signed-off-by: Han Han
---
docs/formatdomain.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 4af0b82569..447ab32c01 100644
--- a/docs/formatdomain.rst
++
On 19/07/23 14:48, Michal Prívozník wrote:
On 7/11/23 08:47, K Shiva Kiran wrote:
- Introduces virNetworkObjGetMetadata() and
virNetworkObjSetMetadata().
- These functions implement common behaviour that can be reused by
network drivers that use the virNetworkObj struct.
- Also adds help
On 19/07/23 21:47, K Shiva Kiran wrote:
- Introduces virNetworkObjGetMetadata() and
virNetworkObjSetMetadata().
- These functions implement common behaviour that can be reused by
network drivers that use the virNetworkObj struct.
- Introduces virNetworkObjUpdateModificationImpact() among o
On 19/07/23 14:48, Michal Prívozník wrote:
On 7/11/23 08:47, K Shiva Kiran wrote:
This patch introduces public Get and Set APIs for modifying ,
and elements of the Network object.
- Added enum to select one of the above elements to operate on.
- Added error code and messages for missing met
- Introduces virNetworkObjGetMetadata() and
virNetworkObjSetMetadata().
- These functions implement common behaviour that can be reused by
network drivers that use the virNetworkObj struct.
- Introduces virNetworkObjUpdateModificationImpact() among other
helper functions that resolve the live
On 7/19/23 3:41 PM, Peter Krempa wrote:
nodeDeviceUpdateMediatedDevices invokes virMdevctlListDefined and
virMdevctlListActive both of which were passed the same 'errmsg' buffer.
Since virCommandSetErrorBuffer() always allocates the error buffer one
of them was leaked.
Fix it by populating the
On 19/07/23 14:48, Michal Prívozník wrote:
On 7/11/23 08:47, K Shiva Kiran wrote:
This commit introduces and fields to the
XML schema of the Network object.
It also adds public Get/Set APIs for modifying all metadata fields
of the same, along with a test program.
K Shiva Kiran (4):
Add
On Mon, Jun 26, 2023 at 2:13 PM Michal Privoznik
wrote:
> Historically, the way to set PC speaker for a guest was to pass:
>
> -soundhw pcspk
>
> but as of QEMU commit v5.1.0-rc0~28^2~3 this is deprecated and we
> should use:
>
> -machine pcspk-audiodev=$id
>
> instead. The old way was then r
nodeDeviceUpdateMediatedDevices invokes virMdevctlListDefined and
virMdevctlListActive both of which were passed the same 'errmsg' buffer.
Since virCommandSetErrorBuffer() always allocates the error buffer one
of them was leaked.
Fix it by populating the 'errmsg' buffer only on failure of
virMdev
From 61d699de0603ca49a67cc898a219cce2613b82ba Mon Sep 17 00:00:00 2001
From: K Shiva Kiran
Date: Tue, 27 Jun 2023 20:48:52 +0530
Subject: [libvirt PATCH v2 2/4] Adding Public Get and Set APIs for
Network Metadata
This patch introduces public Get and Set APIs for modifying ,
and elements of t
On 7/19/23 12:50, Peter Krempa wrote:
> On Tue, Jul 18, 2023 at 14:28:57 +0200, Michal Privoznik wrote:
>> Since nobody is expected to run valgrind over scripts now, we can
>> drop plenty of suppressions. Also, there are some old ones that
>> no longer exist and new ones, that are not covered.
>>
>
On Wed, Jun 21, 2023 at 14:32:30 +0100, Daniel P. Berrangé wrote:
> Historically we wanted to check if logind was actually running, not
> merely activatable, because on systems where systemd is installed,
> but the OS is booted into non-systemd init, we want to fallback to
> pm-utils.
>
> Requirin
On Wed, Jul 19, 2023 at 14:31:24 +0200, Michal Prívozník wrote:
> On 7/19/23 12:50, Peter Krempa wrote:
> > On Tue, Jul 18, 2023 at 14:28:57 +0200, Michal Privoznik wrote:
> >> Since nobody is expected to run valgrind over scripts now, we can
> >> drop plenty of suppressions. Also, there are some o
On 7/19/23 12:43, Peter Krempa wrote:
> On Thu, Jun 29, 2023 at 17:13:42 +0200, Michal Privoznik wrote:
>> Introduced in QEMU commit of v0.14.0-rc0~83^2~1 and not being
>> able to compile the .removable attribute of the "usb-storage"
>> object out, renders our corresponding capability
>> QEMU_CAPS_
On 7/18/23 17:47, Peter Krempa wrote:
> On Tue, Jul 18, 2023 at 17:27:33 +0200, Michal Privoznik wrote:
>> When virsh connects to a non-hypervisor daemon directly (e.g.
>> "nodedev:///system") and user executes 'version' they are met
>> with an error message. This is because cmdVersion() calls
>> v
On Tue, Jul 18, 2023 at 14:28:56 +0200, Michal Privoznik wrote:
> A test case can be part of a test suite (just like we already
> have 'syntax-check'). This then allows developers to run only a
> subset of tests. For instance - when using valgrind test setup
> (`meson test -C _build/ --setup valgri
On Tue, Jul 18, 2023 at 14:28:57 +0200, Michal Privoznik wrote:
> Since nobody is expected to run valgrind over scripts now, we can
> drop plenty of suppressions. Also, there are some old ones that
> no longer exist and new ones, that are not covered.
>
> Signed-off-by: Michal Privoznik
> ---
>
On Thu, Jun 29, 2023 at 17:13:42 +0200, Michal Privoznik wrote:
> Introduced in QEMU commit of v0.14.0-rc0~83^2~1 and not being
> able to compile the .removable attribute of the "usb-storage"
> object out, renders our corresponding capability
> QEMU_CAPS_USB_STORAGE_REMOVABLE useless. Retire it.
>
On a Thursday in 2023, Michal Privoznik wrote:
Introduced in QEMU commit of v0.14.0-rc0~83^2~1 and not being
able to compile the .removable attribute of the "usb-storage"
object out, renders our corresponding capability
QEMU_CAPS_USB_STORAGE_REMOVABLE useless. Retire it.
Signed-off-by: Michal Pr
On Tue, Jul 18, 2023 at 17:27:37 +0200, Michal Privoznik wrote:
> This brings the code closer to real implementation:
> nodeDeviceCreateXML(). For the unique OUI, let's take the value
> from tests/virrandommock.c: 10.
>
> Signed-off-by: Michal Privoznik
> ---
> src/test/test_driver.c | 7 +++
On Tue, Jul 18, 2023 at 17:27:38 +0200, Michal Privoznik wrote:
> After previous commit, there's no functional difference between
> real virRandomGenerateWWN() and the mocked version. Drop the mock
> then.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/virrandommock.c | 8
> 1 file c
On Wed, Jul 19, 2023 at 11:52:45 +0800, Yong Huang wrote:
> On Tue, Jul 18, 2023 at 9:31 PM Peter Krempa wrote:
>
> > On Sun, Jul 16, 2023 at 22:36:21 +0800, ~hyman wrote:
> > > From: Hyman Huang(黄勇)
> > >
> > > Add 'virtio_discard' and 'virtio_write_zeroes' attribute to control
> > > whether di
On Tue, Jul 18, 2023 at 17:27:35 +0200, Michal Privoznik wrote:
> The virRandomGenerateWWN() is used solely by nodedev driver to
> autogenerate WWNN and WWNP when parsing a nodedev XML. Now, the
> idea was (at least during monolithic daemon) that depending on
> which hypervisor driver called the no
On Tue, Jul 18, 2023 at 22:39:26 +0200, Benedek Major wrote:
> The QEMU drivers ide-hd and ide-cd used for IDE and SATA bus devices support
> adding a disk model that is returned on guest query by the IDE or SATA disk
> to the guest.
> The already existing product tag got changed to allow for up t
On Tue, Jul 18, 2023 at 17:27:36 +0200, Michal Privoznik wrote:
> Firstly, drop needless concatenation of two static strings.
> Secondly, use proper (portable) formatter for uint64_t so that
> typecast to ULL can be dropped.
>
> Signed-off-by: Michal Privoznik
> ---
> src/util/virrandom.c | 3 +-
On 6/29/23 17:13, Michal Privoznik wrote:
>
Polite ping.
Michal
On 7/17/23 12:56, Han Han wrote:
> Signed-off-by: Han Han
> ---
> NEWS.rst | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/NEWS.rst b/NEWS.rst
> index 42c2c53091..5ee880efcb 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -27,6 +27,11 @@ v9.6.0 (unreleased)
> ``abstractions/foo`
On 7/18/23 9:55 PM, Jonathon Jongsma wrote:
Since commit 44a0f2f0, we now query mdevctl for transient (active) mdevs
in order to gather attributes for the mdev. Unfortunately, this commit
introduced a regression because nodeDeviceUpdateMediatedDevice() assumed
that all mdevs returned from mdevctl
On 7/11/23 08:47, K Shiva Kiran wrote:
> This patch introduces public Get and Set APIs for modifying ,
> and elements of the Network object.
>
> - Added enum to select one of the above elements to operate on.
> - Added error code and messages for missing metadata.
> - Added public API implementa
On 7/11/23 08:47, K Shiva Kiran wrote:
> This commit introduces and fields to the
> XML schema of the Network object.
> It also adds public Get/Set APIs for modifying all metadata fields
> of the same, along with a test program.
>
> K Shiva Kiran (4):
> Add and for Network Objects
> Addin
On 7/11/23 08:47, K Shiva Kiran wrote:
> - Introduces virNetworkObjGetMetadata() and
> virNetworkObjSetMetadata().
> - These functions implement common behaviour that can be reused by
> network drivers that use the virNetworkObj struct.
> - Also adds helper functions that resolve the live/persi
On Tue, Jul 18, 2023 at 9:31 PM Peter Krempa wrote:
> On Sun, Jul 16, 2023 at 22:36:21 +0800, ~hyman wrote:
> > From: Hyman Huang(黄勇)
> >
> > Add 'virtio_discard' and 'virtio_write_zeroes' attribute to control
> > whether discard and write-zeroes requests are handled by the
> > virtio-blk device
On 7/18/23 16:48, Jonathon Jongsma wrote:
> The virtio-gpu 'blob' support was insufficiently validated. Qemu
> requires a memfd memory backing in order to use udmabuf and enable blob
> support. Example error:
>
> $ virsh start rhel9
> error: Failed to start domain 'rhel9'
> error: inte
On 7/17/23 21:43, Jonathon Jongsma wrote:
> I believe that qemu 4.2.0 is the oldest version of qemu that we still
> support, so I don't think that a new capability would actually be
> necessary for this.
Just for completeness, since Hyman is new contributor: this fact
Jonathon mentions is necessar
On 7/17/23 12:56, Han Han wrote:
> Han Han (2):
> NEWS: qemu: Support removable attribute for scsi disk
> NEWS: cpu_map: Add SapphireRapids cpu model
>
> NEWS.rst | 9 +
> 1 file changed, 9 insertions(+)
>
Reviewed-by: Michal Privoznik
and pushed.
Michal
36 matches
Mail list logo
