On 7/24/23 8:05 AM, Peter Krempa wrote:
As I've promised a long time ago I gave your patches some testing in
regards of cooperation with blockjobs and snapshots.
Since the new version of the patches was not yet posted on the list I'm
replying here including my observations from testing patches f
On 8/1/23 08:11, Martin Kletzander wrote:
On Mon, Jul 31, 2023 at 05:06:44PM -0600, Jim Fehlig wrote:
The first patch is trivial. I suppose the second is debatable. If I build
libvirt with -Dremote_default_mode=legacy but deploy modular daemons,
/run/libvirt/libvirt-sock is provided by virtproxy
30.07.2023 21:03, Stefan Weil via wrote:
Signed-off-by: Stefan Weil
---
This patch was triggered by a spelling check for the generated
QEMU documentation using codespell. It does not try to fix all
typos which still exist in the QEMU code, but has a focus on
those required to fix the documentat
On Wed, Aug 02, 2023 at 10:05:38AM +0100, Daniel P. Berrangé wrote:
This fixes
commit 38abf9c34dc481b0dc923bdab446ee623bdc5ab6
Author: Daniel P. Berrangé
Date: Wed Jun 21 13:22:40 2023 +0100
src: set max open file limit to match systemd >= 240 defaults
Pity we can't drop it because
On Tue, Jun 27, 2023 at 17:07:22 +0200, Pavel Hrdina wrote:
> When user creates a new snapshot after reverting to non-leaf snapshot we
> no longer need to store the temporary overlays as they will be part of
> the VM XMLs stored in the newly created snapshot.
>
> Signed-off-by: Pavel Hrdina
> ---
On Wed, Aug 02, 2023 at 10:11:24AM +0200, Peter Krempa wrote:
When a query for an interface via virInterfaceLookupByMACString finds
multiple interfaces an error is returned. Treat such error with the same
'debug' priority as we treat when the interface was not found to avoid
spamming logs with su
On Tue, Jun 27, 2023 at 17:07:20 +0200, Pavel Hrdina wrote:
> When block commit is not needed we can just simply unlink the
> disk files.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_snapshot.c | 56 ++--
> 1 file changed, 36 insertions(+), 20 deletio
On Wed, Aug 02, 2023 at 09:29:39AM +0200, Peter Krempa wrote:
Few issues with propagating error to the user when debug logging is
enabled,
Peter Krempa (3):
virLXCControllerSetupUsernsMap: Modify debug logging for clean startup
errors
virLXCProcessReadLogOutputData: Refill buffer after filt
On Wed, Aug 02, 2023 at 13:47:16 +0200, Kristina Hanicova wrote:
> Signed-off-by: Kristina Hanicova
> ---
> docs/formatdomain.rst | 10 ++
> src/conf/domain_conf.c| 12 +++-
> src/conf/domain_conf.h| 1 +
> src/conf/domain_validate.c|
On Wed, Aug 02, 2023 at 13:47:17 +0200, Kristina Hanicova wrote:
> Signed-off-by: Kristina Hanicova
> ---
This capability is not actually used after this series. Additionally all
qemu versions seem to support it.
On Wed, Aug 02, 2023 at 13:47:15 +0200, Kristina Hanicova wrote:
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1849570
>
> Signed-off-by: Kristina Hanicova
> ---
> src/qemu/qemu_command.c| 2 ++
> src/vz/vz_utils.c |
Signed-off-by: Kristina Hanicova
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_4.2.0_ppc64.xml | 1 +
tests/qemucapab
Signed-off-by: Kristina Hanicova
---
docs/formatdomain.rst | 6 +-
src/conf/domain_conf.c| 12 +++-
src/conf/domain_conf.h| 1 +
src/conf/domain_validate.c| 3 ++-
src/conf/schemas/domaincommon.rng | 5 +
src/qemu/qemu_domain.c
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1849570
Signed-off-by: Kristina Hanicova
---
src/qemu/qemu_command.c| 2 ++
src/vz/vz_utils.c | 3 ++-
tests/qemuxml2argvdata/disk-blockio.x86_64-latest.args | 2 +-
tests/q
Signed-off-by: Kristina Hanicova
---
docs/formatdomain.rst | 10 ++
src/conf/domain_conf.c| 12 +++-
src/conf/domain_conf.h| 1 +
src/conf/domain_validate.c| 3 ++-
src/conf/schemas/domaincommon.rng | 5 +
5 files changed, 29 inse
Signed-off-by: Kristina Hanicova
---
src/qemu/qemu_command.c | 2 +
src/qemu/qemu_domain.c| 2 +
src/vz/vz_utils.c | 3 +-
...csi-disk-max_unmap_size.x86_64-latest.args | 37 +++
.../disk-scsi-disk-max_un
I noticed this on the list after the 1849570 bug on discard granularity:
https://listman.redhat.com/archives/libvir-list/2020-June/203862.html
so I decided to add maximum unmap size as well.
The series is heavily based on Lin's patches and I would be glad if
there is any way to add Lin into commit
On Tue, Aug 01, 2023 at 04:33:41PM +0200, Michal Privoznik wrote:
See reasoning in 2/2.
Michal Prívozník (2):
Revert "qemu_passt: Actually use @logfd"
Revert "qemu_passt: Precreate passt logfile"
Reviewed-by: Martin Kletzander
src/qemu/qemu_passt.c | 40 +-
This fixes
commit 38abf9c34dc481b0dc923bdab446ee623bdc5ab6
Author: Daniel P. Berrangé
Date: Wed Jun 21 13:22:40 2023 +0100
src: set max open file limit to match systemd >= 240 defaults
The bug referenced in that commit had suggested to set
LimitNOFile=512000:1024
on the basis th
On Wed, Aug 02, 2023 at 09:15:43AM +0200, Michal Prívozník wrote:
On 7/26/23 16:45, Martin Kletzander wrote:
On Wed, Jun 28, 2023 at 12:53:35PM +0200, Michal Privoznik wrote:
If a guest changes MAC address on its vNIC, then QEMU emits
NIC_RX_FILTER_CHANGED event (the event is emitted in other c
On Wed, Aug 02, 2023 at 10:49:55AM +0200, Olaf Hering wrote:
> Wed, 21 Jun 2023 14:32:29 +0100 Daniel P. Berrangé :
>
> > -LimitNOFILE=8192
> > +LimitNOFile=512000:1024
>
> Did someone really rename that knob in upstream systemd?
> My copy of systemd.directives(7) still lists the uppercase varian
Wed, 21 Jun 2023 14:32:29 +0100 Daniel P. Berrangé :
> -LimitNOFILE=8192
> +LimitNOFile=512000:1024
Did someone really rename that knob in upstream systemd?
My copy of systemd.directives(7) still lists the uppercase variant.
As a result this change means the knob is now not recognized anymore.
When a query for an interface via virInterfaceLookupByMACString finds
multiple interfaces an error is returned. Treat such error with the same
'debug' priority as we treat when the interface was not found to avoid
spamming logs with such configurations.
Closes: https://gitlab.com/libvirt/libvirt/-
Avoid logging multiline debug logs so that the function which attempts
to extract a non-debug log error message can work properly.
Signed-off-by: Peter Krempa
---
src/lxc/lxc_controller.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/lxc/lxc_controller.c b/src/l
The caller passes in a 1k buffer, which when debug logging is in use is
easily filled with debug messages only. Thus after the first pass which
is common if the controller process already terminated the buffer will
not contain the real error, but rather a truncated debug message,
which will result
Since the error message originates from a log file it contains a
trailing newline. Strip it as all error handling adds it's own newline.
Signed-off-by: Peter Krempa
---
src/lxc/lxc_process.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
i
Few issues with propagating error to the user when debug logging is
enabled,
Peter Krempa (3):
virLXCControllerSetupUsernsMap: Modify debug logging for clean startup
errors
virLXCProcessReadLogOutputData: Refill buffer after filtering out
noise
virLXCProcessReportStartupLogError: Str
On 7/26/23 16:45, Martin Kletzander wrote:
> On Wed, Jun 28, 2023 at 12:53:35PM +0200, Michal Privoznik wrote:
>> If a guest changes MAC address on its vNIC, then QEMU emits
>> NIC_RX_FILTER_CHANGED event (the event is emitted in other cases
>> too, but that's not important right now). Now, domain
On 7/26/23 16:47, Martin Kletzander wrote:
> On Wed, Jun 28, 2023 at 12:53:36PM +0200, Michal Privoznik wrote:
>> The aim off this event is to notify management application that
>> guest changed MAC address on one of its vNICs so the app can
>> update its internal records, e.g. for finding match be
29 matches
Mail list logo
